platform_external_elfutils/src/elfcmp.c, branch android10-security-release

elfcmp: Get, check and shdrstrndx for section names.

2018-09-13T12:30:30+00:00

elfcmp would use the Ehdr e_shstrndx field to find the shdr string
index table. Use elf_getshdrstrndx instead to be able to handle ELF
files with more than SHN_LORESERVE sections.

Signed-off-by: Mark Wielaard

libebl: Use elf_getshdrstrndx in ebl_section_strip_p.

2018-09-13T12:30:30+00:00

The ebl_section_strip_p function used the Ehdr e_shstrndx field
to get at the name of the (debug) sections. This is not correct
if there are more than SHN_LORESERVE sections. Use elf_getshdrstrndx
to get at the shstrtab section. And drop the Ehdr argument that isn't
necessary anymore.

Signed-off-by: Mark Wielaard

Consolidate error.h inclusion in system.h

2018-07-05T19:06:40+00:00

error.h isn't standard and so isn't part of the musl C library.
To easy future porting, consolidate the inclusion of error.h into system.h.

https://sourceware.org/bugzilla/show_bug.cgi?id=21008

Signed-off-by: Ross Burton

Use the empty string for note names with zero size (without any data).

2017-04-03T21:47:59+00:00

ELF notes can have a zero sized name. In which case there is no data at
all (so also no zero terminator). Make sure to use the empty string for
such notes if the code does not otherwise explicitly check n_namesz.

https://sourceware.org/bugzilla/show_bug.cgi?id=21300

Signed-off-by: Mark Wielaard

Move print_version into printversion.{h|c}

2017-02-17T09:55:28+00:00

Rename version.c so that the implementation is called after the header
and the header doesn't clash with the toplevel version.h. print_version
depends on argp and is only used in the tools.

Signed-off-by: Ulf Hermann

http://elfutils.org/ is now hosted at http://sourceware.org/elfutils/

2016-12-24T21:51:32+00:00

fedorahosted used to be our home, but we are now hosted at sourceware.

Change the elfutils project home to http://elfutils.org/
Point hosted services (email, release, git, bug tracker and web pages)
to https://sourceware.org/elfutils/

Move design notes from README to NOTES.
Add URLs for home, releases, bugs, git and mailinglist to README.

Make the --version output of all tools the same by using a common
print_version function and update the publicly shown copyright holder
to the elfutils developers.

Signed-off-by: Mark Wielaard

elfcmp: fix self-comparison error with GCC 6

2016-04-11T15:07:22+00:00

Noticed with Fedora 24 Alpha, gcc (GCC) 6.0.0 20160406
(Red Hat 6.0.0-0.20).

elfcmp.c: In function ‘main’:
elfcmp.c:364:199: error: self-comparison always evaluates
to false [-Werror=tautological-compare]
        if (unlikely (name1 == NULL || name2 == NULL

Signed-off-by: David Abdurachmanov

elfcmp: Fix leaking Ebl handles.

2016-01-02T19:37:44+00:00

open_file () explicitly gets Ebl handles for both Elf files to compare.
Make sure to close those when done.

Signed-off-by: Mark Wielaard

elfcmp: Don't call memcmp with possible NULL d_buf.

2015-06-05T12:44:59+00:00

When d_size is zero d_buf might be NULL.

Signed-off-by: Mark Wielaard

elfcmp: Add some NULL and zero checks.

2015-01-15T13:16:42+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=1170810#c17

Reported-by: Alexander Cherepanov 
Signed-off-by: Mark Wielaard