platform_external_desugar/java, branch master

Merge remote-tracking branch upstream-master into master

2018-05-04T10:10:50+00:00

* origin/upstream-master: (43 commits)
  Allow --worker_max_instances to take MnemonicName=value to specify max for each named worker.
  Clean up code that directly imports nested classes like Builder, Entry, etc.
  Clean up code that directly imports nested classes like Builder, Entry, etc.
  Clean up code that directly imports nested classes like Builder, Entry, etc.
  Remove use of bare Immutable{List,Map,Set} Builder classes.
  Relax the assertion in Desugar for checking the calls to $closeResource(...). It is possible that $closeResource(...) is not used as the calls to it might be eliminated by some optimization tools, such as Proguard.
  Make attempting to change --config in invocation policy an error.
  Remove alphabetical sorting of options in the canonical list.
  Remove some deprecated resources flags.
  Remove category checking from incompatible changes.
  Support source versions newer than 8 in Bazel's annotation processors
  stub simple core library bridge methods that only differ in return type RELNOTES: None.
  Reflect core library moves in super calls, even in default method stubs.  Always generate default method stubs for emulated methods. RELNOTES: None.
  Make KeepScanner tool search classpath for nearest definition of each member reference, instead of potentially referring to a subtype. Refactor desugar's class loading machinery and related code into a separate package for easier reuse in this tool. RELNOTES: None.
  Minor fixes to KeepScanner tool: - use Guava to read zip entries - Fix keep rules emitted for constructors RELNOTES: None.
  Support custom implementations of emulated core interface methods RELNOTES: None.
  tests,windows: enable android.desugar.runtime
  emulate dynamic dispatch of emulated default interface methods RELNOTES: None.
  Android desugar config options to exclude methods from interface emulation RELNOTES: None.
  send invocations to emulated interfaces through dispatch helper. fix logic for implementing emulated interfaces. RELNOTES: None.
  ...

BUG: none
Test: existing

Allow --worker_max_instances to take MnemonicName=value to specify max for each named worker.

2018-05-04T09:41:52+00:00

RELNOTES: Allow --worker_max_instances to take MnemonicName=value to specify max for each worker.
PiperOrigin-RevId: 195244295
GitOrigin-RevId: 0c12603bedd4a270094137269b910a8587d3f93c
Change-Id: I1ab6bf78b0101c7fbe842d18c62ce844869e4eec

Clean up code that directly imports nested classes like Builder, Entry, etc.

2018-05-04T09:41:44+00:00

PiperOrigin-RevId: 195100670
GitOrigin-RevId: 94b8702db5f9a905337aca74bfc2e7c436bf33ec
Change-Id: Iea45a0d018d49a43181c1e357721d0b552bea777

Clean up code that directly imports nested classes like Builder, Entry, etc.

2018-05-04T09:41:35+00:00

PiperOrigin-RevId: 195040539
GitOrigin-RevId: 0a57d3dcb1cc014d65dbeb604035bb34a7191e29
Change-Id: I78ff7b0f225fbdcdeed44145fe0e28ffc0e4c197

Remove use of bare Immutable{List,Map,Set} Builder classes.

2018-05-04T09:41:19+00:00

Always use the more-qualified class name for clarity at the site of use. There are too many classes named Builder.

PiperOrigin-RevId: 193649193
GitOrigin-RevId: 96d3c91c714544584c9174759bedebf2a6be5e71
Change-Id: I0c9cf0ab619bc743cd15ba63ad7355e008c0f1d1

Relax the assertion in Desugar for checking the calls to $closeResource(...).

2018-05-04T09:41:11+00:00

It is possible that $closeResource(...) is not used as the calls to it might
be eliminated by some optimization tools, such as Proguard.

RELNOTES: n/a.
PiperOrigin-RevId: 193262552
GitOrigin-RevId: 1a2ab6d54e2a8749549f41055cd66f3f6dfea4cc
Change-Id: Ifdbd7b47132b541ecfd831d2a7b83d76853ec206

Make attempting to change --config in invocation policy an error.

2018-05-04T09:41:02+00:00

It will not work as expected, since config is already expanded by this point in options processing.

RELNOTES: None.
PiperOrigin-RevId: 193196664
GitOrigin-RevId: 9c8c77502ff52907a327e6bdc9ac282da0af6b44
Change-Id: I5fa3aaec852b2d16bb8974291735ba4da1709243

Remove alphabetical sorting of options in the canonical list.

2018-05-04T09:40:54+00:00

This was broken for --config. Doing this properly requires keeping the order in which the options were given, which could be done either by filtering the ordered list according to which values affect the final outcome or by tracking the order correctly. I picked the later: the option order was not explicitly tracked for expansions before but now it is.

RELNOTES: canonicalize-flags no longer reorders the flags
PiperOrigin-RevId: 192132260
GitOrigin-RevId: aa98bc29dae14119797febd447302842f4ac68af
Change-Id: I82fb65d38569d4e5a9808f032da1ccc2304e2f18

Remove some deprecated resources flags.

2018-05-04T09:40:46+00:00

RELNOTES: None
PiperOrigin-RevId: 191624839
GitOrigin-RevId: c4987159509cd8de3f0c4070b53ea1bf3b8278cd
Change-Id: Iaf2947340b544491d975d64d19b5337be25a9ac6

Remove category checking from incompatible changes.

2018-05-04T09:40:38+00:00

String categories are deprecated, replace this special-cased value with a specific OptionMetadata tag, TRIGGERED_BY_ALL_INCOMPATIBLE_CHANGES.

RELNOTES: None.
PiperOrigin-RevId: 191069412
GitOrigin-RevId: 78a5fcff8a311c71cfe163a40856f7413e346409
Change-Id: I1be6e8a8c592e0fa8ec29a631957d840f34a2113