<feed xmlns='http://www.w3.org/2005/Atom'>
<title>platform_external_crosvm/kvm, branch android11-tests-release</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.
</subtitle>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/'/>
<entry>
<title>Revert "Revert submission"</title>
<updated>2019-12-02T23:14:27+00:00</updated>
<author>
<name>Chih-Hung Hsieh</name>
<email>chh@google.com</email>
</author>
<published>2019-12-02T22:28:52+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=318303ce0e6ccb67bc575409bf3f9d72f9959545'/>
<id>318303ce0e6ccb67bc575409bf3f9d72f9959545</id>
<content type='text'>
This reverts commit 44c5ab22cbf6332d56d38764131595c4f0fc52cc.

* /dev/kvm does not exist on some test machines,
  so we do not add {kvm,kvm_sys}/TEST_MAPPING files.
* Previous errors of not finding test binary under relative_install_path
  in a sandbox should have been fixed by c/1172431.

Bug: 145158988
Bug: 140938178
Bug: 145231999
Test: atest and TH presubmit test
Change-Id: I3e56703b19b30f95f8ad6b9218fd58abbc7daed4
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit 44c5ab22cbf6332d56d38764131595c4f0fc52cc.

* /dev/kvm does not exist on some test machines,
  so we do not add {kvm,kvm_sys}/TEST_MAPPING files.
* Previous errors of not finding test binary under relative_install_path
  in a sandbox should have been fixed by c/1172431.

Bug: 145158988
Bug: 140938178
Bug: 145231999
Test: atest and TH presubmit test
Change-Id: I3e56703b19b30f95f8ad6b9218fd58abbc7daed4
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert submission</title>
<updated>2019-11-26T21:04:50+00:00</updated>
<author>
<name>Colin Cross</name>
<email>ccross@android.com</email>
</author>
<published>2019-11-26T21:04:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=44c5ab22cbf6332d56d38764131595c4f0fc52cc'/>
<id>44c5ab22cbf6332d56d38764131595c4f0fc52cc</id>
<content type='text'>
Reason for revert: b/145158988

Bug: 145158988
Change-Id: I0d5cd1401641ad32918bd15f2587bc4357b0703e
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reason for revert: b/145158988

Bug: 145158988
Change-Id: I0d5cd1401641ad32918bd15f2587bc4357b0703e
</pre>
</div>
</content>
</entry>
<entry>
<title>Add rust_test modules and TEST_MAPPING.</title>
<updated>2019-11-18T05:38:02+00:00</updated>
<author>
<name>Chih-Hung Hsieh</name>
<email>chh@google.com</email>
</author>
<published>2019-11-18T05:27:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=b6087730849ebd61a5b124a73a5088eddd38d004'/>
<id>b6087730849ebd61a5b124a73a5088eddd38d004</id>
<content type='text'>
* Temporarily append "[workspace]" to Cargo.toml and
  then run "cargo2android.py --tests --run".
* Manually add defaults to limit build host.
* Manually add TEST_MAPPING to select all rust_test modules.
* libsys_util depends on libcap in src/capabilities.rs,
  but not specified in Cargo.toml. Generated Android.bp
  needs post-editing to add libcap to link.

Bug: 140938178
Test: atest --include-subdirs --rebuild-module-info external/crosvm
Change-Id: I814d8632b316a1ca6e69d09c2ab74e7ac9b80bb0
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Temporarily append "[workspace]" to Cargo.toml and
  then run "cargo2android.py --tests --run".
* Manually add defaults to limit build host.
* Manually add TEST_MAPPING to select all rust_test modules.
* libsys_util depends on libcap in src/capabilities.rs,
  but not specified in Cargo.toml. Generated Android.bp
  needs post-editing to add libcap to link.

Bug: 140938178
Test: atest --include-subdirs --rebuild-module-info external/crosvm
Change-Id: I814d8632b316a1ca6e69d09c2ab74e7ac9b80bb0
</pre>
</div>
</content>
</entry>
<entry>
<title>Add crosvm_defaults with only supported platforms.</title>
<updated>2019-11-15T16:16:19+00:00</updated>
<author>
<name>Ivan Lozano</name>
<email>ivanlozano@google.com</email>
</author>
<published>2019-11-15T16:12:24+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=324ed130340e591a0ffbc2ef8d2a7b4a2d116be0'/>
<id>324ed130340e591a0ffbc2ef8d2a7b4a2d116be0</id>
<content type='text'>
Adds a rust_defaults module that ensures that our crosvm modules are
only built on supported platforms.

Bug: 144553403
Bug: 140938178
Test: m -j crosvm.experimental
Test: modules disabled for unsupported platforms.
Change-Id: I0baec2b4f8c6839c858678270c1c6d527ba4716d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds a rust_defaults module that ensures that our crosvm modules are
only built on supported platforms.

Bug: 144553403
Bug: 140938178
Test: m -j crosvm.experimental
Test: modules disabled for unsupported platforms.
Change-Id: I0baec2b4f8c6839c858678270c1c6d527ba4716d
</pre>
</div>
</content>
</entry>
<entry>
<title>Use default module name 'liblibc'</title>
<updated>2019-10-31T19:00:31+00:00</updated>
<author>
<name>Chih-Hung Hsieh</name>
<email>chh@google.com</email>
</author>
<published>2019-10-31T19:00:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=0074e6598852b3133efdd1ca5094310f287a1b2a'/>
<id>0074e6598852b3133efdd1ca5094310f287a1b2a</id>
<content type='text'>
Test: mm all rust projects
Change-Id: I09d488eaf93e4a1023292d0feed3bfc57ab52535
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Test: mm all rust projects
Change-Id: I09d488eaf93e4a1023292d0feed3bfc57ab52535
</pre>
</div>
</content>
</entry>
<entry>
<title>Generate Android.bp into subdirectories.</title>
<updated>2019-10-15T05:41:39+00:00</updated>
<author>
<name>Chih-Hung Hsieh</name>
<email>chh@google.com</email>
</author>
<published>2019-10-15T05:16:51+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=497df9d05d07a791784262596471900a83298793'/>
<id>497df9d05d07a791784262596471900a83298793</id>
<content type='text'>
* Use a script cargo2android.py to generate Android.bp files
  from cargo build -v output. Cargo.toml and some build.rs
  files were temporarily changed to pass cargo build.
* Missing output are copied from old Android.bp file:
  * Rerun cargo2android.py in:
    ./tempfile ./gpu_display ./gpu_buffer ./gpu_renderer
  * Native code modules are not handled by cargo2android.py:
    * Copy modules from old Android.bp to ./gpu_display
    * Copy attributes of crosvm from old Android.bp to ./Android.bp
    * Copy libhost_cpuid to x86_64/Android.bp

Test: mm in crosvm and other rust directories.
Change-Id: I987dd881d088d950e073dc127d19240b6abc57f2
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Use a script cargo2android.py to generate Android.bp files
  from cargo build -v output. Cargo.toml and some build.rs
  files were temporarily changed to pass cargo build.
* Missing output are copied from old Android.bp file:
  * Rerun cargo2android.py in:
    ./tempfile ./gpu_display ./gpu_buffer ./gpu_renderer
  * Native code modules are not handled by cargo2android.py:
    * Copy modules from old Android.bp to ./gpu_display
    * Copy attributes of crosvm from old Android.bp to ./Android.bp
    * Copy libhost_cpuid to x86_64/Android.bp

Test: mm in crosvm and other rust directories.
Change-Id: I987dd881d088d950e073dc127d19240b6abc57f2
</pre>
</div>
</content>
</entry>
<entry>
<title>edition: Eliminate blocks superseded by NLL</title>
<updated>2019-04-18T00:22:57+00:00</updated>
<author>
<name>David Tolnay</name>
<email>dtolnay@chromium.org</email>
</author>
<published>2019-04-15T22:30:21+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=1c5e2557e2eb3992c320b658ef117cb578bc6fe1'/>
<id>1c5e2557e2eb3992c320b658ef117cb578bc6fe1</id>
<content type='text'>
Before the new borrow checker in the 2018 edition, we sometimes used to
have to manually insert curly braced blocks to limit the scope of
borrows. These are no longer needed.

Details in:

https://doc.rust-lang.org/edition-guide/rust-2018/ownership-and-lifetimes/non-lexical-lifetimes.html

TEST=cargo check --all-features
TEST=local kokoro

Change-Id: I59f9f98dcc03c8790c53e080a527ad9b68c8d6f3
Reviewed-on: https://chromium-review.googlesource.com/1568075
Commit-Ready: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: Daniel Verkamp &lt;dverkamp@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before the new borrow checker in the 2018 edition, we sometimes used to
have to manually insert curly braced blocks to limit the scope of
borrows. These are no longer needed.

Details in:

https://doc.rust-lang.org/edition-guide/rust-2018/ownership-and-lifetimes/non-lexical-lifetimes.html

TEST=cargo check --all-features
TEST=local kokoro

Change-Id: I59f9f98dcc03c8790c53e080a527ad9b68c8d6f3
Reviewed-on: https://chromium-review.googlesource.com/1568075
Commit-Ready: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: Daniel Verkamp &lt;dverkamp@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>clippy: Resolve single_match</title>
<updated>2019-04-18T00:22:54+00:00</updated>
<author>
<name>David Tolnay</name>
<email>dtolnay@chromium.org</email>
</author>
<published>2019-04-13T02:35:23+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=9f2929479b23765629978e16914ed773d9304046'/>
<id>9f2929479b23765629978e16914ed773d9304046</id>
<content type='text'>
TEST=bin/clippy

Change-Id: Iea0d3539b3ab587a2d97f676e1d9c7a239504308
Reviewed-on: https://chromium-review.googlesource.com/1566748
Commit-Ready: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: Daniel Verkamp &lt;dverkamp@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
TEST=bin/clippy

Change-Id: Iea0d3539b3ab587a2d97f676e1d9c7a239504308
Reviewed-on: https://chromium-review.googlesource.com/1566748
Commit-Ready: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: Daniel Verkamp &lt;dverkamp@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>clippy: Switch to tool attributes for suppressing lints</title>
<updated>2019-04-15T09:06:09+00:00</updated>
<author>
<name>David Tolnay</name>
<email>dtolnay@chromium.org</email>
</author>
<published>2019-04-12T22:40:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=967c2f2c9bce9e177f0eea3f1bb73d35d9c95922'/>
<id>967c2f2c9bce9e177f0eea3f1bb73d35d9c95922</id>
<content type='text'>
Tool attributes were stabilized in Rust 1.31:
https://blog.rust-lang.org/2018/12/06/Rust-1.31-and-rust-2018.html#tool-lints

Before:

    #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment)]

After:

    #[allow(clippy::cast_ptr_alignment)]

TEST=cargo check --all-features

Change-Id: If2f1511f6231d60578b5e0d5bd4210a68eb08caf
Reviewed-on: https://chromium-review.googlesource.com/1566651
Commit-Ready: David Tolnay &lt;dtolnay@chromium.org&gt;
Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt;
Tested-by: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: David Tolnay &lt;dtolnay@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Tool attributes were stabilized in Rust 1.31:
https://blog.rust-lang.org/2018/12/06/Rust-1.31-and-rust-2018.html#tool-lints

Before:

    #[cfg_attr(feature = "cargo-clippy", allow(cast_ptr_alignment)]

After:

    #[allow(clippy::cast_ptr_alignment)]

TEST=cargo check --all-features

Change-Id: If2f1511f6231d60578b5e0d5bd4210a68eb08caf
Reviewed-on: https://chromium-review.googlesource.com/1566651
Commit-Ready: David Tolnay &lt;dtolnay@chromium.org&gt;
Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt;
Tested-by: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: David Tolnay &lt;dtolnay@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>edition: Remove extern crate lines</title>
<updated>2019-04-15T09:06:08+00:00</updated>
<author>
<name>David Tolnay</name>
<email>dtolnay@chromium.org</email>
</author>
<published>2019-04-11T21:30:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/mirrors/AOSP/platform_external_crosvm/commit/?id=aecf9a4dee6c004bceabf268a5b36d24c3744ca6'/>
<id>aecf9a4dee6c004bceabf268a5b36d24c3744ca6</id>
<content type='text'>
In Rust 2018 edition, `extern crate` is no longer required for importing
from other crates. Instead of writing:

    extern crate dep;
    use dep::Thing;

we write:

    use dep::Thing;

In this approach, macros are imported individually from the declaring
crate rather than through #[macro_use]. Before:

    #[macro_use]
    extern crate sys_util;

After:

    use sys_util::{debug, error};

The only place that `extern crate` continues to be required is in
importing the compiler's proc_macro API into a procedural macro crate.
This will hopefully be fixed in a future Rust release.

    extern crate proc_macro;

TEST=cargo check
TEST=cargo check --all-features
TEST=cargo check --target aarch64-unknown-linux-gnu
TEST=local kokoro

Change-Id: I0b43768c0d81f2a250b1959fb97ba35cbac56293
Reviewed-on: https://chromium-review.googlesource.com/1565302
Commit-Ready: David Tolnay &lt;dtolnay@chromium.org&gt;
Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt;
Tested-by: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: David Tolnay &lt;dtolnay@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In Rust 2018 edition, `extern crate` is no longer required for importing
from other crates. Instead of writing:

    extern crate dep;
    use dep::Thing;

we write:

    use dep::Thing;

In this approach, macros are imported individually from the declaring
crate rather than through #[macro_use]. Before:

    #[macro_use]
    extern crate sys_util;

After:

    use sys_util::{debug, error};

The only place that `extern crate` continues to be required is in
importing the compiler's proc_macro API into a procedural macro crate.
This will hopefully be fixed in a future Rust release.

    extern crate proc_macro;

TEST=cargo check
TEST=cargo check --all-features
TEST=cargo check --target aarch64-unknown-linux-gnu
TEST=local kokoro

Change-Id: I0b43768c0d81f2a250b1959fb97ba35cbac56293
Reviewed-on: https://chromium-review.googlesource.com/1565302
Commit-Ready: David Tolnay &lt;dtolnay@chromium.org&gt;
Commit-Ready: ChromeOS CL Exonerator Bot &lt;chromiumos-cl-exonerator@appspot.gserviceaccount.com&gt;
Tested-by: David Tolnay &lt;dtolnay@chromium.org&gt;
Tested-by: kokoro &lt;noreply+kokoro@google.com&gt;
Reviewed-by: David Tolnay &lt;dtolnay@chromium.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
