From 47939f67252edc6295268dfebff24b5450eaba85 Mon Sep 17 00:00:00 2001 From: Olivier Deprez Date: Mon, 6 Jan 2020 15:45:22 +0100 Subject: coverity: debugfs devfip remove comparisons to LONG_MAX CID 353228: Integer handling issues (CONSTANT_EXPRESSION_RESULT) The checks on size and offset_address in get_entry always resolve to false provided those fields are long long int and cannot be greater than LONG_MAX. Signed-off-by: Olivier Deprez Change-Id: I0fac485a39ac4a40ae8c0d25a706ad74c795e130 --- lib/debugfs/devfip.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'lib') diff --git a/lib/debugfs/devfip.c b/lib/debugfs/devfip.c index 5581b219f..fc14e707e 100644 --- a/lib/debugfs/devfip.c +++ b/lib/debugfs/devfip.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019, Arm Limited. All rights reserved. + * Copyright (c) 2019-2020, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-3-Clause */ @@ -103,10 +103,6 @@ static int get_entry(chan_t *c, struct fip_entry *entry) return -1; } - if ((entry->size > LONG_MAX) || (entry->offset_address > LONG_MAX)) { - return -1; - } - if (entry->size == 0) { return 0; } -- cgit v1.2.3