From 7c3b5dcb95deb41fda40de7eb682629fcbdd3b46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20=C5=BBenczykowski?= Date: Mon, 18 Nov 2019 17:20:01 -0800 Subject: remove configuration option 'ipv4mtu' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Specifying the MTU in a per-device configuration file is in general incorrect because different networks have different MTUs. Carriers or operators that want to lower the MTU can lower the IPv6 MTU (from which the IPv4 MTU is automatically calculated), or set the MTU manually from Nat464Xlat or ConnectivityService. Doing it this way has the benefit of supporting different MTUs for different networks. Test: builds Bug: 144730808 Signed-off-by: Maciej Żenczykowski Change-Id: Ia6005421e81fc0007067d9774e28f9aae64d1160 --- config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.c b/config.c index c370770..e820ba0 100644 --- a/config.c +++ b/config.c @@ -330,7 +330,7 @@ int read_config(const char *file, const char *uplink_interface, const char *plat if (!config_item_int16_t(root, "mtu", "-1", &Global_Clatd_Config.mtu)) goto failed; - if (!config_item_int16_t(root, "ipv4mtu", "-1", &Global_Clatd_Config.ipv4mtu)) goto failed; + Global_Clatd_Config.ipv4mtu = -1; if (!config_item_ip(root, "ipv4_local_subnet", DEFAULT_IPV4_LOCAL_SUBNET, &Global_Clatd_Config.ipv4_local_subnet)) -- cgit v1.2.3