aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYilong Li <liyl@google.com>2020-09-11 02:08:02 -0700
committerYilong Li <liyl@google.com>2020-09-11 19:34:40 -0700
commit735171535eedbf5016b36090f4e5d521ed8301f6 (patch)
tree5705e7af1de16e09340b8a35498f7eab906ac3c0
parent1454ba84c0ac0c2fa683bba236548405b5c40f6a (diff)
downloaddevice_generic_goldfish-opengl-735171535eedbf5016b36090f4e5d521ed8301f6.tar.gz
device_generic_goldfish-opengl-735171535eedbf5016b36090f4e5d521ed8301f6.tar.bz2
device_generic_goldfish-opengl-735171535eedbf5016b36090f4e5d521ed8301f6.zip
renderControl_enc: Add rcCreateBuffer2 method.
This change adds a new rendercontrol method: uint32_t rcCreateBuffer2(size, memoryProperty) This is used to create Vulkan buffers with given memory properties. This will be used on host-visible buffers on Vulkan AEMU/FEMU. Change-Id: Icc4f5ab972ed8d747e4924d0696d085469a9646c
-rw-r--r--system/renderControl_enc/renderControl_client_context.cpp1
-rw-r--r--system/renderControl_enc/renderControl_client_context.h1
-rw-r--r--system/renderControl_enc/renderControl_client_proc.h1
-rw-r--r--system/renderControl_enc/renderControl_enc.cpp43
-rw-r--r--system/renderControl_enc/renderControl_entry.cpp7
-rw-r--r--system/renderControl_enc/renderControl_ftable.h1
-rw-r--r--system/renderControl_enc/renderControl_opcodes.h3
7 files changed, 56 insertions, 1 deletions
diff --git a/system/renderControl_enc/renderControl_client_context.cpp b/system/renderControl_enc/renderControl_client_context.cpp
index 34e973d1..ded019b8 100644
--- a/system/renderControl_enc/renderControl_client_context.cpp
+++ b/system/renderControl_enc/renderControl_client_context.cpp
@@ -63,6 +63,7 @@ int renderControl_client_context_t::initDispatchByName(void *(*getProc)(const ch
rcCloseBuffer = (rcCloseBuffer_client_proc_t) getProc("rcCloseBuffer", userData);
rcSetColorBufferVulkanMode2 = (rcSetColorBufferVulkanMode2_client_proc_t) getProc("rcSetColorBufferVulkanMode2", userData);
rcMapGpaToBufferHandle = (rcMapGpaToBufferHandle_client_proc_t) getProc("rcMapGpaToBufferHandle", userData);
+ rcCreateBuffer2 = (rcCreateBuffer2_client_proc_t) getProc("rcCreateBuffer2", userData);
return 0;
}
diff --git a/system/renderControl_enc/renderControl_client_context.h b/system/renderControl_enc/renderControl_client_context.h
index 62518fcf..54749dfd 100644
--- a/system/renderControl_enc/renderControl_client_context.h
+++ b/system/renderControl_enc/renderControl_client_context.h
@@ -63,6 +63,7 @@ struct renderControl_client_context_t {
rcCloseBuffer_client_proc_t rcCloseBuffer;
rcSetColorBufferVulkanMode2_client_proc_t rcSetColorBufferVulkanMode2;
rcMapGpaToBufferHandle_client_proc_t rcMapGpaToBufferHandle;
+ rcCreateBuffer2_client_proc_t rcCreateBuffer2;
virtual ~renderControl_client_context_t() {}
typedef renderControl_client_context_t *CONTEXT_ACCESSOR_TYPE(void);
diff --git a/system/renderControl_enc/renderControl_client_proc.h b/system/renderControl_enc/renderControl_client_proc.h
index a303e36a..9f8f39c9 100644
--- a/system/renderControl_enc/renderControl_client_proc.h
+++ b/system/renderControl_enc/renderControl_client_proc.h
@@ -65,6 +65,7 @@ typedef uint32_t (renderControl_APIENTRY *rcCreateBuffer_client_proc_t) (void *
typedef void (renderControl_APIENTRY *rcCloseBuffer_client_proc_t) (void * ctx, uint32_t);
typedef GLint (renderControl_APIENTRY *rcSetColorBufferVulkanMode2_client_proc_t) (void * ctx, uint32_t, uint32_t, uint32_t);
typedef int (renderControl_APIENTRY *rcMapGpaToBufferHandle_client_proc_t) (void * ctx, uint32_t, uint64_t);
+typedef uint32_t (renderControl_APIENTRY *rcCreateBuffer2_client_proc_t) (void * ctx, uint64_t, uint32_t);
#endif
diff --git a/system/renderControl_enc/renderControl_enc.cpp b/system/renderControl_enc/renderControl_enc.cpp
index f4024054..f9994c47 100644
--- a/system/renderControl_enc/renderControl_enc.cpp
+++ b/system/renderControl_enc/renderControl_enc.cpp
@@ -2103,6 +2103,48 @@ int rcMapGpaToBufferHandle_enc(void *self , uint32_t bufferHandle, uint64_t gpa)
return retval;
}
+uint32_t rcCreateBuffer2_enc(void *self , uint64_t size, uint32_t memoryProperty)
+{
+ AEMU_SCOPED_TRACE("rcCreateBuffer2 encode");
+
+ renderControl_encoder_context_t *ctx = (renderControl_encoder_context_t *)self;
+ IOStream *stream = ctx->m_stream;
+ ChecksumCalculator *checksumCalculator = ctx->m_checksumCalculator;
+ bool useChecksum = checksumCalculator->getVersion() > 0;
+
+ unsigned char *ptr;
+ unsigned char *buf;
+ const size_t sizeWithoutChecksum = 8 + 8 + 4;
+ const size_t checksumSize = checksumCalculator->checksumByteSize();
+ const size_t totalSize = sizeWithoutChecksum + checksumSize;
+ buf = stream->alloc(totalSize);
+ ptr = buf;
+ int tmp = OP_rcCreateBuffer2;memcpy(ptr, &tmp, 4); ptr += 4;
+ memcpy(ptr, &totalSize, 4); ptr += 4;
+
+ memcpy(ptr, &size, 8); ptr += 8;
+ memcpy(ptr, &memoryProperty, 4); ptr += 4;
+
+ if (useChecksum) checksumCalculator->addBuffer(buf, ptr-buf);
+ if (useChecksum) checksumCalculator->writeChecksum(ptr, checksumSize); ptr += checksumSize;
+
+
+ uint32_t retval;
+ stream->readback(&retval, 4);
+ if (useChecksum) checksumCalculator->addBuffer(&retval, 4);
+ if (useChecksum) {
+ unsigned char *checksumBufPtr = NULL;
+ unsigned char checksumBuf[ChecksumCalculator::kMaxChecksumSize];
+ if (checksumSize > 0) checksumBufPtr = &checksumBuf[0];
+ stream->readback(checksumBufPtr, checksumSize);
+ if (!checksumCalculator->validate(checksumBufPtr, checksumSize)) {
+ ALOGE("rcCreateBuffer2: GL communication error, please report this issue to b.android.com.\n");
+ abort();
+ }
+ }
+ return retval;
+}
+
} // namespace
renderControl_encoder_context_t::renderControl_encoder_context_t(IOStream *stream, ChecksumCalculator *checksumCalculator)
@@ -2163,5 +2205,6 @@ renderControl_encoder_context_t::renderControl_encoder_context_t(IOStream *strea
this->rcCloseBuffer = &rcCloseBuffer_enc;
this->rcSetColorBufferVulkanMode2 = &rcSetColorBufferVulkanMode2_enc;
this->rcMapGpaToBufferHandle = &rcMapGpaToBufferHandle_enc;
+ this->rcCreateBuffer2 = &rcCreateBuffer2_enc;
}
diff --git a/system/renderControl_enc/renderControl_entry.cpp b/system/renderControl_enc/renderControl_entry.cpp
index 2d38bc11..2f30f4c6 100644
--- a/system/renderControl_enc/renderControl_entry.cpp
+++ b/system/renderControl_enc/renderControl_entry.cpp
@@ -58,6 +58,7 @@ extern "C" {
void rcCloseBuffer(uint32_t buffer);
GLint rcSetColorBufferVulkanMode2(uint32_t colorBuffer, uint32_t mode, uint32_t memoryProperty);
int rcMapGpaToBufferHandle(uint32_t bufferHandle, uint64_t gpa);
+ uint32_t rcCreateBuffer2(uint64_t size, uint32_t memoryProperty);
};
#ifndef GET_CONTEXT
@@ -384,3 +385,9 @@ int rcMapGpaToBufferHandle(uint32_t bufferHandle, uint64_t gpa)
return ctx->rcMapGpaToBufferHandle(ctx, bufferHandle, gpa);
}
+uint32_t rcCreateBuffer2(uint64_t size, uint32_t memoryProperty)
+{
+ GET_CONTEXT;
+ return ctx->rcCreateBuffer2(ctx, size, memoryProperty);
+}
+
diff --git a/system/renderControl_enc/renderControl_ftable.h b/system/renderControl_enc/renderControl_ftable.h
index d41bd632..3cec1d36 100644
--- a/system/renderControl_enc/renderControl_ftable.h
+++ b/system/renderControl_enc/renderControl_ftable.h
@@ -61,6 +61,7 @@ static const struct _renderControl_funcs_by_name {
{"rcCloseBuffer", (void*)rcCloseBuffer},
{"rcSetColorBufferVulkanMode2", (void*)rcSetColorBufferVulkanMode2},
{"rcMapGpaToBufferHandle", (void*)rcMapGpaToBufferHandle},
+ {"rcCreateBuffer2", (void*)rcCreateBuffer2},
};
static const int renderControl_num_funcs = sizeof(renderControl_funcs_by_name) / sizeof(struct _renderControl_funcs_by_name);
diff --git a/system/renderControl_enc/renderControl_opcodes.h b/system/renderControl_enc/renderControl_opcodes.h
index df1803a3..a59306d0 100644
--- a/system/renderControl_enc/renderControl_opcodes.h
+++ b/system/renderControl_enc/renderControl_opcodes.h
@@ -56,7 +56,8 @@
#define OP_rcCloseBuffer 10050
#define OP_rcSetColorBufferVulkanMode2 10051
#define OP_rcMapGpaToBufferHandle 10052
-#define OP_last 10053
+#define OP_rcCreateBuffer2 10053
+#define OP_last 10054
#endif