| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
It just started reporting LTE after not doing so the last few days...
I'm not sure if I did something to fix it or if the phone/network just
decided to.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
I think Deactivate and Reset was overkill that was breaking it
|
| | |
|
| |
|
|
|
| |
It's flaky. There may be some wrong interactions between
us and Android for setting up IP addrs, routes, and DNS.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Identify empty impls, mark them abstract, then provide
exception-throwing methods to implement them.
|
| |
|
|
|
|
| |
Due to empty implementation of iccOpenLogicalChannel() in BaseCommands,
the framework was waiting forever for UiccCarrierPrivilegeRules to load,
so the SIM would never appear as present.
|
| |
|
|
|
| |
Wrapper class was not public, and Proguard was removing an enclosing
class that the dbus lib requires.
|
| |
|
|
| |
implement new CommandsInterface methods
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* restructure inter-module dependencies to support this
* dispatch all signals through RilOfono class so we don't have to deal
with registering/unregistering signals as modules come and go
* store module references in RilOfono (rather than RilWrapper) with
internal interface types, so we can dispatch signals
* remove _unknown registration state (not a real oFono string),
use "none" instead
* remove VoiceRadioTechnologyGetter, because the code using it ended
up needing more netreg interaction, to the point we may as well just
use the oFono stuff directly
* allow suppressing propchange logs, because two modules are now
tracking netreg props
* returning RADIO_NOT_AVAILABLE in the RilWrapper, when modules are
null, seemed to prevent the framework from coming online, so just use
GENERIC_FAILURE with a modified log message
* work around issue where ConnManager never reports Attached. It seems
to be a new issue, I guess due to timing differences with this new
implementation. The workaround is to watch NetworkRegistration for
Status changes, and reload ConnectionManager's props in response.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Main object passes oFono interfaces into modules, instead of them
querying the interfaces themselves. Explicitly unregister signals
instead of throwing away the dbus connection.
Preparing to dynamically create/destroy individual modules in response
to oFono interfaces coming (un)available.
|
| |
|
|
| |
Update status, and move test execution to modem-up.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
My test case was to restart ofonod. Before this change, the RIL wouldn't
bring the modem up again.
proguard: allow dbus exception classes to survive (created by
reflection)
Remove hardcoded modem path, take the "first" modem.
Make the error report for some semi-common dbus errors be briefer.
|
| | |
|
| |
|
|
|
| |
This is what oFono reports (maybe QMI voicecall bug), but it breaks
Android's expectations, so map that to INCOMING.
|
| |
|
|
|
|
|
|
| |
Remove intermediate buildtool build step, because we can just let
Proguard strip out the build tool in the final APK.
Change some -keep to -keepclassmembers, as we only need the member if
the class is ever used.
|
| | |
|
| |
|
|
|
| |
Fix bugs and cleanup the SIM file refresh implementation since
it was hard to test in the last commit.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bugfixes, work with oFono driver other than rilmodem.
* Notify VoiceNetworkStateRegistrants when we attach to the data
network -- seems to be the way to get the framework to re-poll data
registration state and start any datacalls it wants to. This should
fix the problems where the framework wouldn't even try to start a
datacall.
* Fall back on voice radio technology value if oFono doesn't provide
data technology. Do it by dependency injection of a limited interface
to minimize coupling.
* Return even inactive datacalls (not sure that it matters much).
* Return the netmask, in e.g. "/30" notation as expected by framework
code.
* Setup/teardown the network interface, using
INetworkManagementService. I guess the oFono rilmodem plugin was
doing this for us as a side-effect. I found the network management
service by searching for Java code that could do that stuff, but we
could switch to something else if needed.
Currently relying on oFono to give us the interface name (patched my
gobidev plugin to specify rmnet0), but I wonder if interface assignment
is something better done outside oFono. Does the modem care which
interface is used for which context? It seems weird, in this usecase
at least, for oFono to give us an interface, if it has no relation to
the modem. Could investigate rild's message "Interface rmnet1 will be
used for CID(2)" to see how it decides.
Some errors I was seeing early on may have come from oFono not having
an interface assigned, so if we do leave that unset on their end
maybe there's something to work around.
|
| | |
|
| |
|
|
|
|
|
| |
oFono has no way for us to support the full Android API of start/stop
tones on demand. The implementation seems good enough to navigate my
voicemail. There was some flakiness, likely caused by my quick hacky
implementation in oFono for DTMF on QMI devices.
|
| |
|
|
|
| |
Gets rid of 'init' warning us it's starting daemons in the init domain,
and allows the debugger to strace ofonod if it crashes.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Methods can mark themselves as safe to run on main thread, in which case
they will not be sent to the dbus thread. A lot are safe for main
thread, because they either always return UNSUPPORTED, or they just
return some props we've been keeping up-to-date.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
netreg CellID seems especially prone to this
|
| |
|
|
|
| |
* Removed unnecessary cross-thread posting (Messages will find their own way to their thread)
* Centralize logging of notifications and facade Android's RegistrantList under my own
|
| |
|
|
|
|
| |
Such as:
* Let catch-alls stop us from crashing unnecessarily
* Log and drop things that aren't severe
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Should remove repetitive code, and chances for errors like doing stuff on the
wrong thread, or an exception that crashes the phone process or never responds
to the caller after the error occurrred.
One downside is that now *everything* is shuttled to another thread, even the
trivial ones that just return some props. This can be addressed later by something
like a @SafeForMainThread annotation.
|
| |
|
|
|
|
|
|
|
|
| |
Basic network info, and SMS seem to be working. No calls or USSD, as
they are not supported by the oFono mainline.
* update init.rc patches
* fix some assumptions I made (ConnManager was sometimes not available
in the QMI version, causing crash; and incoming SMSs seem to have no SMSC)
* change hardcoded (in one place) dbus path to the modem
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|