path: root/Documentation/SubmittingPatches
diff options
authorJosh Triplett <josh@joshtriplett.org>2014-04-03 21:48:28 (GMT)
committerLinus Torvalds <torvalds@linux-foundation.org>2014-04-03 23:21:06 (GMT)
commit74a475acea49459721ae4b062d3da68c74259009 (patch)
tree87d250ceb65f3ceaf9efe7cb0b2f656ea6e7a3b6 /Documentation/SubmittingPatches
parent69369a7003735d0d8ef22097e27a55a8bad9557a (diff)
SubmittingPatches: add style recommendation to use imperative descriptions
Most commit messages use this style, and the recommendation frequently comes up in discussions (especially in response to patches that don't use it), but that recommendation doesn't actually appear anywhere in Documentation. Add this style guideline to SubmittingPatches, using the description from git's SubmittingPatches. Signed-off-by: Josh Triplett <josh@joshtriplett.org> Acked-by: Borislav Petkov <bp@suse.de> Cc: Rob Landley <rob@landley.net> Cc: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'Documentation/SubmittingPatches')
1 files changed, 5 insertions, 0 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 26b1e31d..c74e73c 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -106,6 +106,11 @@ I.e., the patch (series) and its description should be self-contained.
This benefits both the patch merger(s) and reviewers. Some reviewers
probably didn't even receive earlier versions of the patch.
+Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
+instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
+to do frotz", as if you are giving orders to the codebase to change
+its behaviour.
If the patch fixes a logged bug entry, refer to that bug entry by
number and URL.