From f6e92a9e939a28327eea49b5931715ba97a62970 Mon Sep 17 00:00:00 2001 From: Gilbert Ramirez Date: Sun, 12 Mar 2000 04:48:32 +0000 Subject: Break proto_tree_add_item_format() into multiple functions: proto_tree_add_protocol_format() proto_tree_add_uint_format() proto_tree_add_ipxnet_format() proto_tree_add_ipv4_format() proto_tree_add_ipv6_format() proto_tree_add_bytes_format() proto_tree_add_string_format() proto_tree_add_ether_format() proto_tree_add_time_format() proto_tree_add_double_format() proto_tree_add_boolean_format() If using GCC 2.x, we can check the print-format against the variable args passed in. Regardless of compiler, we can now check at run-time that the field type passed into the function corresponds to what that function expects (FT_UINT, FT_BOOLEAN, etc.) Note that proto_tree_add_protocol_format() does not require a value field, since the value of a protocol is always NULL. It's more intuitive w/o the vestigial argument. Fixed a proto_tree_add_item_format-related bug in packet-isis-hello.c Fixed a variable usage bug in packet-v120.c. (ett_* was used instead of hf_*) Checked in Guy's fix for the function declearation for proto_tree_add_text() and proto_tree_add_notext(). svn path=/trunk/; revision=1713 --- packet-isis.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'packet-isis.c') diff --git a/packet-isis.c b/packet-isis.c index ba54a2b88c..5d635e1604 100644 --- a/packet-isis.c +++ b/packet-isis.c @@ -2,7 +2,7 @@ * Routines for ISO/OSI network and transport protocol packet disassembly, core * bits. * - * $Id: packet-isis.c,v 1.3 2000/01/24 03:33:31 guy Exp $ + * $Id: packet-isis.c,v 1.4 2000/03/12 04:47:41 gram Exp $ * Stuart Stanley * * Ethereal - Network traffic analyzer @@ -207,7 +207,7 @@ dissect_isis(const u_char *pd, int offset, frame_data *fd, offset + 2, 1, ihdr->isis_version ); proto_tree_add_item(isis_tree, hf_isis_reserved, offset + 3, 1, ihdr->isis_reserved ); - proto_tree_add_item_format(isis_tree, hf_isis_type, + proto_tree_add_uint_format(isis_tree, hf_isis_type, offset + 4, 1, ihdr->isis_type, "Type: %s (R:%s%s%s)", val_to_str(ihdr->isis_type & ISIS_TYPE_MASK, isis_vals, -- cgit v1.2.3