From 7d442624064b470be60a976c9d9ae06069458aac Mon Sep 17 00:00:00 2001 From: Kovarththanan Rajaratnam Date: Sat, 15 Aug 2009 06:38:10 +0000 Subject: This patch introduces packet_add_new_data_source() which effectively deprecates add_new_data_source(). This is based on the following observation: 1) The tvb + name (aka. data_source) is only used when the protocol tree is visible The current implementation of add_new_data_source() doesn't take this into account and simply allocates a data_source regardless. This is what packet_add_new_data_source() tries to rectify. A couple of dissectors have already been switched over to the new packet_add_new_data_source(). Many are still missing. Help appreciated! svn path=/trunk/; revision=29427 --- epan/reassemble_test.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'epan/reassemble_test.c') diff --git a/epan/reassemble_test.c b/epan/reassemble_test.c index e5e745f18d..828726a215 100644 --- a/epan/reassemble_test.c +++ b/epan/reassemble_test.c @@ -1062,6 +1062,10 @@ void add_new_data_source(packet_info *pinfo _U_, tvbuff_t *tvb _U_, const char *name _U_) {} +void packet_add_new_data_source(packet_info *pinfo _U_, proto_tree *tree _U_, tvbuff_t *tvb _U_, + const char *name _U_) +{} + proto_item * proto_tree_add_uint(proto_tree *tree _U_, int hfindex _U_, tvbuff_t *tvb _U_, gint start _U_, gint length _U_, guint32 value _U_) -- cgit v1.2.3