aboutsummaryrefslogtreecommitdiffstats
path: root/packet-rsvp.c
Commit message (Collapse)AuthorAgeFilesLines
* Correctly handle Resv Tear Confirm message.Gilbert Ramirez2000-06-021-14/+20
| | | | svn path=/trunk/; revision=2036
* Get rid of the only uses of proto_tree_add_item_old() andGilbert Ramirez2000-05-311-3/+3
| | | | | | | | proto_tree_add_item_hidden_old(), and get rid of the functions as well. Also remove a static function in proto.c that is no longer used (it was used by proto_tree_add_item()). svn path=/trunk/; revision=2033
* Add routines for adding items to a protocol tree that take arguments ofGuy Harris2000-05-311-16/+16
| | | | | | | | | | | | | | | | | a particular type, rather than taking a varargs list, along the lines of the "proto_tree_add_XXX_format()" routines. Replace most calls to "proto_tree_add_item()" and "proto_tree_add_item_hidden()" with calls to those routines. Rename "proto_tree_add_item()" and "proto_tree_add_item_hidden()" to "proto_tree_add_item_old()" and "proto_tree_add_item_hidden_old()", and add new "proto_tree_add_item()" and "proto_tree_add_item_hidden()" routines that don't take the item to be added as an argument - instead, they fetch the argument from the packet whose tvbuff was handed to them, from the offset handed to them. svn path=/trunk/; revision=2031
* Add tvbuff class.Gilbert Ramirez2000-05-111-234/+234
| | | | | | | | | | | | | | | Add exceptions routines. Convert proto_tree_add_*() routines to require tvbuff_t* argument. Convert all dissectors to pass NULL argument ("NullTVB" macro == NULL) as the tvbuff_t* argument to proto_tree_add_*() routines. dissect_packet() creates a tvbuff_t, wraps the next dissect call in a TRY block, will print "Short Frame" on the proto_tree if a BoundsError exception is caught. The FDDI dissector is converted to use tvbuff's. svn path=/trunk/; revision=1939
* Register an "ip.proto" dissector table for IPv4, and have dissectors forGuy Harris2000-04-161-3/+8
| | | | | | | | | | protocols that run inside IPv4 register themselves with it using "dissector_add()". Make various dissectors static if they can be, and get rid of any header files that no longer contain any information as a result of that change. svn path=/trunk/; revision=1870
* Avoid using zero-length arrays - they're an extension that only someGuy Harris2000-04-071-6/+4
| | | | | | | | compilers support, and at least some versions of HP's PA-RISC C compiler, for example (which people do use to compile Ethereal), don't support them. svn path=/trunk/; revision=1818
* Fix some errors discovered by making GCC do format string/argumentGuy Harris2000-03-141-3/+4
| | | | | | | | | | | | | | | cross-checking, and by replacing "proto_tree_add_item_format()" by multiple routines to add items of various types. Make the arguments of "proto_tree_add_bytes_format()" and "proto_tree_add_string_format()" that specify the bytes or the string be "const" pointers, so that one can pass a "const" pointer without complaints from the compiler. Squelch a (bogus, but the compiler isn't in a position to know that) complaint about an uninitialized variable. svn path=/trunk/; revision=1716
* New workaround for not using (ulong *) to dereference memory in RSVP.Ashok Narayanan2000-03-131-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here's the email I wrote to Guy with info on this: Subject: Re: [ethereal-dev] Checked in support for MPLS From: Ashok Narayanan <ashokn@cisco.com> To: gharris@flashcom.net Cc: ethereal-dev@zing.org Date: Mon, 13 Mar 2000 00:10:38 -0500 X-Mailer: Mew version 1.94.1 on XEmacs 21.1 (Biscayne) Guy, > The code in that was fetching some fields by casting pointers into the > packet to "ulong *" and dereferencing the resulting pointer - this is > bad for three reasons: > > "ulong" is not a system-declared data type on all platforms > (it's not on FreeBSD 3.4, at least, for example); > > casting an arbitrary pointer into a frame to point to something > longer than 1 byte, and dereferencing it, is dangerous, as > there's no guarantee that said pointer is properly aligned on > machines that require alignment (such as SPARC, Alpha, and MIPS, > and possibly at least some other RISC processors); I agree with both these points. > the data in an RSVP packet is presumably big-endian in any case, > so you should use "pntohl()" to access it, rather than just > blithely dereferencing it; This is the exact problem which a direct cast attempts to work around. A tree of type FT_IPv4 apparently has a network-to-host conversion built into the proto_tree_add_item call. When you added the pntohl, you inserted a second network-to-host conversion - the result is that all the IP addresses are reversed. Here's an excerpt from tethereal.... 1) ~/sniffer/test/ethereal> ./tethereal -n -r ../../sniffs/mpls_te.cap -R 'rsvp.path' 3 8.024159 17.3.3.3 -> 16.2.2.2 RSVP PATH Message 15 31.589751 17.3.3.3 -> 16.2.2.2 RSVP PATH Message 22 47.072205 17.3.3.3 -> 16.2.2.2 RSVP PATH Message <snip> 2) ~/sniffer/test/ethereal> ./tethereal -n -r ../../sniffs/mpls_te.cap -R 'rsvp.path' -V Frame 3 (306 on wire, 306 captured) <snip> Ethernet II <snip> Internet Protocol <snip> Source: 17.3.3.3 (17.3.3.3) Destination: 16.2.2.2 (16.2.2.2) <======== Destination is 16.2.2.2 Options: (4 bytes) Unknown (0x94) (4 bytes) Resource ReserVation Protocol (RSVP) RSVP Header RSVP Version: 1 Flags: 00 Message Type: PATH Message (1) Message Checksum Sending TTL: 254 Message length: 264 SESSION: 1 Length: 16 Class number: 1 - SESSION object C-type: 7 - IPv4 LSP Destination address: 2.2.2.16 (2.2.2.16) <======== Destination is reversed Tunnel ID: 1 Extended tunnel ID: 285410051 I'm looking around in the filtering code (which I don't really understand), to see if I can find a quick fix to the problem. If you or Gilbert knows what's happening, you may want to fix it. But as it stands now, using pntohl() in a proto_tree_add_item() call is broken. A slightly better workaround is to do something like this: memcpy(&ip_addr, pd[offset2], 4); proto_tree_add_item(....., ip_addr); but this is still ugly. I'll implement this workaround and check in the code (since as it stands now, RSVP decoding is broken). However, the underlying issue needs to be resolved. -Ashok svn path=/trunk/; revision=1714
* "ulong" is not a system-declared data type on all platforms;Guy Harris2000-03-101-6/+6
| | | | | | | | | | | | | | | | casting an arbitrary pointer into a frame to point to something longer than 1 byte, and dereferencing it, is dangerous, as there's no guarantee that said pointer is properly aligned on machines that require alignment; the data in an RSVP packet is presumably big-endian in any case, so you should use "pntohl()" to access it, rather than just blithely dereferencing it; so use "pntohl()" to extract fields from an RSVP packet rather than casting pointers to "ulong *" and dereferencing them. svn path=/trunk/; revision=1709
* Support for MultiProtocol Label Switching (MPLS). The following supportAshok Narayanan2000-03-091-134/+502
| | | | | | | | | | | | | | | | | is being added - MPLS Traffic Engineering extensions for RSVP - MPLS-encapsulated IP packets on Ethernet - OSPF Extensions for MPLS (including generic opaque LSA support for OSPF) THe following features will be committed at a later date (if I get around to writing them :-) - Label Distribution Protocol (LDP) - IS-IS Extensions for MPLS svn path=/trunk/; revision=1707
* Fix some "proto_tree_add_text()" calls.Guy Harris2000-03-071-80/+80
| | | | svn path=/trunk/; revision=1701
* Create a header file for every packet-*.c file. Prune the packet.h file.Gilbert Ramirez2000-02-151-1/+433
| | | | | | | | | | | | | This change allows you to add a new packet-*.c file and not cause a recompilation of everything that #include's packet.h Add the plugin_api.[ch] files ot the plugins/Makefile.am packaging list. Add #define YY_NO_UNPUT 1 to the lex source so that the yyunput symbol is not defined, squelching a compiler complaint when compiling the generated C file. svn path=/trunk/; revision=1637
* Fix a bunch of dissectors to use "pi.captured_len" rather thanGuy Harris2000-01-241-2/+2
| | | | | | | | | | "fd->cap_len" for the frame length - or to use macros such as "BYTES_ARE_IN_FRAME()", "IS_DATA_IN_FRAME()", and "END_OF_FRAME", which use "pi.captured_len" - so that they correctly handle frames where the actual data length of the packet is less than the size of the raw frame, e.g. with encapsulations such as ISL. svn path=/trunk/; revision=1530
* Check header->msg_type before using it.Gilbert Ramirez1999-12-131-6/+6
| | | | svn path=/trunk/; revision=1312
* Replace the ETT_ "enum" members, declared in "packet.h", withGuy Harris1999-11-161-21/+61
| | | | | | | | | | | | | | | | | dynamically-assigned "ett_" integer values, assigned by "proto_register_subtree_array()"; this: obviates the need to update "packet.h" whenever you add a new subtree type - you only have to add a call to "proto_register_subtree_array()" to a "register" routine and an array of pointers to "ett_", if they're not already there, and add a pointer to the new "ett_" variable to the array, if they are there; would allow run-time-loaded dissectors to allocate subtree types when they're loaded. svn path=/trunk/; revision=1043
* New proto_tree header_field_info stuff. Header_field_infos now containGilbert Ramirez1999-10-121-30/+82
| | | | | | | | | | | | | | | | | | | | | the base for numbers to be displayed in, bitmasks for bitfields, and blurbs (which are one or two sentences describing the field). proto_tree_add*() routines now automatically handle bitfields. You tell it which header field you are adding, and just pass it the value of the entire field, and the proto_tree routines will do the masking and shifting for you. This means that bitfields are more naturally filtered via dfilter now. Added Phil Techau's support for signed integers in dfilters/proto_tree. Added the beginning of the SNA dissector. It's not complete, but I'm committing it now because it has example after example of how to use bitfields with the new header_field_info struct and proto_tree routines. It was the impetus to change how header_field_info works. svn path=/trunk/; revision=815
* Fix some compilation warnings.Gilbert Ramirez1999-08-291-2/+2
| | | | svn path=/trunk/; revision=609
* Updated RSVP with Ashok's patch. Fixes code for 64-bit platforms.Gilbert Ramirez1999-08-281-4/+4
| | | | svn path=/trunk/; revision=606
* Updated RSVP decoder with Ashok's newest code.Gilbert Ramirez1999-08-271-11/+181
| | | | svn path=/trunk/; revision=590
* Added Ashok's fix for RSVP and support for RSVP+.Gilbert Ramirez1999-08-121-102/+202
| | | | svn path=/trunk/; revision=475
* Made the protocol (but not the fields) use the new proto_tree routine,Gilbert Ramirez1999-07-291-3/+16
| | | | | | | allowing users to filter on the existence of these protocols. I also added packet-clip.c to the Nmake makefile. svn path=/trunk/; revision=402
* Added support for compiling on win32 with Visual C and 'nmake'. It compiles,Gilbert Ramirez1999-07-131-1/+5
| | | | | | | | | | | | but does not link. Perhaps someone who understands the MS tools can help out. I made it link a few months ago, but with different version of glib/gtk+. I can't remember how I made it link. Most of the compatibility issues were resolved with adding #ifdef HAVE_UNISTD_H the the source code. Please be sure to add this to all future code. svn path=/trunk/; revision=359
* Created a new protocol tree implementation and a new display filterGilbert Ramirez1999-07-071-165/+159
| | | | | | | mechanism that is built into ethereal. Wiretap is now used to read all file formats. Libpcap is used only for capturing. svn path=/trunk/; revision=342
* Added RSVP protocol dissector.Gilbert Ramirez1999-06-111-0/+848
svn path=/trunk/; revision=304
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-25 23:59:05 +0000