aboutsummaryrefslogtreecommitdiffstats
path: root/packet-diameter.c
Commit message (Collapse)AuthorAgeFilesLines
* From Joerg Mayer: make a pile of stuff not used outside one source fileGuy Harris2002-05-101-2/+2
| | | | | | | | | static, and add a new "packet-data.h" to declare "proto_data". Display escape sequences in octal in the IAPP dissector, as is now done in the RADIUS dissector. svn path=/trunk/; revision=5441
* From Joerg Mayer: get rid of unused arguments.Guy Harris2002-05-021-12/+12
| | | | svn path=/trunk/; revision=5364
* Removal (or, at least, #ifdeffing out) of unused variables andGuy Harris2002-04-291-3/+1
| | | | | | functions, from David Frascone. svn path=/trunk/; revision=5288
* From David Frascone: fix pathname of Diameter directory file.Guy Harris2002-03-051-3/+2
| | | | svn path=/trunk/; revision=4869
* Don't copy the AVP data to a buffer from the tvbuff and then extractGuy Harris2002-01-311-93/+131
| | | | | | | | | | | | | stuff from the buffer - extract what you need directly from the tvbuff. (And definitely don't extract stuff from the buffer if you haven't copied stuff to it.) For integral AVP items, check the length of the item before processing it. Put time items into the protocol tree as times, not as byte arrays. svn path=/trunk/; revision=4645
* Include <string.h> to declare various string functions.Guy Harris2002-01-301-9/+14
| | | | | | | | | | | | Include "snprintf.h", when needed, to declare "snprintf()" on platforms that don't have it. Fix some formats and arguments to various printing routines. Fix "diameter_time_to_string()" to properly fetch the time value from the data buffer handed to it. svn path=/trunk/; revision=4639
* Convert some "col_add_str()" calls to "col_set_str()".Guy Harris2002-01-211-2/+2
| | | | svn path=/trunk/; revision=4592
* Include files from the "epan" directory and subdirectories thereof withGuy Harris2002-01-211-4/+4
| | | | | | | | | | | | | "epan/..." pathnames, so as to avoid collisions with header files in any of the directories in which we look (e.g., "proto.h", as some other package has its own "proto.h" file which it installs in the top-level include directory). Don't add "-I" flags to search "epan", as that's no longer necessary (and we want includes of "epan" headers to fail if the "epan/" is left out, so that we don't re-introduce includes lacking "epan/"). svn path=/trunk/; revision=4586
* Fix some preferences to eliminate the extra copy of the protocol name atGuy Harris2002-01-151-2/+2
| | | | | | | | | the beginning, and to use underscores rather than periods where the preference's name really isn't part of a hierarchical namespace. Use "%u" rather than "%d" to print unsigned quantities. svn path=/trunk/; revision=4543
* Use "%u", not "%d", to print unsigned quantities.Guy Harris2002-01-081-5/+5
| | | | svn path=/trunk/; revision=4496
* Vendor ID lookup fix, from David Frascone.Guy Harris2002-01-071-54/+141
| | | | svn path=/trunk/; revision=4494
* Move the pointer to the "column_info" structure in the "frame_data"Guy Harris2001-12-101-10/+10
| | | | | | | | | | | | | | | structure to the "packet_info" structure; only stuff that's permanently stored with each frame should be in the "frame_data" structure, and the "column_info" structure is not guaranteed to hold the column values for that frame at all times - it was only in the "frame_data" structure so that it could be passed to dissectors, and, as all dissectors are now passed a pointer to a "packet_info" structure, it could just as well be put in the "packet_info" structure. That saves memory, by shrinking the "frame_data" structure (there's one of those per frame), and also lets us clean up the code a bit. svn path=/trunk/; revision=4370
* Make "dissector_add()", "dissector_delete()", and "dissector_change()"Guy Harris2001-12-031-10/+14
| | | | | | | | take a dissector handle as an argument, rather than a pointer to a dissector function and a protocol ID. Associate dissector handles with dissector table entries. svn path=/trunk/; revision=4308
* Thou shalt not use C++-style comments in C code, for they upset some CGuy Harris2001-11-271-2/+2
| | | | | | compilers. svn path=/trunk/; revision=4284
* Get rid of some unused variables.Guy Harris2001-11-211-6/+1
| | | | svn path=/trunk/; revision=4241
* Allow a dissector to register preferences that it no longer supports asGuy Harris2001-11-041-1/+6
| | | | | | | | | | | | | | | | | | | | | | obsolete; we silently ignore attempts to set those in a preferences file, so that we don't spam the user with error messages caused by them having saved preferences in an earlier release that contained those preferences. Make the Diameter and iSCSI dissectors register obsolete preferences. Crash if some code tries to register a preferences module with a name that contains something other than lower-case ASCII letters, numbers, or underscores, or that has already been registered, or if some code tries to register a preference with a name that contains something other than lower-case ASCII letters, numbers, underscores, or periods, or that has already been registered, so that we don't put code like that in a release and have to shovel code into "prefs.c" to fix it up later. (The problem with multiple modules or preferences with the same name should be obvious; the problem with names with blanks, or upper-case letters, or punctuation, is that they're a pain to type on the command line.) svn path=/trunk/; revision=4148
* Clean up the Info column, by leaving the ": " that separates badGuy Harris2001-11-031-2/+5
| | | | | | | packet/flag information from the PDU type if there's no bad packet or flag informatin. svn path=/trunk/; revision=4144
* Support for desegmentation of Diameter-over-TCP, from David Frascone.Guy Harris2001-11-031-11/+77
| | | | svn path=/trunk/; revision=4141
* In "addStaticAVP()", add the new entry to the list of AVP types afterGuy Harris2001-11-031-1/+5
| | | | | | it's filled in. svn path=/trunk/; revision=4137
* Add support for 64-bit signed integers in "int-64bit.[ch]", add anGuy Harris2001-11-021-10/+4
| | | | | | | | FT_INT64 type, and make the Diameter dissector use it. Handle the 64-bit integer types in the display filter semantics checks. svn path=/trunk/; revision=4125
* From David Frascone: duUpdate to Diameter dissector to load theGuy Harris2001-11-011-101/+867
| | | | | | | dictionary as an XML file rather than building it in, and various Diameter updates. svn path=/trunk/; revision=4122
* From Ronnie Sahlberg: FT_UINT64 support, code to handle 64-bit integersGuy Harris2001-10-291-10/+3
| | | | | | | | without requiring compiler support for them, and updates to the Diameter, L2TP, NFS, and NLM dissectors to use it and to the ONC RPC dissector to allow ONC RPC subdissectors to use it. svn path=/trunk/; revision=4099
* Don't cast "data" to "unsigned long long"; "long long" - or whateverGuy Harris2001-08-041-2/+2
| | | | | | | data type "gint64" really is - should be sufficiient for a %llx format, and not all compilers that support 64-bit data types have "long long". svn path=/trunk/; revision=3820
* From David Frascone: update to the DIAMETER dissector forGuy Harris2001-07-301-603/+699
| | | | | | | | | | | | | | | | | | | | draft-ietf-aaa-diameter-07. His changenotes: Changes: o Flags are now done properly. (I changed it to dissect them like packet-tcp.c does) o Completely re-did the dictionary. I think it is much more maintainable now. And, it is no longer dynamically generated. o Added some lookup routines to work with new dictionary. o Removed lots of old lookup stuff that had been cloned from packet-radius.c. It's much cleaner now. svn path=/trunk/; revision=3799
* Fixes, from Scott Renfro, for some calls to "localtime()" that didn'tGuy Harris2001-07-151-5/+9
| | | | | | | check whether the call succeeded (it doesn't always do so on Windows, for example). svn path=/trunk/; revision=3722
* From Joerg Mayer: explicitly fill in all members of aGuy Harris2001-06-181-23/+23
| | | | | | | "header_field_info" structure, including the ones that are later set by the routines to register fields. svn path=/trunk/; revision=3561
* Fix the copyright notice to reflect the fact that Gerald holds theGuy Harris2001-05-271-3/+4
| | | | | | copyright on Ethereal as a whole. svn path=/trunk/; revision=3473
* Updates from David Frascone.Guy Harris2001-04-101-12/+34
| | | | svn path=/trunk/; revision=3287
* Updates from David Frascone: includes DIAMETER-over-SCTP support.Guy Harris2001-02-231-25/+35
| | | | svn path=/trunk/; revision=3073
* In the DIAMETER dissector, clear the Info column before fetchingGuy Harris2001-02-201-1/+3
| | | | | | | | | | anything from the packet, so that if we throw an exception before setting the Info column, it doesn't have stuff left over from the previous dissector. Tvbuffify the RADIUS dissector. svn path=/trunk/; revision=3055
* Don't do anything with 64-bit integral types if G_HAVE_GINT64 isn'tGuy Harris2001-02-201-10/+16
| | | | | | | | | | | | | | | | | | | | | | defined. Use "gint64" and "guint64", not "long long int", for 64-bit integral types, so that this code works with compilers (such as Microsoft Visual C++) that have 64-bit integral types but that don't call them "long long". Use "pntohll()" to extract 64-bit integral types from a field. Put a "break;" into a "default:" clause - MSVC++ doesn't like switch (XXX) { ... default: } svn path=/trunk/; revision=3051
* As "dissect_diameter()" is now static to "packet-diameter.c", there's noGuy Harris2001-02-191-2/+1
| | | | | | | need to declare it in "packet-diameter.h" - and no need for "packet-diameter.h". svn path=/trunk/; revision=3050
* New tvbuffified DIAMETER dissector, from David Frascone.Guy Harris2001-02-191-522/+567
| | | | | | | | It doesn't do DIAMETER-over-UDP, so the RADIUS dissector no longer checks for DIAMETER packets and calls the DIAMETER dissector if it finds one. svn path=/trunk/; revision=3049
* 3rd time's a charm.Gilbert Ramirez2001-02-161-4/+6
| | | | | | Check against the *correct* buffer size. svn path=/trunk/; revision=3046
* Off-by-a-little-bit in adjusting the offset.Gilbert Ramirez2001-02-161-3/+3
| | | | svn path=/trunk/; revision=3045
* Don't trust avp_length, which is taken directly from the packet data.Gilbert Ramirez2001-02-161-6/+23
| | | | svn path=/trunk/; revision=3044
* Fix up some MSVC complaints about (narrowing) type conversions byGuy Harris2001-02-051-2/+2
| | | | | | | widening formal arguments or narrowing variables passed as actual arguments. svn path=/trunk/; revision=2993
* Add an additional "protocol index" argument to "{old_}dissector_add()",Guy Harris2001-01-091-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | "{old_}heur_dissector_add()", "{old_}conv_dissector_add()", and "register_dissector()", so that an entry in those tables has associated with it the protocol index of the protocol the dissector handles (or -1, if there is no protocol index for it). This is for future use in a number of places. (Arguably, "proto_register_protocol()" should take a dissector pointer as an argument, but 1) it'd have to handle both regular and heuristic dissectors; 2) making it take either a "dissector_t" or a union of that and a "heur_dissector_t" introduces some painful header-file interdependencies so I'm punting on that for now. As with other Ethereal internal APIs, these APIs are subject to change in the future, at least until Ethereal 1.0 comes out....) svn path=/trunk/; revision=2849
* Add a new "prefs_register_protocol()" routine, which is likeGuy Harris2001-01-031-2/+2
| | | | | | | | | | | | "prefs_register_module()" except that it takes a protocol index as returned by "proto_register_protocol()" as its first argument, rather than taking two character strings as arguments as its first two arguments, and uses the protocol's abbreviation as the name to use for preferences in the preferences file and the "-o" flag and uses the protocol's short name as the name to use in the tabs in the "Edit->Preferences" window. svn path=/trunk/; revision=2812
* Have "proto_register_protocol()" build a list of data structures forGuy Harris2001-01-031-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | protocols, in addition to adding structures to the list of filterable fields. Give it an extra argument that specifies a "short name" for the protocol, for use in such places as pinfo->current_proto; the dialog box for constructing filters; the preferences tab for the protocol; and so on (although we're not yet using it in all those places). Make the preference name that appears in the preferences file and the command line for the DIAMETER protocol "diameter", not "Diameter"; the convention is that the name in question be all-lower-case. Make some routines and variables that aren't exported static. Update a comment in the ICP dissector to make it clear that the dissector won't see fragments other than the first fragment of a fragmented datagram. svn path=/trunk/; revision=2810
* For each column, have both a buffer into which strings for that columnGuy Harris2000-11-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | can be put, and a pointer to the string for the column, which might or might not point to that buffer. Add a routine "col_set_str()", which sets the string for the column to the string passed to it as an argument; it should only be handed a static string (a string constant would be ideal). It doesn't do any copying, so it's faster than "col_add_str()". Make the routines that append to columns check whether the pointer to the string for the column points to the buffer for the column and, if not, copy the string for the column to the buffer for the column so that you can append to it (so you can use "col_set_str()" and then use "col_append_str()" or "col_append_fstr()"). Convert a bunch of "col_add_str()" calls that take a string constant as an argument to "col_set_str()" calls. Convert some "col_add_fstr()" calls that take a string constant as the only argument - i.e., the format string doesn't have any "%" slots into which to put strings for subsequent arguments to "col_set_str()" calls (those calls are just like "col_add_str()" calls). Replace an END_OF_FRAME reference in a tvbuffified dissector with a "tvb_length(tvb)" call. svn path=/trunk/; revision=2670
* Add #include <string.h>, to get prototypes for mem* and str* functions.Gilbert Ramirez2000-11-171-1/+2
| | | | svn path=/trunk/; revision=2654
* Updates from David Frascone.Guy Harris2000-10-211-15/+29
| | | | svn path=/trunk/; revision=2520
* Add the "Edit:Protocols..." feature which currently only implementsLaurent Deniel2000-08-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the following: It is now possible to enable/disable a particular protocol decoding (i.e. the protocol dissector is void or not). When a protocol is disabled, it is displayed as Data and of course, all linked sub-protocols are disabled as well. Disabling a protocol could be interesting: - in case of buggy dissectors - in case of wrong heuristics - for performance reasons - to decode the data as another protocol (TODO) Currently (if I am not wrong), all dissectors but NFS can be disabled (and dissectors that do not register protocols :-) I do not like the way the RPC sub-dissectors are disabled (in the sub-dissectors) since this could be done in the RPC dissector itself, knowing the sub-protocol hfinfo entry (this is why, I've not modified the NFS one yet). Two functions are added in proto.c : gboolean proto_is_protocol_enabled(int n); void proto_set_decoding(int n, gboolean enabled); and two MACROs which can be used in dissectors: OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree) CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree) See also the XXX in proto_dlg.c and proto.c around the new functions. svn path=/trunk/; revision=2267
* Allow either old-style (pre-tvbuff) or new-style (tvbuffified)Guy Harris2000-08-071-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dissectors to be registered as dissectors for particular ports, registered as heuristic dissectors, and registered as dissectors for conversations, and have routines to be used both by old-style and new-style dissectors to call registered dissectors. Have the code that calls those dissectors translate the arguments as necessary. (For conversation dissectors, replace "find_conversation_dissector()", which just returns a pointer to the dissector, with "old_try_conversation_dissector()" and "try_conversation_dissector()", which actually call the dissector, so that there's a single place at which we can do that translation. Also make "dissector_lookup()" static and, instead of calling it and, if it returns a non-null pointer, calling that dissector, just use "old_dissector_try_port()" or "dissector_try_port()", for the same reason.) This allows some dissectors that took old-style arguments and immediately translated them to new-style arguments to just take new-style arguments; make them do so. It also allows some new-style dissectors not to have to translate arguments before calling routines to look up and call dissectors; make them not do so. Get rid of checks for too-short frames in new-style dissectors - the tvbuff code does those checks for you. Give the routines to register old-style dissectors, and to call dissectors from old-style dissectors, names beginning with "old_", with the routines for new-style dissectors not having the "old_". Update the dissectors that use those routines appropriately. Rename "dissect_data()" to "old_dissect_data()", and "dissect_data_tvb()" to "dissect_data()". svn path=/trunk/; revision=2218
* Fix typo in description of Diameter.tcp.port preference.Gilbert Ramirez2000-08-031-2/+2
| | | | | | From Jakob Schlyter <jakob@crt.se> svn path=/trunk/; revision=2198
* Include <time.h> to declare "localtime()" and "strftime()", and useGuy Harris2000-07-311-2/+3
| | | | | | | "guint32" rather than "uint32_t" so that it'll compile on systems (e.g., Win32, and probably some UNIX flavors) that don't declare "uint32_t". svn path=/trunk/; revision=2185
* David Frascone's DIAMETER dissector.Guy Harris2000-07-301-0/+752
svn path=/trunk/; revision=2176