aboutsummaryrefslogtreecommitdiffstats
path: root/packet-dcerpc-samr.c
Commit message (Collapse)AuthorAgeFilesLines
* Removed some trailing commas from various DCERPC dissectors.Tim Potter2002-05-311-4/+4
| | | | svn path=/trunk/; revision=5604
* Changed toplevel REF pointer dissection to create a subtree. Not creating a ↵Ronnie Sahlberg2002-05-271-46/+48
| | | | | | | | subtree was a design mistake which caused ugliness in the unicode string str dissector and in other places. Dissectors will temporarily have less pretty output for topleve ref pointers until their output is retuned. svn path=/trunk/; revision=5573
* In "dissect_nt_policy_hnd()":Guy Harris2002-05-111-62/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | add arguments to specify whether the policy handle is being opened or closed, and don't set the "open frame" for the handle unless it's being opened and don't set the "close frame" for the handle unless it's being closed; store the policy handle before fetching it, so that an open or close is marked appropriately in the protocol tree on the first pass; if the policy handle has a name associated with it, put that name into the top-level item for the policy handle. In "packet-dcerpc-spoolss.c": get rid of aun unused variable; make "setjob_commands[]" static, as it's not used outside "packet-dcerpc-spoolss.c"; put a "VALS()" call around the reference to "setjob_commands", to squelch compiler warnings; give the SPOOLSS return code field the appropriate "value_string" array. svn path=/trunk/; revision=5448
* Put in a comment noting that the previous change came from a realGuy Harris2002-05-091-1/+5
| | | | | | capture, so if an IDL disagrees, the IDL is wrong. svn path=/trunk/; revision=5428
* As Ronnie Sahlberg notes, the problem is that the QueryDomainInfoGuy Harris2002-05-091-14/+3
| | | | | | | | response starts with a UNIQUE pointer to a DOMAIN_INFO, not with a REF pointer to a DOMAIN_INFO - and also not with a UNIQUE pointer to a DOMAIN_INFO REF pointer; fix the code to match that. svn path=/trunk/; revision=5427
* In at least one capture, a QueryDomainInfo response starts with what is,Guy Harris2002-05-091-2/+13
| | | | | | | I guess, a UNIQUE pointer to a DOMAIN_INFO REF pointer; dissect it as such. svn path=/trunk/; revision=5426
* Several bugfixes for SAMRRonnie Sahlberg2002-05-071-39/+15
| | | | svn path=/trunk/; revision=5413
* Remove unused function.Tim Potter2002-05-051-14/+3
| | | | | | Dissect a status code at the end of GetAliasMem reply instead of uint32. svn path=/trunk/; revision=5401
* From Joerg Mayer: mark unused arguments as such.Guy Harris2002-05-041-5/+5
| | | | svn path=/trunk/; revision=5380
* Get rid of some unused arguments, and mark some others as unused.Guy Harris2002-04-301-4/+3
| | | | | | | | Remove the declaration of "dissect_nt_sid()" from "packet-dcerpc-samr.c"; get it by including "packet-smb-common.h", instead. svn path=/trunk/; revision=5313
* Use the string in the DCERPC sub-dissector array instead of providingTim Potter2002-04-301-409/+62
| | | | | | another one in the COL_INFO field. svn path=/trunk/; revision=5300
* Un-#if out "samr_dissect_get_alias_membership_response()", to serve as aGuy Harris2002-04-291-21/+2
| | | | | | | | | | | | | reminder to check whether "samr_dissect_get_alias_membership_reply()" should dissect the uint32 at the end as an NT status. Un-#if out "samr_dissect_context_handle_SID()", to serve as a reminder to figure out whether it should be deleted or used. Get rid of "samr_dissect_get_user_groups_rqst()" - it's identical to "samr_dissect_get_groups_for_user_rqst()", but isn't being used. svn path=/trunk/; revision=5295
* Removal (or, at least, #ifdeffing out) of unused variables andGuy Harris2002-04-291-5/+9
| | | | | | functions, from David Frascone. svn path=/trunk/; revision=5288
* Fix "samr_dissect_query_information_alias_reply()" to dissect theGuy Harris2002-04-221-15/+19
| | | | | | ALIAS_INFO structure before the status. svn path=/trunk/; revision=5215
* Fix an error in the "dcerpc_samr_dissectors[]" table.Guy Harris2002-04-221-12/+20
| | | | | | | | | | | | | | | | | Rename "samr_dissect_enum_dom_alias_rqst()" and "samr_dissect_enum_dom_alias_reply()" to "samr_dissect_enum_dom_aliases_rqst()" and "samr_dissect_enum_dom_aliases_reply()", to match the name of the RPC that they dissect. Rename the routines used to dissect the unknown 0x2f requests and replies along the lines of the names of the routines for other unknown requests and replies, and change the Info column information in that fashion as well. Dissect the USER_INFO structure in the QueryUserInfo response. svn path=/trunk/; revision=5211
* Add a "proto_register_dcerpc_smb()" which registers ett_ values forGuy Harris2002-04-181-10/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "packet-dcerpc-nt.c", and registers "dcerpc_smb_init()" as an initialization routine. Take the ett_ registration out of the latter routine, and also take out the "do this only once" stuff. Get rid of the initialization routines for netlogon, samr, and spoolss; they just call "dcerpc_smb_init()", which is now an initialization routine of its own. The policy hash initialization should be done before every capture, so it should be done in an initialization routine, and should not do any "do this only once" stuff. It should also be called only once before every capture, rather than 3 times. The ett_ initialization should, however, be done at the same time all other ett_ initialization is done - at protocol registration time - so it should be done in a "proto_register_" routine. This fixes a bug I saw wherein 1) the tree for Unicode strings was open by default and 2) if you closed one and then exited, Ethereal would crash. The problem is that "proto_register_subtree_array()" doesn't expand the array, it just bumps the number of registered ett_ values; the array is allocated in "proto_init()". As such, if you register ett_ values with "proto_register_subtree_array()" *after* "proto_init()" is called - and, even for the first capture, initialization routines are called after "proto_init()" is called - you will get ett_ numbers that go past the number of elements in the array. Move the declaration of "ett_nt_unicode_string" to "packet-dcerpc-nt.h", as it's exported from "packet-dcerpc-nt.c". Get rid of the declaration of "dcerpc_smb_init()" in "packet-dcerpc-nt.h", and make it static, as it's no longer called from outside "packet-dcerpc-nt.c". svn path=/trunk/; revision=5196
* Display rids for open user, group, alias in COL_INFO.Tim Potter2002-04-171-6/+64
| | | | | | Give query user info its own dissector. svn path=/trunk/; revision=5192
* Prettification of SAMR dissector - display short names in COL_INFO.Tim Potter2002-04-171-184/+1211
| | | | svn path=/trunk/; revision=5191
* Use policy handle hash code in DCERPC/SMB SAMR dissector.Tim Potter2002-04-171-76/+113
| | | | | | Start to move some common stuff into packet-dcerpc-nt.[ch] svn path=/trunk/; revision=5176
* Display non-zero return codes in COL_INFO.Tim Potter2002-04-161-48/+74
| | | | svn path=/trunk/; revision=5170
* #include <string.h> to quieten compiler warning.Tim Potter2002-03-251-1/+2
| | | | svn path=/trunk/; revision=5013
* Fix "dissect_ndr_nt_UNICODE_STRING_str()" so that the "di->levels" valueGuy Harris2002-03-241-2/+2
| | | | | | | | | | | | | | | | | | is decremented after every level is appended to, so that it correctly specifies the number of levels up the tree to which to append stuff. Fix some arguments to various printing routines to specify the correct level. This includes making "dissect_ndr_nt_UNICODE_STRING()" add 1 to the level argument it's passed before passing it on to "dissect_ndr_pointer()". Add a "netlogon_dissect_UNICODE_STRING()" routine to put the fields of a bunch of NDR_POINTER_REF UNICODE_STRING values into subtrees. Fix the labels passed as arguments in a bunch of "dissect_ndr_pointer()" calls. svn path=/trunk/; revision=5011
* Added a value_string for the countreis which have their MS contry code listedRonnie Sahlberg2002-03-141-2/+2
| | | | | | at www.unicode.org and made samr and netlogon use it. svn path=/trunk/; revision=4943
* Final patch in preparing for NETLOGON dissector.Ronnie Sahlberg2002-03-111-19/+72
| | | | | | | Exported some functions from packet-dcerpc-samr.c and added two more functions the netlogon dissector will need. svn path=/trunk/; revision=4921
* Move the STRING dissector to packet-dcerpc-nt.c and add one more parameterRonnie Sahlberg2002-03-111-88/+5
| | | | | | to make it more similar to the UNICODE_STRING dissector. svn path=/trunk/; revision=4920
* Rename samr_dissect_LOGON_HOURS() to dissect_ndr_nt_LOGON_HOURS() andRonnie Sahlberg2002-03-111-7/+7
| | | | | | | export it to other modules. NETLOGON dissector (and others) will need this function. svn path=/trunk/; revision=4919
* Moved dissect_ndr_nt_NTTIME() from packet-dcerpc-samr.c to packet-dcerpc-nt.cRonnie Sahlberg2002-03-101-28/+1
| | | | | | since this function will be used by other NT services as well such as NETLOGON. svn path=/trunk/; revision=4918
* Don't use "proto_tree_add_string_format()" whenGuy Harris2002-03-101-4/+3
| | | | | | "proto_tree_add_string()" will suffice. svn path=/trunk/; revision=4913
* Use "dissect_ndr_nt_UNICODE_STRING_str()", notGuy Harris2002-03-101-69/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "dissect_ndr_nt_UNICODE_STRING_string()", in "samr_dissect_connect2_server()"; that eliminates an unnecessary extra level of protocol tree. That removes the last call to "dissect_ndr_nt_UNICODE_STRING_string()"; eliminate that routine. In "dissect_ndr_nt_UNICODE_STRING()", initially create the subtree with the name of the field as a string, so that if an exception is thrown before the name is set, the subtree won't show up as blank when displayed or printed. Also pass in the name to "dissect_ndr_pointer()", so the same happens for subtrees below it. Append only the string data, not its name, to items up the tree, as the name was put in when the item was created. Also, when adding a colon before the string, put a space after the colon, as is done elsewhere in Ethereal. When appending additional strings, put the blank before the new string, not after it. In "dissect_ndr_nt_STRING()", put the subtree into the string with the name of the field, rather than just "String". Pass in that name to "dissect_ndr_pointer()", so subtrees below it get a name when they're initially created. Get rid of colons in the name string passed to "dissect_ndr_pointer()" in some calls. Supply a non-null name string in more calls to "dissect_ndr_pointer()", and fix some calls to pass in the name of the field being handed to "dissect_ndr_pointer()". There's no need to fetch the entire "header_field_info" structure for a protocol field in order to get the field's name - just use "proto_registrar_get_name()" to get the name. Use a length of -1, not 0, when creating a subtree whose length will be set when the dissection of the items under the subtree is complete; that way, if an exception is thrown while dissecting the items - which means the item goes past the end of the tvbuff - the item will refer to all data to the end of the tvbuff, rather than referring to nothing. Fix a typo in the name of the "hf_samr_unknown_string" field. svn path=/trunk/; revision=4912
* Rename function and variables for dissecting an NT service Account ControlRonnie Sahlberg2002-03-061-94/+106
| | | | | | | | bitmap and make the function not static. This bitmap is present in other RPC protocols for NT services as well besides SAMR. svn path=/trunk/; revision=4889
* Moved dissector for UNICODE_STRING structure from packet-dcerpc-samr.c to ↵Ronnie Sahlberg2002-03-061-178/+1
| | | | | | packet-dcerpc-nt.c since this is a structure that is common to all NT services and not only SAMR. svn path=/trunk/; revision=4888
* Properly (for English) pluralize names beginning with "s".Guy Harris2002-02-261-5/+30
| | | | svn path=/trunk/; revision=4813
* From Ronnie Sahlberg: add "alias name" and "group name" fields for aliasGuy Harris2002-02-261-3/+13
| | | | | | | and group names, and use them instead of the numeric "alias" and "group" fields when putting the names into the protocol tree. svn path=/trunk/; revision=4812
* From Ronnie Sahlberg: add decoding of the (known) individual bits ofGuy Harris2002-02-141-22/+141
| | | | | | the Account-Control bits. svn path=/trunk/; revision=4734
* From Ronnie Sahlberg:Guy Harris2002-02-131-102/+210
| | | | | | | | | | fix various alignment problems; change/prettify a few of the structures; other updates. svn path=/trunk/; revision=4729
* From Ronnie Sahlberg:Guy Harris2002-02-121-179/+273
| | | | | | | | | | | | | | SAMR updates; a bugfix in dissect_ndr_pointer() (should not check referent id for aliases for unique pointers); enhancement to dissect_ndr_pointer() to make it possible to hand a generic int value to the dissector for the pointer object in a similar way as hf_index values are passed through the pointer layer. svn path=/trunk/; revision=4721
* From Ronnie Sahlberg:Guy Harris2002-02-111-21/+22
| | | | | | | | | | | | fix to LookupRids to match what the IDL file says; fix to "dissect_ndr_uint64()" to specify the right length to "proto_tree_add_item()"; give the protocol tree items for array header counts and offsets the correct offsets in the packet. svn path=/trunk/; revision=4719
* From Todd Sabin:Guy Harris2002-02-101-2/+14
| | | | | | | | | | | | dissect dcerpc UDP replies correctly - use the opnum from the request, ont the reply (the opnum from the request is frequently wrong in Microsoft's DCE RPC implementation); don't crash if the packet isn't found in the hash tables; dissect SamrLookupDomain requests properly. svn path=/trunk/; revision=4718
* From Ronnie Sahlberg: display the SAMR "Account Control" field in hex.Guy Harris2002-02-101-3/+4
| | | | svn path=/trunk/; revision=4714
* Fixes from Ronnie Sahlberg.Guy Harris2002-02-081-66/+167
| | | | svn path=/trunk/; revision=4710
* From Ronnie Sahlberg: add dissectors for the rest of SAMR.Guy Harris2002-02-081-165/+1308
| | | | svn path=/trunk/; revision=4708
* From Ronnie Sahlberg:Guy Harris2002-02-061-13/+14
| | | | | | | | | | the count fields in SAMR replies aren't array max_count values, so don't display them as such; Put conformant and conformant varying array length/offset/etc. values into the protocol tree. svn path=/trunk/; revision=4701
* DCE RPC enhancements, and SAMR improvements, from Ronnie Sahlberg.Guy Harris2002-01-291-77/+1918
| | | | svn path=/trunk/; revision=4618
* From Ronnie Sahlberg:Guy Harris2002-01-251-2/+493
| | | | | | | NDR pointer handling in DCE RPC SAMR updates svn path=/trunk/; revision=4608
* Include files from the "epan" directory and subdirectories thereof withGuy Harris2002-01-211-2/+2
| | | | | | | | | | | | | "epan/..." pathnames, so as to avoid collisions with header files in any of the directories in which we look (e.g., "proto.h", as some other package has its own "proto.h" file which it installs in the top-level include directory). Don't add "-I" flags to search "epan", as that's no longer necessary (and we want includes of "epan" headers to fail if the "epan/" is left out, so that we don't re-introduce includes lacking "epan/"). svn path=/trunk/; revision=4586
* From Todd Sabin:Guy Harris2001-12-061-8/+63
| | | | | | | | | | | add "dissect_ndr_ctx_hnd()" for dissecting context handles, and use it in various DCERPC dissectors; beef up the MS Security Account Manager dissector. Also, export "NT_errors[]" for use by that dissector. svn path=/trunk/; revision=4350
* Rename the "packet-msrpc-XXX.[ch]" files to "packet-dcerpc-XXX.[ch]", asGuy Harris2001-11-211-0/+126
per Todd Sabin's suggestion. svn path=/trunk/; revision=4242
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-27 06:13:53 +0000