aboutsummaryrefslogtreecommitdiffstats
path: root/gtk/expert_dlg.c
Commit message (Collapse)AuthorAgeFilesLines
* Remove some unnecessary includes: a lot of things don't need globals.h and ↵Jeff Morriss2010-08-301-14/+13
| | | | | | register.h svn path=/trunk/; revision=34017
* (Minor) Cleanup signal callbak signatures and related:Bill Meier2010-08-231-1/+1
| | | | | | | | - Don't mark callback arg as _U_ if actually used (and vice-versa); - Use Null as user_data in g_signal_callback if unused in callback; - Use correct signature for certain event callbacks. svn path=/trunk/; revision=33895
* Fix Bug 4388 "Expert Info Composite" : wrong font in tab "Details" Anders Broman2010-03-281-1/+4
| | | | | | By commenting out gtk_widget_modify_font() in expert_dlg_init_table() as per Geralds comment. svn path=/trunk/; revision=32322
* Initialise a couple of variables to prevent gcc warnings.Martin Mathieson2010-03-221-1/+1
| | | | svn path=/trunk/; revision=32267
* Didier Gautheron:Anders Broman2009-09-021-8/+25
| | | | | | | Expert info clean up. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3971 svn path=/trunk/; revision=29663
* make the columns sortable.Anders Broman2009-08-271-0/+7
| | | | svn path=/trunk/; revision=29583
* Don't copy const strings, store the pointer in the list store instead,Anders Broman2009-08-271-13/+22
| | | | | | saves memory. svn path=/trunk/; revision=29582
* From Didier Gautheron:Anders Broman2009-08-261-6/+7
| | | | | | | expert info clean up, https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3948 svn path=/trunk/; revision=29566
* We no longer need the "ascending arrow" and "descending arrow" imagesGuy Harris2009-08-241-349/+340
| | | | | | | | for clists, as we're not using a clist. Clean up white space, and use C89 comments rather than C99/C++ comments. svn path=/trunk/; revision=29540
* Use list_store isf deprecated clist.Anders Broman2009-08-241-180/+186
| | | | | | Try to optimize expert_comp_table. svn path=/trunk/; revision=29539
* From Didier gautheron via bug 3929:Kovarththanan Rajaratnam2009-08-231-1/+1
| | | | | | | * Expert Info / Expert Info Composite requires a full protocol tree. * Delay tree NULL pointer check in bootp dissector svn path=/trunk/; revision=29530
* From Didier gautheron via bug 3929:Kovarththanan Rajaratnam2009-08-231-2/+4
| | | | | | | | | | * Don't use g_string_chunk_clear(). It is only defined if GLib >= 2.14 From me: * Whitespace fixes svn path=/trunk/; revision=29529
* expert_comp_table.c: Minor cleanupAnders Broman2009-08-221-15/+12
| | | | | | expert_dlg.c change GtkOptionMenu to GtkComboBox. svn path=/trunk/; revision=29504
* Destroy window with parent, update label when showing window.Anders Broman2009-08-191-1/+4
| | | | svn path=/trunk/; revision=29481
* From Didier Gautheron:Anders Broman2009-08-191-64/+43
| | | | | | | | | Part 2 Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization Optimize expert info. Slightly changed by me. svn path=/trunk/; revision=29478
* Windows transient to main window and destoyed with it.Anders Broman2009-06-111-1/+2
| | | | svn path=/trunk/; revision=28704
* Have tap listeners specify whether the "packet" routine requiresGuy Harris2009-06-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | a protocol tree; the column values. This includes stats-tree listeners. Have the routines to build the packet list, and to retap packets, honor those requirements. This means that cf_retap_packets() no longer needs an argument to specify whether to construct the column values or not, so get rid of that argument. This also means that there's no need for a tap to have a fake filter to ensure that the protocol tree will be built, so don't set up a fake "frame" filter. While we're at it, clean up some cases where "no filter" was represented as a null string rather than a null pointer. Have a routine to return an indication of the number of tap listeners with filters; use that rather than the global num_tap_filters. Clean up some indentation and some gboolean vs. gint items. svn path=/trunk/; revision=28645
* Turn on -Wshorten-64-to-32 by default, and fix some issues that turnedGuy Harris2009-04-211-2/+2
| | | | | | | | up (99 44/100% of which were assignments of double-precision floating-point constants to floats). Hopefully this will catch at least some P64 issues on UN*X. svn path=/trunk/; revision=28108
* Fix some "format not a string literal and no format arguments" warnings.Stig Bjørlykke2008-10-311-1/+1
| | | | svn path=/trunk/; revision=26641
* Bring the windows to front when rescanning of packets are done.Anders Broman2008-10-121-0/+6
| | | | svn path=/trunk/; revision=26423
* Don't put (non-extern'd) prototypes for protect_thread_critical_region() andJeff Morriss2008-08-051-15/+13
| | | | | | | | | | unprotect_thread_critical_region() in every module in gtk/: instead have those modules include main.h (which has the properly extern'd prototype). This should fix the link error on HP-UX described in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2702 svn path=/trunk/; revision=25933
* Fix some simple cases of GTK2 deprecated API usage by using a renamed or ↵Bill Meier2008-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | equivalent API gtk_container_border_width() ==> gtk_container_set_border_width() gtk_container_children() ==> gtk_container_get_children() gtk_entry_new_with_max_length() ==> gtk_entry_new(); gtk_entry_set_max_length() gtk_menu_append() ==> gtk_menu_shell_append() gtk_menu_prepend() ==> gtk_menu_shell_prepend() gtk_notebook_set_page() ==> gtk_notebook_set_current_page() gtk_paned_gutter_size() ==> gtk_paned_set_gutter_size() gtk_radio_button_group() ==> gtk_radio_button_get_group() gtk_signal_connect() ==> g_signal_connect() gtk_signal_disconnect() ==> g_signal_handler_disconnect() gtk_signal_emit_by_name() ==> g_signal_emit_by_name() gtk_signal_handler_block_by_data() ==> g_signal_handlers_block_matched() gtk_signal_handler_block_by_func() ==> g_signal_handlers_block_by_func() gtk_signal_handler_unblock_by_data() ==> g_signal-handlers_unblock_matched() gtk_signal_handler_unblock_by_func() ==> g_signal-handlers_unblock_by_func() gtk_spin_button_get_value_as_float() ==> gtk_spin_button_get_value() gtk_toggle_button_set_state() ==> gtk_toggle_button_set_active() svn path=/trunk/; revision=25634
* Removed the usage of topic_available() as we now have all topics.Stig Bjørlykke2008-06-211-10/+4
| | | | svn path=/trunk/; revision=25505
* Force foreground when background is forced in expert info dialogs.Stig Bjørlykke2008-05-011-0/+1
| | | | svn path=/trunk/; revision=25211
* From Jim Young:Jaap Keuter2008-04-231-12/+18
| | | | | | | Small patch to gtk/expert_dlg.c to test for the existance of the etd->label before use. This patch stops GTK assertion on Linux. svn path=/trunk/; revision=25160
* rename REGISTER_xxx_GROUP_NONE to REGISTER_xxx_GROUP_UNSORTED, as NONE seems ↵Ulf Lamping2008-04-171-1/+1
| | | | | | a bit misleading svn path=/trunk/; revision=25086
* move all code from color.c into color_utils.cUlf Lamping2008-04-131-1/+1
| | | | | | | remove color.c rename colors.h into color_utils.h (hopefully this reduces confusion to /color.h) svn path=/trunk/; revision=24974
* sort #includes by directoriesUlf Lamping2008-04-131-22/+23
| | | | svn path=/trunk/; revision=24968
* move tap_dfilter_dlg.h from / to /gtk (and use the callback mechanism in ↵Ulf Lamping2008-04-121-1/+1
| | | | | | main.c instead) svn path=/trunk/; revision=24956
* proto_draw -> main_proto_drawUlf Lamping2008-04-121-1/+1
| | | | svn path=/trunk/; revision=24954
* where it's not necessary, remove #include "compat_macros.h"Ulf Lamping2008-04-121-1/+0
| | | | svn path=/trunk/; revision=24922
* second round to replace SIGNAL_CONNECT with g_signal_connectUlf Lamping2008-04-111-6/+6
| | | | | | | | This requires some casts to be added and I just don't want to add casts at all possible places. So I compile and only add casts where the (MSVC) compiler has a hard time. Unfortunately this won't find any problems in Linux/Unix only code - I'll keep an eye on the buildbot and try to fix things as I'm going on ... svn path=/trunk/; revision=24913
* OBJECT_..._DATA --> g_object_..._dataBill Meier2008-04-111-4/+4
| | | | svn path=/trunk/; revision=24895
* Added help button in expert info and expert info composite dialogs.Stig Bjørlykke2008-02-171-2/+14
| | | | svn path=/trunk/; revision=24374
* From David Howells :Sebastien Tandel2007-05-291-1/+1
| | | | | | | | | | | | | | | | Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat 4.1.2-8). The failures fall into two categories: (1) Casts between pointers and 32-bit integers without an intermediary cast via 'long' or 'unsigned long'. This results in a compiler warning complaining about casts between a pointer and an integer of a different size. (2) Passing values to "%lld" or similar printf-style format options that the compiler thinks are a different size. Such values need to be cast to 'long long' or 'unsigned long long'. svn path=/trunk/; revision=21975
* nikai@nikai.net:Jörg Mayer2006-11-141-1/+0
| | | | | | | Remaining fixes from: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225 svn path=/trunk/; revision=19895
* move value_strings from expert_dialogs into expert.c to remove duplicatesUlf Lamping2006-08-311-20/+0
| | | | | | keep the highest severity level of the current file (experimental) svn path=/trunk/; revision=19104
* Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUIGuy Harris2006-05-221-3/+3
| | | | | | strings, and function names. svn path=/trunk/; revision=18205
* name changeRonnie Sahlberg2006-05-211-2/+2
| | | | svn path=/trunk/; revision=18197
* From Greg Morris:Anders Broman2006-03-151-0/+1
| | | | | | | | | | | | | | | | | | | | | Modification to (proto.h) is made to add an additional expert group type of PI_REQUEST_CODE to allow Request tag information to be passed to the expert tap. This is for such reasons where a dissector would like to echo specific information about certain types of requests. For example: NCP connection request is really a request not a REPLY_CODE. Same is true for the TCP SYN request. Changes to packet-ncp.c 1. Server broadcast message flag. Now indicates if the message is a pending message or an oplock clear notification. 2. Cleanup of packet signature detection process. Previous method had some flaws so I redesigned it. Appears to be solid now. 3. Echo NCP Server Session information to expert tap. Note on item #3: NCP Connection+Task = NCP Session, a Single connection can have many tasks. The server sees each connection/task as a unique session. For this reason the NCP session information is now echoed to the expert composite statistics so that you can easily identify the different NCP processes and sessions. It is important to NCP analysis to understand that each session is most likely a different program on the requesting host sharing the same NCP connection. Changes to packet-ncp2222.inc 1. Comment out the echo of NCP connection info to expert tap. Replaced by NCP sessions. 2. Add displayEID in request decode (resolves Coverity defect for dead code in NCP dissector) Changes to ncp2222.py 1. Fix for endian display of bindery object type in NCP 0x1720. 2. Fix for size of bindery object type to 2 bytes instead of 4 to match other bindery NCP's. svn path=/trunk/; revision=17636
* Don't se_leak expert_info records.Luis Ontanon2006-02-131-3/+5
| | | | | | | se_alloc them where and if needed, not every time expert_set_info_vformat is called. svn path=/trunk/; revision=17293
* add an userdata argument to register_stat_cmd_arg() and its callback to use ↵Luis Ontanon2006-02-111-3/+3
| | | | | | the callback for multiple registrations. svn path=/trunk/; revision=17252
* Revert 16279.Gilbert Ramirez2005-10-211-3/+1
| | | | svn path=/trunk/; revision=16281
* From Greg Morris.Gilbert Ramirez2005-10-201-1/+3
| | | | | | | Expert data must perform a re-dissection to trigger the NCP dissector. Change the call cf_retap_packets() to cf_redissect_packets(). svn path=/trunk/; revision=16279
* move the list down to the latest message while new messages rush in. We ↵Ulf Lamping2005-10-031-0/+2
| | | | | | might want to have a checkbox or alike to en/disable this (as discussed for the Statistics) lately. svn path=/trunk/; revision=16092
* Mark some unused and unremovable arguments as unused.Guy Harris2005-09-171-2/+2
| | | | svn path=/trunk/; revision=15846
* Have cf_retap_packets() take an argument that indicates whether toGuy Harris2005-09-141-1/+1
| | | | | | | generate columns; use cf_retap_packets instead of cf_redissect_packets() when running taps (the general flow graph stat uses the Info column). svn path=/trunk/; revision=15793
* Move "Expert Info" from "Statistics" to "Analyze" menu item.Ulf Lamping2005-09-131-61/+142
| | | | | | | | | | *significantly* improve performance (100000 infos from ~5min to 25sec!) Add a simple severity based filter mechanism. replace // style comments by /**/ svn path=/trunk/; revision=15791
* Frame numbers are unsigned, and they start at 1; 0 is what's used forGuy Harris2005-09-111-3/+8
| | | | | | | | | | | | "unknown" for frame numbers. Note that in epan/frame_data.h, and make the frame number in experts unsigned, and use 0 for "unknown", and display it as an unsigned number - and, if it's 0, don't display it at all. Fix the signature of "expert_dlg_draw()" to match what a tap's draw routine's signature is expected to be. svn path=/trunk/; revision=15760
* some things fixed, leftover from code cleanup (thanks to the buggy MSVC ↵Ulf Lamping2005-09-111-2/+2
| | | | | | dependencies) svn path=/trunk/; revision=15755
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-26 21:03:25 +0000