aboutsummaryrefslogtreecommitdiffstats
path: root/asn1/snmp
Commit message (Collapse)AuthorAgeFilesLines
* Build the ASN.1 dissectors directly into epan/dissectors (rather than buildingJeff Morriss2011-10-101-4/+0
| | | | | | | | | | | | | | | | | | | | them and then copying them over). The "all" target to builds these dissectors now (instead of "generate_files" and/or "copy_files"). asn2wrs's "-O" option now means "the dissector goes in this directory" (rather than "all output goes in this directory"); it also means that the "-s" (single output file) option is now required. Fix things up so that it's possible to build all of the ASN.1 dissectors in one shot. Fix building of conformance files when doing out-of-source-tree builds. Unfortunately "make all" in the asn1 directory always builds something--I think because of circular depedencies. svn path=/trunk/; revision=39333
* Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*:Bill Meier2011-10-101-1/+1
| | | | | | | | | | | | | | | Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39332
* Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier2011-10-051-6/+6
| | | | | | | | | | | | | | reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39263
* Change the case of "sNMPv2-Trap" to match RFC 3416. Reported by Qiyao.Gerald Combs2011-09-231-1/+1
| | | | svn path=/trunk/; revision=39114
* From Paul Stath via bug 5731: The check for engineID length should only ↵Chris Maynard2011-08-021-1/+1
| | | | | | | | occur if the engineID has a non-zero length. Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5731 svn path=/trunk/; revision=38303
* Use correct encoding for proto_tree_add_item().Stig Bjørlykke2011-07-191-17/+17
| | | | svn path=/trunk/; revision=38107
* From Sean Van Gorder:Anders Broman2011-06-051-1/+1
| | | | | | | | | | | | | | When Wireshark attempts to read an SNMP packet with a variable-bindings item with an OID containing an index string which includes an entry of type "Unsigned32", Wireshark will stop dissecting the packet at this index entry and end with the error: [Dissector bug, protocol SNMP: proto.c:2761: failed assertion "DISSECTOR_ASSERT_NOT_REACHED"] https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5883 svn path=/trunk/; revision=37558
* Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte2011-04-211-1/+1
| | | | svn path=/trunk/; revision=36771
* Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte2011-04-211-1/+1
| | | | svn path=/trunk/; revision=36760
* Rollback r36614 and change dissect_SMUX_PDUs_PDU() to use previouslyStephen Fisher2011-04-131-2/+3
| | | | | | | unused smux_tree instead of tree. Per suggestion from Stig on -dev. svn path=/trunk/; revision=36624
* Fix Coverity 524: NEGATIVE_RETURNSStephen Fisher2011-04-121-2/+2
| | | | | | | | | | | | | | Coverity sees that two calls to tvb_length_remaining() with an offset of 0 may return -1 (for an "out of bounds" condition), which would lead to an assignment of -1 to an unsigned variable and then passing it to functions further down that cannot accept negative values. Use tvb_ensure_length_remaining() to throw an exception in a case of out of bounds access (though unlikely with an offset of 0) instead of tvb_length_remaining(), which would return -1. svn path=/trunk/; revision=36615
* Fix Coverity 1047: UNUSED_VALUE in dissect_smuxStephen Fisher2011-04-121-2/+1
| | | | svn path=/trunk/; revision=36614
* Corrected switch-case flow.Stig Bjørlykke2011-04-121-1/+1
| | | | | | Coverity 1184. svn path=/trunk/; revision=36579
* Use a unique variable name. Fixes Coverity CID 593.Gerald Combs2011-04-071-4/+4
| | | | svn path=/trunk/; revision=36512
* From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :Jeff Morriss2011-03-251-1/+9
| | | | | | | | | | | | | Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors. (The SSL dissector was already updated in one of two spots with bug 4535/rev 32456.) A couple of the patches had to be manually applied. From me: Fix the comments to match the change (including in the TCP and SSL dissectors.) svn path=/trunk/; revision=36332
* Allow for expert items to be actually attached somewhere.Jaap Keuter2011-01-201-9/+12
| | | | svn path=/trunk/; revision=35594
* Only chop the last character (new line) from the error message.Stig Bjørlykke2010-12-301-1/+1
| | | | svn path=/trunk/; revision=35310
* Fix a buffer overflow in the engineId preferences. Fixes bug 5530.Gerald Combs2010-12-291-11/+15
| | | | svn path=/trunk/; revision=35298
* Rename the routines that handle dissector tables with unsigned integerGuy Harris2010-12-201-10/+10
| | | | | | | | | | | keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
* Fix various typos and spelling errors.Bill Meier2010-12-061-1/+1
| | | | svn path=/trunk/; revision=35126
* One more:Stig Bjørlykke2010-10-291-1/+1
| | | | | | Make the third argument to a UAT copy callback a size_t. svn path=/trunk/; revision=34696
* Make the third argument to a UAT copy callback a size_t.Stig Bjørlykke2010-10-291-1/+1
| | | | svn path=/trunk/; revision=34695
* From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4615 :Jeff Morriss2010-10-141-134/+194
| | | | | | | | | | | | | The attached patch adds the missing decoded fields by moving the proto_tree_add_item() call so that it is no longer within an error handler and will be called under normal circumstances (as well as error conditions. From me: Apply the change to the ASN.1 source. Also some white space indentation cleanup. svn path=/trunk/; revision=34505
* Copy the rev 34143 changes to packet-snmp.c over to the asn1 source.Jeff Morriss2010-09-171-13/+13
| | | | | | | hf_snmp_engineid_enterprise is now a BASE_EXT_STRING, not BASE_RANGE_STRING. This fixes the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5233 svn path=/trunk/; revision=34151
* Mark encryptedData as unused, to avoid warnings when not HAVE_LIBGCRYPT.Stig Bjørlykke2010-08-021-2/+2
| | | | svn path=/trunk/; revision=33691
* Added missing include <string.h>.Stig Bjørlykke2010-08-021-0/+1
| | | | svn path=/trunk/; revision=33690
* oid_encoded2string() returns a const char *; don't assign it to a charGuy Harris2010-07-021-2/+4
| | | | | | | | | *. Don't declare variables in the middle of a block; not all the compilers we use support that. svn path=/trunk/; revision=33409
* Don't add raw bytes to the tree.Gerald Combs2010-07-011-2/+3
| | | | svn path=/trunk/; revision=33403
* Moved register_ber_syntax_dissector() and register_ber_oid_syntax() fromStig Bjørlykke2010-06-281-2/+1
| | | | | | proto_reg_handoff_* to proto_register_*. svn path=/trunk/; revision=33345
* Avoid crash when adding SNMP Users.Stig Bjørlykke2010-06-261-7/+8
| | | | | | This fixes bug 4926. svn path=/trunk/; revision=33329
* Have abs_time_to_str() and abs_time_to_str_secs() take an additionalGuy Harris2010-05-211-1/+1
| | | | | | | | argument indicating whether to include the time zone in the string. If we're constructing a display filter, don't include the time zone, otherwise do. Fixes bug 4756. svn path=/trunk/; revision=32913
* Don't type prune the data_ptr pointer for UAT.Stig Bjørlykke2010-05-021-2/+2
| | | | svn path=/trunk/; revision=32628
* #include <string.h> and/or #include <stdio.h> not needed.Bill Meier2010-04-071-2/+0
| | | | svn path=/trunk/; revision=32417
* Fix for bug 4551.Jaap Keuter2010-03-051-0/+19
| | | | | | Add type to engine ID MAC Address format for Cisco agent/manager. svn path=/trunk/; revision=32125
* from Luis Ontanon:Anders Broman2010-03-041-4/+27
| | | | | | | | calculate the value of a ber integer by hand instead of just using proto_tree_add_item(). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3230 svn path=/trunk/; revision=32113
* From LEGO via bug 3459:Stig Bjørlykke2010-03-041-2/+5
| | | | | | | Add a callback to UAT to be called after the table has being updated, use it to renew the snmp_ue_cache. svn path=/trunk/; revision=32112
* From Luis Ontanon:Anders Broman2010-03-021-9/+35
| | | | | | | Check for duplicate entries in usmUserTable. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2426 svn path=/trunk/; revision=32081
* Add a third date format, ABSOLUTE_TIME_DOY_UTC, to show UTC with theGuy Harris2010-02-271-1/+1
| | | | | | | | | | | | date as YYYY/DDD, where DDD is a 1-origin day of year. Move the formats to a "time_fmt.h" file, included by the headers that use it. Have abs_time_to_str() and abs_time_secs_to_str() take the date format value, rather than a Boolean "show this as UTC" flag, as an argument. Document the ABSOLUTE_TIME_ formats a bit better. Use that format in the CCSDS and VCDU dissectors, rather than having those dissectors do the formatting themselves. svn path=/trunk/; revision=32034
* Switch to using a bundled version of the openSUSE Build Service packagesGerald Combs2009-12-211-4/+1
| | | | | | | | for GNUTLS since they provide 32-bit and 64-bit Windows packages. We no longer have winposixtype.h, so remove its #includes and add a ssize_t typedef to config.h.win32. svn path=/trunk/; revision=31341
* For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofGuy Harris2009-12-191-1/+1
| | | | | | | | | | | ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. svn path=/trunk/; revision=31319
* Add an argument to abs_time_to_str() and abs_time_secs_to_str()Guy Harris2009-12-101-4/+5
| | | | | | | | | | | indicating whether the time should be shown as local time or UTC. For now, always pass FALSE, meaning "show as local time". Clean up some stuff in the SNMP dissector, use abs_time_secs_to_str() for times with one-second resolution, and update a comment in various macros in the WSP dissector, while we're at it. svn path=/trunk/; revision=31227
* Made enterprise_oid pointer const.Stig Bjørlykke2009-11-091-1/+1
| | | | svn path=/trunk/; revision=30877
* Remove an unused variable.Stig Bjørlykke2009-11-091-1/+0
| | | | svn path=/trunk/; revision=30876
* Added some type renames.Stig Bjørlykke2009-11-011-0/+3
| | | | svn path=/trunk/; revision=30798
* Added a UAT table to describe enterprise specific-trap types.Stig Bjørlykke2009-11-012-29/+120
| | | | svn path=/trunk/; revision=30796
* Added SNMP to "Decode ASN.1 file as" list.Stig Bjørlykke2009-10-301-0/+2
| | | | svn path=/trunk/; revision=30766
* Remove unused NEED_PACKET_PROTO_H variableKovarththanan Rajaratnam2009-10-081-1/+0
| | | | svn path=/trunk/; revision=30409
* Fixed offset_from_real_beginning() -> tvb_offset_from_real_beginning()Stig Bjørlykke2009-10-051-1/+1
| | | | svn path=/trunk/; revision=30349
* Return from dissect_snmp_VarBind() when detecting invalid oid.Stig Bjørlykke2009-10-051-1/+8
| | | | svn path=/trunk/; revision=30348
* offset_from_real_beginning() is only called with 0 as second argument, so ↵Kovarththanan Rajaratnam2009-09-101-3/+3
| | | | | | remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning(). svn path=/trunk/; revision=29844