aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* rpc: add shutdown routine.Dario Lombardo2017-01-201-0/+8
| | | | | | | Change-Id: Ic00dae4b73ef89d6108c8c3085b7ce5a99d88574 Reviewed-on: https://code.wireshark.org/review/19690 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
* sshdump: add sudo option.Dario Lombardo2017-01-201-9/+19
| | | | | | | | | | Basic installation of tcpdump (the default remote capture binary) don't have setcap option. Give the user the option to run tcpdump with sudo (already possible with a custom remote capture command). Change-Id: I273798b5f7dc63b468b03eb633bfc60f53e30743 Reviewed-on: https://code.wireshark.org/review/19672 Reviewed-by: Dario Lombardo <lomato@gmail.com>
* DNS: update name_len variable when replacing name stringPascal Quantin2017-01-201-0/+2
| | | | | | | | | Bug: 13334 Change-Id: I07248747f678d4f89bbde33280b4d596462a4429 Reviewed-on: https://code.wireshark.org/review/19688 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
* disabled_protos: add cleanup function.Dario Lombardo2017-01-203-0/+28
| | | | | | | | | Change-Id: I7d585404463691946e2aa67e14e53edb813d9be8 Reviewed-on: https://code.wireshark.org/review/19681 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
* tap-tcp-stream.h: fix double declaration introduced in g73b5e3dPascal Quantin2017-01-201-16/+0
| | | | | | Change-Id: I2656e323b9ea6d41566ab0cef1e4a94e3591b08c Reviewed-on: https://code.wireshark.org/review/19687 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
* follow-stream: add cleanup function.Dario Lombardo2017-01-203-0/+19
| | | | | | | | Change-Id: Icfe7de118bc49da57f537601c2f256e4a028b4e2 Reviewed-on: https://code.wireshark.org/review/19680 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* Bluetooth: HCI_EVT: Implement "LE Direct Advertising Report"Michal Labedzki2017-01-201-1/+86
| | | | | | | | | | | It is part of Bluetooth Core 4 specification. Change-Id: I7a1e542285d65452d99f753b27777fff80ad1c59 Reviewed-on: https://code.wireshark.org/review/19646 Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* Qt: Fix a sequence dialog crash.Gerald Combs2017-01-201-1/+2
| | | | | | | | | | | | | | | If gui.geom.SequenceDialog.maximized is TRUE, loadGeometry will trigger a resize event, which will in turn call resetAxes. Call loadGeometry after we've initialized our various QCustomPlot bits so that resetAxes doesn't crash. Bug: 13329 Change-Id: I4d27683fb3eee0a7c897800401bfa3869e97662b Reviewed-on: https://code.wireshark.org/review/19683 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* Fix typo.Guy Harris2017-01-201-1/+1
| | | | | | Change-Id: I46be1220c8e789e1006cfbf7cff60e9556ff2caf Reviewed-on: https://code.wireshark.org/review/19685 Reviewed-by: Guy Harris <guy@alum.mit.edu>
* Qt: modify RTT graph (handle GSO, SACK, etc), plus bug fixesKevin Hogan2017-01-205-57/+224
| | | | | | | | | | | | | | | | | | | | Modifications to RTT graph: - change x-axis to time (s) rather than sequence number [ avoids sequence number wraparound ambiguity, plus easier to correlate RTT changes to tcptrace graph ] - change RTT computation to properly handle acks to GSO packets - change RTT computation to take SACK blocks into account Bug fixes: - eliminate potential memory leak if some packets are unacked - ensure RTT graph is shown if TCPGraph window is opened to it directly Change-Id: I2bdcab97399ebde0f15c78fa19c882529a814580 Reviewed-on: https://code.wireshark.org/review/19662 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* LDAP: fix wrong use of g_strlcpy introduced in gc397addPascal Quantin2017-01-202-3/+3
| | | | | | | | | | | | | Last parameter is the destination buffer size, not the number of bytes to copy. Bug: 13332 Change-Id: I9a6f5231d2d7a94fd5e692e8bbf4f5dba30b7c1a Reviewed-on: https://code.wireshark.org/review/19677 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* packet: clean shutdown routines.Dario Lombardo2017-01-191-0/+1
| | | | | | Change-Id: I620c683d77c724181a506e10f9d06a3944878690 Reviewed-on: https://code.wireshark.org/review/19679 Reviewed-by: Michael Mann <mmann78@netscape.net>
* Always display vht mcs data rate, but mark invalid assuming BCC encoding.Ashish Shukla2017-01-191-3/+7
| | | | | | | | | Bug: 12859 Change-Id: Iaf2242b0dcf16f211d5a7565b96099cc44e8bf3d Reviewed-on: https://code.wireshark.org/review/17899 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
* epan: add shutdown function for dissectors.Dario Lombardo2017-01-192-13/+27
| | | | | | | | | | | | Dissectors can register shutdown functions, that will be called just before program exit. Those function will free the memory allocated during the init function. Change-Id: Id88228af2cc916bfb316fe7b36d46499f6e4f8d4 Reviewed-on: https://code.wireshark.org/review/19282 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* DVB-S2-BB: Obey frame format from BB Header fieldsMustBeArt2017-01-191-20/+88
| | | | | | | | | | | | | | | | | | | | Interpret packet contents according to the descriptive fields contained in the BB header. Instead of always assuming a Generic Stream frame format, use the TS/GS field to detect Generic Stream, Generic Packetized, Transport Stream, or (reserved) frame formats and decode accordingly. In the case of Generic Stream frames, check the validity of header fields ISSYI, NPD, and UPL, and issue expert info if they are invalid for Generic Stream frames. Then dissect as GSE (as before). For other frame formats, just dump them as bytes for now. Change-Id: I6b040207f83369110eb704c543861c887f77baa7 Reviewed-on: https://code.wireshark.org/review/19634 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
* Remove space character from ETHERWATCH magic keyMichael Mann2017-01-191-1/+1
| | | | | | | | | | | | | V6.0 only has one space after "ETHERWATCH", not two so heuristics fail. "ETHERWATCH " (one space) still seems like enough of a distinction. Bug: 13093 Change-Id: Ib8786f6e2f5f595a4cab710b91cf78d175a6ab88 Reviewed-on: https://code.wireshark.org/review/19673 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
* IEEE80211: Updated VHT Group ID ManagementRadhashyam Behera2017-01-191-10/+60
| | | | | | | | | | | | Detailed decode of Membership status & User Position in GroupID Mamagement frame. Bug: 13322 Change-Id: I74b1d93757e3e10a2a0d4423fcfdcd2265e1bd62 Reviewed-on: https://code.wireshark.org/review/19564 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
* Qt: add graph of unacked (outstanding) bytes to window scale graphKevin Hogan2017-01-192-10/+52
| | | | | | | | | | | This metric is commonly used as an estimate of the sender's congestion window. [ when examining a capture taken from the sender ] Change-Id: I812d5556cef477c08ef1e5d396fbdddda9a6751e Reviewed-on: https://code.wireshark.org/review/19661 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
* dns: change get_dns_name to return consumed bytes + actual name len.Dario Lombardo2017-01-199-207/+228
| | | | | | | | | | | | | | | | | | | | Because of the DNS name encoding, the consumed bytes in the tvb and the length of the string of the dns name can be different. We need to handle them separately for the purpose they are. Moreover the name string can contain null bytes, then we can't rely on strlen() but we need the actual length. Subsequent calls to proto_tree_add_string() will require to pass the string to format_text() in order have non-printable characters printed. Bug: 13289 Change-Id: I6d0b295867ece265f8995f82da2c629992aeb703 Reviewed-on: https://code.wireshark.org/review/19539 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
* pcep: Add support of draft-ietf-pce-pcep-service-aware-13Simon Zhong2017-01-191-88/+335
| | | | | | | | | | update support of draft-ietf-pce-segment-routing-08 Change-Id: I4d25268bb331462fbe219f242ff8278b017de37b Reviewed-on: https://code.wireshark.org/review/19642 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* QUIC: fix dissection of ACK FrameAlexis La Goutte2017-01-191-27/+24
| | | | | | | | | | First Ack Block is always present in ACK Frame (don't depend of present of NACK) Change-Id: I702151a6ccb236272ace9dfdf0f4b507a549871e Reviewed-on: https://code.wireshark.org/review/19627 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* RSVD dissector: added RSVD v2 verbsVolodymyr Khomenko2017-01-192-22/+35
| | | | | | | | | | | | | | | | | Improved operation_code map to resolve RSVD v2 codes. Changed GET_FILE_INFO -> GET_INITIAL_INFO for spec conformance. See https://msdn.microsoft.com/en-us/library/dn392322.aspx SMB2 IOCTL FSCTL_SVHDX_ASYNC_TUNNEL_REQUEST must be handled in the same way as FSCTL_SVHDX_SYNC_TUNNEL_REQUEST: RSVD dissector must be used (new async flow used by RSVDv2). See https://msdn.microsoft.com/en-us/library/dn366375.aspx Ping-Bug: 11232 Change-Id: Ie51773fc2199a7674538101b87cec398354bd97a Reviewed-on: https://code.wireshark.org/review/19657 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* Populate logcat year based on localtimeFrank Carpenter2017-01-191-1/+3
| | | | | | | | | | Change-Id: If7c790c25ed24da1b1442ee86e3a2f75bd3f8856 Reviewed-on: https://code.wireshark.org/review/19658 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* packet.c: use call_routine() for all listsMartin Kaiser2017-01-191-18/+3
| | | | | | | | | | | | | For running through the postseq cleanup and final registration lists, we can use the same dummy function call_routine() that is used for the init and the cleanup lists. We don't need our own copies. Change-Id: Ia1ea647d5831adda26dab86eceba8fcf704ce122 Reviewed-on: https://code.wireshark.org/review/19668 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* Use dissector tables for PPP protocols' options.Michael Mann2017-01-194-1152/+1922
| | | | | | | | | | | | | | | Create pinos for all of the PPP protocols options and a dissector table to store them all. Adapt a new version of dissect_ip_tcp_options, (now ppp_dissect_options) that uses the dissector tables for name of options and dissection function. Also standardize the dissectors for all protocols so that all include type and length in the dissection. Change-Id: I0033574e2831789040a1ce2857bf0e825d791cbe Reviewed-on: https://code.wireshark.org/review/19656 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
* packet: free postseq_cleanup_routines list.Dario Lombardo2017-01-181-6/+7
| | | | | | | | | Change-Id: Ic1972399b706407ce8f15a3e554f1304a36d1009 Reviewed-on: https://code.wireshark.org/review/19663 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
* Update fuzz-test to match capinfos behavior.Gerald Combs2017-01-181-1/+1
| | | | | | | | As of gebd3dc6, capinfos returns 2 for invalid capture files. Change-Id: I00c1ab44c9929a9e922ac2a1ee8904632c1e460f Reviewed-on: https://code.wireshark.org/review/19667 Reviewed-by: Gerald Combs <gerald@wireshark.org>
* Fix Access Violation in plugin_if_mainwindow_get_ws_info(...)Paul Offord2017-01-182-2/+2
| | | | | | | | | | | Call to plugin_if_get_ws_info when no packets are being displayed causes an Access Violation in plugin_if_mainwindow_get_ws_info as the pointer in cf->current_frame is NULL. Bug: 12973 Change-Id: I33e8fe6f3894963a6f1f1ec9aa9169f85e1e3b18 Reviewed-on: https://code.wireshark.org/review/19659 Reviewed-by: Roland Knall <rknall@gmail.com>
* Gigamon Trailer support for new chassis typesSandeep Dahiya2017-01-181-9/+17
| | | | | | | | | Change-Id: Ib24cd2c701c0e158c07eff4dffe0bbf9937d132b Reviewed-on: https://code.wireshark.org/review/19660 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* OpenFlow (v5/1.4): Add complete dissection of error messagesAlexis La Goutte2017-01-181-4/+22
| | | | | | | | | | | Like for OpenFlow (v4/1.3) (g4b7c2781fb) Change-Id: I61cfea015e548e5eaa37856df86e96bd0ba21795 Ping-Bug: 13221 Reviewed-on: https://code.wireshark.org/review/19644 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* stat_tap_ui: add cleanup function.Dario Lombardo2017-01-183-0/+16
| | | | | | | | | Change-Id: I0275a6e0d5d151f086d96c6388b9fa647ea0085c Reviewed-on: https://code.wireshark.org/review/19654 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
* Bluetooth: HCI_EVT: Implement some commands from Core 4Michal Labedzki2017-01-171-100/+367
| | | | | | | | | | Now all unimplemented commands are in /* TODO */ Change-Id: I53c8dd0a660b62403214a3c75297e627337ed5fb Reviewed-on: https://code.wireshark.org/review/19645 Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* packet: free init/cleanup functions lists.Dario Lombardo2017-01-171-6/+8
| | | | | | | | Change-Id: Ia28ceef189f8fe16105da88c01e1a159d5029c0a Reviewed-on: https://code.wireshark.org/review/19655 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* exported_object: add cleanup function.Dario Lombardo2017-01-173-0/+21
| | | | | | | | Change-Id: If4c35d18db1dc982e981004838e0eabbf4479e78 Reviewed-on: https://code.wireshark.org/review/19653 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* exported_pdu: add cleanup function.Dario Lombardo2017-01-173-0/+15
| | | | | | | | Change-Id: Iafc9f1c4b2a0210d8098b37eefc095e740182258 Reviewed-on: https://code.wireshark.org/review/19648 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* profinet (pn): Fix Dead Store (Dead assignement/Dead increment) Warning ↵Alexis La Goutte2017-01-161-1/+0
| | | | | | | | found by Clang Change-Id: Id00e7dc1b23f7fce31845f024671a05fe06fc660 Reviewed-on: https://code.wireshark.org/review/19635 Reviewed-by: Anders Broman <a.broman58@gmail.com>
* RSVD: fix TUNNEL_SCSI_REQUESTVolodymyr Khomenko2017-01-161-0/+14
| | | | | | | | | | | Length of CDBBuffer must be always 16 bytes If CDBLength is less than 16, add padding bytes Change-Id: I241a10325ebe17b32469eaf7dc530fc7fe2105de Reviewed-on: https://code.wireshark.org/review/19628 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* 802.11(ad): not longer need to use p_add_proto_data/p_get_proto_data for ↵Alexis La Goutte2017-01-161-8/+4
| | | | | | | | | | pass isGrant to beamforming control function Change-Id: I719ff48a1992904c80c602f9706697e71b93ccba Reviewed-on: https://code.wireshark.org/review/19640 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
* packet-nvme-rdma: Support Dissecting connect cmd & inline data.Parav Pandit2017-01-162-40/+114
| | | | | | | | | | | | | | | | | This patch adds support to dissect data of the connect command which comes along with the cmd in same packet. It also removed unwanted tvb addition for rdma fabric commands, completion and nvme commands. Bug: 13201 Change-Id: I33062f67a69cdca4b909ed8c08201dea5e0aa095 Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19632 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* packet-tns.c: Add Version2 (SQLNET_RETURN_OPI_PARAM)Alexandr Savca2017-01-161-0/+60
| | | | | | | | | | | I've tested with pcaps from SampleCaptures (wiki). Change-Id: Ifa1b628fbc675843c54dfd4b993809fd072dc69c Reviewed-on: https://code.wireshark.org/review/19636 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* xml(.h): fix indent (use spaces) and modelinesAlexis La Goutte2017-01-151-25/+38
| | | | | | | | | | | use same indent like packet-xml.c Change-Id: I687b0306ba1d3559ce4a299a0e66c55e3f04fdfd Reviewed-on: https://code.wireshark.org/review/19641 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
* [Automatic update for 2017-01-15]Gerald Combs2017-01-1510-1014/+1107
| | | | | | | | Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ia487718c34913b5bb8297184fedb6c7ecaf604e6 Reviewed-on: https://code.wireshark.org/review/19637 Reviewed-by: Gerald Combs <gerald@wireshark.org>
* DVB-S2-BB: Use proto_tree_add_bitmask()MustBeArt2017-01-141-38/+36
| | | | | | | | Change-Id: I1a4b50873a183c0f6051dc0db3fecf5e62c92cbb Reviewed-on: https://code.wireshark.org/review/19633 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* Qt: fix memory leaks in UatDialogPeter Wu2017-01-131-1/+9
| | | | | | | | | | | | Avoid leaking memory for the stringified UAT field values (tostr) and for copies of rows. Change-Id: I1bf20035fabe92da8216c820bc47ebce7dd73951 Reviewed-on: https://code.wireshark.org/review/19604 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
* geoip: free resources to avoid leak.Dario Lombardo2017-01-131-1/+4
| | | | | | | | | | Change-Id: Ia4a938e8a6b3856959c375f4bfcdf565a21eabef Reviewed-on: https://code.wireshark.org/review/19629 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com>
* DVB-S2 BB: Handle GSE Padding in BB framesMustBeArt2017-01-131-20/+34
| | | | | | | | | | | | | | | GSE Padding is outside of any GSE Packet and continues to the end of the Baseband Frame, per 4.2.1 of ETSI TS 102 606-1. Added dvb-s2_gse.padding as an integer representing the length in bytes of the padding field. Change-Id: I9ed22c37a1969059a09ba44d9e3473cb9d0a1880 Reviewed-on: https://code.wireshark.org/review/19579 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
* X2AP: replace non ASCII characters in ASN.1 source filesPascal Quantin2017-01-132-5/+5
| | | | | | Change-Id: I114ba3fc68dccf9f791488920f602906d2d8c124 Reviewed-on: https://code.wireshark.org/review/19626 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
* LTE RRC: upgrade dissector to v13.4.0Pascal Quantin2017-01-1311-378/+494
| | | | | | | | | Change-Id: I5f7de78f0be320781091e17ec8c471a3fd482b14 Reviewed-on: https://code.wireshark.org/review/19625 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
* tools: add options documentation to valgrind-wireshark.shDario Lombardo2017-01-131-1/+19
| | | | | | Change-Id: Id0bb85b9499f1e6f327b711d38deefe295e92c1a Reviewed-on: https://code.wireshark.org/review/19624 Reviewed-by: Anders Broman <a.broman58@gmail.com>
* SSL: fix compilation without libgcrypt or gnutlsPascal Quantin2017-01-131-0/+2
| | | | | | Change-Id: I785db404969f89a3f90eddbda5542ee6b676ddb8 Reviewed-on: https://code.wireshark.org/review/19623 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>