aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix small typoRonnie Sahlberg2002-07-311-2/+2
| | | | svn path=/trunk/; revision=5920
* Don't loop forever in "find_rsvp_session_tempfilt()" orGuy Harris2002-07-311-3/+10
| | | | | | | | | | | | | "dissect_rsvp_msg_tree()" if there's a zero-length object. In "find_rsvp_session_tempfilt()", check to make sure the data exists before fetching it, so that it doesn't throw an exception - the information it returns is only used to put items into the protocol tree, so there's no reason to quit dissecting the packet just because it can't find that information because, for example, not enough of the packet data was captured. svn path=/trunk/; revision=5919
* From Chris Waters: check 802.11 FCS if present.Guy Harris2002-07-312-3/+37
| | | | svn path=/trunk/; revision=5918
* Adding a new macro CMP_ADDRESS similar to ADDRESS_EQUAL but this one will returnRonnie Sahlberg2002-07-311-1/+15
| | | | | | | -1,0,1 as the xxxcmp() functions will instead of just true/false. Useful if you not only want to check for equality but also if you want to have a way to order the elements. svn path=/trunk/; revision=5917
* From Graeme Hewson:Guy Harris2002-07-305-93/+211
| | | | | | | | | | Ethereal sometimes creates a progress dialog bar and then, if the processing is fast, quickly destroys it. The resulting "flash" can be disconcerting. This set of patches ensures a progress bar is either not created or is displayed for a minimum time. svn path=/trunk/; revision=5916
* Call "proto_item_add_subtree()" to create a subtree for POST data, don'tGuy Harris2002-07-301-5/+9
| | | | | | | just use the return value of a "proto_tree_add" routine as if it could be used as a protocol tree. svn path=/trunk/; revision=5915
* From Michael Tuexen: AF_INET6 support for DLT_NULL captures fromGuy Harris2002-07-303-3/+6
| | | | | | | | Darwin/MacOS X. (As if FreeBSD and {Net,Open}BSD having different AF_INET6 values wasn't enough, we have The Other BSD having its own value....) svn path=/trunk/; revision=5914
* #ifdef out some variables not used on Windows.Guy Harris2002-07-301-30/+32
| | | | | | | | | If printing a single packet to a file, don't use the "print to a printer" code for Windows. Only free "print_args.dest" *after* the last usage. svn path=/trunk/; revision=5913
* Code from Jan Berkel <jan.berkel@gmx.de> toUwe Girlich2002-07-291-13/+541
| | | | | | | * fully decode client->server packets (mouse movement, button press etc.) * start of decoding server->client packets (names of first command as text) svn path=/trunk/; revision=5912
* From Didier Gautheron: add FPGetUserInfo.Guy Harris2002-07-291-1/+107
| | | | svn path=/trunk/; revision=5911
* From Joerg Mayer:Guy Harris2002-07-291-2/+5
| | | | | | | | gtk/colors.c: Fix a memleak found by valgrind (Note that there are similar bugs in other functions that use the same construct with path!) svn path=/trunk/; revision=5910
* From Joerg Mayer:Guy Harris2002-07-2919-165/+133
| | | | | | | | | | | | | All files: - Replace types from sys/types.h by those from glib.h - Replace ntoh family of macros from netinet/in.h and winsock2.h by g_ntoh family from glib.h - Remove now unneeded includes of sys/types.h, netinet/in.h and winsock2.h wtap.h Move includes to the top svn path=/trunk/; revision=5909
* Committing Kerberos NetBIOS address type stuff from Jim McDonough.Richard Sharpe2002-07-291-1/+8
| | | | svn path=/trunk/; revision=5908
* Changed the SMB dissector to put ALL command PDUs in one SMB in the summaryRonnie Sahlberg2002-07-271-22/+30
| | | | | | | | line, separated by ; It only prints "Request"/"Response" for the first command to save space svn path=/trunk/; revision=5907
* If conversations have already been created in lower layers, say TCP beforeRonnie Sahlberg2002-07-271-8/+8
| | | | | | | | | | | | | SMB sees the PDU, then SMB would forget to create the proper state variables and crash. SMB is changed to split the operation into 1, only create a conversation if it needs to. (as before) 2, detect if it needs to create the si.ct state variables independant of whether smb also created a conversation or not. Without this patch and with changes to say TCP to create conversations ethereal would crash at the first packet the SMB dissector would see. svn path=/trunk/; revision=5906
* From Stefan Wenk: remove an unnecessary +1 from some offsetGuy Harris2002-07-251-4/+3
| | | | | | computations. svn path=/trunk/; revision=5905
* For connection-oriented DCE RPC, show the stub data if we can't actuallyGuy Harris2002-07-251-2/+18
| | | | | | | do anything else with a request or reply (e.g., because we haven't seen the bind request). svn path=/trunk/; revision=5904
* Remove trailing space characters between a netbios name and the name type.Tim Potter2002-07-221-1/+14
| | | | | | This makes the display look much nicer! svn path=/trunk/; revision=5903
* Update from Anand V. Narwani:Guy Harris2002-07-221-6/+54
| | | | | | | | | | fix a minor problem in which the Info colum was incorrectly defaulted to "Fragmentation Frame"; add 4 missing fields for the Extended header in Fragmentation frames. svn path=/trunk/; revision=5902
* Fix up some comments.Guy Harris2002-07-211-10/+9
| | | | | | | | Fix up a call to use the right byte-ordering routine (both routines have the same effect, but we want to use the right one to make it clearer what we're doing). svn path=/trunk/; revision=5901
* Mention the "-h" flag.Guy Harris2002-07-211-1/+6
| | | | | | Fix up the list of arguments to "-S" in the synopsis. svn path=/trunk/; revision=5900
* "yyin" is from lex/flex, so it should be "extern", not "static" - weGuy Harris2002-07-211-15/+19
| | | | | | | | | | | | | | | | | | have to modify lex/flex's input stream, not some private "FILE *". Fix up the usage message to: mention the "-h" flag; not mention the non-existent "-w" flag; fit within 80 columns. Add "-h" to the list of options in the "getopt()" call, as there's code to support it, and remove "-r" and "-w", as there wasn't any code to support them. svn path=/trunk/; revision=5899
* Fix the problems WRT overwriting a capture file. From Joerg Mayer.Richard Sharpe2002-07-211-2/+10
| | | | svn path=/trunk/; revision=5898
* Offsets in packets should be "int", not "guint8", unless there is anGuy Harris2002-07-211-3/+3
| | | | | | | | | | | *inviolable guarantee* that the offset will *never* be bigger than 255. (The same applies for "guint16" and 65535.) Otherwise, you run the risk of an infinite loop (packets are not guaranteed to be valid, nor are the contents of capture files - and there's no guarantee that you're reading a DOCSIS file if you've turned on the "force interpretation as DOCSIS" flag.) svn path=/trunk/; revision=5897
* From Anand V. Narwani: fix to the Info column for Request frames.Guy Harris2002-07-201-3/+3
| | | | svn path=/trunk/; revision=5896
* From Prabhakar Krishnan: add item to SMB protocol tree for time betweenGuy Harris2002-07-204-6/+30
| | | | | | request and response. svn path=/trunk/; revision=5895
* Include sys/types.h to provide the type size_t, which is neededUwe Girlich2002-07-191-1/+6
| | | | | | | | | further down in this file but must not be defined yet in the C source, which includes this header file. Example: without this change, packet-dcerpc-samr.c 1.51 could not be compiled under SINIX-M. svn path=/trunk/; revision=5894
* From Richard Urwin: fixes for README.plugins.Guy Harris2002-07-193-9/+16
| | | | | | | Combine the two entries for Anand Narwani in the AUTHORS file and the Ethereal man page list of contributors. svn path=/trunk/; revision=5893
* Change a "proto_tree_add_uint()" call to use "proto_tree_add_item()".Guy Harris2002-07-171-2/+3
| | | | | | | When dissecting a BYE packet, bump the chunk count when dissecting the SSRC/CSRC identifiers, so the loop terminates properly. svn path=/trunk/; revision=5892
* Add an extra argument to "tvb_find_line_end()", which specifies what itGuy Harris2002-07-1719-74/+158
| | | | | | | | | | | | should do if it doesn't find an EOL; if FALSE, it behaves as before, returning values that treat the line as ending at the end of the tvbuff, and if TRUE, it returns -1, so its caller can do segment reassembly until it gets the EOL. Add an option to the SMTP dissector to do segment reassembly, and do segment reassembly of the first line. svn path=/trunk/; revision=5891
* From Kan Sasaki:Guy Harris2002-07-171-64/+210
| | | | | | | | | | | | | 1. Add some VSAs. 2. Modify the routines match_numval() and rd_match_strval_attrib() to use a null string pointer, rather than a 0 value, to signify the end of the attribute table, because some vendors are using an attribute with a value of 0. 3. Bug fix. svn path=/trunk/; revision=5890
* From Joerg Mayer:Guy Harris2002-07-1766-345/+42
| | | | | | | | | | | | | | | dftest.c: Remove #if-0-ed includes packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c, packet-wtp.c, ethereal_gen.py: Remove redundant include varargs (already in snprintf.h, and required only for snprintf.h) Remove unused include of snprintf.h from files not using "snprintf()". svn path=/trunk/; revision=5889
* Get rid of some "unused variable" and "unused static function" warnings,Guy Harris2002-07-173-30/+89
| | | | | | | | | | | | | | | and some compile errors in Tethereal, when compiling without libpcap. If libpcap is missing (whether that's detected at compile time or, as on Windows, at run time), don't call any of the "capture_prefs" routines - the routine to create the capture preferences page wasn't called, so the other routines can try to refer to non-existent widgets and other items and crash. Get rid of the stub routines in "capture_prefs()" used when compiling without libpcap, as they're no longer called. svn path=/trunk/; revision=5888
* From Joerg Mayer: add #includes of "snprintf.h" in modules that usedGuy Harris2002-07-164-3/+16
| | | | | | "snprintf()" but weren't including "snprintf.h". svn path=/trunk/; revision=5887
* Get rid of carriage returns.Guy Harris2002-07-161-43/+43
| | | | svn path=/trunk/; revision=5886
* Don't allocate structures to remember how to re-access a packet's data,Guy Harris2002-07-161-12/+27
| | | | | | | or the array to hold pointers to those structures, if we're only reading the file sequentially. svn path=/trunk/; revision=5885
* From Graeme Hewson:Guy Harris2002-07-1622-157/+285
| | | | | | | | | | | | | | | | Allow "-" as the output file name in Wiretap, referring to the standard error. Optimize the capture loop. Fix some of the error-message printing code in Ethereal and Tethereal. Have Wiretap check whether it can seek on a file descriptor, and pass the results of that test to the file-type-specific "open for output" routine. Have the "open for output" routines for files where we need to seek when writing the file return an error if seeks don't work. svn path=/trunk/; revision=5884
* From Graeme Hewson:Guy Harris2002-07-161-6/+3
| | | | | | | | | | In sync mode, if the capture file written by the child can't be opened by the parent, ethereal will write two identical popup error messages. This patch fixes the problem. svn path=/trunk/; revision=5883
* Update the "NT sucks for PPP capture" note to include NT 5.1 (XP andGuy Harris2002-07-151-25/+24
| | | | | | | | .NET Server). Fix indentation. svn path=/trunk/; revision=5882
* Added support for dissecting RSVP Bundle MessagesAshok Narayanan2002-07-151-203/+290
| | | | svn path=/trunk/; revision=5881
* From Joerg Mayer:Guy Harris2002-07-151-10/+9
| | | | | | | Replace our own definitions of TRUE/FALSE by their glib.h equivalents. Put sys/types.h into ifdefs. svn path=/trunk/; revision=5880
* From Joerg Mayer:Guy Harris2002-07-152-22/+8
| | | | | | Use the GLib macros to convert from network to host byte order. svn path=/trunk/; revision=5879
* From Joerg Mayer:Guy Harris2002-07-151-9/+9
| | | | | | | | | Change struct addr to guint32 which is the way it is used anyway. Use the GLib macros to convert from network to host byte order. svn path=/trunk/; revision=5878
* Fix a sample call to add an item to the subtree for a protocol to add itGuy Harris2002-07-151-7/+17
| | | | | | | | | | there rather than to the top-level tree, and use "proto_tree_add_item()". Add a description of PROTOSHORTNAME, and give an example of the way PROTONAME, PROTOSHORTNAME, and PROTOABBREV would be set for a protocol. svn path=/trunk/; revision=5877
* The mysterious two bytes were just the FCS. Use the length field fromGuy Harris2002-07-151-2/+12
| | | | | | | | | the IP header as the reported length again, but make the actual length be the minimum of the length of the tvbuff and the reported length, just to keep from having a weird tvbuff that has more data than the packet has. svn path=/trunk/; revision=5876
* Clean up the setting of "id_offset" and "sd_offset"; this fixes a bug inGuy Harris2002-07-151-68/+46
| | | | | | handling the first few packets in a file. svn path=/trunk/; revision=5875
* SMTP and FTP response codes need more than 1 byte, as they can go up toGuy Harris2002-07-152-6/+6
| | | | | | 999; give them 4. svn path=/trunk/; revision=5874
* Redo the way random access is handled. Save, for each packet, theGuy Harris2002-07-151-120/+230
| | | | | | | | | | | | | | offset of the beginning of the first record containing data from that packet, and the offset from the first byte of data in that record of the first byte of data from that packet; to read a given packet, seek to the offset of the first record, and keep processing packets until we find one with the right direction. This fixes a problem where it wasn't correctly reading the packet, when doing random access, in cases where you have a sequence of records that stop in the middle of a packet. svn path=/trunk/; revision=5873
* This seems to fix the problem of trying to save over the top of an existingRichard Sharpe2002-07-151-9/+12
| | | | | | capture on some occassions. svn path=/trunk/; revision=5872
* Add Booleans for the Ack and Srefresh messages, and move the Boolean forGuy Harris2002-07-141-5/+13
| | | | | | the HELLO message to be in numerical message-code order. svn path=/trunk/; revision=5871