aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Don't prime the display filter unless we're re-applying it; otherwise,Guy Harris2002-04-201-2/+2
| | | | | | | we aren't building a protocol tree, and we can't prime the filter against the tree. svn path=/trunk/; revision=5206
* Bug fix from Frank Singleton.Guy Harris2002-04-191-2/+2
| | | | svn path=/trunk/; revision=5205
* On Windows, don't put the capture preferences item into theGuy Harris2002-04-191-2/+9
| | | | | | "Preferences" dialog box if we couldn't load WinPcap. svn path=/trunk/; revision=5204
* proto_registrar_get_nth(hfinfo->id) == hfinfo, so use the latter ratherGuy Harris2002-04-191-2/+2
| | | | | | than the former. svn path=/trunk/; revision=5203
* Initial support for writing NetXRay 2.x (Windows Sniffer) formatGuy Harris2002-04-184-6/+157
| | | | | | captures, from Olivier Abad. svn path=/trunk/; revision=5202
* From Phil Williams: support for looking up fields by name.Guy Harris2002-04-184-14/+44
| | | | | | | Clean up some white space, and one non-extern declaration in "epan/proto.h". svn path=/trunk/; revision=5201
* More LSA updatesRonnie Sahlberg2002-04-181-14/+187
| | | | svn path=/trunk/; revision=5200
* Removed init routine as the dcerpc/smb init is now done in the correctTim Potter2002-04-181-10/+1
| | | | | | location. svn path=/trunk/; revision=5199
* Use common policy handle hashing code in packet-dcerpc-nt.cTim Potter2002-04-181-3/+24
| | | | | | Fix for lsa_open_policy request dissection. svn path=/trunk/; revision=5198
* Catch attempts to register ett_ values after the array of "tree isGuy Harris2002-04-181-1/+11
| | | | | | expanded" flags has been allocated. svn path=/trunk/; revision=5197
* Add a "proto_register_dcerpc_smb()" which registers ett_ values forGuy Harris2002-04-187-53/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "packet-dcerpc-nt.c", and registers "dcerpc_smb_init()" as an initialization routine. Take the ett_ registration out of the latter routine, and also take out the "do this only once" stuff. Get rid of the initialization routines for netlogon, samr, and spoolss; they just call "dcerpc_smb_init()", which is now an initialization routine of its own. The policy hash initialization should be done before every capture, so it should be done in an initialization routine, and should not do any "do this only once" stuff. It should also be called only once before every capture, rather than 3 times. The ett_ initialization should, however, be done at the same time all other ett_ initialization is done - at protocol registration time - so it should be done in a "proto_register_" routine. This fixes a bug I saw wherein 1) the tree for Unicode strings was open by default and 2) if you closed one and then exited, Ethereal would crash. The problem is that "proto_register_subtree_array()" doesn't expand the array, it just bumps the number of registered ett_ values; the array is allocated in "proto_init()". As such, if you register ett_ values with "proto_register_subtree_array()" *after* "proto_init()" is called - and, even for the first capture, initialization routines are called after "proto_init()" is called - you will get ett_ numbers that go past the number of elements in the array. Move the declaration of "ett_nt_unicode_string" to "packet-dcerpc-nt.h", as it's exported from "packet-dcerpc-nt.c". Get rid of the declaration of "dcerpc_smb_init()" in "packet-dcerpc-nt.h", and make it static, as it's no longer called from outside "packet-dcerpc-nt.c". svn path=/trunk/; revision=5196
* bugs found when verifying agains muddle generated idl fileRonnie Sahlberg2002-04-171-1/+15
| | | | svn path=/trunk/; revision=5195
* Bugfixes for LSA dissector and a small change to the security_descriptor ↵Ronnie Sahlberg2002-04-172-44/+74
| | | | | | dissector in packet-smb.c so we can call it from DCERPC NDR encoded services. svn path=/trunk/; revision=5194
* Tiny bugfix. One element was declared as of the wrong type.Ronnie Sahlberg2002-04-171-3/+3
| | | | svn path=/trunk/; revision=5193
* Display rids for open user, group, alias in COL_INFO.Tim Potter2002-04-171-6/+64
| | | | | | Give query user info its own dissector. svn path=/trunk/; revision=5192
* Prettification of SAMR dissector - display short names in COL_INFO.Tim Potter2002-04-171-184/+1211
| | | | svn path=/trunk/; revision=5191
* Added LSAENUMERATEPRIVILEGESACCOUNT, LSAADDPRIVILEGESTOACCOUNT and ↵Ronnie Sahlberg2002-04-171-10/+156
| | | | | | LSAREMOVEPRIVILEGESFROMACCOUNT function dissectors and support functions to LSA. svn path=/trunk/; revision=5190
* In "fragment_add_seq_check()", handle short frames the same wayGuy Harris2002-04-171-49/+24
| | | | | | | | | | | | regardless of whether they're the first frame we see in a reassembly or not - put all but the last fragment into the hash table (so subsequent frames with the same reassembly ID don't get misdissected as unfragmented frames), return the head of the fragment list for the first fragment and NULL for all other fragments (so the first fragment gets dissected as a fragmented packet), and unhash the fragment head from the reassembly hash table when we see the last fragment. svn path=/trunk/; revision=5189
* Added dissection of LSA functions LSALOOKUPPRIVILEGENAME and ↵Ronnie Sahlberg2002-04-171-7/+62
| | | | | | LSALOOKUPPRIVILEGEVALUE svn path=/trunk/; revision=5188
* Added dissection and support functions for LSAENUMERATEPRIVILEGESRonnie Sahlberg2002-04-172-5/+155
| | | | | | function. svn path=/trunk/; revision=5187
* Don't try to reassemble short frames - but do still pass them through atGuy Harris2002-04-172-20/+87
| | | | | | | | least some of the reassembly mechanism, so we can deal with both bogus and real last fragment (display the bogus ones as unfragmented frames, treat the real ones as fragments). svn path=/trunk/; revision=5186
* Change the way not implemented functions are commented out so thast etherealRonnie Sahlberg2002-04-172-7/+126
| | | | | | will still print the name of the function even if no dissector for it exists. svn path=/trunk/; revision=5185
* Fix up the handling of the "fragmented" flag in the "packet_info"Guy Harris2002-04-171-13/+26
| | | | | | structure (make it match the way it's done in the IP dissector). svn path=/trunk/; revision=5184
* Remove some temporary functions from NETLOGON now that the real functionsRonnie Sahlberg2002-04-171-107/+2
| | | | | | exist in LSA. svn path=/trunk/; revision=5183
* Show the "More Fragments" indicator as such, rather than as a "this isGuy Harris2002-04-171-4/+4
| | | | | | fragmented" vs. "this is not fragmented" indicator. svn path=/trunk/; revision=5182
* LSA dissector updates. Adds a lot of LSA functions to the dissector.Ronnie Sahlberg2002-04-174-919/+1546
| | | | | | | Also export dissect-nt-GUID() from netlogon since this structure is common to other interfaces as well. svn path=/trunk/; revision=5181
* Don't bother with "reassembled_key" structures - just use theGuy Harris2002-04-171-52/+33
| | | | | | | | | | | | | | | "frame_data" structure for the frame as the key structure, and use the frame number in that field as the key. (We could be even cheesier and use the frame number as the key, with casts.) When we move an entry from the hash table of reassemblies to the hash table of reassembled packets, free the key structure for the first hash table. (This doesn't plug a leak, as they get freed when you reinitialize the data structures, but it does reduce the memory needed for them to the amount needed for in-progress reassemblies rather than the amount needed for all reassemblies.) svn path=/trunk/; revision=5180
* In a ChangeHosts request, display 4-byte Internet addresses as IPv4Guy Harris2002-04-172-29/+23
| | | | | | | | | | | | addresses. When showing a list of keysyms, build the text representation of the item for the list by appending keysyms to the text of the item as dissected; this fixes a bug in the display of those keysums, and means that we don't build a text string with the keysyms if we're not generating the text representation. svn path=/trunk/; revision=5179
* Fix up the offsets in the list of segments.Guy Harris2002-04-171-2/+2
| | | | svn path=/trunk/; revision=5178
* Add a separate hash table to the reassembly code for reassembledGuy Harris2002-04-173-104/+636
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | packets, using the reassembly ID and the frame number of the final frame as the key. There is no guarantee that reassembly IDs won't be reused, even when talking between the same source and destination address; if, once reassembly is complete, the "fragment_data" structure is moved to the latter hash table, this will keep reused reassembly IDs from causing mis-reassembly. Add a routine "fragment_add_seq_check()", which if a fragment has the "more fragments" flag not set but is the first fragment of a reassembly, treats that as a non-fragmented frame, allocating a "fragment_data" structure for the reassembly but not attaching any fragment to it, and adding it to a reassembled packet list; if a packet has been reassembled, removes it from the table of reassemblies and moves it to the table of reassembled packets; if the frame's been seen already, looks it up in the table of reassembled packets rather than the table of reassemblies. Add reassembly support for fragmented 802.11 frames. Use "fragment_add_seq_check()" to cope with the fact that some hardware+drivers apparently hands us reassembled frames with a non-zero fragment number and the "more fragments" bit clear (as if it puts the 802.11 header of the *last* fragment onto the reassembled data). svn path=/trunk/; revision=5177
* Use policy handle hash code in DCERPC/SMB SAMR dissector.Tim Potter2002-04-174-83/+203
| | | | | | Start to move some common stuff into packet-dcerpc-nt.[ch] svn path=/trunk/; revision=5176
* Rename the "frag_offset" argument of "fragment_add_seq()" toGuy Harris2002-04-172-9/+9
| | | | | | | "frag_number", to make it clearer that it's not a byte offset but a sequence number. svn path=/trunk/; revision=5175
* From Michael Tuexen: add missing support for the T-Bit in ABORT chunks.Guy Harris2002-04-161-19/+31
| | | | svn path=/trunk/; revision=5174
* Add support for desegmentation of X11 messages.Guy Harris2002-04-162-1134/+1501
| | | | | | | | | | | | | | Try to check whether the first request we see is an initial connection request, and dissect it as such if so. Get rid of the global "next_offset" variable. Check for buffer overflows when building the summary item for a list of keysyms. Display BASE_DEC items in decimal, not hex. svn path=/trunk/; revision=5173
* Fix more Politecnico di Torino links.Gerald Combs2002-04-161-5/+5
| | | | svn path=/trunk/; revision=5172
* Do the standard "next entry offset" stuff in NT NOTIFY replies, so as toGuy Harris2002-04-161-2/+25
| | | | | | | | | 1) handle inter-entry padding; 2) quit when the "next entry offset" is 0 (that being the signal for the last entry). svn path=/trunk/; revision=5171
* Display non-zero return codes in COL_INFO.Tim Potter2002-04-163-50/+105
| | | | svn path=/trunk/; revision=5170
* From Michael Tuexen:Guy Harris2002-04-151-6/+22
| | | | | | | | - support for current SCTP checksum - fix a bug for the -S parameter - fix a bug in the displayed output for the TSN and PPI. svn path=/trunk/; revision=5169
* ASAP support, from Michael Tuexen.Guy Harris2002-04-154-2/+559
| | | | svn path=/trunk/; revision=5168
* From Jason Lango: a hack to get SDES length correct on QT packets.Guy Harris2002-04-151-6/+4
| | | | svn path=/trunk/; revision=5167
* From Simharajan Srishylam:Guy Harris2002-04-151-18/+22
| | | | | | | | In capability element, length is for the value (excluding type & len field) not for the whole element. Results in packets not being parsed correctly. svn path=/trunk/; revision=5166
* From Ronnie Sahlberg: dissect_mount_dirpath_call()Uwe Girlich2002-04-151-8/+19
| | | | | | | The sprintf() thingy failed to properly null terminate the string thus causing damage. svn path=/trunk/; revision=5165
* Use "CLEANUP_PUSH()" and "CLEANUP_CALL_AND_POP()" to plug potentialGuy Harris2002-04-151-20/+62
| | | | | | | | | | | | | | memory leaks. Put "Requests", not "X11 request", in the Info column for packets to the server - we already know it's X11, and there may be more than one request in the packet. Put "Replies/events", not "X11 event", in the Info column for packets from the server - we already know it's X11, and there may be more than one message, and the messages might be replies rather than events. svn path=/trunk/; revision=5164
* From Joerg Mayer: get rid of some unused variables and arguments.Guy Harris2002-04-146-155/+107
| | | | | | | Use "tvb_get_ntohs()" to fetch the checksum from a VJ compressed packet, rather than doing the ntoh by hand. svn path=/trunk/; revision=5163
* From Joerg Mayer:Guy Harris2002-04-1421-331/+340
| | | | | | | | | | | | Declares some variables static. Creates a new include file packet-rsvp.h, and make use of it (change some extern decls to #inlcude). Move the file packet-pgm.h into packet-pgm.c as it is not used by anything outside packet-pgm.c. svn path=/trunk/; revision=5162
* From Didier Gautheron: make the "code" field an signed decimal number.Guy Harris2002-04-141-5/+5
| | | | svn path=/trunk/; revision=5161
* M2UA support, from Michael Tuexen.Guy Harris2002-04-144-2/+1392
| | | | svn path=/trunk/; revision=5160
* Get rid of another global variable.Guy Harris2002-04-141-45/+44
| | | | svn path=/trunk/; revision=5159
* Display Boolean bitfields that control whether other fields show up in aGuy Harris2002-04-141-5/+5
| | | | | | | | | message regardless of whether they're set or clear, so you can see not only what flags are set, but also what flags aren't set. (The previous checkin only affected bitfields that don't control whether other fields show up in a message.) svn path=/trunk/; revision=5158
* Display Boolean bitfields regardless of whether they're set or clear, soGuy Harris2002-04-141-5/+8
| | | | | | | you can see not only what flags are set, but also what flags aren't set. Don't show reserved bits unless they're set, though. svn path=/trunk/; revision=5157