For each column, have both a buffer into which strings for that column

can be put, and a pointer to the string for the column, which might or
might not point to that buffer.

Add a routine "col_set_str()", which sets the string for the column to
the string passed to it as an argument; it should only be handed a
static string (a string constant would be ideal).  It doesn't do any
copying, so it's faster than "col_add_str()".

Make the routines that append to columns check whether the pointer to
the string for the column points to the buffer for the column and, if
not, copy the string for the column to the buffer for the column so that
you can append to it (so you can use "col_set_str()" and then use
"col_append_str()" or "col_append_fstr()").

Convert a bunch of "col_add_str()" calls that take a string constant as
an argument to "col_set_str()" calls.

Convert some "col_add_fstr()" calls that take a string constant as the
only argument - i.e., the format string doesn't have any "%" slots into
which to put strings for subsequent arguments to "col_set_str()" calls
(those calls are just like "col_add_str()" calls).

Replace an END_OF_FRAME reference in a tvbuffified dissector with a
"tvb_length(tvb)" call.

svn path=/trunk/; revision=2670

1 files changed, 9 insertions, 9 deletions

diff --git a/packet-rtcp.c b/packet-rtcp.c
index 4774282db4..481ce9304d 100644
--- a/packet-rtcp.c
+++ b/packet-rtcp.c
@@ -633,7 +633,7 @@ dissect_rtcp( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree )
 	pinfo->current_proto = "RTCP";
 
 	if ( check_col( pinfo->fd, COL_PROTOCOL ) )   {
-		col_add_str( pinfo->fd, COL_PROTOCOL, "RTCP" );
+		col_set_str( pinfo->fd, COL_PROTOCOL, "RTCP" );
 	}
 	
 	if ( check_col( pinfo->fd, COL_INFO) ) {
@@ -641,28 +641,28 @@ dissect_rtcp( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree )
 		/* switch ( pd[ offset + 1 ] ) { */
 		switch ( tvb_get_guint8( tvb, 1 ) ) {
 			case RTCP_SR:
-				col_add_str( pinfo->fd, COL_INFO, "Sender Report");
+				col_set_str( pinfo->fd, COL_INFO, "Sender Report");
 				break;
 			case RTCP_RR:
-				col_add_str( pinfo->fd, COL_INFO, "Receiver Report");
+				col_set_str( pinfo->fd, COL_INFO, "Receiver Report");
 				break;
 			case RTCP_SDES:
-				col_add_str( pinfo->fd, COL_INFO, "Source Description");
+				col_set_str( pinfo->fd, COL_INFO, "Source Description");
 				break;
 			case RTCP_BYE:
-				col_add_str( pinfo->fd, COL_INFO, "Goodbye");
+				col_set_str( pinfo->fd, COL_INFO, "Goodbye");
 				break;
 			case RTCP_APP:
-				col_add_str( pinfo->fd, COL_INFO, "Application defined");
+				col_set_str( pinfo->fd, COL_INFO, "Application defined");
 				break;
 			case RTCP_FIR:
-				col_add_str( pinfo->fd, COL_INFO, "Full Intra-frame Request (H.261)");
+				col_set_str( pinfo->fd, COL_INFO, "Full Intra-frame Request (H.261)");
 				break;
 			case RTCP_NACK:
-				col_add_str( pinfo->fd, COL_INFO, "Negative Acknowledgement (H.261)");
+				col_set_str( pinfo->fd, COL_INFO, "Negative Acknowledgement (H.261)");
 				break;
 			default:
-				col_add_str( pinfo->fd, COL_INFO, "Unknown packet type");
+				col_set_str( pinfo->fd, COL_INFO, "Unknown packet type");
 				break;
 		}
 	}