Convert IPX-and-friend dissectors in packet-ipx.c to use

tvbuffs.

In doing so, I realied that my recommendation for using
tvb_new_subset(pi.compat_top_tvb, -1, -1) was incorrect, because
some dissectors (ethernet!) change pi.len and pi.cap_len. So, I have
to take those two variables into account instead of using -1 and -1.

So, I provide a macro called tvb_create_from_top(offset), where
offset is the name of your offset variable. It is a wrapper around
tvb_new_subset().

I converted the lines that followed my suggestion to use
tvb_create_from_top().

In proto.c I added
proto_tree_add_debug_text(proto_tree*, const char*, ...)
It's much like proto_tree_add_text(), except that it takes no offset
or length; it's soley for temporarily putting debug text into the
proto_tree while debugging a dissector. In making sure that its
use is temporary, the funciton also prints the debug string to stdout
to remind the programmer that the debug code needs to be removed
before shipping the code.

svn path=/trunk/; revision=2068

1 files changed, 3 insertions, 4 deletions

diff --git a/packet-cops.c b/packet-cops.c
index 2a4c0811d8..693959d10c 100644
--- a/packet-cops.c
+++ b/packet-cops.c
@@ -4,7 +4,7 @@
  *
  * Copyright 2000, Heikki Vatiainen <hessu@cs.tut.fi>
  *
- * $Id: packet-cops.c,v 1.1 2000/06/07 22:57:45 gram Exp $
+ * $Id: packet-cops.c,v 1.2 2000/06/15 03:48:39 gram Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Gerald Combs <gerald@zing.org>
@@ -154,10 +154,9 @@ static void dissect_cops(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 #else
 static void dissect_cops(const u_char *pd, int o, frame_data *fd, proto_tree *tree)
 {
-        tvbuff_t *tvb;
-        packet_info *pinfo = &pi;
+	packet_info	*pinfo = &pi;
+	tvbuff_t	*tvb = tvb_create_from_top(o);
         guint8 op_code;
-        tvb = tvb_new_subset(pinfo->compat_top_tvb, o, -1, -1);
 #endif
 
         pinfo->current_proto = "COPS";