diff options
author | Laurent Deniel <laurent.deniel@free.fr> | 2000-08-13 14:09:15 +0000 |
---|---|---|
committer | Laurent Deniel <laurent.deniel@free.fr> | 2000-08-13 14:09:15 +0000 |
commit | cc36f0b9312fc36778bf227cbaaf02c89baf09b3 (patch) | |
tree | 0aff9b70a00a628a713030dc9000f3b5492d492b /packet-atalk.c | |
parent | db31ba13c8b9f82c1b96b5444fe3b7e8ff109ce1 (diff) | |
download | wireshark-cc36f0b9312fc36778bf227cbaaf02c89baf09b3.tar.gz wireshark-cc36f0b9312fc36778bf227cbaaf02c89baf09b3.tar.bz2 wireshark-cc36f0b9312fc36778bf227cbaaf02c89baf09b3.zip |
Add the "Edit:Protocols..." feature which currently only implements
the following:
It is now possible to enable/disable a particular protocol decoding
(i.e. the protocol dissector is void or not). When a protocol
is disabled, it is displayed as Data and of course, all linked
sub-protocols are disabled as well.
Disabling a protocol could be interesting:
- in case of buggy dissectors
- in case of wrong heuristics
- for performance reasons
- to decode the data as another protocol (TODO)
Currently (if I am not wrong), all dissectors but NFS can be disabled
(and dissectors that do not register protocols :-)
I do not like the way the RPC sub-dissectors are disabled (in the
sub-dissectors) since this could be done in the RPC dissector itself,
knowing the sub-protocol hfinfo entry (this is why, I've not modified
the NFS one yet).
Two functions are added in proto.c :
gboolean proto_is_protocol_enabled(int n);
void proto_set_decoding(int n, gboolean enabled);
and two MACROs which can be used in dissectors:
OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree)
CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree)
See also the XXX in proto_dlg.c and proto.c around the new functions.
svn path=/trunk/; revision=2267
Diffstat (limited to 'packet-atalk.c')
-rw-r--r-- | packet-atalk.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/packet-atalk.c b/packet-atalk.c index a9f85b3572..9ec3359b07 100644 --- a/packet-atalk.c +++ b/packet-atalk.c @@ -1,7 +1,7 @@ /* packet-atalk.c * Routines for Appletalk packet disassembly (DDP, currently). * - * $Id: packet-atalk.c,v 1.39 2000/08/07 03:20:22 guy Exp $ + * $Id: packet-atalk.c,v 1.40 2000/08/13 14:08:00 deniel Exp $ * * Simon Wilkinson <sxw@dcs.ed.ac.uk> * @@ -196,6 +196,8 @@ dissect_rtmp_data(const u_char *pd, int offset, frame_data *fd, proto_tree *tree guint16 node; /* might be more than 8 bits */ int i; + OLD_CHECK_DISPLAY_AS_DATA(proto_rtmp, pd, offset, fd, tree); + if (!BYTES_ARE_IN_FRAME(offset, 3)) { old_dissect_data(pd, offset, fd, tree); return; @@ -292,6 +294,8 @@ dissect_nbp(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) { guint op, count; int i; + OLD_CHECK_DISPLAY_AS_DATA(proto_nbp, pd, offset, fd, tree); + if (!BYTES_ARE_IN_FRAME(offset, 2)) { old_dissect_data(pd, offset, fd, tree); return; @@ -370,6 +374,8 @@ dissect_ddp(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) { proto_item *ti; static struct atalk_ddp_addr src, dst; + OLD_CHECK_DISPLAY_AS_DATA(proto_ddp, pd, offset, fd, tree); + if (!BYTES_ARE_IN_FRAME(offset, DDP_HEADER_SIZE)) { old_dissect_data(pd, offset, fd, tree); return; |