diff options
| author | João Valverde <joao.valverde@tecnico.ulisboa.pt> | 2015-11-27 02:28:17 +0000 |
|---|---|---|
| committer | João Valverde <j@v6e.pt> | 2016-01-28 18:13:48 +0000 |
| commit | 265a41e14da6b3ebf1e49e726eee62d1372110bf (patch) | |
| tree | f1a524f8e66ebd43691de84649f231f32ee125f6 /codecs | |
| parent | 97a1a50e200a6c50e0014dde7e8ec932c30190a1 (diff) | |
| download | wireshark-265a41e14da6b3ebf1e49e726eee62d1372110bf.tar.gz wireshark-265a41e14da6b3ebf1e49e726eee62d1372110bf.tar.bz2 wireshark-265a41e14da6b3ebf1e49e726eee62d1372110bf.zip | |
autotools: Don't use "user variables" to set build flags
GNU coding standards recommend against it and automake is designed
around it.
This allows overriding the global build flags using AM_CFLAGS, etc.,
or per object flags, something that is difficult or impossible currently
because of automake precedence rules.
Change-Id: I3f1ea12e560af5a46b2f04b342b1882bbf123f12
Reviewed-on: https://code.wireshark.org/review/13455
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
Diffstat (limited to 'codecs')
| -rw-r--r-- | codecs/Makefile.am | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/codecs/Makefile.am b/codecs/Makefile.am index d55b259644..d75f246f2b 100644 --- a/codecs/Makefile.am +++ b/codecs/Makefile.am @@ -20,13 +20,9 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. include Makefile.common -include ../Makefile.am.inc +include $(top_srcdir)/Makefile.am.inc -AM_CFLAGS =-DWS_BUILD_DLL - -if HAVE_WARNINGS_AS_ERRORS -AM_CFLAGS += -Werror -endif +AM_CPPFLAGS += -I$(top_srcdir)/wiretap -DWS_BUILD_DLL CLEANFILES = \ libwscodec.la \ @@ -48,9 +44,6 @@ libwscodecs_la_DEPENDENCIES = ${top_builddir}/wsutil/libwsutil.la libwscodecs_la_LIBADD = ${top_builddir}/wsutil/libwsutil.la -# Common headers -AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/wiretap - checkapi: $(PERL) $(top_srcdir)/tools/checkAPIs.pl -g abort -g termoutput -build \ -sourcedir=$(srcdir) \ |