diff options
| author | Michael Mann <mmann78@netscape.net> | 2014-08-08 09:19:29 -0400 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2014-08-09 01:57:08 +0000 |
| commit | cd02af56a1e39c66b44fd7957aff3b7b77a59e9d (patch) | |
| tree | 4a3e859751bb73268115a607e9dffcec008bb411 /asn1/ros/packet-ros-template.c | |
| parent | bb15274a4a82fcab1c06935fa1e249f436420a02 (diff) | |
| download | wireshark-cd02af56a1e39c66b44fd7957aff3b7b77a59e9d.tar.gz wireshark-cd02af56a1e39c66b44fd7957aff3b7b77a59e9d.tar.bz2 wireshark-cd02af56a1e39c66b44fd7957aff3b7b77a59e9d.zip | |
Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions.
Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree.
Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141
Reviewed-on: https://code.wireshark.org/review/3500
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'asn1/ros/packet-ros-template.c')
| -rw-r--r-- | asn1/ros/packet-ros-template.c | 19 |
1 files changed, 18 insertions, 1 deletions
diff --git a/asn1/ros/packet-ros-template.c b/asn1/ros/packet-ros-template.c index 849b4346f9..cdfa73e3cb 100644 --- a/asn1/ros/packet-ros-template.c +++ b/asn1/ros/packet-ros-template.c @@ -75,6 +75,15 @@ static int hf_ros_time = -1; /* Initialize the subtree pointers */ static gint ett_ros = -1; +static gint ett_ros_unknown = -1; +static gint ett_ros_invoke_argument = -1; +static gint ett_ros_return_result = -1; +static gint ett_ros_bind_invoke = -1; +static gint ett_ros_bind_result = -1; +static gint ett_ros_bind_error = -1; +static gint ett_ros_unbind_invoke = -1; +static gint ett_ros_unbind_result = -1; +static gint ett_ros_unbind_error = -1; #include "packet-ros-ett.c" static expert_field ei_ros_dissector_oid_not_implemented = EI_INIT; @@ -84,7 +93,6 @@ static dissector_table_t ros_oid_dissector_table=NULL; static GHashTable *oid_table=NULL; static GHashTable *protocol_table=NULL; -static gint ett_ros_unknown = -1; void register_ros_oid_dissector_handle(const char *oid, dissector_handle_t dissector, int proto _U_, const char *name, gboolean uses_rtse) @@ -483,6 +491,15 @@ void proto_register_ros(void) { static gint *ett[] = { &ett_ros, &ett_ros_unknown, + &ett_ros_invoke_argument, + &ett_ros_return_result, + &ett_ros_bind_invoke, + &ett_ros_bind_result, + &ett_ros_bind_error, + &ett_ros_unbind_invoke, + &ett_ros_unbind_result, + &ett_ros_unbind_error, + #include "packet-ros-ettarr.c" }; |