diff options
author | Gerald Combs <gerald@wireshark.org> | 2004-05-14 03:03:47 +0000 |
---|---|---|
committer | Gerald Combs <gerald@wireshark.org> | 2004-05-14 03:03:47 +0000 |
commit | 4e5714b8f2ee94daea32c37b0d1ef58bbe8fccb9 (patch) | |
tree | 8d40f0840d4fa98484eaa4237cb2d56888bbffbb /ChangeLog | |
parent | ee7618dc6ee2c0c502d00fc50281f26e2b826426 (diff) | |
download | wireshark-4e5714b8f2ee94daea32c37b0d1ef58bbe8fccb9.tar.gz wireshark-4e5714b8f2ee94daea32c37b0d1ef58bbe8fccb9.tar.bz2 wireshark-4e5714b8f2ee94daea32c37b0d1ef58bbe8fccb9.zip |
Final commits for 0.10.4 (I hope).
svn path=/trunk/; revision=10885
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 3783 |
1 files changed, 2321 insertions, 1462 deletions
@@ -1,2432 +1,3291 @@ -2004-03-26 04:01 gerald +2004-05-14 02:46 gerald - * plugins/rudp/packet-rudp.c: + * packaging/nsis/ethereal.nsi: - Call plugin_address_table_init() before - proto_register_protocol(). + Make the GTK2 interface the default. Remove GTK-Wimp from the + GTK2 section. I originally tried to make it disabled by default + (using "Section /o"), but this caused odd behavior in the + installer. -2004-03-26 02:10 guy +2004-05-14 01:58 sahlberg - * Makefile.common: + * packet-kerberos.c: - Include packet-sip.h in the release. + add dissection of pa-prov-srv-location preauthentication type + used by packetcable. -2004-03-26 01:55 gerald +2004-05-13 22:25 jmayer - * packet-sip.h: + * configure.in: - Add packet-sip.h + Paul Smith: bugfix: make loadable module support work when cross + compiling -2004-03-26 01:39 gerald +2004-05-13 22:09 jmayer - * ChangeLog, NEWS: + * acinclude.m4: - Final changes for the 0.10.3 (codename: "Ides of March") release. + Fix --with-krb5 when given a directory -2004-03-26 00:28 guy +2004-05-13 21:56 gerald - * AUTHORS, packet-sip.c, gtk/Makefile.common, gtk/sip_stat.c: + * packet-scsi.c: - From Martin Mathieson: SIP statistics tap. + From Dinesh Dutt: Mode Sense (10) and Mode Select (10) bugfixes. -2004-03-26 00:21 guy +2004-05-13 21:56 jmayer - * packet-ber.c, packet-ber.h, packet-kerberos.c: + * configure.in: - Fix a typo. + Thomas Anders: fix usage of brk5_dir - Clean up white space. +2004-05-13 20:54 obiot -2004-03-26 00:01 guy + * Makefile.nmake, packaging/nsis/Makefile.nmake: - * plugins/: Xass-list, Xplugin_api.c, Xplugin_api.h, - Xplugin_api_decls.h, Xplugin_table.h: + Fix a typo (seperate should be separate). - Update for Tomas Kukosa's new APIs to get the parent and the - nth-grandparent-up for a protocol tree item and to get the last - item created by the BER dissector (that API and the new names for - the universal tags were supplied by him - the checkin item didn't - give him credit). +2004-05-13 20:45 obiot -2004-03-26 00:00 guy + * NEWS: - * packet-kerberos.c: + WBXML OPAQUE is not really a protocol. - From Tomas Kukosa: use the "proto_item_get_parent()" and - "proto_item_get_parent_nth()" routines, and use the new name for - some of the constants for universal tags. + Add RTCP to updated protocols. -2004-03-25 23:59 guy +2004-05-13 20:20 gerald - * packet-q931.c: + * AUTHORS, Makefile.common, NEWS, packet-ldp.c, packet-ldp.h, + packet-mpls-echo.c, packet-ntp.c, packet-ntp.h, + epan/Makefile.common: - From Tomas Kukosa: put the number string for a number IE into the - top-level item for the IE tree. + From Carlos Pignataro: Add MPLS Echo support. -2004-03-25 23:58 guy +2004-05-13 20:02 gerald - * packet-per.c: + * NEWS: - From Tomas Kukosa: don't allow the PER protocol to be disabled. + Add a note about generic media dissection, and add WBXML updates. -2004-03-25 23:57 guy +2004-05-13 17:26 obiot - * packet-ber.c, packet-ber.h: + * packet-wbxml.c: - Add constants and names for all universal tags. + Fix a typo in the CHANNEL document ID. - Add "get_ber_last_created_item()" to get the last created item - - you can't access the global variable from a plugin. +2004-05-13 17:24 obiot -2004-03-25 23:55 guy + * packet-rtcp.c: - * epan/proto.c, epan/proto.h, plugins/plugin_api_list.c: + As noted by Frédéric Huet, RFC1889 section 6.4 says: "The list of + items in each chunk is terminated by one or more null octets, the + first of which is interpreted as an item type of zero to denote + the end of the list, and the remainder as needed to pad until the + next 32-bit boundary. - From Tomas Kukosa: add APIs to get the parent of a protocol tree - item and the item N levels up from a protocol tree item. + A chunk with zero items (four null octets) is valid but useless." -2004-03-25 23:25 tuexen + Process chunks with four zero octets as "padding". - * packet-m3ua.c: +2004-05-13 16:57 jmayer - Fix tags for 07 version. + * acinclude.m4: -2004-03-25 23:11 guy + Thomas Anders: Don't add library paths twice - * plugins/: ciscosm/.cvsignore, rlm/.cvsignore, rudp/.cvsignore: +2004-05-13 16:34 jmayer - Add .cvsignore files to the new plugins. + * prefs.h: -2004-03-25 23:09 guy + Remove comma at end of enum - * plugins/: ciscosm/packet-sm.c, rlm/packet-rlm.c, - rudp/packet-rudp.c: +2004-05-13 15:28 ulfl - Squelch compiler warnings, and remove some trailing blanks from - lines. + * prefs.c, prefs.h, gtk/gui_prefs.c, gtk/main.c, gtk/main.h: -2004-03-25 19:11 guy + Win32 only: Preference setting to open a console window, one of: + never (default), automatic (like before), always - * plugins/: ciscosm/AUTHORS, ciscosm/COPYING, ciscosm/ChangeLog, - ciscosm/INSTALL, ciscosm/NEWS, rlm/AUTHORS, rlm/COPYING, - rlm/ChangeLog, rlm/INSTALL, rlm/NEWS, rudp/AUTHORS, rudp/COPYING, - rudp/ChangeLog, rudp/INSTALL, rudp/NEWS: +2004-05-13 13:49 sahlberg - Add the usual extra files to the new plugins. + * packet-isns.c: -2004-03-25 16:01 ulfl + dissect the authentication-block flag bit - * doc/README.developer: +2004-05-13 13:39 sahlberg - added hint to use g_snprintf instead of snprintf and sprintf + * packet-isns.c: -2004-03-25 11:21 guy + isns standard is unclear here but some servers do respond with a + 0 length PGT in DevAttrRegRsp if the DevAttrReg contained it. - * AUTHORS, Makefile.am, configure.in, doc/ethereal.pod, - packaging/nsis/Makefile.nmake, packaging/nsis/ethereal.nsi, - plugins/Makefile.am, plugins/Makefile.nmake, - plugins/ciscosm/Makefile.am, plugins/ciscosm/Makefile.nmake, - plugins/ciscosm/moduleinfo.h, plugins/ciscosm/packet-sm.c, - plugins/rlm/Makefile.am, plugins/rlm/Makefile.nmake, - plugins/rlm/moduleinfo.h, plugins/rlm/packet-rlm.c, - plugins/rudp/Makefile.am, plugins/rudp/Makefile.nmake, - plugins/rudp/moduleinfo.h, plugins/rudp/packet-rudp.c: - - From Duncan Sargeant: Cisco SS7 RUDP, RLM, and Session Management - support. - -2004-03-25 09:17 guy - - * packet-ber.c, packet-ber.h, packet-kerberos.c, epan/proto.c, - epan/proto.h, plugins/plugin_api_list.c, plugins/Xass-list, - plugins/Xplugin_api.c, plugins/Xplugin_api.h, - plugins/Xplugin_api_decls.h, plugins/Xplugin_table.h: + Allow DevAttrRegRsp to contain 0 length PGTs. - From Tomas Kukosa: BER dissector enhancements and proto.c updates - to support them. +2004-05-13 13:28 sahlberg - From Ronnie Sahlberg: Kerberos updates with new constants from - the current draft, decryption and dissection of Kerberos blobs, - and changes to work with the changed BER dissector. + * packet-isns.c: -2004-03-25 08:01 guy + update to isns: make it handle PGT with length 0 properly only + try to dissect the attributes if this is the first PDU in a + sequence. - * packet-dcerpc-rs_prop_plcy.c: +2004-05-13 12:19 ulfl - DCE RPC version numbers supplied to the registration routines are - just major version numbers. + * gtk/http_stat.c: -2004-03-25 06:39 ulfl + fixed httpstat_reset, so reloading a capture file won't increase + statistic values more and more - * packet-dcerpc-rs_prop_plcy.c: +2004-05-13 10:10 ulfl - MSVC warning removed + * epan/: Makefile.nmake, doxygen.cfg: -2004-03-25 04:44 guy + use sed to create a temporary doxygen config file, to get the + version number from ..\config.nmake - * packet-mq.c: +2004-05-13 09:04 ulfl - MQ dissector update from metatech. + * NEWS: -2004-03-24 21:27 obiot + we now have export dialogs, and we can change the main windows + layout - * epan/Makefile.am, epan/dfilter/Makefile.am, - epan/ftypes/Makefile.am, wiretap/Makefile.am: +2004-05-13 03:34 gerald - Fix the CLEANFILES target so both static and shared libraries are - cleaned. + * NEWS, config.nmake, configure.in, epan/doxygen.cfg: -2004-03-24 06:36 ulfl + Bump the version up to 0.10.4. Preliminary updates to the NEWS + file. Updates welcome. - * packet-aim-chatnav.c, packet-aim-invitation.c, packet-aim-oft.c, - packet-aim-popup.c, packet-aim-stats.c, packet-aim-translate.c: +2004-05-12 20:20 guy - commented out unused aim_handle's + * packet-mpls.c: -2004-03-24 04:26 guy + From Carlos M. Pignataro: MPLS PW Control Channel Header support. - * packet-rsvp.c: +2004-05-12 19:55 guy - Use "tvb_format_text()" to display a string, so that - non-printable characters are handled reasonably. + * packet-bacnet.c: -2004-03-24 00:39 obiot + Make the calls to build the protocol tree regardless of whether + we're building one or not - we have to do some of that work + anyway, so we know the offset of the payload and so that we call + sub-dissectors, and the easiest way to do that is to do all the + work (you make more procedure calls that way than you'd like, but + the procedures at least return quickly when they find they've + been passed a null pointer; hopefully that won't add too much CPU + time to dissection of BACNET traces on the first pass). - * AUTHORS: + Don't use "proto_tree_add_uint_format()" in a case where it's not + necessary - and fix the field being used not to have a bitmask, + as it's not a bitfield. - Update address. +2004-05-12 19:23 guy -2004-03-24 00:38 obiot + * packet-time.c: - * doc/ethereal-filter.pod.template: + From Thomas Anders: display the time in time protocol packets as + a date and time rather than as a raw + seconds-since-1900-01-01-00:00:00 GMT. - Add a description for the bitwise_and (&) operator. + Put it into the protocol tree as a named field (the named field + was there but wasn't being used). -2004-03-23 21:19 guy + Give the RFC number for the protocol in a comment. - * Makefile.common, alert_box.c, alert_box.h, dftest.c, - packet-diameter.c, report_err.h, tethereal.c, epan/Makefile.am, - epan/epan.c, epan/epan.h, epan/report_err.h, gtk/main.c, - plugins/plugin_api.h, plugins/plugin_api_list.c, - plugins/asn1/packet-asn1.c: +2004-05-12 09:40 guy - Make "epan_init()" take, as additional arguments, pointers to - routines that dissectors should call to report file open and read - errors, and have "report_open_failure()" and - "report_read_failure()" call through those pointers, rather than - being defined and exported by the application using libethereal - - instead, the application would define those functions and pass - pointers to them to 'epan_init()". + * packet-ptp.c: - Move "report_err.h" to the epan directory, as the functions it - declares are now part of the libethereal API. + You can hand a string to "col_add_str()" as an argument - or to + "col_set_str()", for that matter. -2004-03-23 19:51 guy + Eliminate a compiler warning by initializing a variable. - * AUTHORS, Makefile.common, packet-ftam.c, packet-ftam.h, - epan/Makefile.common: + Don't use "match_strval()" on values you don't know for certain + are in the value_string table - use "val_to_str()", so that you + don't get a null pointer if the value isn't in that table. + ("Know for certain" meaning "the code has made sure it's a value + that's in the table", not "the protocol spec says the field must + have one of the values in the table".) - From Yuri Sidelnikov: FTAM support. +2004-05-12 09:29 guy -2004-03-23 19:37 guy + * packet-3g-a11.c: - * packet-pres.c, packet-pres.h: + From Ryuji Somegawa: fix some typos. - From Yuriy Sidelnikov: call ACSI dissector for data blocks. +2004-05-12 03:37 gerald -2004-03-23 19:31 guy + * AUTHORS, packet-ptp.c, doc/ethereal.pod, epan/Makefile.common: - * packet-3g-a11.c: + From Dominic Béchaz: IEEE 1588 (Precision Time Protocol) support. - From Ryuji Somegawa: fix some decode problems. +2004-05-11 22:07 jmayer -2004-03-23 19:25 guy + * manuf, FAQ, help/faq.txt: - * AUTHORS, packet-ieee80211.c: + Update manuf and FAQ to current master files - From Jouni Malinen: handle 802.11i RSN IE, and add new status and - result codes for 802.11i. +2004-05-11 14:21 nneul -2004-03-23 18:59 tuexen + * packet-afs-defs.h, packet-afs-macros.h, + packet-afs-register-info.h, packet-afs.c, packet-afs.h: - * packet-m2pa.c: + add initial support for newer opcodes - - Updated reference to ID version 11. - Added type of status - message to Info column. +2004-05-11 11:27 guy -2004-03-23 18:44 guy + * packet-mq.c: - * packet-dcerpc-samr.c: + From metatech: - Reassembly of MQ messages spanning several PDU - + RESET message - From Ronnie Sahlberg: small fix to prevent dereferencing null - pointers. +2004-05-11 11:20 guy -2004-03-23 18:36 guy + * packet-ldp.c: - * packet-aim-adverts.c, packet-aim-chat.c, packet-aim-chatnav.c, - packet-aim-directory.c, packet-aim-icq.c, - packet-aim-invitation.c, packet-aim-messaging.c, - packet-aim-oft.c, packet-aim-popup.c, packet-aim-stats.c, - packet-aim-translate.c, packet-aim-userlookup.c: + From Carlos M. Pignataro: interface parameter and VC type updates + from the following internet drafts: o PWE updates: - + draft-ietf-pwe3-control-protocol-06.txt - + draft-ietf-pwe3-sonet-05.txt - + draft-ietf-pwe3-fragmentation-05.txt - + draft-ietf-pwe3-fcs-retention-00.txt - + draft-vainshtein-pwe3-tdm-control-protocol-extensi-00.txt - + draft-ietf-pwe3-vccv-02.txt - + draft-ietf-pwe3-iana-allocation-04.txt - Zero-length arrays are *not* valid in C89, even if GCC doesn't - happen to have a problem with them; MSVC++, for example, doesn't - handle them, so we comment them out. +2004-05-11 11:19 guy -2004-03-23 18:33 tuexen + * epan/Makefile.am: - * README.macos: + From Lars Roland: add the libethereal .def file to the list of + files included in the distribution. - pcap-stdinc.h is not needed on a Mac OS X system. +2004-05-11 11:04 guy -2004-03-23 18:06 guy + * epan/.cvsignore: - * packet-cdp.c, epan/tvbuff.c, epan/tvbuff.h: + From Lars Roland: ignore the libethereal DLL and export file in + CVS. - Use "tvb_format_text()" to display strings, so we handle - non-printable characters. +2004-05-11 10:57 guy - Some strings appear to be null-padded; add a - "tvb_format_stringzpad()" routine to handle them, so that we - don't show the padding characters as "\000". + * packet-ber.c: -2004-03-23 18:04 tuexen + Add a colon to the top-level item for a sequence or set, to + separate the name for the sequence or set from any summary items + added as the members of the sequence or set are dissected. - * packet-sctp.c: +2004-05-11 10:55 guy - Add tap functionality. + * packet-rtsp.c: -2004-03-23 18:03 guy + A line is an RTSP request merely because it begins with a string + that's an RTSP request name - either the line has to end after + the request name or there has to be a whitespace character after + the request name. - * packet-x11.c: +2004-05-11 07:30 guy - Handle the case where the keycodemap entry for one of the - keycodes processed in the first loop in "keycode2keysymString()" - is null. I don't know whether the right thing to do is to give - up (as we're doing now) or to not check that map. + * packet-kerberos.c: - In that routine, we set "syms" to "keycodemap[keycode]", and give - up if it's null; use "syms" in that routine instead of - "keycodemap[keycode]", so we know that those places don't have to - worry about "keycodemap[keycode]" being null. + Kerberos encryption types are ASN.1 integers, meaning signed + values, and at least one mail message: - Fix up indentation. -2004-03-23 18:02 tuexen + http://mailman.mit.edu/pipermail/kerberos/2004-February/004653.html - * Makefile.common: + shows some of the weird Microsoft encryption type values logged + by some KDC implementation as negative integers. Also, show them + as decimal in the top-level line for encryption types, just as we + do in the lines for each encryption type. - Add packet-sctp.h +2004-05-11 07:26 guy -2004-03-23 17:27 tuexen + * packet-ber.c: - * packet-sctp.h: + In the top-level summary item for a bitstring, show the names of + the bits as a parenthesized, comma-separated lists - using only + blanks as separators doesn't work well if the names themselves + have blanks in them, as some of them do. - Include file for packet-sctp.c and tap listeners. + Note that "dissect_ber_integer()" won't work well if the length + of the item isn't appropriate for the field, e.g. a length > 4 + for an FT_INTn or FT_UINTn field. -2004-03-23 15:39 tuexen +2004-05-11 02:02 gerald - * packet-m3ua.c: + * packet-spnego.c: - Added support for version 07 of the ID. + Make sure next_level_value isn't NULL before trying to access one + of its members. -2004-03-23 07:57 guy +2004-05-11 01:05 ulfl - * gtk/menu.c: + * config.nmake: - From Tomas Kukosa: don't change the state of the "Expand Tree" - menu items if we're changing whether there's a packet currently - selected. + add "configurable" path to doxygen.exe -2004-03-23 07:40 guy +2004-05-11 01:00 ulfl - * x11-fields: + * epan/Makefile.am: - "keys" is a LISTofCARD8, so it should have type BYTES, not UINT8. + add the new doxygen.cfg file to the EXTRA_DIST files -2004-03-23 07:39 guy +2004-05-11 00:56 ulfl - * packet-aim.c: + * epan/doxygen.cfg: - Get rid of a no-longer-used argument. + experimental doxygen support -2004-03-23 07:23 guy +2004-05-11 00:53 ulfl - * packet-aim.c: + * epan/Makefile.nmake: - The dissectors for particular AIM families aren't for real - protocols, and they don't create their own subtrees; hand them - the pointer to the AIM subtree, rather than the top-level tree, - so they'll put the protocol tree items in the AIM subtree. + adding a doxygen target -2004-03-23 06:48 guy +2004-05-10 23:13 ulfl - * capture.c: + * epan/proto.h: - Include "packet-ap1394.h" to declare "capture_ap1394()". + prepared for generate documentation using doxygen, added lot's of + new (hopefully correct) comments -2004-03-23 06:21 guy +2004-05-10 22:20 obiot - * AUTHORS, Makefile.common, packet-aim-admin.c, - packet-aim-adverts.c, packet-aim-bos.c, packet-aim-buddylist.c, - packet-aim-chat.c, packet-aim-chatnav.c, packet-aim-directory.c, - packet-aim-generic.c, packet-aim-icq.c, packet-aim-invitation.c, - packet-aim-location.c, packet-aim-messaging.c, packet-aim-oft.c, - packet-aim-popup.c, packet-aim-signon.c, packet-aim-ssi.c, - packet-aim-stats.c, packet-aim-translate.c, - packet-aim-userlookup.c, packet-aim.c, packet-aim.h, - doc/ethereal.pod, epan/Makefile.common: + * packet-http.c, util.c, util.h: - From Jelmer Vernooij: split the AIM dissector into multiple - files, and add a few more SNACs. + As noted by Thomas Anders, the Heimdal libroken library has a + base64_decode() function with a different signature than the one + defined in util.c/util.h. For this reason, we need to rename our + base64_decode() routine. -2004-03-23 03:19 guy + The routine is now called epan_base64_decode(). - * README.macos: +2004-05-10 22:14 obiot - Note that you need X11 and the X11 developer headers and - libraries installed in order to build Ethereal. + * epan/tvbuff.c: - Michael Tuexen indicated how to successfully build GTK+ 2.4 on - Mac OS X (10.3[.x], at least) - update the directions to give the - latest versions of GLib/Pango/GTK+/ATK and to give instructions - on how to make them build. + From Jerry Talkington: speed up tvb_uncompress() by increasing + the minimal and default uncompression buffer. -2004-03-23 01:58 guy +2004-05-10 14:02 ulfl - * packet-ipv6.c: + * epan/proto.h: - The "len" argument to capture routines should not be decremented - as you move through the packet - it's the total length of - captured data. + use GNUC_FORMAT_CHECK in every appropriate function -2004-03-23 01:29 guy +2004-05-10 08:29 ulfl - * packet-ucp.c: + * epan/proto.h: - If we don't find a trailing / in a parameter, throw the - appropriate exception (that's what the old code that did its own - scan did). + first try to get rid of annoying double definition of the + proto_tree_add_xy_fromat functions, because of GNUC printf format + checks -2004-03-23 01:02 guy +2004-05-10 03:30 gerald - * Makefile.common, capture.c, packet-ap1394.c, packet-ap1394.h, - epan/Makefile.common, epan/packet_info.h, epan/to_str.c, - wiretap/libpcap.c, wiretap/wtap.c, wiretap/wtap.h: + * Makefile.common: - Add support for DLT_APPLE_IP_OVER_IEEE_1394. + Add ps.c to BUILT_SOURCES, so that "make distcheck" doesn't burst + into flames. -2004-03-23 00:17 guy +2004-05-09 18:54 guy - * wiretap/eyesdn.c: + * epan/: Makefile.nmake, libethereal.def: - Clean up the code to check the file type. + From Lars Roland: fix some MSVC build problems. -2004-03-22 23:50 guy +2004-05-09 10:03 guy - * README.macos: + * AUTHORS, Makefile.am, Makefile.common, Makefile.nmake, + alert_box.c, capture.c, config.h.win32, config.nmake, + configure.in, file.c, follow.h, packet-ansi_a.h, + packet-ansi_map.h, packet-dcerpc.h, packet-fc.h, packet-gsm_a.h, + packet-gsm_map.h, packet-h225.h, packet-isup.h, packet-mtp3.h, + packet-rpc.h, packet-smb-sidsnooping.h, packet-wsp.h, + prefs-int.h, prefs.h, print.h, smb.h, tap-ansi_astat.c, + tap-gsm_astat.c, tap-h225counter.c, tap-rpcstat.c, tap-smbsids.c, + tap-smbstat.c, tap-wspstat.c, tap.h, tethereal.c, + doc/Makefile.nmake, epan/Makefile.common, epan/Makefile.nmake, + epan/libethereal.def, epan/plugins.h, epan/proto.h, + epan/resolv.h, epan/dfilter/dfilter.h, epan/ftypes/ftypes.h, + gtk/Makefile.nmake, gtk/follow_dlg.c, + packaging/nsis/Makefile.nmake, packaging/nsis/ethereal.nsi, + plugins/mgcp/Makefile.nmake, plugins/mgcp/packet-mgcp.c: - To build with GLib 2.x/GTK+ 2.x, you need to configure with - --enable-gtk2 regardless of whether you have GLib 1.2[.x]/GTK+ - 1.2[.x] installed or not. + From Lars Roland: add support for building a libethereal.dll with + MSVC: -2004-03-22 23:40 guy + add a config.nmake option to control whether to build + libethereal.dll or not; - * README.macos: + remove "./wiretap" from PATH to prevent problems due to + wrongly-loaded files; - Note that GTK+ 2.4 doesn't work, and indicate why. + build dissector.lib with MSVC; - Enumerate the dependencies for GLib 2.4/GTK+ 2.4, and indicate - that GNU gettext is also required, even though it's not in the - set of dependencies on the GTK+ site (after all, the ENTIRE WORLD - runs Linux, RIGHT?). + move "print.c" and "ps.c" to the dissector helpers, as + "print.c" + imports variables from packet-frame.c and packet-data.c, + which + are in libethereal; - Give a (partial) order for the dependencies. + move "g711.c" out of the dissector helpers, as they're + used only + by Ethereal in a tap, not in Tethereal or in any + dissector; - Note some issues with building and installing the JPEG and libpng - libraries. + add a .def file for libethereal; -2004-03-22 22:53 deniel + arrange to declare global variables exported from + libethereal + with "__declspec(dllimport)" when building programs that + import + those variables; - * AUTHORS, packet-x11.c, x11-fields: + update the NSIS installer. - * X11 dissector: + Make the "configure" script define ETH_VAR_IMPORT as "extern". - - in decoding of replies: 0 is not an unknown opcode, it means - that the request was unseen or that the opcode of the request - is unknown (e.g. due to unseen / undecoded QueryExtension - replies) +2004-05-09 09:26 ulfl - - add special processing for QueryExtension requests & replies in - order to store new opcodes in a value_string of opcodes saved - per conversation + * epan/proto.h: - - try to resynchronize sequence number once at first reply if no - initial connection request was seen + added changed some comments to better reflect current "behaviour" - - add decoding of SendEvent request +2004-05-09 09:07 obiot - - add decoding of many replies (AllocColor, GetInputFocus, - GetGeometry, GetPointerControl, GetScreenSaver, - GetSelectionOwner, GrabKeyboard, GrabPointer, InternAtom, - ListProperties, LookupColor, QueryBestSize, QueryKeymap, - QueryPointer, TranslateCoordinates) + * packet-http.c: - - fix decoding of EnterNotify / LeaveNotify events + Move the creation of the de-chunked data source to the place + where the data is being dechunked; this will highlight the + correct bytes when selecting the compressed data from the + protocol tree. - - add decoding of most events (FocusIn, FocusOut, Expose, - GraphicsExpose, NoExpose, VisibilityNotify, CreateNotify, - DestroyNotify, UnmapNotify, MapNotify, MapRequest, - ReparentNotify, ConfigureNotify, GravityNotify, ResizeRequest, - CirculateNotify, CirculateRequest, PropertyNotify, - SelectionClear, SelectionRequest, SelectionNotify, - ColormapNotify, ClientMessage) + Add comments for explaining what happens where. - - miscellaneous changes & code cleaning + Strip trailing white space. -2004-03-22 22:37 gerald +2004-05-09 08:29 guy - * packaging/nsis/ethereal.nsi: + * epan/ftypes/ftypes.c: + + From Graeme Hewson: + + Fix off-by-one errors in slice_func + +2004-05-09 08:25 guy + + * epan/ftypes/ftype-string.c: + + From Graeme Hewson: + + "aim.fnac.ssi.buddyname==ab" caused segmentation fault. Fix + handling of unparsed value as byte string. + +2004-05-09 08:17 guy + + * epan/dfilter/semcheck.c: + + From Graeme Hewson: + + Error if protocol specified on RHS of display filter + comparison. + If user specified "fc", they probably intended a byte value + rather than + the fibre channel protocol; fix makes mistake clear. + + Fix assertion failure with range on LHS of display filter + comparison + and field on RHS. - !ifdef-ize out a GTKWimp text section. +2004-05-09 07:01 ulfl -2004-03-22 21:29 gerald + * gtk/: menu.c, proto_draw.c: + + make notebook tabs scrollable, if not all fits into the pane, + enable a popup menu on the notebook tabs, with the tab labels + +2004-05-08 22:03 guy + + * epan/dfilter/scanner.l: + + From Graeme Hewson: get rid of unnecessary check (it's necessary + for octal, as the maximum of 3 octal digits can be more than + 0377, but not necessary for hex, as the maximum of 2 hex digits + can't be more than 0xff). + +2004-05-08 21:43 gerald * epan/Makefile.am: - Add Makefile.common to the distribution. + Don't try to include epan/config.h.win32 in the distribution. -2004-03-22 20:35 gerald +2004-05-08 21:31 obiot - * Makefile.nmake, epan/Makefile.nmake: + * packet-dcm.c: - From Lars Roland: Fix a couple of MSVC build problems. + From Richard Coe: only create a conversation on the first packet + of a DICOM conversation. -2004-03-22 20:16 guy +2004-05-08 17:54 tuexen - * packet-h225.c: + * packet-sctp.c: - From Tomas Kukosa: supportedTunnelledProtocols in EndpointType is - a SEQUENCE OF TunnelledProtocol, not just a TunnelledProtocol. + Fixed problems of handling PkTDRP chunks. -2004-03-22 20:01 guy +2004-05-08 13:39 obiot - * packet-diameter-defs.h: + * packet-dcm.c: - Make the strings in the NAS-Port-Type AVP match the text in - http://www.ietf.org/internet-drafts/draft-ietf-aaa-diameter-nasreq-14.txt. + The DICOM dissector assumed that any existing conversation was a + DICOM conversation. Fix this by checking whether there is + conversation data for the DICOM dissector. If not, the + conversatioj is not a DICOM conversation, and we do not attempt + at dissecting it as DICOM. -2004-03-22 17:03 gerald +2004-05-08 12:59 obiot - * config.nmake, configure.in, epan/configure.in: + * packet-http.c: - Bump the version up to 0.10.3. + D'oh - remove leading '+' marks from manually applying a patch. -2004-03-22 16:19 gerald +2004-05-08 12:54 obiot - * Makefile.am: + * packet-http.c: - Back out previous accidentally-committed change. + From Jerry Talkington: -2004-03-22 16:05 gerald + * Add comments on why we may not use tvb_free() at some places. - * Makefile.am, packet-isup.c, packet-radius.c: + * Add a new data source for a reassembled chunked entity. - Handle null RADIUS attribute information without crashing. Found - by Jonathan Heusser. +2004-05-08 11:40 obiot -2004-03-22 01:18 guy + * epan/dfilter/README.dfilter: - * packet-cdp.c: + Add the valuable input from Gilbert Ramirez in reply to questions + I had when thinking at implemeting an "in" display filter + operation. - Fix a typo. +2004-05-08 10:28 obiot -2004-03-21 23:46 guy + * packet-http.c: - * packet-3g-a11.c: + Fix a tvb_free() of a tvbuffer created as a tvb_new_subset(), + which caused double freeing of memory. Add a comment at the + tvb_new_subset() call so future developers will be warned. - The CDMA2000 A11 dissector doesn't put anything into the protocol - tree for a packet with an unknown type, so we make it just reject - those packets so other dissectors can claim them. + Always add the compressed entity as an item in the protocol tree, + so it can be exported by selecting the packet bytes. -2004-03-21 23:19 guy +2004-05-08 08:49 guy - * packet-diameter.c: + * AUTHORS, packet-dcm.c, doc/ethereal.pod, epan/Makefile.common: - Clean up white space. + From Rich Coe: DICOM support. - Just use "proto_tree_add_item()" to put the session ID into the - protocol string. +2004-05-07 18:15 obiot -2004-03-21 23:10 guy + * epan/tvbuff.c: - * packet-diameter.c: + Memory management of tvb_uncompress() needs tvb_set_free_cb(). - From Anders Broman: fix the value strings for decoding of AVP - values, add the T flag, make the result code and session ID named - fields, and add some more field types. +2004-05-07 17:36 obiot -2004-03-21 23:08 guy + * packet-http.c: - * packet-diameter-defs.h: + Add Uncompressed/Compressed to the compressed data source label + for clarity. - From Anders Broman: add some more AVP's, result codes, etc.. +2004-05-07 12:29 tpot -2004-03-21 22:55 guy + * packet-dcerpc.c, packet-smb-sidsnooping.c: - * README.macos: + Compile fixes for change to dcerpc_info structure. - Update to note that the 10.3.3 Software Update will probably also - install a new libpcap shared library but not install new libpcap - headers. +2004-05-07 12:15 ulfl -2004-03-21 19:57 jmayer + * gtk/: hostlist_table.c, main.c, menu.c, + service_response_time_table.c: - * packet-ipdc.h, packet-ipdc.c: + rename context menu items: Match -> Apply as Filter Prepare -> + Prepare a Filter and prepended a ... at appropriate submenu items - Prefix ENUM types ip IPDC_ in order to prevent type clashes with - windows includes (MSVC). Proposed fix by Ulf Lamping. +2004-05-07 11:34 ulfl -2004-03-21 19:04 jmayer + * epan/value_string.h: - * README.macos: + did some code cleanup, added some comments from value_string.c - Update to include the libpcap problems. Using excerpts from a - mailexchange between Guy Harris and Peter ("downtime"). +2004-05-07 11:24 ulfl -2004-03-21 17:13 nneul + * packet-dcerpc.c, packet-dcerpc.h, tap-dcerpcstat.c, + gtk/dcerpc_stat.c: - * AUTHORS, packet-ipvs-syncd.c, epan/Makefile.common: + replace info field "gboolean request" by "guint8 ptype", so the + packet type can be better detected - add support for dissecting multicast sync packets for Linux IPVS +2004-05-07 11:07 ulfl -2004-03-20 20:06 guy + * packet-dcerpc.c: - * packet-aim.c: + tag some protocol items as generated - From Jelmer Vernooij: add support for SNAC(x,1), SNAC(1,2-6) and - SNAC(1,0x13). +2004-05-07 08:12 ulfl -2004-03-20 19:09 guy + * gtk/recent.h: - * packet-radius.c: + removed obsolete comments - If we can't decrypt the user password, display it as hex data, - not as text. +2004-05-07 08:02 guy - Make "rdconvertbufftostr()" use "isprint()" to determine whether - to display a character as itself or as an escape. Move our - redefinition of "isprint()" above "rdconvertbufftostr()" so that - we make the "is it printable?" decision appropriately. + * AUTHORS, packet-bootp.c, doc/ethereal.pod: -2004-03-20 18:51 guy + From Thomas Anders: - * packet-radius.c: + - support vendor-specific DHCP option 43 interpretation per + CableLabs standards (for compliant cable devices, identified + by option 60) - support DHCP option 122 with all suboptions (RFC + 3495: CableLabs Client Configuration; RFC 3594: PacketCable + Security Ticket Control) - update DHCP options list: add options + 117-122 (see + http://www.iana.org/assignments/bootp-dhcp-parameters) - minor + enhancements for DHCP options 2, 82 - minor code cleanup - Make a separate display type for the user password, rather than - having the code to handle RADIUS_STRING know that User Password - has an AVP type value of 2. As only the User Password field has - that display type, we don't have to check whether we're handling - vendor-specific VSAs. +2004-05-06 20:50 obiot -2004-03-20 10:47 jmayer + * epan/config.h.win32: - * packet-ipdc.h: + Get rid of epan/config.h.win32. - Remove trailing comma +2004-05-06 20:48 obiot -2004-03-20 10:32 jmayer + * Makefile.nmake, config.h.win32, epan/Makefile.nmake, + epan/dfilter/Makefile.nmake: - * acinclude.m4, epan/acinclude.m4: + Get rid of epan/config.h.win32. - Workaround for (at least) some RedHat platforms: Add -lresolv in - case it's missing but required by the heimdal libs. + Fix a missing ZLIB_CFLAGS in epan/Makefile.nmake. -2004-03-20 08:32 guy +2004-05-06 17:40 obiot - * epan/timestamp.c: + * epan/tvbuff.c: - Make "timestamp_type" static, as all access to it should be - through the routines in this file. + From Kendy Kutzner: a char should be compared with '\0', not + NULL. -2004-03-20 08:01 guy +2004-05-06 10:24 sahlberg - * packet-ipdc.c: + * AUTHORS, packet-isns.c: - "tmp_tag_text" can hold a string of up to 255 characters, which - means it needs to be 256 characters long to hold a maximum-length - string plus a terminating '\0', as noted by Stefan Esser. + add tcp reassembly to isns - Don't bother putting in the null terminator at the end in the - case where we're putting an IP address or address/port into - "tmp_tag_text" - "sprintf()" does that for you. + also make isns not dump core just because someone has encoded an + integer in 0 bytes. - In the case where it's an IP address and port, do it all in one - sprintf call - I don't think there's a guarantee that + still need to add reassembly of fragmented pdus (first + fragment/last fragment) but have example captures of that so + thats for tomorrow. - sprintf(tmp_tag_text, "%s:%u", tmp_tag_text, ...) +2004-05-05 20:12 ulfl - works, although it could work. + * gtk/endpoint_talkers_table.c: - Also, handle the case where the length is neither 4 (IP address) - nor 6 (IP address/port). + various context menu related changes -2004-03-20 07:49 guy +2004-05-05 17:28 obiot - * packet-ucp.c: + * AUTHORS, packet-slsk.c, doc/ethereal.pod: - Don't use fixed-length buffers for strings - there's no absolute - string length. + From Kendy Kutzner: use the tvb_uncompress() routines instead of + the own SLSK decompression routine. -2004-03-20 07:26 guy +2004-05-05 09:30 guy - * packet-tcap.c: + * packet-aim-bos.c, packet-aim-messaging.c, packet-aim.c, + packet-aim.h: - In "dissect_tcap_tid()", check that the length of the transaction - ID is <= 4, so we don't copy more than 4 bytes to a 4-byte - integer. + Use "tvb_reported_length_remaining()" in "until the end of the + packet" loops, so we mark frames as short if they've been cut + short by a snapshot length. -2004-03-20 06:34 guy + The user class in buddy list TLVs appears to be 2 bytes, in at + least some captures; make "dissect_aim_userclass()" take the user + class value, and the length of the user class field, as + arguments, and have the caller fetch the value. Also, display + the numerical value of the user class in hex, as it's a bitset. - * gtk/: main.c, menu.c, proto_draw.c, proto_draw.h: + Fix the messaging dissector to put stuff under the top-level item + rather than at the top level. - From Tomas Kukosa: + Fix a typo. - add Expand Tree to the View menu; + Clean up indentation. - make the Expand Tree context menu active iff the - currently-selected item has a subtree; +2004-05-05 08:49 guy - fix the GTK2 code for Expand Tree. + * gtk/main.c: -2004-03-20 06:14 guy + Note that hiding panes in the paned widgets doesn't do what we + want with GTK+ 1.2[.x], although it does so with GTK+ 2.x. - * AUTHORS, packet-aim.c, doc/ethereal.pod: +2004-05-05 07:31 guy - From Jelmer Vernooij: add support for some more SNACs. + * prefs.c, prefs.h, gtk/layout_prefs.c: -2004-03-20 06:06 guy + Use an enum when initializing "prefs.gui_layout_type". - * packet-smb.c: + Add an entry to that enum at the end and use that to generate the + value of LAYOUT_QTY. - From Ronnie Sahlberg: Windows XP SP1 appears to send the OS and - LANMAN fields over the wire in ASCII in SessionSetupandX messages - even though the "Unicode strings" flag is set. +2004-05-05 06:55 obiot -2004-03-20 05:53 guy + * AUTHORS, packet-http.c, epan/tvbuff.c, epan/tvbuff.h: - * packet-ipdc.c, packet-ipdc.h: + From Jerry Talkington: + + - Helper functions for uncompressing compressed + tvbuffers. + + - Compressed content coding dissection in HTTP. + +2004-05-05 03:05 gerald + + * packet-mmse.c: + + Check the value length in get_encoded_strval(), so that we don't + feed a length less than 1 to tvb_get_string(). - Updates from Josh Bailey and Ruud Linders. +2004-05-04 21:12 etxrab + + * packet-sip.c: + + Fixed a copy-paste error + +2004-05-04 21:08 guy + + * gtk/: main.c, menu.c: + + Use "main_widgets_show_or_hide()" to control the visibility of + all the main window widgets, rather than requiring a relayout if + the visibility of the main toolbar, filter toolbar, or statusbar + is changed. + + Clean up indentation. + +2004-05-04 20:49 guy + + * gtk/: main.c, main.h, menu.c: -2004-03-19 20:40 tuexen + If all we're doing is changing the visibility of a pane, we don't + have to re-lay-out the main window, we just need to change the + visibility of the appropriate widgets - that reduces the amount + of drawing done, speeding things up a little and reducing + flicker. + +2004-05-04 20:40 guy + + * gtk/main.c: + + Display "main_second_pane" if, and only if, both widgets in it + are displayed; otherwise, if you hide both of them (e.g., hiding + the packet details and packet data panes in the default layout), + "main_second_pane" remains but as a gray blob, rather than having + the remaining pane take over the entire window. + +2004-05-04 20:04 guy + + * gtk/menu.c: + + Put the coloring rules back under View. + +2004-05-04 17:46 tuexen * packet-sctp.c: - Fixed a typo: sctp.verfication_tag -> sctp.verification_tag + Clean up some variable names. -2004-03-19 10:24 guy +2004-05-04 09:12 guy - * packet-e164.c: + * packet-sndcp.c: - Use "E.164", not "E164". + Get rid of a trailing comma. - In the field names, use the filter name of the protocol - "e164" - - rather than "E164". +2004-05-04 09:03 guy -2004-03-19 07:54 guy + * packet-gprs-llc.c: - * AUTHORS, Makefile.common, packet-gsm_a.c, packet-gsm_map.c, - packet-gsm_ss.c, packet-gsm_ss.h, packet-tcap.c, packet-tcap.h, - epan/Makefile.common: + Fix some typos, and get rid of an inapplicable boilerplate + comment. - From Michael Lum: + Get rid of some trailing commas. - GSM A facility element decoding; + Show the SAPI symbolically in the top-level item for the address + field. - make TCAP dissector export routines for use by various - GSM - dissectors; +2004-05-04 08:30 guy - make GSM MAP dissector use exported TCAP - routines/defines; + * packet-ntlmssp.c: - GSM Supplementary Services support. + We don't need to save the challenge values as per-conversation or + per-packet information. -2004-03-19 07:49 guy +2004-05-04 07:24 guy - * doc/README.developer: + * packet-text-media.c: - Update to reflect current reality. + Add the RFC 3023 XML media types. -2004-03-19 06:23 guy +2004-05-04 07:12 guy - * gtk/: main.c, main.h, menu.c: + * packet-http.c: - From Tomas Kukosa: add a new "Expand Tree" context menu item, - which expands the selected item and all items below it. + Chunked data reassembly *is* done in + "req_resp_hdrs_do_reassembly()". -2004-03-19 06:14 guy + That means that the description of the "desegment HTTP bodies" + preference setting shouldn't speak of it causing the dissector to + trust the content length (which makes it somewhat long anyway), + as it also desegments chunked bodies that lack a Content-Length + header; expand the tooltip for the preference to speak of that. - * packet-tcp.c: +2004-05-04 06:53 guy - From Ronnie Sahlberg: + * req_resp_hdrs.c: - make tcp_dissect_pdus() understand how to skip to the - next PDU; + "tvb_get_string()" returns a pointer to "g_malloc()"ed data, so + you have to free it when you're done with it. - make the skip-to-the-next-PDU code stop attempting to - decode - segments that are known to be completely within an - already seen - PDU. + It never returns a null pointer, however, so there's no need to + check for that. -2004-03-19 05:33 guy + Clean up the code to process Transfer-Encoding a bit. - * packet-rtsp.c: +2004-05-04 06:21 guy - From Anders Broman: put E.164 numbers into the protocol tree - using the E.164 routines. + * packet-http.c: -2004-03-19 05:22 guy + Note that the way we currently handle the chunked encoding + doesn't work if the HTTP data takes more than one packet. - * wiretap/libpcap.c: +2004-05-04 06:14 guy - In the read routine, set the 802.11 pseudo-header for - WTAP_ENCAP_PRISM_HEADER, WTAP_ENCAP_IEEE_802_11_WLAN_BSD, and - WTAP_ENCAP_IEEE_802_11_WLAN_AVS. + * packet-dcerpc.c: - In the seek_read routine, set it for all 802.11 types. + Display a server boot time of 0 as "Unknown" (as that's what's + sent when the client sends its first PDU to the server, and when + the endpoint mapper sends back an error PDU on behalf of the + server, because they don't know the server's boot time - it's + unlikely that the server was booted precisely at January 1, 1970, + 00:00:00 GMT). -2004-03-18 21:14 obiot + Clean up some white space. - * epan/timestamp.c: +2004-05-04 06:01 guy - From Lars Roland: Move timestamp_type into libethereal and - provide accessor methods for getting and setting the timestamp - type. + * packet-cops.c: - This is a move towards a real libethereal shared library. + Don't assume the length field in a PacketCable object is sane. -2004-03-18 19:04 obiot +2004-05-03 23:47 guy - * column.c, dftest.c, globals.h, tethereal.c, epan/Makefile.am, - epan/Makefile.nmake, epan/column-utils.c, epan/timestamp.h, - gtk/main.c, gtk/menu.c, gtk/packet_list.c: + * doc/ethereal.pod, gtk/menu.c: - From Lars Roland: Move timestamp_type into libethereal and - provide accessor methods for getting and setting the timestamp - type. + The GNOME HIG calls the View menu item for the status bar + "Statusbar", not "Status Bar". - This is a move towards a real libethereal shared library. +2004-05-03 23:37 guy -2004-03-18 15:53 gerald + * doc/ethereal.pod: - * packet-wsp.c: + The "View" menu has items to show or hide the three display + panes; it calls the middle pane the "Packet Details" pane, which + is perhaps less geeky than "Protocol Tree". Update the man page + to call it the "packet details". - Call proto_register_field_array() after - proto_register_protocol(), and not before. + Update the description of the menu items to more closely reflect + current reality. -2004-03-18 09:00 guy +2004-05-03 23:34 guy - * packet-isup.c, packet-q931.c, packet-q931.h: + * gtk/menu.c: - From Tomas Kukosa: + Move "Coloring Rules" from "View" to "Edit" - you're editing the + set of coloring rules Ethereal uses (yes, those views affect the + way the packets are displayed, but that also applies to at least + some the preferences, which are in Edit->Preferences). - improve the Info column text for reassembled messages; + Get rid of the "Show" menu under "View", moving the items up to + the main "View" menu, as per the GNOME HIG. Give some of them + accelerators, and change the accelerators for some other "View" + items to avoid collisions. - register subdissectors for dissecting Q.931 IEs and make - the - ISUP dissector call the codeset 0 IE subdissector through - a - handle. +2004-05-03 22:55 guy -2004-03-18 08:25 guy + * packet-ber.c: - * AUTHORS, Makefile.common, packet-ipdc.c, packet-ipdc.h, - doc/ethereal.pod, epan/Makefile.common: + Squelch some compiler warnings. - From Josh Bailey: IPDC support. +2004-05-03 22:15 ulfl -2004-03-17 21:48 deniel + * gtk/: endpoint_talkers_table.c, endpoint_talkers_table.h, + hostlist_table.c, hostlist_table.h: - * proto_hier_stats.c, proto_hier_stats.h, - gtk/proto_hier_stats_dlg.c: + add name resolution to both endpoint and conversation lists - * Protocol Hierarchy Statistics: +2004-05-03 19:03 guy - - store times of first and last packets in ph_stats_t + * packet-dcerpc-lsa-ds.c: - - add bandwidth columns in GUI + From Jean-Baptiste Marchand: add some more operation names. - - miscellaneous code cleaning +2004-05-03 18:53 guy -2004-03-17 19:57 jmayer + * make-reg-dotc, make-tapreg-dotc: - * Makefile.am: + Add an RCS ID. - Correctly spell REAMDE.macos +2004-05-03 18:51 guy -2004-03-17 19:50 obiot + * register.h: - * packet-wbxml.c: + "register_all_tap_menus()" no longer exists. - Enclose WV-CSP 1.2 token mappings in conditional compile - comments. Once the WV-CSP 1.2 specifications will be corrected - and in approved state, we can get rid of those comments (#ifdef - ... #endif). +2004-05-02 21:35 guy -2004-03-17 18:20 jmayer + * packet-chdlc.c: - * Makefile.am, acinclude.m4, configure.in, epan/acinclude.m4, - epan/configure.in: + From Carlos Pignataro: handle the padding byte between the + protocol type field and playload for OSI network layer packets. - Experimental Heimdal Kerberos detection. As this is experimental - and does not yet work reliably this feature is off by default. - Enable it by using --with-krb5 during configure. Please do not - yet make use of this feature (i.e. please do not *use* the - defines provided by this option), until it has received further - testing and fixing. Please run and check what the configure - says. +2004-05-02 21:16 ulfl -2004-03-17 18:13 jmayer + * gtk/: hostlist_eth.c, hostlist_fc.c, hostlist_fddi.c, + hostlist_ip.c, hostlist_ipx.c, hostlist_table.c, + hostlist_table.h, hostlist_tcpip.c, hostlist_tr.c, + hostlist_udpip.c, menu.c: - * FAQ, manuf, help/faq.txt: + build a endpoints (aka hostlist) dialog, which shows all kinds of + endpoints in a notebook - Sync with the sources +2004-05-02 21:10 ulfl -2004-03-17 17:46 jmayer + * gtk/endpoint_talkers_table.c: - * epan/Makefile.am: + slightly changed to prevent naming conflict with hostlist_table.c - Add new docsis files for static build. This is currently - necessary and needs to be fixed. +2004-05-02 17:25 ulfl -2004-03-17 09:24 guy + * gtk/: endpoint_talkers_eth.c, endpoint_talkers_fc.c, + endpoint_talkers_fddi.c, endpoint_talkers_ip.c, + endpoint_talkers_ipx.c, endpoint_talkers_table.c, + endpoint_talkers_table.h, endpoint_talkers_tcpip.c, + endpoint_talkers_tr.c, endpoint_talkers_udpip.c, menu.c: - * wiretap/eyesdn.c: + build a conversation (aka endpoint_talkers) dialog, which shows + all kinds of conversations in a notebook - "esc_read()" is passed a FILE_T, not a FILE_T * - a FILE_T is a - pointer (a FILE * if zlib isn't used, a gzFile if zlib is used). +2004-05-02 15:23 ulfl - Use "size_t" for the amount of data to read in - "eyesdn_check_file_type()", to squelch signed vs. unsigned - warnings. + * gtk/hostlist_table.c: -2004-03-17 09:01 guy + after retapping, immediately redraw table to avoid annoying + redraw even on "static" capture files - * packet-slsk.c: +2004-05-02 15:04 ulfl - Suppress compiler warnings about unused arguments. + * file.c: -2004-03-17 09:00 guy + bugfix: reset the tap listeners, when the capture file is closed - * gtk/tcp_graph.c: +2004-05-02 08:54 ulfl - Use "g_ntohs()" rather than "ntohs()". + * gtk/: layout_prefs.c, ui_util.c, ui_util.h: -2004-03-17 08:59 guy + move function xpm_to_widget() from layout_prefs to ui_util, as + this can be useful not only in layout_prefs - * gtk/main.c: +2004-05-02 07:31 guy - Cast a "char" to "guchar" before passing it to the ctype macros, - so that it doesn't get sign-extended. + * epan/ftypes/ftype-string.c: -2004-03-17 08:46 guy + Make sure the character values we pass to "isprint()" aren't + sign-extended. - * packet-gsm_map.c: +2004-05-02 00:43 guy - Unfortunately, GCC 2.8.1 on x86/Solaris 7 doesn't do enough - compile-time optimization; in particular, if you call - GSM_MAP_PARAM_DISPLAY with a Gtag argument of GSM_MAP_P_NONE, the - compiler does figure out that it only need generate code for the - first branch for the first if in that macro, and it sort of seems - to understand that _param_fcn is guaranteed to be null, but it - doesn't optimize out the test and the branch for _param_fcn not - being null - it does, however, generate a call to location 0, - which, when you compile as position-independent code, the - assembler refuses to assemble. + * autogen.sh: - Therefore, we put into the test for _param_fcn being null an - additional test for Ga1 being GSM_MAP_P_NONE, which at least - manages to get the code through the compiler. + Some versions of libtool stick extra stuff after the version + number, e.g. some versions from the FreeBSD ports collection add + "-freebsd-ports". Match non-white-space text after the version + number. -2004-03-17 06:55 guy +2004-05-01 23:56 guy - * AUTHORS, doc/ethereal.pod, plugins/docsis/AUTHORS, - plugins/docsis/Makefile.am, plugins/docsis/Makefile.nmake, - plugins/docsis/README, plugins/docsis/packet-docsis.c, - plugins/docsis/packet-docsis.h, - plugins/docsis/packet-intrngreq.c, - plugins/docsis/packet-macmgmt.c, plugins/docsis/packet-rngreq.c, - plugins/docsis/packet-type29ucd.c, plugins/docsis/packet-ucd.c: + * epan/strutil.c: - From Brian Wheeler: DOCSIS 2.0 support. + GLib 1.2[.x]'s "g_string_free()" doesn't return a value. -2004-03-16 19:23 guy +2004-05-01 22:55 obiot - * AUTHORS, packet-mq.c, doc/ethereal.pod, epan/Makefile.common: + * file.c, simple_dialog.h, gtk/simple_dialog.c: - From metatech: IBM WebSphere MQ protocol support. + The display filter engine can return an error message that is not + safe when using GTK2 code for rendering the error. In order to + correctly render the error message, it must be XML escaped. -2004-03-16 19:13 guy + TODO: track down the remaining places where this XML escaping is + required, and fix it there too (not sure if they exist + though). - * packet-cdp.c: +2004-05-01 21:34 guy - From Paul Ionescu: handle ODR hub default gateway announcements. + * tap-sipstat.c: -2004-03-16 18:18 guy + From Lars Roland: add message counts to the SIP statistics. - * README.macos: +2004-05-01 21:33 guy - It's Mac OS, not MacOS. + * doc/: ethereal.pod, tethereal.pod: - Note that Ethereal doesn't work on pre-X Mac OS, in case somebody - sees ".macos" and thinks it'll work on OS 9 or earlier versions. + From Lars Roland: document the SIP statistics. - Explain that GLib and GTK+ now need to be shared libraries, and - that the GLib 1.x and GTK+ 1.x release tarballs were built with - an older version of libtool that didn't support building them as - shared libraries on OS X. +2004-05-01 21:18 guy -2004-03-15 12:21 jmayer + * AUTHORS, Makefile.common, packet-mq-pcf.c, packet-mq.c, + packet-mq.h, epan/Makefile.common: - * AUTHORS, autogen.sh: + From metatech: - Peter Kjellerstedt: * Correct the version checks (use path - expansion rather than regular expressions, and fail if the - tools are not installed at all). * Make it possible to specify - other names for the auto* tools to use (e.g., automake-1.6 - instead of automake). + for the MQ dissector: + - PDU desegmentation; + - XA messages; + - Netbios, SPX, HTTP support; + - Subdissector table; -2004-03-15 02:24 jmayer + dissector for the MQ Programmable Command Formats protocol. - * TODO: +2004-05-01 21:04 obiot - Add Build process items to TODO + * print.c: -2004-03-15 02:04 jmayer + Add escaping of an apostrophe in XML output. - * README.macos: +2004-05-01 20:46 obiot - Beginnings of README.macos + * epan/: strutil.c, strutil.h: -2004-03-14 23:55 deniel + Add an XML escaping routine: xml_escape() - * gtk/: color_filters.c, color_filters.h: +2004-05-01 20:15 obiot - * Color filters: + * epan/proto.h: - Read of color filters rewritten to remove possibility of buffer - overflow in read_filters_file() and to fix comment & blank line - handling. This removes any limitation (and stack overflow) on - the lengths of color filter name and filter expression which are - now dynamically allocated. + Squelch a compiler warning (extraneous extern on struct). - Fix removal/deletion of color filters (avoid segmentation fault - when some color filter is deleted and then the list cleared for - instance). The use of g_slist_remove() within an iterator is - simply unsafe if the code is not prepared to handle this. + Fix the PROTO_ITEM_IS_XXX and PROTO_ITEM_SET_XXX macros by + replacing the if(x) with trigraphs so the macros can still be + used in subsequent conditional tests. - Fix a small memory leak in revert_filters(). +2004-05-01 19:24 ulfl - Remove inappropriate comments in read_filters(). + * gtk/: endpoint_talkers_table.c, hostlist_table.c: - Miscellaneous code cleaning. + bugfix: remove all elements on "tree reset", don't keep the first + entry in the list -2004-03-14 14:04 deniel +2004-05-01 18:40 ulfl - * gtk/rtp_stream_dlg.c: + * gtk/proto_hier_stats_dlg.c: - Fix incorrect number of arguments for format and compilation - warnings. + GTK2: expand all tree elements when opening dialog -2004-03-14 08:07 jmayer +2004-05-01 18:39 ulfl - * Makefile.am: + * epan/proto.h: - Whitespace change + prevent null pointer exception -2004-03-13 22:49 ulfl +2004-05-01 17:22 obiot - * capture-wpcap.c, capture.c, capture.h, gtk/capture_dlg.c, - gtk/main.c: + * gtk/: menu.c, color_dlg.c: - experimental: make usage of pcap_setbuff to increase the kernel - buffer size + From Richard Urwin: ensure that the initial colour is appropriate + in all cases. The colouring rules are also available now when no + packets have been captured or loaded from file. -2004-03-13 19:51 ulfl +2004-05-01 17:02 obiot - * doc/ethereal.pod, help/capturing.txt: + * packet-ranap.c: - updated texts to reflect the latest GUI changes + From Michael Lum: -2004-03-13 17:50 ulfl + - Write to the INFO column only if it is visible. - * gtk/menu.c: + - Add the RANAP message to the protocol tree. - using a stock icon for the open recent "clear list" item +2004-05-01 15:15 ulfl -2004-03-13 15:30 ulfl + * file.c, packet-tcp.c, print.c, epan/proto.c, epan/proto.h, + gtk/proto_draw.c: - * gtk/simple_dialog.c: + add PROTO_ITEM_SET_HIDDEN() and PROTO_ITEM_SET_GENERATED(), this + sets flags for later rendering of the field data - replaced vsnprintf by g_vsnprintf +2004-05-01 14:22 etxrab -2004-03-13 15:15 ulfl + * packet-rtp-events.c: - * gtk/: ansi_a_stat.c, ansi_map_stat.c, bootp_stat.c, - capture_info_dlg.c, capture_prefs.c, color_dlg.c, dcerpc_stat.c, - decode_as_dlg.c, endpoint_talkers_table.c, fc_stat.c, - follow_dlg.c, gsm_a_stat.c, gsm_map_stat.c, gtk_stat_util.c, - gui_prefs.c, hostlist_table.c, io_stat.c, isup_stat.c, - ldap_stat.c, main.c, nameres_prefs.c, prefs_dlg.c, rpc_stat.c, - service_response_time_table.c, simple_dialog.c, smb_stat.c, - summary_dlg.c, tcp_graph.c, wsp_stat.c: + From Martin Mathieson :small patch for rtp-events that shows in + the info column which packets that mark the end of events - replaced sprintf / snprintf by g_snprintf, various other string - related changes +2004-05-01 14:19 etxrab -2004-03-13 14:07 ulfl + * packet-sip.c: - * gtk/: bootp_stat.c, decode_as_dlg.c, follow_dlg.c, - h225_counter.c, h225_ras_srt.c, help_dlg.c, http_stat.c, main.c, - mgcp_stat.c: + From Martin Mathieson Update of SIP resend detection. - various string related changes +2004-05-01 06:21 ulfl -2004-03-13 12:09 ulfl + * tools/win32-setup.sh: - * gtk/: mgcp_stat.c, rpc_progs.c, rtp_analysis.c, rtp_stream_dlg.c, - supported_protos_dlg.c, tap_dfilter_dlg.c, wsp_stat.c: + minor changes - various string related changes, mainly replace sprintf/snprintf - by g_snprintf +2004-05-01 00:34 sahlberg -2004-03-13 11:47 ulfl + * packet-dcerpc-netlogon.c: - * gtk/dfilter_expr_dlg.c: + more deltatypes - replaced snprintf by g_snprintf and removed #include "snprintf.h" +2004-04-30 22:19 guy -2004-03-13 11:43 ulfl + * packet-spnego.c: - * gtk/color_dlg.c: + Clean up the creation of the tvbuff for a mechToken so that the + length and reported length are both no larger than the length of + the token. - replaced gtk_widget_show() by a single gtk_widget_show_all(), - changed a printf thing +2004-04-30 21:33 guy -2004-03-13 10:15 jmayer + * packet-media.c: - * Makefile.am, epan/Makefile.am, epan/configure.in, - epan/dfilter/Makefile.am, epan/ftypes/Makefile.am, - wiretap/Makefile.am: + Get rid of a compiler warning. - Make libethereal and libwiretap shared libs. +2004-04-30 21:32 guy -2004-03-13 09:35 guy + * gtk/layout_prefs.c: - * packet-cdp.c: + GCC warning removed. (ANSI C says it's "implementation-defined" + what integral type an enum corresponds to; I guess GCC says + "unsigned int" and MSVC says "int".) - Clean up the message for one capability bit, as per a suggestion - by John Engelhart. +2004-04-30 21:11 guy -2004-03-13 09:27 guy + * packet-cops.c: - * packet-pres.c: + Make some floating-point fields FT_FLOAT, rather than FT_UINT32. - From Yuriy Sidelnikov: handle the case where a presentation - selector exists but has a length of zero. +2004-04-30 17:07 obiot -2004-03-12 17:23 gerald + * AUTHORS, packet-http.c, packet-media.c, packet-wsp.c, + packet-multipart.c, epan/Makefile.common: - * util.c: + Add a generic media dissector. The dissectors trying to find a + suitable media dissector for a given media type (value of a + Content-Type header) must provide the logic to fall-back to this + media dissector upon no match. - Don't automatically set a capture filter if DISPLAY or REMOTEHOST - are "localhost" or "127.0.0.1". + Note that you must set the pinfo->match_string to the media type + name, and if the media type is specified with parameters, then + those parameters can be added to pinfo->private_data. If there + are no parameters, or the parameter decoding is not implemented, + you must set pinfo->private_data to NULL. -2004-03-12 16:31 gerald + Known TODOs: - * Makefile.am, epan/Makefile.am: + - Fix the WSP parameter handling so it accompanies any media + dissector. + Simplest approach is to retrieve the header field label from + the WSP + Content-Type field and to search for a semicolon in it (or by + using + the string length of the content type string representation). - Add cvsversion.h, x11-declarations.h, and x11-register-info.h to - CLEANFILES so that "make distcheck" will work. + - Verify that that subdissection always works in the WSP + dissector, + even when the protocol tree is not being built. -2004-03-12 08:42 guy + - Implement the media dissector in the remaining dissectors that + use the + media type string table. - * packet-3g-a11.c: +2004-04-30 15:26 obiot - Fix some typos, as per Ryuji Somegawa. + * packet-http.c: -2004-03-11 09:54 sahlberg + Beware: sscanf() only operates on C strings. A pointer returned + by tvb_get_ptr() is not necessarily NULL terminated, hence a NULL + terminated string must be generated from the returned pointer. - * packet-ndmp.c: +2004-04-30 07:56 ulfl - make NDMP start distinguishing between different versions. - Between v2 and v3 some structures changed their definition. + * doc/README.xml-output: - I arbirtrarily made the preference set V2 as the default. I have - no idea what the most common ndmp version is maybe someone that - knows which is the most popular iversion in the wild will change - it to default to that. + updated to reflect the latest changes of exporting PDML in + ethereal -2004-03-11 09:18 guy +2004-04-30 06:56 ulfl - * packet-symantec.c, epan/Makefile.common, wiretap/libpcap.c, - wiretap/wtap.c, wiretap/wtap.h: + * epan/: proto.h, dfilter/dfilter.c: - Add support for DLT_ value 99, as used by the Axent Raptor - firewall/Symantec Enterprise Firewall. Thanks, Axent/Symantec, - for not asking us for a DLT_ value and not telling us about the - link-layer type. + removed unused things -2004-03-11 03:24 gerald +2004-04-30 06:30 ulfl - * packet-dccp.c: + * gtk/layout_prefs.c: - Fix a typo. + removed warnings of GTK1 compilation -2004-03-11 00:22 gerald +2004-04-30 06:24 ulfl - * gtk/stream_prefs.c: + * packet-acse.c, packet-cops.c, packet-pres.c, packet-spnego.c, + packet-tcp.c: - Make the color preferences popup menu shrink to its natural size - instead of filling in its entire table cell. + MSVC warnings removed -2004-03-10 23:42 guy +2004-04-30 05:25 ulfl - * packet-3g-a11.c: + * gtk/layout_prefs.c: - From Ryuji Somegawa: + MVSC warning removed - add a value_string for the PDSN code; +2004-04-30 00:40 guy - use for the service option the value_string that was - already - there and add a new value to that value_string; + * prefs.c, prefs.h, gtk/layout_prefs.c, gtk/layout_prefs.h: - fix up some existing entries, and add some new entries, - to the - Radius attribute table. + The layout types and pane types don't depend on GTK+, so move + their definitions to "prefs.h". -2004-03-09 20:23 guy + Use them, rather than (incorrect) raw numerical values, when + initializing the preferences. - * packet-pgm.c: +2004-04-30 00:22 guy - Fix formats for "sizeof" so that "sizeof" values get displayed - correctly if they're "int"s or "long"s. + * gtk/layout_prefs.c, gtk/main.c, image/icon_layout_1.xpm, + image/icon_layout_2.xpm, image/icon_layout_3.xpm, + image/icon_layout_4.xpm, image/icon_layout_5.xpm, + image/icon_layout_6.xpm: - Get rid of the unused PGM_xxx_SZ variables. + Squelch some compiler warnings. -2004-03-09 20:08 guy + Clean up white space. - * packet-netflow.c: +2004-04-29 22:40 sahlberg - Dynamically allocate the array of field entries in a NetFlow V9 - template, rather than allocating a fixed table of 64 entries (and - possibly overflowing that table). + * AUTHORS, Makefile.common, packet-dcerpc-efs.c, + packet-dcerpc-efs.h, epan/Makefile.common: - Clear out the hash table of template entries, freeing all the - allocated arrays, when a new capture is opened. + From JBM -2004-03-09 11:31 jmayer + Dissection of the EncryptedFileSystem dce/rpc interface. - * COPYING: + This dissector also contains a complete and fully tested IDL + definition for the entire interface. - Prefix COPYING with the following text +2004-04-29 20:28 obiot - Just to avoid some misunderstandings: - While parts of Ethereal can be built and distributed as - libraries, these parts are still covered by the license below, - and NOT by the Lesser General Public License or any other - license. + * AUTHORS: -2004-03-09 09:24 guy + From Jerry Talkington: HTTP chunked transfer coding. - * packet-dcerpc-afs4int.c, packet-dcerpc-fldb.c, - packet-dcerpc-rs_pgo.c: +2004-04-29 20:26 obiot - Make variables not used outside the module static. + * packet-http.c: - Initialize "hf_error_st" to -1, the same way other hf_ variables - are initialized, and make it an "int", as other hf_ variables - are. + From Jerry Talkington: move the chunks subtree to the HTTP + protocol tree. -2004-03-09 06:46 guy +2004-04-29 20:21 gerald - * packet-pgm.c: + * AUTHORS, packet-ppp.c: - Add some checks for valid option lengths, and for the first - option being a length option. + From Carlos Pignataro: PPP OSI Network Layer Control Protocol + [RFC1377] support. - Break out of the option processing loop if we see an option with - the "end" bit set. +2004-04-29 18:11 tuexen -2004-03-09 02:12 obiot + * packet-sctp.c: - * packet-wbxml.c, packet-text-media.c: + Fixed a typo reported by Berward Meyknecht. - Redesigned the token map aggregation. +2004-04-29 17:03 ulfl - New simpler lists for both known registered WBXML public IDs and - unknown lists based on content type value. The latter have the - possibility to add a discriminator which facilitates a more - correct/appropriate selection of the token map in cases where - more (backwards incompatible) versions exist. + * prefs.c, prefs.h, gtk/Makefile.am, gtk/Makefile.common, + gtk/layout_prefs.c, gtk/layout_prefs.h, gtk/main.c, + gtk/prefs_dlg.c: - Now the EXT_T tokens are correctly decoded, and a mapping - function can be assigned. This has been done in WML (existing - code reused there) and in WV-CSP (new functions looking up a - value in a value_string based on the offset after the EXT_T_0 - token). + added selection of different main window pane layouts, also added + some preferences and a new preference page for this - Add the textual WV-CSP media type to packet-text-media.c. +2004-04-29 16:49 ulfl - TODO - write the discriminators for WML, SyncML and WV-CSP. Add - the code for running the discriminators and possibly iterating - over a list of mappings. + * Makefile.am, image/icon_layout_1.xpm, image/icon_layout_2.xpm, + image/icon_layout_3.xpm, image/icon_layout_4.xpm, + image/icon_layout_5.xpm, image/icon_layout_6.xpm: -2004-03-09 01:08 jmayer + added pane layout icons coming from pan (gnome newsreader) - * packet-radius.c: +2004-04-29 16:35 ulfl - Lars Roland: Another ugly bzero() call fixed + * gtk/gui_prefs.c: -2004-03-08 23:45 guy + fixed a typo - * file.c, file.h, gtk/menu.c: +2004-04-29 16:33 ulfl - Don't refer to "auto_scroll_live" if HAVE_LIBPCAP isn't defined - - and put the definition of it back under HAVE_LIBPCAP and don't - add an extra declaration in "file.h", as there's no longer code - that needs to refer to it if HAVE_LIBPCAP isn't defined. + * packet-tcp.c: -2004-03-08 23:37 jmayer + added "[CHECKSUM INCORRECT]" to the info column - * autogen.sh: +2004-04-29 11:58 sahlberg - Maybe automake version handling will be right this time + * packet-rpc.c: -2004-03-08 23:19 guy + technically speaking rpc duplicate replies are not + retransmissions - * plugins/irda/packet-irda.c: + only the request is tecnically a restransmission the reply is + technically not a retransmission (since it is a new reply to the + retransmitted request) - Add the URL of the specifications page. + mark duplicated replies as RPC duplicate ... instead of as RPC + retransmission -2004-03-08 23:07 jmayer + thanks to Cal for pointing this out. - * file.c, file.h: +2004-04-29 08:13 sahlberg - This makes ethereal compile again when configured --without-pcap - I don't know whether this is the optimal patch, but it does the - job. + * packet-isns.c: - file.h: extern declaration of auto_scroll_live file.c: always - declare auto_scroll_live + update to isns and prettify is a bit. -2004-03-08 22:44 jmayer +2004-04-28 20:56 guy - * autogen.sh: + * gtk/proto_draw.c: - automake versions like 1.5.1 were not detected correctly + Note that a custom widget might be the right way to speed up the + construction of the hex dump pane (so we don't need a progress + bar(!) while it's being filled in), and might have some other UI + advantages as well. -2004-03-08 22:03 obiot +2004-04-28 20:47 guy - * packet-image-gif.c, packet-image-jfif.c, packet-multipart.c, - packet-smpp.c, packet-text-media.c, packet-wbxml.c, packet-wsp.c: + * gtk/capture_dlg.c: - Remove email addresses and add a reference to the AUTHORS file - (or man page) for contacting the authors of the files. + Change the punctuation in one tooltip (I think "select the + desired one" would be an independent clause, so it should be + separate from the other clause with a semicolon). -2004-03-08 21:41 obiot + Note that, in that tooltip, in some cases "link-layer types" + would be appropriate and in others "link-layer header types" + might be more appropriate. - * packet-wbxml.c: +2004-04-28 19:13 gram - Rearrange WV-CSP tokens in numeric order, and flag WV-CSP bugs. + * gtk/capture_dlg.c: - Track differences between WV-CSP versions in the token - definitions. + Minor wording changes in tooltips. - Get rid of 8-bit characters in some comments. +2004-04-28 18:39 ulfl - Get rid of 'unused symbol' warnings. + * gtk/capture_dlg.c: -2004-03-08 19:41 guy + added tooltips for various input fields - * plugins/irda/packet-ircomm.c: +2004-04-28 17:50 obiot - Use "tvb_format_text()" on the port name, so that if there are - bytes in it that aren't printable characters, they'll be shown as - C-style escape sequences. + * doc/dfilter2pod.pl: -2004-03-08 07:47 sahlberg + When building the Ethereal documentation on MSVC++/cygwin the + cygwin perl will not swallow the '\r\n' line end sequence when + invoking chomp(), but instead the '\r' character will remain. For + this reason, chomp() cannot be used and global removal of '\r' + and '\n' characters must be used instead, like in: $_ =~ + s/[\r\n]//g; - * gtk/io_stat.c: +2004-04-28 15:38 gerald - update to iostat make it automagically make sure the field is - part of the filter string + * AUTHORS, packet-ldp.c, doc/ethereal.pod: -2004-03-07 22:46 guy + From Carlos Pignataro: - * plugins/irda/packet-ircomm.c: + Graceful Restart Mechanism for LDP [RFC3478] + Fault Tolerance for LDP [RFC3479] + Update IANA assigned Status codes + Fixed some typos. - Fetch the port name string using "tvb_get_string()", so that we - don't have to worry about overflowing a buffer; thanks to Stefan - Esser for catching that one. (It also means we handle it if - there's no '\0' at the end.) +2004-04-28 05:47 guy -2004-03-07 18:18 ulfl + * AUTHORS, doc/ethereal.pod, wiretap/file_access.c: - * gtk/dfilter_expr_dlg.c: + From Joe Marcus Clarke: force the standard output to be in binary + mode on Windows. - fixed a bug GTK_WIDGET_VISIBLE -> GTK_WIDGET_SENSITIVE, added - some (not yet finished) work +2004-04-27 19:54 guy -2004-03-07 02:57 guy + * packet-aim.h: - * packet-radius.c: + Declare "dissect_aim_userclass()" as it's used in files other + than "packet-aim.c". - Get rid of a variable I'd forgotten to back out before I checked - the code in. +2004-04-27 19:16 ulfl -2004-03-06 22:17 guy + * gtk/: main.c, recent.c, recent.h: - * packet-radius.c: + Freely adjustable status line separations. - Note that for THE3GPP_IPV6_DNS_SERVERS we probably *do* need to - handle multiple IPv6 addresses. +2004-04-26 21:11 obiot -2004-03-06 22:06 guy + * packet-aim.c: - * packet-radius.c: + From Jelmer Vernooij: - From Fritz Budiyanto: add various IPv6 attributes as per RFC - 3162, and also handle the THE3GPP_IPV6_DNS_SERVERS attribute. + Add 2 missing header fields. -2004-03-06 21:46 guy +2004-04-26 19:08 tuexen - * wiretap/Makefile.am: + * packet-sctp.c: - From Jeff Morriss: delete "ascend-grammar.c" and - "ascend-grammar.h" with "make maintainer-clean", as they're - generated files. + - added a hidden field sctp.initiate_tag - expanded data for + tapping. -2004-03-06 15:55 ulfl +2004-04-26 18:21 obiot - * gtk/dfilter_expr_dlg.c: + * packet-aim-admin.c, packet-aim-adverts.c, packet-aim-bos.c, + packet-aim-buddylist.c, packet-aim-chat.c, + packet-aim-directory.c, packet-aim-generic.c, packet-aim-icq.c, + packet-aim-invitation.c, packet-aim-location.c, + packet-aim-messaging.c, packet-aim-popup.c, packet-aim-signon.c, + packet-aim-ssi.c, packet-aim-translate.c, + packet-aim-userlookup.c, packet-aim.c, packet-aim.h: - some code cleanup + From Jelmer Vernooij: -2004-03-06 11:16 ulfl + Add support form extra SNACs. All TLV's are now recognized. - * gtk/dfilter_expr_dlg.c: +2004-04-26 17:21 obiot - replaced show/hide by sensitive/insensitive to see all fields - everytime + * tools/win32-setup.sh: -2004-03-06 11:10 ulfl + Some of the DLLs from the developer ZIP archives don't have the + executable bit set. As a result, tethereal cannot run for the + generation of the protocol field list for the ethereal-filter + documentation. - * gtk/capture_dlg.c: + Fix this issue when unpacking the ddeveloper ZIP archives. - using a table for layout of stop capture fields, added - limitations corresponding to the maximum filesize (2GB) +2004-04-26 17:10 obiot -2004-03-06 10:46 guy + * AUTHORS, packet-http.c, packet-wccp.c, req_resp_hdrs.c, + doc/ethereal.pod: - * packet-q933.c: + From Jerry Talkington: - Dissect chunked transfer-coded body in + HTTP - Update email address - Propagate to the Q.933 dissector Tomas Kukosa's change to have 3, - not 4, bits of codeset in an IE (that's how many bits of codeset - there are). +2004-04-26 15:58 gram - Make the "q933_info_element_vals[]" array have - NUM_INFO_ELEMENT_VALS members and define NUM_INFO_ELEMENT_VALS be - (Q933_IE_SHIFT_CODESET+1), as that array should have the number - of codesets worth of elements. + * print.c: -2004-03-06 10:29 guy + Look for out of bounds data after calling tvb_length_remaining(). - * packet-q933.c: +2004-04-26 07:34 sahlberg - Propagate to the Q.933 dissector Anders Broman's change to the - Q.931 dissector to add more filterable fields. + * packet-per.c: -2004-03-06 10:11 guy + the the restricted character string has 0 characters in the + encoding, then we should NOT do any byte alignments. - * packet-q931.c: +2004-04-26 02:09 gram - From Anders Broman: + * epan/ftypes/ftype-string.c: - use the packet-e164.c stuff to analyze E.164 numbers; + When producing a display-filter representation of an FT_STRING*, + represent any non-printable character in hex, as "\xNN". We rely + on isprint(), which may not be the best solution because it is + locale-specific. - add some more filterable fields. +2004-04-25 23:45 ulfl -2004-03-06 10:09 guy + * gtk/: main.c, recent.c, recent.h: - * packet-isup.c: + save the position of the main window panes in the recent file, + and restore their position when program is started again (GTK2 + only) - From Anders Broman: +2004-04-25 22:34 ulfl - use the packet-e164.c country code and international - network - value_string tables; + * gtk/print_dlg.c: - provide a bit mask for Q.850 cause code values. + removed some labels -2004-03-06 06:50 ulfl +2004-04-25 22:25 jmayer - * gtk/capture_dlg.c: + * TODO: - using a table for layout of multi files fields, do some code - cleanup + Add Heimdal detection -2004-03-06 03:25 guy +2004-04-25 22:14 obiot - * packet-bgp.c, packet-eigrp.c, epan/Makefile.am, - epan/Makefile.nmake, epan/addr_and_mask.c, epan/addr_and_mask.h: + * tools/win32-setup.sh: - Add routines to process IPv{4,6}-address-and-prefix-length pairs, - masking out the appropriate bits in the address. + Add code for HTTP proxy detection based on the http_proxy shell + variable. - Use them in the BGP and EIGRP dissectors. + Fix the tests with string equal empty_string: "$str" == "" is + either "$str" = "" or -z "$str" -2004-03-06 02:35 guy +2004-04-25 22:14 ulfl - * packet-isup.c: + * gtk/menu.c: - Don't fetch the IWFA into a buffer, just use - "proto_tree_add_item()" - that way, we don't have to worry about - overflowing the buffer. Thanks to Stefan Esser for reporting - that vulnerability. + changed the export dialog menu item names (added some + descriptions) - Fix up the indentation and blurb for the IWFA IPv6 Address item. +2004-04-25 21:54 obiot -2004-03-06 02:26 guy + * TODO: + + Remove "Display filters: add regexes to strings and byte ranges" + as it has been done. + + Add the possibility to test the packet summary line and the + packet dissection to take part in display filter tests: - + summary matches "(?i)response" - dissection contains "Unknown" + +2004-04-25 21:46 guy + + * gtk/print_dlg.c: - * packet-bgp.c: + Squelch a compiler warning. - Add a check for a too-large IPv6 prefix length, to avoid - overflowing a buffer, and add checks for IPv4 and IPv6 prefix - lengths of 0, to avoid underflowing a buffer. +2004-04-25 21:10 obiot -2004-03-06 02:20 guy + * doc/README.plugins: - * packet-eigrp.c: + Replace the plugin linkage libs into PLUGIN_LIBS which is + generated from the top-level configure.in when running configure. - Put in the URL of a page that discusses EIGRP packets. +2004-04-25 21:07 obiot - Handle the prefix length and address similarly to the way that - the BGP dissector does, so that we mask out all the bits that the - prefix length tells us to, rather than just masking out entire - bytes. + * configure.in, plugins/acn/Makefile.am, + plugins/artnet/Makefile.am, plugins/asn1/Makefile.am, + plugins/ciscosm/Makefile.am, plugins/docsis/Makefile.am, + plugins/enttec/Makefile.am, plugins/giop/Makefile.am, + plugins/gryphon/Makefile.am, plugins/irda/Makefile.am, + plugins/lwres/Makefile.am, plugins/megaco/Makefile.am, + plugins/mgcp/Makefile.am, plugins/pcli/Makefile.am, + plugins/rdm/Makefile.am, plugins/rlm/Makefile.am, + plugins/rtnet/Makefile.am, plugins/rudp/Makefile.am, + plugins/v5ua/Makefile.am: + + Replace the plugin linkage libs into PLUGIN_LIBS which is + generated from the top-level configure.in when running configure. + +2004-04-25 20:42 obiot + + * packet-wsp.c: - Check the prefix length so that we don't overflow the buffer for - prefix lengths > 32 - thanks to Stefan Esser for catching that - one - and so that we're not confused by a prefix length of 0. + Fix highlighting of unknown typed parameter bytes (caused an + exception to be thrown when expoerting as PDML. -2004-03-06 01:54 guy + Implement the Size parameter (WSP 1.4 encoding). - * packet-igap.c: + Add the word "parameter" to the parameter header field blurbs. - Handle bogus account and message lengths - don't overflow a - buffer. Thanks to Stefan Esser for catching that. + Provide stubs for the not yet implemented typed parameter + decoding, in order to make the distiction between a valid + undecoded and an unknown (and potentially invalid) typed + parameter. -2004-03-05 23:12 sahlberg +2004-04-25 20:23 guy - * packet-dcerpc-netlogon.c, packet-dcerpc-netlogon.h: + * packet-gprs-llc.c: - Kerberos contain a structure that is VERY similar to - VALIDATE_SAM_INFO2 so declare it here. This substructure in the - w2k kerberos PAC structure is called PAC_LOGIN_INFO and might - actually exist inside the netlogon interface as well? + From Josef Korelus: use "val_to_str()", not "match_strval()", so + we don't crash with incorrect values. -2004-03-05 23:09 sahlberg +2004-04-25 16:53 jmayer - * packet-dcerpc.c, packet-dcerpc.h: + * FAQ, help/faq.txt: - we need to export init_ndr_pointer_list() from packet-dcerpc so - that we can manually call functions to dissect NDR encoded - structures without going through the DCERPC interface. + Updated to Arpil 20th - There are NDR encoded blobs that are not encapsulated inside - DCERPC such as in kerberos and those dissectors need this. +2004-04-25 16:52 jmayer -2004-03-05 22:25 obiot + * manuf: + + New entries + +2004-04-25 16:04 ulfl + + * gtk/: main.h, menu.c, print_dlg.c: + + created new "export" dialogs for the current export file formats + +2004-04-25 15:16 jmayer + + * plugins/: ciscosm/packet-sm.c, rlm/packet-rlm.c, + rudp/packet-rudp.c: + + Fix the fix + +2004-04-25 12:04 ulfl + + * file.c, print.h, gtk/print_dlg.c: + + put all required data into the print_args, instead of confusing + seperation of data + +2004-04-25 11:22 jmayer + + * doc/tethereal.pod: + + Typo: It's 'item *' not 'item*' + +2004-04-25 11:20 jmayer + + * plugins/rudp/packet-rudp.c: + + It's proto_register_rudp not proto_reg_rudp + +2004-04-25 11:13 jmayer + + * plugins/: ciscosm/packet-sm.c, rlm/packet-rlm.c, + rudp/packet-rudp.c: + + Give --enable-static a chance to succeed: Some plugins failed to + do initialization inside a #ifndef ENABLE_STATIC. + +2004-04-25 10:40 etxrab * packet-diameter.c: - Add a preference to the Diameter dissector allowing to control - whether application ID zero is a valid application ID (it is - often used as experimental applciation ID). By default, the - preference is disabled. + Add a preferense wether console output should be made in case of + unknown command codes, avps or flags etc Default is off. - Fix the XML dictionary parser so it skips comment lines too. +2004-04-25 10:38 etxrab -2004-03-05 22:22 jmayer + * xmlstub.c: - * packet-3g-a11.c: + Use the newly added "report_failure" rather than g_warning if no + xml library present. - Lars wrote gint16, not guint16 +2004-04-25 09:02 ulfl -2004-03-05 22:17 jmayer + * doc/Makefile.nmake, doc/editcap.pod, doc/idl2eth.pod, + doc/mergecap.pod, doc/tethereal.pod, doc/text2pcap.pod, + help/overview.txt: - * packet-3g-a11.c: + build a list of the input file formats instead of a floating + text, added program names to HTML titles, various minor fixes - Replace u_-types by g-types (based on a patch by Lars Roland) - Remove extra "," at end of enum. Remove extra ";" at end of - block. +2004-04-25 08:01 ulfl -2004-03-05 10:56 guy + * gtk/: print_dlg.c, range_utils.c: - * AUTHORS, packet-3g-a11.c, doc/ethereal.pod, epan/Makefile.common: + changed the print dialog, so it will keep the user settings after + reopening the dialog and some code cleanup - From Ryuji Somegawa: CDMA2000 A11 support. +2004-04-25 04:53 gram -2004-03-05 10:47 guy + * epan/dfilter/scanner.l, tools/lemon/lemonflex-tail.inc: - * packet-ucp.c: + Add support for flex 2.5.31. - From Tom Uijldert: decode and display alphanumeric message - content and password as well. +2004-04-25 04:01 guy -2004-03-05 10:36 guy + * packet-cops.c: - * packet-rtsp.c: + From Dick Gooris: add two extra PacketCable tables (and clean up + some white space). + +2004-04-24 23:13 ulfl + + * file.c, print.c, print.h, tethereal.c, gtk/print_dlg.c: + + some code cleanup of the printing system + +2004-04-24 16:47 ulfl + + * packet-dcerpc.c: + + some additional output while reassembling fragments, to give the + user better information about the fragmenting going on, some + other minor changes + +2004-04-24 06:46 ulfl + + * reassemble.c: + + add fragment length output to the payload output + +2004-04-23 23:56 sahlberg + + * packet-dcerpc-netlogon.c: + + prettified a few netlogon calls and populate col_info with + account names + +2004-04-23 23:31 sahlberg + + * packet-dcerpc-netlogon.c, packet-dcerpc.c: + + update to netlogon to dissect the timestamps in + VALIDATION_UAS_INFO + + update to dcerpc time_t dissector to print the string "No time + specified" when the seconds field is 0xffffffff + +2004-04-23 22:34 sahlberg + + * packet-dcerpc-netlogon.c: + + update to netlogon, now also decode the delete user/group/alias + deltas. + +2004-04-23 19:53 ulfl + + * doc/ethereal.pod: + + seperated the input file formats into list elements, instead of a + "floating text" + +2004-04-23 19:47 ulfl + + * epan/packet.c: + + added a byte count output to the packet details notebook tabs + (only visible if desegmenting activated) - From Anders Broman: add some filterable fields, and un-hide some - other ones. +2004-04-23 19:43 ulfl -2004-03-05 10:29 guy + * gtk/proto_draw.c: - * AUTHORS, Makefile.common, packet-e164.c, packet-e164.h, - packet-isup.c, epan/Makefile.common: + added a progress dialog box, while processing packet details, + activating packet details notebook pages, to avoid desegmenting + GUI confusion - From Anders Broman: add a dissector for E.164 numbers, and use it - in the ISUP dissector, to allow filtering on E.164 numbers. +2004-04-23 16:46 ulfl -2004-03-05 10:08 guy + * packet-dcerpc-conv.c: - * packet-gsm_map.c: + some string clarifications + +2004-04-23 05:19 guy + + * Makefile.nmake: + + From Lars Roland: + + "make distclean" now removes "cvsversion.h"; + + new "update_plugin_api" which just builds the "xyzzy" + target in + the plugins subdirectory but makes sure that "config.h" + has been + generated, added. + +2004-04-23 05:16 guy + + * gtk/range_utils.c: + + Mark some parameters as unused (the GTK+ signal calling sequence + requires that they be present). + +2004-04-23 04:58 guy + + * packet-tcp.c: + + From Jon Oberheide: put the "this is a continuation of" item into + the protocol tree under the TCP top-level item, rather than at + the top level itself, as the protocol hierarchy statistics code + can't handle non-protocol items at the top level. + +2004-04-23 03:22 guy + + * gtk/file_dlg.c: + + Get rid of static forward declaration of "toggle_captured_cb()", + as it's no longer defined here. + +2004-04-23 03:20 guy + + * plugins/megaco/packet-megaco.c: + + Get rid of bogus extra "proto_tree_add_text()" arguments. + +2004-04-23 02:00 gerald + + * gtk/Makefile.am: + + Add gsm_map_stat.h and mtp3_stat.h to the distribution. + +2004-04-22 21:40 ulfl + + * gtk/: file_dlg.c, print_dlg.c: + + oops, forgotten to test with GTK1... + +2004-04-22 21:29 ulfl + + * gtk/: file_dlg.c, Makefile.am, Makefile.common, range_utils.c, + range_utils.h, print_dlg.c: + + seperated common packet range code from the save and the print + dialog, and put it into new range_utils files. This will avoid: + a) duplicate code in save and print dialog and b) yet another + code duplication for future dialogs (export, ...) + +2004-04-22 20:31 jmayer + + * packet-ipdc.h: + + No comma after last element in enum + +2004-04-22 20:29 jmayer + + * packet-rtps.h: + + No C++ style comments + +2004-04-22 20:08 etxrab + + * gtk/sip_stat.c, packet-sip.c, packet-sip.h: + + From Martin Mathieson add 2 hidden display filters for SIP - + namely: (1) sip.error (for all responses with code >= 300) (2) + sip.resend (for all packets that appear to have been + retransmitted). A field showing a count of these is shown in the + SIP stats window. + +2004-04-22 20:02 obiot + + * acinclude.m4, configure.in: + + More correct implementation of the --disable-usr-local option. + +2004-04-22 17:03 ulfl + + * file.c, print.c, print.h, print.ps, tethereal.c, gtk/print_dlg.c: + + added some options and enhancements to the print output: -ps: + added formatting hints for ghostscript, so pdf conversion will be + much better -ps: print a thin line at the top and bottom of each + page -ps/text: add an option to start a new page for every packet + (formfeed) + +2004-04-22 08:22 guy + + * AUTHORS, packet-icmpv6.c, packet-ipv6.h: + + From Shinsuke Suzuki: + + - sync ICMPv6 Type number with the official assignment + (as of + Apr 14 2004) + + - decode MLDv2 query packet + +2004-04-21 19:58 etxrab + + * plugins/megaco/packet-megaco.c: + + Skipp leading spaces in front of MEGACO and fix dissection of + TransactionResponseAck + +2004-04-21 17:57 guy + + * gtk/: gsm_map_stat.h, gsm_map_summary.c, mtp3_stat.c, + mtp3_stat.h, mtp3_summary.c: + + From Michael Lum: + + ANSI and GSM MAP stats enhancements and cleanups; + + enhanced parameter dissection related to SS for GSM + A-interface + and MAP; + + minor GSM SMS fix; + + GSM SS enhancements for parameter dissection; + + MTP3 statistics tap. + +2004-04-21 12:08 sahlberg + + * packet-dcerpc-netlogon.c: + + update to netlogon to show DsrGetDcNameEx2() Client account + name, domain name and site name + +2004-04-21 05:53 guy + + * AUTHORS, packet-ansi_map.c, packet-ansi_map.h, packet-gsm_a.c, + packet-gsm_map.c, packet-gsm_map.h, packet-gsm_sms.c, + packet-gsm_ss.c, packet-gsm_ss.h, packet-isup.h, packet-mtp3.c, + packet-mtp3.h, epan/to_str.c, gtk/Makefile.common, + gtk/ansi_map_stat.c, gtk/gsm_map_stat.c, gtk/isup_stat.c: From Michael Lum: - Make a lot of changes to identify a subset of MAP - parameters in - messages. IMSI, MSISDN, MSC Number, HLR Number, VLR - Number, - etc. Most of the SMS related MAP messages are dissected - with - the parameters identified and decoded. Also include PRN, - SRI, - and some of the other common messages (unfortunately not - Insert - Sub yet). + ANSI and GSM MAP stats enhancements and cleanups; - Fix some typoes. + enhanced parameter dissection related to SS for GSM + A-interface + and MAP; -2004-03-05 10:06 guy + minor GSM SMS fix; - * packet-gsm_sms.c: + GSM SS enhancements for parameter dissection; - From Michael Lum: fix the TP header dissection, for some messages - the wrong bits were used to identify the message content. + MTP3 statistics tap. -2004-03-05 10:05 guy +2004-04-21 00:48 obiot - * packet-tcap.c: + * gtk/follow_dlg.c: - From Michael Lum: show Component data even if it is handled by - another dissector. + Part 2 of Ulf's print update. -2004-03-05 09:58 guy +2004-04-20 23:54 obiot - * AUTHORS, packet-cdp.c, doc/ethereal.pod: + * packet-mmse.c: - From John Englehart: CDP updates (hello packets, show - capabilities the same way Cisco's "show cdp neighbor" does). + Provide MMSE 1.1 dissection. -2004-03-05 00:02 jmayer + Please test with MMSE 1.1 captures! - * autogen.sh: +2004-04-20 22:34 ulfl - Libtool requires version 1.4 + * file.c, print.c, print.h, print.ps, tethereal.c: -2004-03-04 23:33 obiot + changed postscript output: reduced print margin to 1/2 inch and + font size to 8 point, include filename in page header, wrap too + long lines - * packet-wbxml.c: +2004-04-20 19:27 obiot + + * packet-wsp.c: + + Fix the Content-Type parameter rendering as sometimes the code + was adding its value to the header field and sometimes to its + label in the protocol tree only. + +2004-04-20 13:15 gerald - Cosmetic fix in WV-CSP tag definitions. + * AUTHORS, doc/ethereal.pod: - Flag a known VERY NASTY bug in WV-CSP 1.2 where a token is being - defined twice with the same binary identifier. It's already a - mess that they don't provide backwards compatible encodings; you - can now write a WV-CSP document without being able to parse it - because of version issues (hint: 1.2 has no public WBXML - identifier yet and the spec explicitly asks to set it to - "Unknown/Missing" so you could write an 1.1 message in 1.2 - format, which looks *really* weird as the tokens are mixed in - both codings). + Update Thierry Pelle's address. - Consequence: I have to foresee a discriminator for the WBXML - dissectors so I *may* predict the correct version. I like - reviewing in engineering :) +2004-04-20 08:33 sahlberg -2004-03-04 23:16 obiot + * packet-ldap.c: + + try to dissect the ms cldap netlogon rpc flags bits. the + information comes from the samba sources and may or may not be + reliable or menaingful. + + ms documentation in their knowledgebase says that the only really + important part in the netlogon response is the sitename. + + (i have reasons to belive at least one of the flags, closest, is + completely bogous) + +2004-04-20 05:32 ulfl + + * packet-aim-icq.c, packet-aim-oft.c: + + fixed MSVC problems + +2004-04-20 05:07 guy + + * AUTHORS, packet-tuxedo.c, epan/Makefile.common: + + From metatech: basic BEA Tuxedo protocol support. + +2004-04-20 04:48 guy + + * packet-aim-admin.c, packet-aim-adverts.c, packet-aim-bos.c, + packet-aim-buddylist.c, packet-aim-chat.c, packet-aim-chatnav.c, + packet-aim-directory.c, packet-aim-generic.c, packet-aim-icq.c, + packet-aim-location.c, packet-aim-messaging.c, packet-aim-oft.c, + packet-aim-ssi.c, packet-aim-translate.c, packet-aim.c, + packet-aim.h: + + From Jelmer Vernooij: + + Add support for a couple more SNAC's. + + Handle TLV's in a somewhat more extendible manner. + + Fix a bug in the buddylist dissector that caused pango + warnings. + +2004-04-20 04:17 guy + + * packet-acse.c, packet-ftam.c: + + From Yuriy Sidelnikov: add a dissector table for OIDs to the ACSE + dissector, and make the FTAP dissector register itself in that + table. + +2004-04-19 23:36 obiot + + * packet-ip.c: + + Add a textual "(Dont Fragment)" and "(More Fragments)" to the + ip.flags line in case the DF bit or the MF bit is set. + +2004-04-19 23:26 obiot * packet-wbxml.c: - Fix WML 1.0 token definitions (WBXML tokens must be in the range - 0--3F as the 2 most significant bits of every token byte - represent whether the tag has content and/or has an attribute - list. + Fix a bug in the processing of WV-CSP OPAQUE data (TCPAddress was + Integer in WV-CSP 1.0 but became a String from WV-CSP 1.1 + onwards). -2004-03-04 22:24 ulfl + The token code page 3 of WV-CSP 1.2 is the same as in WV-CSP 1.1 + (not 1.0). - * gtk/capture_dlg.c: +2004-04-19 22:41 guy + + * packet-rtps.c: + + Put the value(s) of a parameter into the top-level item for that + parameter, and clean up the display of the value(s) under that + item. + +2004-04-19 20:20 guy - using a gtk_table instead of hbox'es for "multiple files" fields + * packet-rtps.c: -2004-03-04 21:36 jmayer + Add length checks to submessages. - * .cvsignore, epan/.cvsignore: + Clean up the handling of parameter sequences - add a bunch of + length checking, give each parameter a protocol tree item with + the ID/length/value under it, and don't format variable-length + string parameters into fixed-length buffers. Use the + parameter-sequence dissector for the ISSUE message. - Update x11 includes + Use the "number of bits" value when dissecting a bitmap. -2004-03-04 21:27 ulfl +2004-04-19 08:26 guy - * capture.c, gtk/capture_dlg.c: + * AUTHORS, doc/ethereal.pod: - capture dialog limits now with units. no gint "wrap around" - tests implemented yet + Update Pasi Eronen's e-mail address. -2004-03-04 19:31 ulfl +2004-04-19 08:19 guy - * capture.c, capture.h, gtk/capture_dlg.c, gtk/main.c: + * packet-rtps.c: - fixed differences between capture GUI frontend and backend + Use a "while()" loop, rather than a "do { ... } while()" loop, in + "dissect_rtps()", just in case a message with *no* submessages is + sent. -2004-03-04 16:19 jmayer + Fetch the flags field in that loop, as we need the E bit value to + determine the byte order of the "next submessage offset" field; + fetch that value in the loop as well, and pass both those values, + and the byte-order flag, to submessage dissector routines as + necessary. - * make-version.pl: + Make the main protocol tree item for each submessage cover the + entire submessage; put into that protocol tree an item that + covers the submessage ID, with a named field. - Andrew Hood: don't rely on last modified date + use numeric - compare + Construct the submessage subtree in that loop, rather than in the + submessage dissectors. -2004-03-04 08:53 jmayer + Put into that subtree items for the flags and next submessage + offset; we do that in the submessage dissector, as the + interpretation of the bits in the flags field differs from + submessage to submessage. - * Makefile.common, epan/Makefile.common, epan/configure.in: +2004-04-18 20:08 guy - Check for PERL in epan/configure.in Fix generation of x11 - includes. + * packet-rtps.c: -2004-03-04 08:41 jmayer + The "next_submsg" argument passed to "get_bitmap()" is an offset + within the tvbuff, not a relative offset, so it should just be a + "gint". - * aclocal-missing/.cvsignore: +2004-04-18 19:52 guy - aclocal-missing isn't needed any more + * packet-rtps.c: -2004-03-04 08:26 jmayer + Get rid of an unused variable. - * Makefile.am, epan/Makefile.am: +2004-04-18 18:55 guy - Move the x11 generation into epan. aclocal-missing isn't needed - any more. + * packet-rtps.c: -2004-03-04 08:25 jmayer + Make "little_endian" local to the routines to parse submessages. - * autogen.sh, aclocal-flags, aclocal-missing/dummy: + Before checking for the "RTPS" tag, make sure we have at least 4 + bytes in the message. - Hackremoval: Automake newer than 1.4 survives if it finds more - than one file for the same package. + Use "tvb_reported_length()" to get the length of the message, so + we throw an exception on a packet cut short by a snapshot length. + + Put in a comment asking whether the byte order of the "offset to + next submessage" field is little-endian or specified by the E + bit. + +2004-04-18 10:16 obiot + + * README.win32: + + Update the cygwin build instructions (plugins can now be compiled + too). + + Hint on how cygwin gcc can be used to compile a native Win32 + Ethereal. + +2004-04-18 06:41 ulfl + + * README.win32: -2004-03-04 08:20 jmayer + added a small section about the supported compilers - * mergecap.c: +2004-04-18 06:40 ulfl - Undo an unnecessary change + * packet-rtps.c: -2004-03-04 07:51 guy + removed some MSVC warnings - * xdlc.c: +2004-04-18 06:39 ulfl + + * packet-rtps.h: + + replaced some integer types by glib ones, to be able to compile + again on win32 + +2004-04-17 22:11 guy + + * packet-rtps.c: + + Put "#" in pre-processor keywords at the beginning of the line - + I seem to remember that at least at one point in the history of + C, at least one compiler required that. + + Clean up the byte-order stuff - LITTLE_ENDIAN and BIG_ENDIAN + aren't defined by Ethereal or GLib, so we shouldn't use them + (some platforms might define them, but at least some platforms + define them *both* as non-zero values, so they can't be used as + "true or false" values for "e_bit"), and we don't need to worry + about the byte order of the machine running Ethereal - we should + just use Ethereal's standard routines to fetch little-endian or + big-endian values. + + Get rid of C++ comments. + +2004-04-17 21:43 guy + + * AUTHORS, Makefile.common, packet-rtps.c, packet-rtps.h, + doc/ethereal.pod, epan/Makefile.common: + + From Lukas Pokorny: RTPS (Real-Time Publish-Subscribe) support. + +2004-04-17 20:58 guy + + * packet-mq.c: + + Updates from metatech: + + - Added SPI messages. + - A bit a factorisation. + +2004-04-17 11:50 ulfl + + * print.c, print.h, gtk/print_dlg.c: + + added PSML output to the printing dialog + +2004-04-17 10:45 obiot + + * packet-wbxml.c: + + Fix a typo in %DateTime of length 7 (missing colon between + minutes and seconds). + +2004-04-17 09:02 ulfl + + * print.c: + + PDML output: if a protocol field is invisible, add the attribute: + hide="yes" to the field node + +2004-04-17 04:43 guy + + * packet-q931.c: + + Neaten up the display of the top-level protocol tree item for a + number IE. + +2004-04-17 03:38 guy + + * packet-x11.c, x11-fields: + + In EnterNotify and LeaveNotify events, the last byte isn't a + Boolean, it's a bitmask with "focus" and "same-screen" bits. + +2004-04-17 03:02 guy + + * packet-diameter.c: - Back out the previous change - the problem wasn't what I thought - it was. The problem is that two arguments to an "sprintf()" call - were switched; un-switch them. + The value returned by "diameter_avp_get_value()" is used only in + protocol tree items that also have the AVP value in the text, so + there's no reason to have the string returned by + "diameter_avp_get_value()" contain that value as well - it's + redundant. -2004-03-04 07:07 guy +2004-04-17 01:12 guy - * packet-ber.h, packet-h225.h, packet-per.h, epan/plugins.c, - plugins/plugin_api.h, plugins/plugin_api_list.c, + * gtk/color_dlg.c: + + Confirmation dialogs should be marked as such. + +2004-04-17 01:09 guy + + * gtk/: capture_dlg.c, capture_prefs.c: + + Failure to get the list of interfaces should be reported as an + error. + +2004-04-17 01:07 guy + + * capture.c: + + Failures when capturing should be reported as errors. + +2004-04-17 01:05 guy + + * dftest.c: + + Update to handle the changed epan_init() API, with a "general + failure" routine added. Add a missing newline to the end of read + failure messages. + +2004-04-17 01:01 guy + + * gtk/io_stat.c: + + Report problems due to the user specifying something we can't + handle as errors, not warnings. + +2004-04-16 23:57 guy + + * gtk/main.c: + + Report errors in opening various configuration files at the time + the failure occurs; now that "simple_dialog()" queues up messages + if we don't yet have the main window, those messages will be + queued up until then. + + Move the point at which we pop up those queued messages after the + "process all pending GUI events" is done, so that those messages + are properly displayed on top of the main window. + +2004-04-16 23:16 guy + + * alert_box.c, alert_box.h, packet-diameter.c, simple_dialog.h, + tethereal.c, epan/epan.c, epan/epan.h, epan/report_err.h, + gtk/main.c, gtk/simple_dialog.c, plugins/plugin_api_list.c, plugins/Xass-list, plugins/Xplugin_api.c, plugins/Xplugin_api.h, plugins/Xplugin_api_decls.h, plugins/Xplugin_table.h: - From Tomas Kukosa: add packet-ber.c routines to the plugin API. + Add a "report_failure()" routine to allow dissectors to report + arbitrary errors to the user. Use that, rather than + "g_warning()", in the Diameter dissector to report errors reading + the dictionary. -2004-03-04 06:43 guy + Make the format argument to "simple_dialog()" a "const" pointer. - * autogen.sh: + Fix up the read-error message in Tethereal to end with a newline. - Remove blanks after a parenthesis in the output of "autoconf - --version" and "automake --version". + If a simple dialog is requested before the main window or the + capture-control window is popped up, queue it up and pop the + queued messages up once the main or capture-control window is + displayed. - We only appear to need autoconf 2.52, not 2.53. +2004-04-16 22:44 obiot -2004-03-04 06:28 guy + * packet-wbxml.c: - * configure.in, epan/configure.in, wiretap/configure.in: + Add a discriminator for WV-CSP so the correct version is used for + rendering the WBXML tokens in WV-CSP. - Get rid of an out-of-date comment. + Provide rendering of OPAQUE data for media types, based on a + framework of 4 functions that take care of well-known and literal + tags and attribute names for deciding on the meaning of the + OPAQUE data. Applied to SI, EMN and WV-CSP. - We only appear to need autoconf 2.52, not 2.53. + Update reference URLs for WAP, OMA and related specs. -2004-03-03 23:51 jmayer + Note: as the WBXML common code only takes ~2000 lines while the + token mappings take ~4000 lines, maybe it is time to envisage + writing the per-media mappings to dedicated source files + (packet-wbxml-wml.c, packet-wbxml-wv_csp.c etc)? - * Makefile.am: +2004-04-16 20:20 guy - Remove generation of register.c from toplevel - it's in epan now + * file.c: -2004-03-03 22:47 jmayer + If we're printing summaries and packet detail or hex dump + information, print the header before each summary line, and print + a blank line separating the summary line and the remaining + information. - * AUTHORS, packet-dcerpc.c: +2004-04-16 19:36 guy - Yaniv Kaul: show interface names - win32 only + * gtk/: color_dlg.c, color_filters.c, color_filters.h: -2004-03-03 22:24 guy + Make "new_color_filter()" take the background and foreground + colors, as GdkColors, as arguments. - * wiretap/: 5views.c, airopeek9.c, ascend.c, cosine.c, csids.c, - dbs-etherwatch.c, etherpeek.c, eyesdn.c, hcidump.c, lanalyzer.c, - libpcap.c, netmon.c, netxray.c, radcom.c, snoop.c, visual.c, - vms.c, wtap.c: +2004-04-16 19:05 guy - Have "wtap_read()" set "wth->phdr.pkt_encap" to - "wth->file_encap", rather than requiring individual capture file - type handlers to do it (unless they're doing per-packet - encapsulation, in which case we check to make sure they didn't - *leave* it as WTAP_ENCAP_PER_PACKET). + * gtk/color_filters.c: -2004-03-03 22:14 jmayer + You have to initialize a GtkColor structure before passing it to + "get_color()" - otherwise, GDK will allocate a color from the + colormap to match whatever random values happen to be there. - * AUTHORS, mergecap.c, doc/mergecap.pod: +2004-04-16 18:17 ulfl - Bill Guyton: mergecap can write to stdout by using the special - filename - + * file.c, print.c, tethereal.c, gtk/print_dlg.c: -2004-03-03 21:55 jmayer + make print dialog "Packet Format" options somewhat similar to the + Ethereal panes, thus better understandable - * epan/Makefile.am: +2004-04-16 05:30 ulfl - Jeff Morriss: Remove packet-ncp2222.c during maintainer-clean + * gtk/print_dlg.c: -2004-03-03 21:35 jmayer + bugfix: make the "no dissections" radiobutton insensitive, if + packet details isn't selected - * autogen.sh, configure.in, epan/configure.in, - wiretap/configure.in: +2004-04-15 23:28 guy - Require autoconf 2.53 and automake 1.6 + * cfile.h, file.c, gtk/find_dlg.c: -2004-03-03 02:06 guy + Rename a bunch of variables and routines that pertain to string + search with "string" rather than "ascii", to make it clearer what + they're involved with. - * xdlc.c: + Use "gtk_toggle_button_set_active()", not + "gtk_toggle_button_set_state()" (the latter is a deprecated alias + for the former, probably dating back to GTK+ 1.0[.x] - 1.2[.x] + and later have "gtk_toggle_button_set_active()"). - Don't show "func=" if the P/F bit isn't set. + Do *NOT* change the radio buttons for the type of string search + to do based on whether we're doing a string search or not - doing + so means we don't correctly remember the type of string search. - Don't put an extra space between "func=" and "P" or "F" if it is - set. + Get rid of code to fetch some values that we don't subsequently + use. -2004-03-03 01:49 guy +2004-04-15 22:38 obiot - * wiretap/eyesdn.c: + * packet-wbxml.c: - Set the packet encapsulation value to the file encapsulation. + Add two preferences to the WBXML dissector: - Control the + rendering of WBXML tokens to a media type token mapping. - + Control the dissection of the tokens that make up the WBXML body. + Both preferences are OFF by default. -2004-03-03 00:18 jmayer + Fix some comments as they did not reflect the current state + anymore. - * Makefile.am: +2004-04-15 19:56 ulfl - Return of the .PHONY target (aka cvsversion.h) + * print.c, print.h, gtk/print_dlg.c: -2004-03-03 00:07 jmayer + added print output option, to suppress dissection completely (for + raw packet hexdump) - * Makefile.am, epan/Makefile.am: +2004-04-15 19:05 ulfl - Jeff Morriss: Move generation of packet-ncp2222.c to epan to make - things work again + * print.c, gtk/print_dlg.c: -2004-03-02 23:53 jmayer + added print output of PDML format - * epan/configure.in: +2004-04-15 09:24 guy - Jeff Morriss: Add PYTHON to epans configure + * AUTHORS, packet-cops.c: -2004-03-02 23:45 jmayer + From Dick Gooris: PacketCable support in the COPS dissector. - * doc/README.plugins, plugins/asn1/packet-asn1.c, - plugins/irda/packet-irda.c, plugins/v5ua/packet-v5ua.c: +2004-04-15 08:34 sahlberg - Note to self: If you update the code, you should update the docs - too. + * packet-kerberos.c: - Update README.plugins to use ENABLE_STATIC instead of - __ETHEREAL_STATIC__ Update some plugins, that were created after - my changes according to the outdated docs. Changed occurrences - of G_MODULE_EXPORT void plugin_reg_handoff(void) into - G_MODULE_EXPORT void plugin_reg_handoff(void) + decryption and dissection of PA_ENC_TIMESTAMP - as the one line Python version doesn't work with the Python of - Suse 9.0 +2004-04-15 07:47 sahlberg -2004-03-02 22:15 obiot + * packet-kerberos.c: - * packet-wbxml.c: + dissect EncKDCRepPart applications 25 and 26 - Add Wireless Village dissection (part 1). I will have to rewrite - the support for custom EXT_T_x handlers as in WV-CSP you're - allowed to *not* have the index point to a string in the string - table (verified in WBXML specs). +2004-04-15 00:18 guy - Unfortunately, WV-CSP is *never* backwards compatible. - Additionally, things get messed up when the WBXML document does - *not* contain the WV-CSP DocType. As a result, I eventually - require to let the end-user choose which WV-CSP version they want - to see in such cases. + * packet-tcp.c: - Fix code page errors with global tokens (don't depend on code - pages). + Add some braces to squelch a GCC warning. - Add some comment at the top level of the file. +2004-04-14 22:13 obiot -2004-03-02 22:07 ulfl + * doc/README.plugins, plugins/acn/Makefile.am, + plugins/artnet/Makefile.am, plugins/asn1/Makefile.am, + plugins/ciscosm/Makefile.am, plugins/docsis/Makefile.am, + plugins/enttec/Makefile.am, plugins/giop/Makefile.am, + plugins/gryphon/Makefile.am, plugins/irda/Makefile.am, + plugins/lwres/Makefile.am, plugins/megaco/Makefile.am, + plugins/mgcp/Makefile.am, plugins/pcli/Makefile.am, + plugins/rdm/Makefile.am, plugins/rlm/Makefile.am, + plugins/rtnet/Makefile.am, plugins/rudp/Makefile.am, + plugins/v5ua/Makefile.am: - * capture.c, capture.h, gtk/capture_dlg.c, gtk/main.c: + Add support for plugin dissectors on cygwin builds, by adding the + following line to every Makefile.am file for a given plugin XXX: - implemented capture dialog 3rd (+x) proposal + XXX_la_LIBADD = -L../../epan -lethereal @GLIB_LIBS@ -2004-03-02 19:13 ulfl + This way symbols defined in libethereal and GLib are resolved + when linking the plugin dissector modules. - * gtk/capture_dlg.c: +2004-04-14 18:42 obiot - replaced all seperate gtk_widget_show() by a single - gtk_widget_show_all() call + * configure.in, epan/ftypes/Makefile.am, wiretap/configure.in: -2004-03-02 18:55 ulfl + At last compiling on CygWin works again! Added the missing PCRE + and GLIB libraries to libftypes. - * Makefile.nmake, epan/Makefile.nmake: + Provide caching of computed configure tests. - from Lars Roland: fix Makefiles.nmake after changes from Joerg +2004-04-14 05:46 ulfl -2004-03-02 03:46 jmayer + * file.c, gtk/capture_info_dlg.c: - * epan/Makefile.am: + two memory leaks removed - The sources of the plugin are now in ../oldpath/file.c +2004-04-14 04:45 etxrab -2004-03-02 01:48 jmayer + * packet-sip.c: - * epan/Makefile.common: + Correct the removal of spaces before parameters in the Content + type line, change some tags according to --sip-publish-03 - Move register.c from from DISSECTOR_SRC to DISSECTOR_SUPPORT_SRC - to avoid a circular dependency +2004-04-13 22:07 obiot -2004-03-02 01:39 jmayer + * packet-mmse.c: - * packet-postgresql.c: + Fix the default clause for not implemented MMS headers by adding + more generic code from WSP (based on the wkh_default() method). - Add a comment about PDU types + Add initial support for MMS 1.1 and MMS 1.2 (header names, PDU + types, response status codes, message status). -2004-03-02 01:21 jmayer + TODO: implement the *full* header dissections for MMS 1.1 and MMS + 1.2. - * Makefile.am, Makefile.common, Makefile.nmake, epan/Makefile.am, - epan/Makefile.common, epan/Makefile.nmake, epan/configure.in: +2004-04-13 21:32 guy - Move the dissectors into libethereal (no static/shared lib - changes): - Create epan/Makefile.common - Move dissector_src and - helper files from Makefile.common to epan/Makefile.common - - Create register.c in epan/ - link all the files into libethereal - - put plugin_src into epan/Makefile.am + * packet-gprs-llc.c: - Try to make rpms build with rpm v4 again (sorry, I've forgotten - who to attribute this to). + Use the "a_bit" true_false_string for the "llcgprs.as" field. -2004-03-01 22:39 jmayer +2004-04-13 21:29 guy - * packaging/rpm/SPECS/ethereal.spec.in: + * packet-sndcp.c: - Include shared libs if they exist + Change the decision tree for protocol and data compression so + that it doesn't test all four possibilities - with the old code, + GCC doesn't understand that one of the four possibilities must be + true, so it complains that "compression_field_item" might not be + set, but it does understand that with the new code. -2004-03-01 22:36 jmayer +2004-04-13 18:01 tuexen - * .cvsignore, epan/.cvsignore: + * capture.c, capture.h, file.c, gtk/capture_info_dlg.c: - Remove some obsolete _static files + From Jon Oberheide: Add interface name to the capture and + ethereal window while capturing. -2004-03-01 22:28 jmayer +2004-04-13 17:48 guy - * TODO: + * packet-gprs-llc.c: - Fix a typo + Get rid of some unused variables, as per Josef Korelus. -2004-03-01 09:11 sahlberg +2004-04-13 04:45 guy - * packet-ber.c: + * packet-sndcp.c: - Update to BER, dont do anything at all if there is no octet - string (length == 0) + Don't put blanks at the ends of strings added with + "col_add_fstr()", put them at the beginnings of strings appended + with "col_append_str()", so there won't be extra blanks at the + end. -2004-03-01 08:34 sahlberg +2004-04-13 04:36 guy - * packet-smb.c: + * AUTHORS, packet-sndcp.c, epan/Makefile.common: - Make the SMB dissector better at catching what is probably a - DCERPC payload inside Write commands and make sure the proper - things are stored in the hash so we remember what is and what is - not a IPC$ share ontop of which all file i/o is to dcerpc - interfaces. + From Christian Falckenberg: GPRS SNDCP support. -2004-02-29 10:41 ulfl +2004-04-13 04:21 guy - * gtk/: capture_dlg.c, find_dlg.c: + * AUTHORS, packet-bssgp.c, packet-gprs-llc.c, epan/Makefile.common: - improved resizability + From Josef Korelus: GPRS LLC support. -2004-02-29 09:02 guy +2004-04-13 04:04 guy - * packet-fcfcs.c: + * AUTHORS, packet-bpdu.c, packet-cisco-oui.c, doc/ethereal.pod: - From Dave Sclarsky: + From Clinton Work: dissect Cisco PID 0x010b as STP (it's actually + their own modified Per-VLAN STP, so there's some extra stuff at + the end of the packet that needs to be decoded). - fix the offset of the platform type; + Indicate in a comment in packet-cisco-oui.c what PVSTP is. - make the platform name an FT_BYTES field rather than an - FT_STRING field. +2004-04-12 22:14 guy -2004-02-29 08:47 guy + * packet-http.c: - * packet-isup.c, epan/column-utils.c, epan/packet_info.h: + Put in a comment noting a possible memory leak. - From Jeff Morriss: +2004-04-12 18:01 ulfl - support the ISUP CIC as a circuit ID; + * gtk/rtp_stream_dlg.c: - add a preference option to control whether to put the CIC - into - the Info column or not. + ESC key presses Close button -2004-02-29 08:30 guy +2004-04-12 09:48 ulfl - * packet-mtp3.c: + * gtk/: http_stat.c, rpc_progs.c, sip_stat.c, tcp_graph.c, + wsp_stat.c: - From Jeff Morriss: dissect the MTP3 routing label regardless of - whether we're building a protocol tree, so that the source and - destination addresses are set. + added a close button to the dialogs, use the dlg_window_new + function for all dialogs -2004-02-29 08:01 guy +2004-04-12 08:59 ulfl - * Makefile.common, ncp2222.py, packet-ncp-nmas.c, - packet-ncp-nmas.h, packet-ncp2222.inc: + * gtk/gsm_map_stat.c: - From Greg Morris: + added missing #include from my latest checkin - Novell Modular Authentication Services support; +2004-04-12 08:53 ulfl - fix some return values and decodes; + * gtk/: ansi_a_stat.c, ansi_map_stat.c, bootp_stat.c, + dcerpc_stat.c, fc_stat.c, gsm_a_stat.c, gsm_map_stat.c, + h225_counter.c, h225_ras_srt.c, http_stat.c, isup_stat.c, + ldap_stat.c, rpc_stat.c, smb_stat.c: - show the NDS reply buffer only in service request - packets. + added a close button to the dialogs, use the dlg_window_new + function for all dialogs -2004-02-28 22:56 guy +2004-04-12 07:10 ulfl - * etypes.h, packet-arp.c, packet-l2tp.c, packet-radius.c, - packet-srvloc.c, packet-wap.h, packet-wsp.c, packet-wtls.c, - packet-wtp.c: + * gtk/: endpoint_talkers_table.c, hostlist_table.c: - Update URLs for various IANA documents. + added a close button to the dialogs -2004-02-28 22:07 ulfl +2004-04-11 20:57 guy - * gtk/find_dlg.c: + * packet-aim.c: - redesign of the whole dialog + From Jon Oberheide: add the "Password Hash" label to + AIM_TLV_PASSWORD (0x0025) which was previously "Unknown". -2004-02-28 22:04 ulfl +2004-04-11 20:47 guy - * file.c: + * AUTHORS, packet-aim-signon.c, doc/ethereal.pod: - tweaked the simple_dialog texts, to reflect the current search - behaviour + From Jon Oberheide: add a missing hf[] entry for a field. -2004-02-28 21:55 guy + Fix up AUTHORS and the authors list in the Ethereal man page. - * gtk/main.c: +2004-04-10 09:10 ulfl - Default to not using the ring buffer (as the default number of - files is 1 file, i.e. the simple "just keep capturing until told - to stop" mode, you can't use a ring buffer). + * README.win32: -2004-02-28 20:59 guy + did lot's of cleanup to the text, especially in the library + sections - * epan/packet.c: +2004-04-10 07:29 ulfl - Not all dissector handles have protocols associated with them; - check for that before handing a null protocol handle to another - routine. + * Makefile.nmake: -2004-02-28 16:21 ulfl + Modify the "setup" target to download the packages we've defined, + so that we don't download the GTK1 packages unless we have + GTK1_DIR defined. - * capture.c, capture.h, gtk/capture_dlg.c, gtk/main.c: +2004-04-09 19:44 gerald - Capturing: "Number of files" switches between normal and multiple - mode, "Use ring buffer" switches between multiple single run and - real ring buffer + * gtk/follow_dlg.c: -2004-02-28 13:06 ulfl + Make the hex dump byte counter a guint32, so that we don't wrap + prematurely. - * gtk/capture_dlg.c: +2004-04-09 16:54 gerald - removed "magically" label switching of "Stop capture after x - kilobyte(s)" field, put it into seperate fields. + * Makefile.nmake, tools/win32-setup.sh: -2004-02-28 04:39 guy + Modify the "setup" target to download the packages we've defined, + so that we don't download the GTK2 packages unless we have + GTK2_DIR defined. - * prefs.c: + Fix some path checking in win32-setup.sh. - Select "misc" as the foundry for the default font, so we don't - get JIS fonts and the like when we pop up the font selection - dialog. +2004-04-09 09:15 guy -2004-02-28 04:21 guy + * packet-mq.c: - * gtk/filter_prefs.c: + From metatech: - Yes, you do have to free the display filter after compiling it, - otherwise you leak memory. + - No registration of port 1414, only the heuristics. -2004-02-28 04:18 guy + - More dissection of pre-defined MQ structures or + messages types + (MSH, DH, DLH, OR, RR, PMR, MDE, MQSET, MQINQ, MQPUT1, + PING). - * gtk/: filter_prefs.c, filter_prefs.h, find_dlg.c: +2004-04-09 08:39 guy - The string in the Find Frame dialog box isn't necessarily a - display filter string; check its syntax appropriately for the - type of search we're doing when colorizing it. + * packet-ipdc.c, packet-ipdc.h: - Searching for an empty text string is a pointless exercise; - report that as an error. + From Josh Bailey: -2004-02-27 19:07 ulfl + Fix missing handling for tags 0x6F and 0x70 (send and + receive + encoding type). - * gtk/: dcerpc_stat.c, fc_stat.c, file_dlg.c, find_dlg.c, - io_stat.c, ldap_stat.c, rpc_stat.c, smb_stat.c, - tap_dfilter_dlg.c: + Shorten fields displayed in COL_INFO. - added dfilter string syntax check to various places + Display information about all IPDC packets in COL_INFO if + there's more than one. -2004-02-27 15:51 obiot +2004-04-09 07:38 ulfl - * AUTHORS: + * Makefile.nmake: + + use the configured names from config.nmake for the required apps + list + +2004-04-09 07:37 ulfl - Bitwise AND display filter operation. + * README.win32: -2004-02-27 12:00 obiot + do some more explanations how to use the new library download + tool updated ADNS library version - * epan/: dfilter/README.dfilter, dfilter/dfvm.c, dfilter/dfvm.h, - dfilter/gencode.c, dfilter/grammar.lemon, dfilter/scanner.l, - dfilter/semcheck.c, dfilter/sttype-test.c, dfilter/sttype-test.h, - ftypes/ftype-bytes.c, ftypes/ftype-double.c, - ftypes/ftype-integer.c, ftypes/ftype-ipv4.c, ftypes/ftype-none.c, - ftypes/ftype-pcre.c, ftypes/ftype-string.c, ftypes/ftype-time.c, - ftypes/ftype-tvbuff.c, ftypes/ftypes.c, ftypes/ftypes.h: +2004-04-09 03:51 sahlberg - First attempt at "bitwise AND" display filter operator. + * packet-h225.c: - Document how a display operator can be added. + even more h235 dissection -2004-02-27 10:03 sahlberg +2004-04-09 03:32 sahlberg - * gtk/tcp_graph.c: + * packet-h225.c: - cosmetic update to tcp graphs. + some more h235 dissection - Put both capture filename and x.x.x.x:x -> y.y.y.y:y describing - the tcp session we are currently graphing in the menu text of the - window. +2004-04-09 01:07 sahlberg -2004-02-27 09:25 guy + * packet-h225.c: - * packet-gtp.c: + Add dissection of AuthenticationMechanism to h235 - Fix up the previous checkin. +2004-04-09 00:31 sahlberg -2004-02-27 09:02 guy + * packet-per.h: - * packet-sna.c: + Make it more obvious when ethereal fails to dissect a PER + contruct - Have "dissect_control()" construct the subset tvbuff it - processes, and have it set the length and reported length - appropriately. + 1, put a hint why it failed in the COL_INFO line 2, abort + dissecting any further (by reading from the arbitrary position + 9999 in the tvb 3, put "something unknown here [xxx]" as the last + entry in the tree. -2004-02-26 12:02 sahlberg +2004-04-08 23:52 sahlberg - * packet-ber.c: + * packet-h225.c: - Small change to the octet string dissector for BER. + implement some basic dissection of H.235 ClearToken so that the + capture reported on the list will be dissected properly. - make it create a new tvb and pass it to the callback so that the - callback can pick up the length of the octet string by doing a - tvb_length_remaining(tvb, 0); + maybe someone should break out all the h.235 code sometime later + and put it in packet-h235.c? -2004-02-26 09:48 guy +2004-04-08 20:36 gerald - * packet-mtp3.c: + * Makefile.nmake, README.win32, config.nmake, tools/win32-setup.sh: - From Jeff Morris: re-add support for WTAP_ENCAP_MTP3, lost in the - previous checkin. + Add a Makefile.nmake target called "setup" that uses the script + tools\win32-setup.sh to -2004-02-26 09:39 guy + - Check for applications required to build Ethereal + - Download and unpack required packages into $ETHEREAL_LIBS - * acinclude.m4: + Update ADNS to the latest version. + + Make Python 2.3 the default. - From Albert Chin: libpcap 0.8.1 loads the BPF driver on AIX, but - to do so it requires routines from -lcfg and -lodm - if - attempting to link with libpcap fails, try linking with libpcap - and -lcfg and -lodm and, if that succeeds, add all those - libraries to the link list. +2004-04-08 19:07 ulfl -2004-02-25 23:15 guy + * gtk/capture_dlg.c: - * packet-afp.c: + catch the enter key from the interface drop-down list, so + pressing enter will really start a capture - Use "tvb_get_string()" rather than duplicating its functionality - by hand. +2004-04-08 10:21 sahlberg - Clean up "name_in_bitmap()" a bit. + * packet-dcerpc-netlogon.c: - In "loop_record()", don't bother allocating a buffer for the tag - used if there's no name for the item. + update to netlogon: make it dissect all the bits of the + UserAccountControl flags field in the pac structure and elsewhere + in netlogon -2004-02-25 23:13 guy +2004-04-08 09:34 sahlberg - * packet-sna.c: + * packet-dcerpc-netlogon.c: - Use "tvb_get_string()" rather than duplicating its functionality - by hand. + dissection of netlogon userflags in tha pac structure and + elsewhere - In "dissect_control_0e()", use the remaining reported length in - the tvbuff rather than the length. +2004-04-08 09:17 sahlberg -2004-02-25 23:12 guy + * packet-dcerpc-netlogon.c: - * packet-x11.c: + dissect group attributes for the pac structure and other places + in netlogon - Make sure the keysym list is present before allocating a buffer - to hold it. +2004-04-08 08:05 guy -2004-02-25 23:11 guy + * gtk/capture_dlg.c: - * packet-quake2.c: + On Windows, when looking for the ":" that separates the interface + description from the interface name, don't count ":" followed by + "//", as it might be part of "rpcap://". - Use "tvb_get_string()" instead of duplicating its functionality - by hand. +2004-04-08 05:19 sahlberg - Don't make a copy of the message in - "dissect_quake2_client_commands_uinfo()" and - "dissect_quake2_client_commands_stringcmd()", just use the copy - in the tvbuff. + * doc/ethereal.pod: -2004-02-25 22:45 guy + update doc with better description of SUM/COUNT/MIN/MAX/AVG. - * doc/README.developer: +2004-04-08 05:09 sahlberg - Describe some problems with processing data pointed to by the - result of "tvb_get_ptr()". + * packet-tcp.c: - Add a section on roubustness, giving a number of potential - problems that aren't just portability problems. + update tcp so that it will print the string "(relative + sequence/ack number)" in the header for the fields affected by + using human readable sequence and ack numbers. - Document "tvb_get_string()" and "tvb_get_stringz()", better - document "tvb_memcpy()" and "tvb_memdup()". +2004-04-07 06:18 guy - Fix a typo. + * packet-ipmi.c: -2004-02-25 21:05 guy + From Duncan Laurie: the LUN field in IPMI packets is only in the + lower 2 bits. - * gtk/follow_dlg.c: +2004-04-07 06:04 guy - Get rid of a debugging printf. + * etypes.h, packet-eapol.c, packet-ethertype.c: -2004-02-25 17:44 ulfl + From Jouni Malinen: add support for the 802.11i/RSN + pre-authentication Ethertype. - * gtk/menu.c: +2004-04-07 04:31 sahlberg + + * gtk/: rpc_stat.c, service_response_time_table.c: + + make service response time statistics work for "unknown" rpc + programs. all proicedures will however get "interesting" names + such as "proc-1" etc except procedure 0 which is ALWAYS "NULL" + +2004-04-07 03:57 sahlberg - Seperated the "Go" menu, corresponding to: - http://developer.gnome.org/projects/gup/hig/1.0/menus.html#menu-standard-go + * packet-rpc.c: -2004-02-25 09:31 guy + when dealing with unknown rpc programs, create a fake + program/version/procedure table so that we can get service + response time tables working later. - * packet-atalk.c, packet-dcerpc-mapi.c, packet-dhcpv6.c, - packet-dsi.c, packet-enip.c, packet-gtp.c, packet-icmpv6.c, - packet-ieee80211.c, packet-nfs.c, packet-nlm.c, packet-ntlmssp.c, - packet-rpc.c, packet-rtcp.c, packet-telnet.c, packet-vj.c, - packet-wsp.c, packet-x11.c, packet-xdmcp.c: +2004-04-06 19:02 ulfl - Use "tvb_get_string()" instead of allocating a (len+1)-sized - buffer, "tvb_memcpy()"ing to it, and putting in a null - terminator; "tvb_get_string()" will check whether all bytes of - the string are present before allocating the buffer, so that you - don't leak memory if the copy throws an exception, and don't - crash if the length is absurdly large. + * AUTHORS, prefs.c, prefs.h, doc/ethereal.pod, gtk/gui_prefs.c, + gtk/main.c: + + from Thomas Palmer: add a preference setting for filter toolbar + placement + +2004-04-06 16:08 gerald + + * gtk/main.c: - Use "tvb_memdup()" instead of allocating a buffer and - "tvb_memcpy()"ing to it, so that an exception is thrown before - you try to allocate the buffer (for the same reasons as listed - above). + Remove an extraneous 'break'. - Before allocating a buffer used when processing a chunk of data - from a packet, get a pointer to the chunk with "tvb_get_ptr()", - or check that the data is all there with - "tvb_ensure_bytes_exist()", so that an exception is thrown before - you try to allocate the buffer (for the same reasons as listed - above). +2004-04-05 00:49 sahlberg - Fix up the lengths of the tvbuff used when dissecting ONC RPC - opaque data with a particular dissector. + * packet-kerberos.c: + + Add support to decrypt the encrypted part of AS/TSG -REP PDUs. + Now we only need application 25/26 to be dissected as well for it + to be useful ... -2004-02-25 07:52 sahlberg +2004-04-05 00:28 sahlberg * packet-kerberos.c: - for netbios type addresses in kerberos print the netbios type as - hex and not decimal + Added some more principal name types from the kerberos draft + +2004-04-04 07:12 sahlberg + + * AUTHORS, doc/ethereal.pod: + + Love contributed great help to get the heimdal decryption support + working (wherein we also discovered an obscure bug inside heimdal + itself) Great thanks to Love. + +2004-04-03 22:33 etxrab + + * packet-sip.c: + + As pointed out by Chernishov Yury - strip of leading spaces of + parameters + +2004-04-03 22:13 etxrab + + * packet-isup.c, AUTHORS: + + From Chernishov Yury Don't destroy SIP dissector entrys in info + column for application/isup + +2004-04-03 03:50 guy + + * packet-smb-common.c: + + In "get_unicode_or_ascii_string()", treat a negative length + argument as a very large unsigned integer (which it probably is), + and trim it at INT_MAX, and fix the handling of too-long ASCII + strings so that the "..." gets inserted. Make sure that all the + bytes of the string exist before truncating the string length to + the buffer length, so that the appropriate exception is thrown. -2004-02-25 06:22 guy +2004-04-03 00:29 sahlberg + + * packet-rpc.c: + + Add a new preference option so that users that really really want + to can tell ethereal "I dont care if the heuristics are too weak" + "I want to see the ONC-RPC layer for these weird protocols that + are not known to ethereal" "If I get a lot of false positives + it is my own fault and I will not complain" + + This allows ethereal to dissect the rpc layer (and do + request/response matching) even for those onc-rpc protocols that + ethereal doesnt know about yet. + +2004-04-02 22:01 sahlberg + + * packet-spnego.c: + + If the packet is short, dont try to create a blob item that + spans beyound the end of the short packet since that will raise + an exception and we wont even attempt to dissect those (kerberos + usually) bytes that we do have in the packet. + +2004-04-02 21:38 sahlberg * packet-smb.c: - Dissect FILE_RENAME_INFO. + dont bail out just because we dont have the entire security blob + present in a pdu. even for short frames, try to pass on as mush + as possible to gssapi. - Combine the dissection for 0x0101 and 1004 in Set File Info. +2004-04-02 09:04 guy -2004-02-25 05:52 guy + * epan/column-utils.c: - * ringbuffer.c: + From Olivier Biot: support AT_STRINGZ columns. - Only handle as a suffix stuff following a "." in the last - component of a pathname. +2004-04-02 08:27 guy -2004-02-25 05:21 guy + * wiretap/: nettl.c, nettl.h: - * ringbuffer.c: + From Mark C. Brown: add support for FDDI and Token Ring cards. - Don't unlink ringbuffer files if we haven't yet allocated the - array of ringbuffer files - yes, we can fail before that's done, - so we have to check for that. + Set the file encapsulation the same way it's done for iptrace + captures - leave it as "unknown" to start with, and, for each + packet we see, set it to the packet's encapsulation type if the + file encapsulation type is unknown and set it to "per-packet" if + the file encapsulation type is "known" but isn't the type of that + packet, so files that have all the same type of packet have that + type as the file type and packets that *don't* have all the same + type of packet have "per-packet". -2004-02-25 00:16 ulfl +2004-04-02 07:59 guy - * gtk/io_stat.c: + * packet-aim-messaging.c: - changed some labels + From Devin Heitmueller: do a better job of decoding the AIM + messaging SNAC for outgoing and incoming subtypes. -2004-02-24 23:25 ulfl +2004-04-02 07:40 guy - * gtk/io_stat.c: + * wiretap/eyesdn.c: - minor redesign of the dialog + From Rolf Fiedler: fix a comment, and fix the code to get the + packet length. -2004-02-24 19:42 ulfl +2004-04-02 07:28 guy - * README.win32: + * AUTHORS, packet-ymsg.c: + + From Devin Heitmueller: do YMSG desegmentation. + +2004-04-02 05:19 guy + + * packet-isup.c: + + Get rid of an extra "=" at the end of the file. + +2004-04-02 05:07 guy + + * packet-diameter-defs.h: + + Get rid of CRs. + +2004-04-01 20:34 etxrab + + * packet-isup.c: + + Fix a copy paste error + +2004-04-01 09:15 sahlberg + + * packet-kerberos.c: + + add dissection of the canonicalize bit which some windows clients + use + +2004-03-31 21:04 guy + + * packet-isup.c: + + Get rid of CR's. + +2004-03-31 20:57 guy + + * packet-radius.c: + + Get rid of CR's. + +2004-03-31 20:25 etxrab + + * packet-radius.c: + + Add RADIUS AVP 101, the value string to go with it and some ACC + vendor AVP:s + +2004-03-31 20:23 etxrab + + * packet-isup.c: + + Add dissection of user to user indicators parameter, Split some + lines and some white space changes + +2004-03-31 01:31 jmayer + + * TODO: + + configure.in merging has been done. Add another point + +2004-03-31 01:25 jmayer + + * epan/: acinclude.m4, configure.in: + + No longer needed after merging epan/configure.in into + configure.in + +2004-03-30 20:56 etxrab + + * packet-diameter-defs.h: - added a new section "Installing GTK-Wimp" + Fixed some cut-and-paste errors, added some RADIUS AVPS sorted + some value string... -2004-02-24 18:54 guy +2004-03-30 19:37 guy + + * packet-smb-mailslot.c, wiretap/wtap.c: + + From Albert Chin: "config.h" should come before all other + #includes. + +2004-03-30 19:36 guy + + * plugins/rudp/packet-rudp.c: + + From Albert Chin: the Sun WorkShop 5.0 compiler and HP-UX 10.20 + compiler don't allow you to initialize aggregates with an + initializer that includes non-constant values. + +2004-03-30 19:34 guy * Makefile.am: - Add "make-version.pl" to the distribution. + From Albert Chin: on IRIX, if -la depends on -lb, you must link + with -lb -la. -2004-02-24 18:51 ulfl +2004-03-30 19:15 guy - * config.nmake, packaging/nsis/Makefile.nmake, - packaging/nsis/ethereal.nsi: + * packet-eapol.c: - added gtk-wimp to the nsis installer build + From Jouni Malinen: add support for the most likely EAPOL-Key + packet type. -2004-02-24 18:44 ulfl +2004-03-30 19:07 guy - * README.win32: + * config.guess, config.sub: - updated some things (optional packages, nsis, gtk-wimp) + Back out the previous change, as it checked in older versions of + config.guess and config.sub. -2004-02-24 18:39 ulfl +2004-03-30 19:01 guy - * gtk/gui_prefs.c: + * packet-3g-a11.c: - changed some label texts + From Ryuji Somegawa: fix AirLink record dissection. -2004-02-24 18:23 guy +2004-03-30 18:55 guy - * packet-dcerpc-rs_pgo.c: + * AUTHORS, Makefile.common, packet-sip.c, tap-sipstat.c, + gtk/sip_stat.c: - From Jaime Fournier: more bug fixes. + From Lars Roland: Tethereal version of SIP statistics tap, and + fixes to the Ethereal version. -2004-02-24 17:59 ulfl +2004-03-30 18:45 guy - * gtk/compat_macros.h: + * plugins/Makefile.nmake: - fixed some GTK2 stock items keyboard shortcuts + From Lars Roland: have "make clean" and "make distclean" clean up + the new Cisco VoIP plugins. -2004-02-24 17:57 ulfl +2004-03-30 18:30 guy - * gtk/menu.c: + * plugins/: ciscosm/packet-sm.c, rlm/packet-rlm.c, + rudp/packet-rudp.c: - fixed some menu item capitalization and keyboard shortcuts + From Duncan Sargeant: include "moduleinfo.h" so that the plugins + get the right version number. -2004-02-24 17:53 ulfl +2004-03-30 18:23 guy - * gtk/io_stat.c: + * packet-radius.c: - added a "Close" button to the dialog + From Michael Kopp: add support for vendor-specific items for the + Cisco VPN 3000 Concentrator, Cisco VPN 5000 Concentrator and + Cisco Broadband Service Manager. -2004-02-24 17:49 ulfl +2004-03-30 18:14 guy - * packet-clnp.c, packet-mdshdr.c, packet-tcp.c, - help/capture_filters.txt, help/capturing.txt, - help/display_filters.txt, help/getting_started.txt, - help/well_known.txt: + * packet-gtp.c: - fixed various typos + The extension ID field in a Private Extension IU is 2 bytes, so + the length of the IU must be at least 2 bytes in order to dissect + the contents. -2004-02-24 09:40 sahlberg + Just use "proto_tree_add_item()" to add the value of the private + extension, and do so only if it's not zero-length. - * packet-nbns.c, packet-tcp.c, epan/packet.c: +2004-03-30 17:52 guy - with the cahnges to when to call the heuristic dissector (and the - fact that nbss does not register its conversation) this caused - WANT_PDU_TRACKING to be decremented multiple times between the - dissectors and thus ethereal could no longer reliably spot SMB - PDUs that started in the middle of a tcp segment (unless we do - reassembly which we dont do unless we have to since it eats soo - many resources) + * packet-mip6.c: - FIX so that ethereal once again can spot SMB (and other) protocol - PDUs that start in the middle of a segment. + Fix the length used for the protocol tree item for Mobile IPv6 + options. -2004-02-24 08:05 guy +2004-03-30 17:38 guy - * packet-dcerpc-rs_pgo.c: + * packet-aim-location.c: - From Jaime Fournier: bug fixes. + From Devin Heitmueller: put back the info level for the user info + request. -2004-02-24 05:52 guy +2004-03-30 07:39 sharpe - * gtk/capture_dlg.c: + * config.guess, config.sub, packet-dcerpc-lsa.c, + packet-dcerpc-samr.c, packet-dcerpc-spoolss.c, + packet-dcerpc-svcctl.c, packet-smb-common.h, packet-smb.c: - Small cleanup - the for loop was left over from earlier code that - kept searching backwards for a backslash until it found one - followed by "Device\", and no longer looped. + Add the mask for an NT ACL ACE to the summary list for each ACE. + This means we don't have to expand the ACE to see what the + permission mask is. -2004-02-24 02:45 gerald + There are a couple of other places where this could be used, but + I have not done anything about them. - * NEWS: +2004-03-29 23:14 guy + + * gtk/dlg_utils.c: + + It *appears* that if you don't explicitly request that a file + chooser dialog be centered on its parent, it still gets so + centered; we remove the call to do so from the GTK+ >= 2.4 file + selection dialog creation code. + +2004-03-29 23:03 guy + + * gtk/dlg_utils.c: + + In a "save" dialog, the "yes" button should be a "Save" button, + not an "Open" button. + +2004-03-29 22:55 guy + + * gtk/: dlg_utils.c, dlg_utils.h, file_dlg.c: + + Add another wrapper routine, "file_selection_set_extra_widget()", + to set the "extra options" portion of a file selection dialog, + and use it rather than #if'ed code. + +2004-03-29 22:40 guy + + * gtk/: capture_dlg.c, dlg_utils.c, dlg_utils.h, file_dlg.c, + follow_dlg.c, print_prefs.c: + + Make "file_selection_new()" take as its second argument an + Ethereal-defined indication of the action (open vs. save), + regardless of whether we're building for GTK+ >= 2.4 or not; we + just ignore the argument in pre-2.4 GTK+. + + Use "file_selection_new()" rather than #if'ed code to use it or + "gtk_file_chooser_dialog_new()" for GTK+ >= 2.4 and + "gtk_file_selection_new()" or it for pre-2.4 GTK+. + + Add a "file_selection_set_current_folder()" routine that does the + appropriate thing depending on whether we're GTK+ >= 2.4 or not, + and use that rather than #if'ed code to use + "gtk_file_chooser_set_current_folder()" or + "gtk_file_selection_set_filename()". + +2004-03-28 00:26 guy + + * packet-eapol.c: + + From Jouni Malinen: + + Small changes for EAPOL-Key dissector for IEEE + 802.11i/RSN: + - add Encrypted Key Data flag for key info + - do not try to parse EAPOL-Key Key Data if it is + encrypted + (RSN: Encrypted Key Data flag, WPA: Group Key) + - Key Index and Key ID are reserved in RSN + +2004-03-27 12:18 ulfl + + * gtk/: capture_dlg.c, file_dlg.c: + + minor code cleanup, including removed MSVC warnings + +2004-03-27 12:14 jmayer + + * aclocal-fallback/: glib-2.0.m4, glib.m4, gtk-2.0.m4, gtk.m4: + + Fix some aclocal warnings during autogen.sh + +2004-03-27 12:07 jmayer + + * acinclude.m4, wiretap/acinclude.m4: + + Some aclocal warning fixes during autogen.sh + +2004-03-27 11:53 guy + + * packet-tcp.c: + + From Ronnie Sahlberg: RST and FIN segments are neither + zero-window packets nor duplicate ACKs. + +2004-03-27 11:52 jmayer + + * autogen.sh, configure.in: + + OK, I'm impatient. In case of problems, I'm to blame, not + Olivier. + + Olivier Biot: Merge epan/configure.in back into configure.in + Leave epan/confiugre.in and epan/acinclude.m4 in case we need to + undo this. + +2004-03-27 11:33 guy + + * process-x11-fields.pl: + + From Gisle Vanem: add a "this is a generated file" comment to the + output of process-x11-fields. + +2004-03-27 11:32 guy + + * AUTHORS, Makefile.common, packet-ansi_801.c, packet-ansi_a.c, + packet-ansi_map.c, packet-gsm_map.c, packet-gsm_sms.c, + packet-gsm_sms.h, packet-gsm_ss.c, packet-gsm_ss.h, + epan/Makefile.common: + + From Michael Lum: + + ANSI IS-801 support; + + dissect more GSM supplementary services messages and + fields. + +2004-03-27 11:16 oabad + + * gtk/: capture_dlg.c, dlg_utils.c, dlg_utils.h, file_dlg.c, + follow_dlg.c, print_prefs.c: + + Use the new GtkFileChooserDialog when built with gtk+ 2.4 + +2004-03-27 11:16 guy + + * wiretap/: nettl.c, nettl.h: + + From Mark C. Brown: add support for iether (dual-port gigabit) + cards in nettl files. + +2004-03-27 11:13 guy + + * gtk/: bootp_stat.c, h225_counter.c, h225_ras_srt.c, http_stat.c, + mgcp_stat.c, sip_stat.c, wsp_stat.c: + + From Lars Roland: use the generic filter dialog for the SIP, + HTTP, WSP, and BOOTP taps. + + Get rid of the "dlg" variable in some of those taps - it's never + set, so it's always null, and nothing useful is done with it if + it's null. - Add a missing line. + Make static some variables and functions not used outside the + source file in which they're defined. |