diff options
| author | kkoizumi <kkoizumi46@gmail.com> | 2016-02-27 00:47:30 +0900 |
|---|---|---|
| committer | Pascal Quantin <pascal.quantin@gmail.com> | 2016-02-26 18:37:43 +0000 |
| commit | 9b34763e22471de6ddb790c3aeb1c00043bb9674 (patch) | |
| tree | 9a70ea1e732f7b0a8bb92c0e5d4f862ee645e50d | |
| parent | 83a9aadf3c910348d2c212d06398415ccceae2a1 (diff) | |
| download | wireshark-9b34763e22471de6ddb790c3aeb1c00043bb9674.tar.gz wireshark-9b34763e22471de6ddb790c3aeb1c00043bb9674.tar.bz2 wireshark-9b34763e22471de6ddb790c3aeb1c00043bb9674.zip | |
tcp_stream_dialog: Integer overflow in Average Throughput
Overflow occurs in the TCP Stream Graphs window when Average Throughput exceeds 20-30 Gbps.
* Screenshot examples
https://raw.githubusercontent.com/koizumi-k/pub/master/misc/stream1-current-win64.png
https://raw.githubusercontent.com/koizumi-k/pub/master/misc/stream2-current-win64.png
Change-Id: I4e557fdeae659ef27b986fca18c74cc8983fe4d3
Reviewed-on: https://code.wireshark.org/review/14163
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
(cherry picked from commit 0b3544083e89abd38443cff4691d9fc616ccf995)
Reviewed-on: https://code.wireshark.org/review/14169
| -rw-r--r-- | ui/qt/tcp_stream_dialog.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/qt/tcp_stream_dialog.cpp b/ui/qt/tcp_stream_dialog.cpp index 9f3fa9d91c..3df3f27c00 100644 --- a/ui/qt/tcp_stream_dialog.cpp +++ b/ui/qt/tcp_stream_dialog.cpp @@ -644,7 +644,7 @@ void TCPStreamDialog::fillThroughput() QVector<double> rel_time, seg_len, tput_time, tput; int oldest = 0; - int sum = 0; + guint64 sum = 0; // Financial charts don't show MA data until a full period has elapsed. // The Rosetta Code MA examples start spitting out values immediately. // For now use not-really-correct initial values just to keep our vector |