diff options
| author | Guy Harris <guy@alum.mit.edu> | 2003-12-23 01:22:52 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2003-12-23 01:22:52 +0000 |
| commit | 5b3d2e36e46051212e3c5fa99d5fa1b48eb066a2 (patch) | |
| tree | 7ab8a92d328a096c36f2d030cd8ceb975f7d5cff | |
| parent | b136fc75120400a97b847f855c4df2e67c0f42c1 (diff) | |
| download | wireshark-5b3d2e36e46051212e3c5fa99d5fa1b48eb066a2.tar.gz wireshark-5b3d2e36e46051212e3c5fa99d5fa1b48eb066a2.tar.bz2 wireshark-5b3d2e36e46051212e3c5fa99d5fa1b48eb066a2.zip | |
Note that we should handle the Content-Length entity header.
svn path=/trunk/; revision=9424
| -rw-r--r-- | packet-http.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/packet-http.c b/packet-http.c index 13d7925da4..54c5ac6fab 100644 --- a/packet-http.c +++ b/packet-http.c @@ -6,7 +6,7 @@ * Copyright 2002, Tim Potter <tpot@samba.org> * Copyright 1999, Andrew Tridgell <tridge@samba.org> * - * $Id: packet-http.c,v 1.77 2003/12/22 00:57:33 guy Exp $ + * $Id: packet-http.c,v 1.78 2003/12/23 01:22:52 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -447,6 +447,18 @@ dissect_http(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) } } + /* + * XXX - if there was a Content-Length entity header, we should + * use its value, as there might be stuff in this tvbuff + * past the end of the body. + * + * If there was no Content-Length entity header, we should + * accumulate all data until the end of the connection. + * That'd require that the TCP dissector call subdissectors + * for all frames with FIN, even if they contain no data, + * which would require subdissectors to deal intelligently + * with empty segments. + */ datalen = tvb_length_remaining(tvb, offset); if (datalen > 0) { tvbuff_t *next_tvb = tvb_new_subset(tvb, offset, -1, -1); |