diff options
| author | Harald Welte <laforge@osmocom.org> | 2020-09-11 22:14:05 +0200 |
|---|---|---|
| committer | Pascal Quantin <pascal@wireshark.org> | 2020-09-12 00:11:55 +0200 |
| commit | a517d9578f1c413011661f48c85d66af84b56140 (patch) | |
| tree | eec67f700ae70ec1ab592980e432fb9bf48e4775 | |
| parent | da1d6317968ce7259efacdfbf819d5b907cd99c6 (diff) | |
| download | wireshark-a517d9578f1c413011661f48c85d66af84b56140.tar.gz wireshark-a517d9578f1c413011661f48c85d66af84b56140.tar.bz2 wireshark-a517d9578f1c413011661f48c85d66af84b56140.zip | |
Q.933: Fix decoding of PVC Status field
This field is actually a bitmask of four bits. It's somewhat odd
to decode it using a value_string. In any case, the values were
plain wrong (shifted to the left by '1').
See Figure A.3 of ITU-T Q.933
A related pcap file can be found at
https://people.osmocom.org/laforge/pcap/gsmtap-fr-q933-pvc_status.pcap
(cherry picked from commit 13ac47ad4ecdf9ce4363d89f15a245fc10c3c67e)
| -rw-r--r-- | epan/dissectors/packet-q933.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/epan/dissectors/packet-q933.c b/epan/dissectors/packet-q933.c index f33680a1ea..dc375709b2 100644 --- a/epan/dissectors/packet-q933.c +++ b/epan/dissectors/packet-q933.c @@ -1119,9 +1119,10 @@ dissect_q933_link_integrity_verf_ie(tvbuff_t *tvb, int offset, int len, */ static const value_string q933_pvc_status_vals[] = { {0x00, "Inactive"}, - {0x02, "Active"}, - {0x08, "New"}, - {0x0a, "New, Active"}, + {0x01, "Active"}, + {0x02, "Deleted"}, + {0x04, "New"}, + {0x05, "New, Active"}, {0, NULL} }; |