aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2005-09-21 14:20:43 +0000
committerGerald Combs <gerald@wireshark.org>2005-09-21 14:20:43 +0000
commit551b9bc61d50fa9dba8180bc380d81cc9da6e278 (patch)
treef122bb2257762582cdeff43258ea966ef1f13e15
parent85ae3a808668f783a820c642b86d375af5cc1b77 (diff)
downloadwireshark-551b9bc61d50fa9dba8180bc380d81cc9da6e278.tar.gz
wireshark-551b9bc61d50fa9dba8180bc380d81cc9da6e278.tar.bz2
wireshark-551b9bc61d50fa9dba8180bc380d81cc9da6e278.zip
Free our flow graph strings when we're done with them. Add a note about
flow graphs to the release notes, along with other stuff. svn path=/trunk/; revision=15928
-rw-r--r--docbook/release-notes.xml26
-rw-r--r--gtk/graph_analysis.c11
2 files changed, 33 insertions, 4 deletions
diff --git a/docbook/release-notes.xml b/docbook/release-notes.xml
index a0e39ccfc2..f81f8c44fa 100644
--- a/docbook/release-notes.xml
+++ b/docbook/release-notes.xml
@@ -67,7 +67,8 @@ Gnu info
<section id="WhatsNew"><title>What's New</title>
<section><title>Bugfixes</title>
<para>
- The following bugs have been fixed since the previous release:
+ The following security vulnerabilities have been fixed since the
+ previous release:
<itemizedlist>
<listitem><para>
@@ -168,6 +169,10 @@ Gnu info
</para>
<para>
+ When trying to save a flow graph, Ethereal could crash.
+ </para>
+
+ <para>
The PCRE library that ships with the Windows installer has been upgraded
from version 4.4 to 6.3 in response to a
<ulink url="http://www.securityfocus.com/bid/14620">security
@@ -215,6 +220,10 @@ Gnu info
by Ethereal.
</para></listitem>
+ <listitem><para>
+ Ethereal's memory managment has been greatly improved.
+ </para></listitem>
+
</itemizedlist>
</para>
</section>
@@ -258,11 +267,12 @@ Gnu info
</section>
+ <!-- XXX needs to be written
<section id="RemovingEthereal"><title>Removing Ethereal</title>
<para>
- <!-- XXX needs to be written -->
</para>
</section>
+ -->
<section id="FileLocations"><title>File Locations</title>
<para>
@@ -285,13 +295,21 @@ Gnu info
<section id="GettingHelp"><title>Getting Help</title>
<para>
- <!-- XXX needs to be written -->
+ Community support is available on the ethereal-users mailing list.
+ Subscription information and archives for all of Ethereal's mailing
+ lists can be found on <ulink url="http://www.ethereal.com/lists">the
+ web site</ulink>. There is also an <ulink url="irc://irc.freenode.net/ethereal">IRC channel dedicated to Ethereal</ulink>.
+ </para>
+ <para>
+ Commercial support, training, and development services are available
+ from <ulink url="http://www.etherealsoft.com/">Ethereal Software</ulink>.
</para>
</section>
<section id="FAQ"><title>Frequently Asked Questions</title>
<para>
- <!-- XXX needs to be written -->
+ A complete FAQ is available on the
+ <ulink url="http://www.ethereal.com/faq.html">Ethereal web site</ulink>.
</para>
</section>
diff --git a/gtk/graph_analysis.c b/gtk/graph_analysis.c
index f8dfa0a418..2e1e4a046b 100644
--- a/gtk/graph_analysis.c
+++ b/gtk/graph_analysis.c
@@ -261,6 +261,11 @@ static void overwrite (GString *gstr, char *text_to_insert, guint32 p1, guint32
}
+/*
+ * XXX - We might want to refactor this to write the graph data directly to
+ * the file instead of loading everything into strings first.
+ */
+
/****************************************************************************/
static gboolean dialog_graph_dump_to_file(graph_analysis_data_t* user_data)
{
@@ -447,6 +452,12 @@ static gboolean dialog_graph_dump_to_file(graph_analysis_data_t* user_data)
fprintf(of,"%s\n",tmp_str->str);
}
+ g_string_free(label_string, TRUE);
+ g_string_free(empty_line, TRUE);
+ g_string_free(separator_line, TRUE);
+ g_string_free(tmp_str, TRUE);
+ g_string_free(tmp_str2, TRUE);
+
fclose (of);
return TRUE;