tools/wireshark/ws_diag_control.h, branch master

Add an include sub-directory to the tree

2021-11-12T17:33:13+00:00

Blind attempt to fix Debian package brokenness managing
headers separately from install rules.

Global public headers that don't fit any of the Wireshark
libraries should be placed in include/.

Eventually the C files in the root dir should be placed somewhere
else as well (like src/) but this is not a priority.

Fixes #17726.

text_import: just suppress the two-initializers warning.

2021-03-27T21:00:44+00:00

Stick with the simpler "init everything to invalid, and then override
that" mechanism, and just turn off the warning for thse structures.

wiretap: have file handlers advertise blocks and options supported.

2021-02-21T23:18:35+00:00

Instead of a "supports name resolution" Boolean and bitflags for types of
comments supported, provide a list of block types that the file
type/subtype supports, with each block type having a list of options
supported.  Indicate whether "supported" means "one instance" or
"multiple instances".

"Supports" doesn't just mean "can be written", it also means "could be
read".

Rename WTAP_BLOCK_IF_DESCRIPTION to WTAP_BLOCK_IF_ID_AND_INFO, to
indicate that it provides, in addition to information about the
interface, an ID (implicitly, in pcapng files, by its ordinal number)
that is associated with every packet in the file.  Emphasize that in
comments - just because your capture file format can list the interfaces
on which a capture was done, that doesn't mean it supports this; it
doesn't do so if the file doesn't indicate, for every packet, on which
of those interfaces it was captured (I'm looking at *you*, Microsoft
Network Monitor...).

Use APIs to query that information to do what the "does this file
type/subtype support name resolution information", "does this file
type/subtype support all of these comment types", and "does this file
type/subtype support - and require - interface IDs" APIs did.

Provide backwards compatibility for Lua.

This allows us to eliminate the WTAP_FILE_TYPE_SUBTYPE_ values for IBM's
iptrace; do so.

wiretap: Convert ascend.y to Lemon.

2020-11-30T08:15:43+00:00

Convert wiretap/ascend.y.in from Bison/YACC to Lemon and rename it to
wiretap/ascend_parser.lemon. Tighten up some of our scanning and
parsing. Make the indentation in it and related files consistent. Aside
from the recent IPv4 fragment offset changes, this produces identical
output to the 3.4 branch for the Ascend trace files I have here.

Remove the comment about supporting other commands. Another timeline
might have an Ascend that successfully pivoted to DSL or 15625B+1D
gigabit ISDN, but this one has neither.

This was our last/only Bison/YACC file, so remove Bison/YACC as a
development and packaging dependency and remove references to it from
the documentation.

Revert "Make versions of DIAG_OFF() and DIAG_ON() for GCC 4.2 through 4.5."

2018-09-11T18:54:02+00:00

This reverts commit f6b8bc39c66c878ff25a4f48fff382f8775a2711.

Reason for revert: prior to 4.6 or so, the pragmas didn't work as well,
e.g. they couldn't be used inside a function; we depend on them being
usable within a function.

Change-Id: I7a7a0c08a2aca553233c237b8b6c43115095804e
Reviewed-on: https://code.wireshark.org/review/29610
Reviewed-by: Guy Harris

Make versions of DIAG_OFF() and DIAG_ON() for GCC 4.2 through 4.5.

2018-09-11T07:31:31+00:00

The macOS buildbot is currently using llvm-gcc, which is based on GCC
4.2.

Change-Id: I8497243333410380e1d0bc7fa35bccbf841cada1
Reviewed-on: https://code.wireshark.org/review/29596
Reviewed-by: Guy Harris

Fix what seems like a copy-paste error.

2018-09-10T03:49:13+00:00

Change-Id: I084824c57f1eb61189b337ae3e4786d1d8a88707
Reviewed-on: https://code.wireshark.org/review/29525
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris

Revert "Try unconditionally using the pragmas in Clang."

2018-09-09T21:58:21+00:00

This reverts commit 051efd105a8404093139dd4a54620c98c4ff170e.

Reason for revert: The Clang on the macOS buildbot is 3.1, so it should
have been using the _Pragmas; perhaps it "supports" them but they don't
actually *work*, or perhaps something else is wrong.

Change-Id: Id5c3365875c694e6bd4f1a4d8d92e7581cd4585f
Reviewed-on: https://code.wireshark.org/review/29522
Reviewed-by: Guy Harris

Try unconditionally using the pragmas in Clang.

2018-09-09T21:14:40+00:00

This should test whether the macOS buildbot Clang really *does* support
them, in which case we should use them, or not.

Change-Id: I52b7b9c450b5f7ba09df72a56ddb91b5750196dc
Reviewed-on: https://code.wireshark.org/review/29521
Reviewed-by: Guy Harris

Older versions of Clang don't understand -Wpedantic.

2018-05-18T22:31:05+00:00

Define DIAG_OFF_PEDANTIC and DIAG_ON_PEDANTIC, and have it do nothing on
Clang prior to 4.0.

Change-Id: Ic6b2e607659db66f3210401024bf3f2239665506
Reviewed-on: https://code.wireshark.org/review/27649
Petri-Dish: Guy Harris 
Reviewed-by: Peter Wu 
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris