tools/wireshark/extcap, branch master WIP Patches to add a samsung-ipc dissector to Wireshark Corrects repeated words throughout the code. 2021-12-22T11:01:11+00:00 Moshe Kaplan me@moshekaplan.com 2021-12-20T02:40:23+00:00 69d54d6f8e668b6018375121ea2afb99f3dd0177 Repeated words were found with: egrep "(\b[a-zA-Z]+) +\1\b" . -Ir and then manually reviewed. Non-displayed strings (e.g., in comments) were also corrected, to ease future review. 
Repeated words were found with:
egrep "(\b[a-zA-Z]+) +\1\b" . -Ir
and then manually reviewed.
Non-displayed strings (e.g., in comments)
were also corrected, to ease future review.
Use UINT64_C() with two constants 2021-12-22T01:53:46+00:00 João Valverde j@v6e.pt 2021-12-21T08:53:44+00:00 2c44afbba3b6f5f01dd87a5c42beaa1186aaa07a 






Extcap logging: Corrected incorrect selector default value syntax
2021-12-21T21:05:22+00:00

j.novak@netsystem.cz
j.novak@netsystem.cz

2021-12-21T21:05:22+00:00

df537a63fb55b30c314a054d75639d5e814eaaca












Clean up some printf() format strings
2021-12-21T02:15:46+00:00

João Valverde
j@v6e.pt

2021-12-20T11:04:26+00:00

5ce2ae2804df33892e2757ccc21a76b70b70e67d












Replace g_strdup_printf() with ws_strdup_printf()
2021-12-19T21:21:58+00:00

João Valverde
j@v6e.pt

2021-12-18T18:48:20+00:00

0ccd69e530ed18ac19a4484c76bdbef94d1ab2b1

Use macros from inttypes.h.





Use macros from inttypes.h.







Replace g_snprintf() with snprintf()
2021-12-19T20:06:13+00:00

João Valverde
j@v6e.pt

2021-12-17T20:05:19+00:00

fe5248717faa1c99a4d0c761fa8da63afffc5d3f

Use macros from inttypes.h with format strings.





Use macros from inttypes.h with format strings.







wslog: Avoid logging any output to stdout
2021-12-14T12:05:41+00:00

João Valverde
j@v6e.pt

2021-12-14T01:22:24+00:00

cf3cb3a695c1df24c8bf7047a63779b6e407a6a7

For historical reasons our logging inherited from GLib the logging of
some levels to stdout. Namely levels "info" and "debug" (to which we
added "noisy").

However this practice is discouraged because it mixes debug output
with application output for CLI tools and breaks many common usage
scenarios, like using tshark in pipes.

This change flips the logic on wslog to make logging to stderr the
default behavior.

Extcap subprocess have a hidden dependency on stdout so add that.

Some GUI users may also have a dependency on stdout. Because
GUI tools are unlikely to depend on stdout for programatic output
add another exception for wireshark GUI, to preserve backward
compatibility.





For historical reasons our logging inherited from GLib the logging of
some levels to stdout. Namely levels "info" and "debug" (to which we
added "noisy").

However this practice is discouraged because it mixes debug output
with application output for CLI tools and breaks many common usage
scenarios, like using tshark in pipes.

This change flips the logic on wslog to make logging to stderr the
default behavior.

Extcap subprocess have a hidden dependency on stdout so add that.

Some GUI users may also have a dependency on stdout. Because
GUI tools are unlikely to depend on stdout for programatic output
add another exception for wireshark GUI, to preserve backward
compatibility.







Fix extcap-base.[ch] indentation
2021-12-11T17:49:40+00:00

João Valverde
j@v6e.pt

2021-12-11T17:47:03+00:00

773420bad91ec17c29a42a0341162e3931818881

Make header indentation consistent with C source.

Fix EditorConfig settings.





Make header indentation consistent with C source.

Fix EditorConfig settings.







extcap: Use standard --log-level and --log-file CLI options
2021-12-07T23:07:55+00:00

João Valverde
j@v6e.pt

2021-12-07T10:39:38+00:00

9b0b3c118af9926e97a1033432bab18b0207cf25

This should allow simultaneous logging to the console and the log
file when running an extcap from the CLI.

One difference is that the extcap error/warning dialogs in the GUI
have extra information in standard wslog format (may or may not
be a good thing).





This should allow simultaneous logging to the console and the log
file when running an extcap from the CLI.

One difference is that the extcap error/warning dialogs in the GUI
have extra information in standard wslog format (may or may not
be a good thing).







Extcap: Improve the log handler logic
2021-12-06T18:51:42+00:00

João Valverde
j@v6e.pt

2021-12-05T20:51:49+00:00

290234f3f5c9114952d80906503bddaec5ad539f

If we have a log file write everything to the file, to provide
a complete picture in the log.

Debug information cannot be written to the parent process when
running in child mode.





If we have a log file write everything to the file, to provide
a complete picture in the log.

Debug information cannot be written to the parent process when
running in child mode.