tools/wireshark/extcap/udpdump.c, branch master

Replace g_strdup_printf() with ws_strdup_printf()

2021-12-19T21:21:58+00:00

Use macros from inttypes.h.

Fix logging with extcaps

2021-12-03T12:30:53+00:00

Extcaps require a log file when invoked in child mode. It also has
a specific flag to enable debugging, other that the wslog options.

Fix the logging to:
  1. Enable debug log level if --debug is used.
  2. Do not emit messages to the stderr if debug is enabled.

This brings extcap logging to the same feature level it had before
wslog replaced GLib logging.

extcap: reword error message referencing captype

2021-10-13T05:03:31+00:00

There exists a program called "captype" but it's not used here.

ws_getopt: Rename struct and macros

2021-09-30T13:59:28+00:00

This is part of the API and should also be renamed to avoid conflicts.

Use the musl in-tree getopt_long() everywhere

2021-09-16T23:43:54+00:00

Besides the obvious limitation of being unavailable on Windows,
the standard is vague about getopt() and getopt_long() has many
non-portable pitfalls and buggy implementations, that increase
the maintainance cost a lot. Also the GNU libc code currently
in the tree is not suited for embedding and is unmaintainable.

Own maintainership for getopt_long() and use the musl implementation
everywhere. This way we don't need to worry if optreset is available,
or if the $OPERATING_SYSTEM version behaves in subtly different ways.

The API is under the Wireshark namespace to avoid conflicts with
system headers.

Side-note, the Mingw-w64 9.0 getopt_long() implementation is buggy
with opterr and known to crash. In my experience it's a headache to
use the embedded getopt implementation if the system provides one.

Move LINKTYPE_WIRESHARK_UPPER_PDU definitions to a separate header.

2021-08-20T09:18:19+00:00

Have wsutil/exported_pdu_tlvs.h define the LINKTYPE_WIRESHARK_UPPER_PDU
TLV type and length values, as well as the port type values written to
files in EXP_PDU_TAG_PORT_TYPE TLVs.

Update the comment that describes the LINKTYPE_WIRESHARK_UPPER_PDU TLVs
to more completely and correctly reflect reality (it was moved from
epan/exported_pdu.h to wsutil/exported_pdu_tlvs.h).

Rename those port type values from OLD_PT_ to EXP_PDU_PT_; there is
nothing "old" about them - yes, they originally had the same numerical
values as the PT_ enum values in libwireshark, but that's no longer the
case, and the two are now defined independently.  Rename routines that
map between libwireshark PT_ values and EXP_PDU_PT_ values to remove
"old" from the name while we're at it.

Don't include epan/exported_pdu.h if we only need the
LINKTYPE_WIRESHARK_UPPER_PDU definitions - just include
wsutil/exported_pdu_tlvs.h.

In extcap/udpdump.c, include wsutil/exported_pdu_tlvs.h rather than
defining the TLV types ourselves.

Use the wsutil/pint.h functions to fill in "exported PDU" headers.

2021-08-20T07:35:33+00:00

That makes the code cleaner, including making it clearer that the fields
in those headers are big-endian.

wslog: Check environment initialization for errors

2021-06-25T23:18:26+00:00

Initialiaze the cmdarg error stream earlier.

Dumpcap also needs to know earlier if it is running in capture
child mode.

wslog: Check if we are initialized and add missing inits

2021-06-21T16:03:29+00:00

Instead of receiving the program name from GLib, pass it explicitly
to ws_log_init() instead  and use that to initialize the GLib program
name.

ws_log_parse_args() will now exit the program when it encounters an
argument error if exit_failure >= 0.

Replace g_log() calls with ws_log()

2021-06-16T12:50:27+00:00