tools/wireshark/extcap/extcap-base.c, branch master

Extcap logging: Corrected incorrect selector default value syntax

2021-12-21T21:05:22+00:00

Replace g_strdup_printf() with ws_strdup_printf()

2021-12-19T21:21:58+00:00

Use macros from inttypes.h.

wslog: Avoid logging any output to stdout

2021-12-14T12:05:41+00:00

For historical reasons our logging inherited from GLib the logging of
some levels to stdout. Namely levels "info" and "debug" (to which we
added "noisy").

However this practice is discouraged because it mixes debug output
with application output for CLI tools and breaks many common usage
scenarios, like using tshark in pipes.

This change flips the logic on wslog to make logging to stderr the
default behavior.

Extcap subprocess have a hidden dependency on stdout so add that.

Some GUI users may also have a dependency on stdout. Because
GUI tools are unlikely to depend on stdout for programatic output
add another exception for wireshark GUI, to preserve backward
compatibility.

extcap: Use standard --log-level and --log-file CLI options

2021-12-07T23:07:55+00:00

This should allow simultaneous logging to the console and the log
file when running an extcap from the CLI.

One difference is that the extcap error/warning dialogs in the GUI
have extra information in standard wslog format (may or may not
be a good thing).

Extcap: Improve the log handler logic

2021-12-06T18:51:42+00:00

If we have a log file write everything to the file, to provide
a complete picture in the log.

Debug information cannot be written to the parent process when
running in child mode.

extcap: Register log handler conditionally

2021-12-06T18:51:42+00:00

This matches the original implementation and allows displaying
logs to the console, including debug information, when running
an extcap from the CLI for testing and development purposes.

This should make extcap logging bug-for-bug compatible with the
behavior before dc7f0b88bb.

Define more log domains for extcaps

2021-12-05T00:28:26+00:00

Fix logging with extcaps

2021-12-03T12:30:53+00:00

Extcaps require a log file when invoked in child mode. It also has
a specific flag to enable debugging, other that the wslog options.

Fix the logging to:
  1. Enable debug log level if --debug is used.
  2. Do not emit messages to the stderr if debug is enabled.

This brings extcap logging to the same feature level it had before
wslog replaced GLib logging.

Use the musl in-tree getopt_long() everywhere

2021-09-16T23:43:54+00:00

Besides the obvious limitation of being unavailable on Windows,
the standard is vague about getopt() and getopt_long() has many
non-portable pitfalls and buggy implementations, that increase
the maintainance cost a lot. Also the GNU libc code currently
in the tree is not suited for embedding and is unmaintainable.

Own maintainership for getopt_long() and use the musl implementation
everywhere. This way we don't need to worry if optreset is available,
or if the $OPERATING_SYSTEM version behaves in subtly different ways.

The API is under the Wireshark namespace to avoid conflicts with
system headers.

Side-note, the Mingw-w64 9.0 getopt_long() implementation is buggy
with opterr and known to crash. In my experience it's a headache to
use the embedded getopt implementation if the system provides one.

Replace g_assert() with ws_assert()

2021-06-19T01:23:31+00:00