Otherwise, just because a flag is appropriate for $CC, that doesn't necessarily mean it's appropriate for $CFLAGS_FOR_BUILD. (We don't use CFLAGS_FOR_BUILD for many things, so it's probably not worth making a lot of effort to throw all the warning flags into it if we're cross-compiling; we *do* throw them in for native compilation, which is what most developers use and test with, so that should be sufficient to let the warnings catch problems with the build tools we're building.) Change-Id: I317e5b34b046aa16d793b85ea67f105f6d1faca3 Reviewed-on: https://code.wireshark.org/review/8028 Reviewed-by: Guy Harris <guy@alum.mit.edu>
------------------------------------------------------------------------
r50228 | mmann | 2013-06-28 19:54:58 -0700 (Fri, 28 Jun 2013) | 11 lines
Changed paths:
M /trunk/epan/dissectors/packet-kdsp.c
Improvements for the KDSP dissector. Bug 8864 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8864)
From Yuri Schaeffer
It addresses the following issues:
- Payload was included for all CAPPACKET messages. Even when not flagged by bitmap (bug).
- Frame Checksum (FCS) was not read from bitmap all following data is off by 4. (bug)
- Headers indicated in bitmap could use own subtree
- Payload is malformed because it is assumed the span 'the rest of the packet'. In reality more commands can follow. (bug)
------------------------------------------------------------------------
r50230 | mmann | 2013-06-29 12:59:08 -0700 (Sat, 29 Jun 2013) | 1 line
Changed paths:
M /trunk/epan/dissectors/packet-ip.c
M /trunk/epan/dissectors/packet-ppp.c
M /trunk/epan/dissectors/packet-tcp.c
M /trunk/epan/ip_opts.h
Separate IP option header fields for each dissector that uses dissect_ip_tcp_options(). Bug 8823 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8823)
------------------------------------------------------------------------
r50282 | cmaynard | 2013-06-30 22:23:17 -0700 (Sun, 30 Jun 2013) | 4 lines
Changed paths:
M /trunk/epan/tvbuff.c
There are a few dissectors that pass the return value of tvb_length_remaining() as the size argument to the tvb_format_*() functions. Try to do something sane if that value happens to be -1 (or negative in general). One such example is packet-bthfp.c, as found and reported by Coverity in CID 1035325 (Improper use of negative value).
Note: There are other ways to handle this of course, but this fix is suitable for backporting to both 1.10 and 1.8, as it does not break binary compatibility. Is there a better way to fix this though? For now, schedule this for backport.
------------------------------------------------------------------------
r50301 | cmaynard | 2013-07-01 09:29:17 -0700 (Mon, 01 Jul 2013) | 3 lines
Changed paths:
M /trunk/plugins/profinet/packet-dcerpc-pn-io.c
Fix Coverity CID 1035326 (Improper use of negative value) by guarding against tvb_reported_length_remaining() possibly returning -1.
#BACKPORT(1.10,1.8)
------------------------------------------------------------------------
r50303 | cmaynard | 2013-07-01 12:52:32 -0700 (Mon, 01 Jul 2013) | 3 lines
Changed paths:
M /trunk/ws80211_utils.c
Fix Coverity CID 997052 (Infinite loop) by declaring 'err' volatile.
#BACKPORT(1.10)
------------------------------------------------------------------------
r50306 | cmaynard | 2013-07-01 13:38:12 -0700 (Mon, 01 Jul 2013) | 2 lines
Changed paths:
M /trunk/ws80211_utils.c
Add some casts to try to appease the Ubuntu buildbot, which is angry from r50303.
------------------------------------------------------------------------
r50305 | cmaynard | 2013-07-01 13:25:49 -0700 (Mon, 01 Jul 2013) | 3 lines
Changed paths:
M /trunk/plugins/asn1/packet-asn1.c
Fix Coverity CID 280618 (Dereference before null check).
#BACKPORT(1.10,1.8)
------------------------------------------------------------------------
r50313 | mmann | 2013-07-02 09:02:31 -0700 (Tue, 02 Jul 2013) | 1 line
Changed paths:
M /trunk/epan/expert.c
Cache the malformed filter instead of looking it up each time a malformed packet comes in. This drastically speeds up the load time of captures with lots of malformed packets (ie fuzztesting).
------------------------------------------------------------------------
Update the release notes.
svn path=/trunk-1.10/; revision=50710
(Debian squeeze installs lua includes in /usr/include/lua5.1 and libs under /usr/lib, there's no --with-lua=<dir> setting for this configuration) see also https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8438 svn path=/trunk/; revision=48146
are built with warnings. Also add compiler-specific flags (in this case, just the flags to enable ANSI C compilation) to CFLAGS_FOR_BUILD. svn path=/trunk/; revision=47479
exists by doing: if test "x$3" != "x" ; then because if the program contains quotes it breaks the shell's parsing. Instead test for the existence of $4 (which is mandatory if $3 is given). Fix up the test program for -Wlogical-op so that it actually compiles warning-free (at least on my system) when the compiler doesn't have the bug we're checking for. svn path=/trunk/; revision=46926
it do an additional check, if it finds that a given compiler option is
supported by the compiler, to see whether it's supported but
undesirable. The arguments are a chunk of code to try to compile with
-Werror, and a string to be used in the "checking..." message printed
when trying to compile the cunk of code.
Try enabling -Wshadow again, but have it check whether
extern int atoi(char *p);
int
foo(char *p)
{
int (*fptr)(char *p) = atoi;
return fptr(p) * 2;
}
compiles with -Wshadow and -Werror, so that we don't use -Wshadow with
compilers that complain about that; some older versions of GCC complain
about that, and it's really not worth our effort to eliminate or rename
arguments in function prototypes to make -Wshadow work even with those
compilers.
svn path=/trunk/; revision=46475
The modification to acinclude.m4 adds a new test in the AC_WIRESHARK_OSX_INTEGRATION_CHECK section to first look for the library gtkmacintegration. "gtkmacintegration" is the new internal name for GTK+ MAC OSX library after the project was moved to www.gtk.org. Previously this library was known as igemacintegration. The patches to the three gtk/*.c files update the conditional #include <gtkmacintegration/gtkosxapplication.h> to use the new folder name. The Option 1 patch will break any build environment that expects to find the gtkosapplication.h file in the older igemacintegration folder. In addition the patch includes updates to gtk/main.c and gtk/main_menubar.c for a more standard looking App menu. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6702 svn path=/trunk/; revision=45869
Fixes Bug #7449: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7449 ----- Issue: Building Wireshark with '-O0 -D_FORTIFY_SOURCE=2 ...' fails The warning [error] message: /usr/include/features.h:314:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp]` A bit of research shows that this warning was added to a recent version of glibc (on at least Fedora). See: http://sourceware.org/bugzilla/show_bug.cgi?id=13979 The warning message occurs if -D_FORTIFY_SOURCE=... is used and the gcc 'optimization level' == 0 (-O0). Unfortunately when building with -O0 this warning message: 1. Causes compiles to fail (if -Werror [stop on warning]) 2. Causes ./configure to fail with an (incorrect) message about the pcap header being older than the libpcap version. svn path=/trunk/; revision=43601
Update Lua from 5.1 to 5.2 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7400 svn path=/trunk/; revision=43482
Update autoconf script to check for Lua 5.2 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7400 svn path=/trunk/; revision=43480