tools/wireshark, branch v3.0.7

Build 3.0.7.

2019-12-04T18:35:05+00:00

Change-Id: I6d2ee1b2095f202b6e68f73ad335bd66f4f084f9
Reviewed-on: https://code.wireshark.org/review/35310
Reviewed-by: Gerald Combs

Prep for 3.0.7.

2019-12-04T00:17:16+00:00

Change-Id: I5adc18b0365cac1d73f30758b808f9885e3868aa
Reviewed-on: https://code.wireshark.org/review/35306
Reviewed-by: Gerald Combs

NSIS: The "Sshdump" option installs Ciscodump as well.

2019-12-02T23:25:44+00:00

Use consistent capitalization while we're here.

Change-Id: I0591654b0e73d33528f9cfe990a1491ce6cccc8b
Reviewed-on: https://code.wireshark.org/review/35278
Reviewed-by: Gerald Combs 
(cherry picked from commit 63945535ac9232f74abe14c76024ff4c2a542137)
Reviewed-on: https://code.wireshark.org/review/35298

wsutil: Respect working directory on Windows

2019-12-02T21:33:40+00:00

Pass working directory parameter to win32_create_process() in
ws_pipe_spawn_sync().

Change-Id: I0abbc4fbf733138b20c2a34845b147530417c91e
Reviewed-on: https://code.wireshark.org/review/34533
Petri-Dish: Michael Mann 
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann 
(cherry picked from commit 1f2d36aa0bbb0b089d8d61afe53acc630581f15f)
Reviewed-on: https://code.wireshark.org/review/35293
Petri-Dish: Stig Bjørlykke 
Reviewed-by: Stig Bjørlykke

ws_pipe: fix memory leaks in spawn arguments handling

2019-12-02T21:17:04+00:00

On Windows, ws_pipe_spawn_sync always leaks 'winargs', and leaks 'argv'
on some error paths. Fix these and refactor the common argument parsing
functionality to reduce duplication of functionality.

Change-Id: I8fa5ca45aec20b53f6fa243b0dd07241a345f7ab
Reviewed-on: https://code.wireshark.org/review/32932
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń 
Reviewed-by: Peter Wu 
(cherry picked from commit dd1245f5be20e10f8ef917b20c302129b505cd97)
Reviewed-on: https://code.wireshark.org/review/35291
Petri-Dish: Stig Bjørlykke 
Reviewed-by: Stig Bjørlykke

wsutil: Fix 30 seconds freeze if process fails to start

2019-12-02T20:55:59+00:00

In ws_pipe_wait_for_pipe() on Windows, the WaitForMultipleObjects() waits
on the pending pipe connection events and process handle. If the process
handle is signalled, then it means that the process did exit without
connecting to the pipes.

The WaitForMultipleObjects() was not waiting on the process handle and thus
if the process did fail without connecting to pipes the Wireshark gui was
frozen for 30 seconds.

This change fixes the freeze by increasing the number of handles, so
WaitForMultipleObjects() is aware of the process handle.

Change-Id: Id13824a60baf4be7795cbe1d5ed1c7932edbff45
Reviewed-on: https://code.wireshark.org/review/33028
Reviewed-by: Gerald Combs 
(cherry picked from commit b075b8c7f7bc88b3d2811ac46c40bd677c5464ee)
Reviewed-on: https://code.wireshark.org/review/35292
Petri-Dish: Stig Bjørlykke 
Tested-by: Petri Dish Buildbot

ws_pipe: fix return value of ws_pipe_spawn_async on error path

2019-12-02T19:39:19+00:00

The function returns a GPid, not a gboolean. Callers (mmdbresolv and
extcap) only assume WS_INVALID_PID to be invalid (as documented).

Change-Id: I40b491272a451f569864fa3259009d6d3fcce772
Fixes: v2.5.1rc0-413-g1a0987904f ("Generalize our process spawning code.")
Reviewed-on: https://code.wireshark.org/review/32933
Petri-Dish: Peter Wu 
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń 
Reviewed-by: Anders Broman 
(cherry picked from commit 51ac1047a7e434a0b2e264780b2fa31f1d986898)
Reviewed-on: https://code.wireshark.org/review/35290
Petri-Dish: Stig Bjørlykke 
Reviewed-by: Stig Bjørlykke

wsutil: Refactor WIN32 ws_pipe_wait_for_pipe()

2019-12-02T19:21:16+00:00

The ws_pipe_wait_for_pipe() implementation had multiple issues:
  * Use auto-reset events with ConnectNamedPipe (should be manual-reset)
  * Leaking event handles
  * Not checking return value from CreateEvent()
  * Waiting on closed handles

This change fixes all the above mentioned issues.

Bug: 15696
Change-Id: Ia0c389a902655f85eccb0c59288b4a7d49da48c9
Reviewed-on: https://code.wireshark.org/review/32896
Petri-Dish: Guy Harris 
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń 
Reviewed-by: Anders Broman 
(cherry picked from commit a051d5d869e1932a718eb43bc2089e88cadd30e3)
Reviewed-on: https://code.wireshark.org/review/35289
Petri-Dish: Stig Bjørlykke

wsutil: Warn on empty arguments

2019-12-02T19:14:24+00:00

Callers should not include empty strings in arguments list. Log warning
message instead of silently dropping remaining arguments.

Change-Id: Ia68c7b90cec860e032f81a4008aa005b07ebcfd5
Ping-Bug: 15586
Reviewed-on: https://code.wireshark.org/review/32849
Petri-Dish: Anders Broman 
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman 
(cherry picked from commit 1998de886cbeb5aceef017fe4c2d03e754a90bb9)
Reviewed-on: https://code.wireshark.org/review/35288
Petri-Dish: Stig Bjørlykke 
Reviewed-by: Tomasz Moń

Release notes: The macOS installer ships with Qt 5.12.6.

2019-12-02T16:49:43+00:00

Change-Id: Ic3a0cbe40bd90a7a3f3d11e0df993a724c74fb65
Reviewed-on: https://code.wireshark.org/review/35284
Reviewed-by: Gerald Combs