<feed xmlns='http://www.w3.org/2005/Atom'>
<title>tools/wireshark, branch v1.12.11rc0</title>
<subtitle>WIP Patches to add a samsung-ipc dissector to Wireshark 
</subtitle>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/'/>
<entry>
<title>1.12.10 → 1.12.11.</title>
<updated>2016-02-26T22:18:25+00:00</updated>
<author>
<name>Gerald Combs</name>
<email>gerald@wireshark.org</email>
</author>
<published>2016-02-26T22:16:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=194ea9e1a529415970540fd4dc4b9b79d1bbaed5'/>
<id>194ea9e1a529415970540fd4dc4b9b79d1bbaed5</id>
<content type='text'>
Change-Id: I6cce6adff00ad5f5d4e439b28c83c58a17946b68
Reviewed-on: https://code.wireshark.org/review/14181
Reviewed-by: Gerald Combs &lt;gerald@wireshark.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I6cce6adff00ad5f5d4e439b28c83c58a17946b68
Reviewed-on: https://code.wireshark.org/review/14181
Reviewed-by: Gerald Combs &lt;gerald@wireshark.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Build 1.12.10.</title>
<updated>2016-02-26T19:52:25+00:00</updated>
<author>
<name>Gerald Combs</name>
<email>gerald@wireshark.org</email>
</author>
<published>2016-02-25T23:13:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=7f56a20e1e701216b3c31c3540022f604978b1e3'/>
<id>7f56a20e1e701216b3c31c3540022f604978b1e3</id>
<content type='text'>
Change-Id: I9ac125306dc973dfcab9b2aaf064568d92e42e24
Reviewed-on: https://code.wireshark.org/review/14176
Reviewed-by: Gerald Combs &lt;gerald@wireshark.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I9ac125306dc973dfcab9b2aaf064568d92e42e24
Reviewed-on: https://code.wireshark.org/review/14176
Reviewed-by: Gerald Combs &lt;gerald@wireshark.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>snmp: Decode msgSecurityParameters ASN.1 header</title>
<updated>2016-02-26T12:45:49+00:00</updated>
<author>
<name>Stig Bjørlykke</name>
<email>stig@bjorlykke.org</email>
</author>
<published>2016-02-26T11:03:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=f30a29e53e931563c7ca871297a5acbdc109770b'/>
<id>f30a29e53e931563c7ca871297a5acbdc109770b</id>
<content type='text'>
Decode ASN.1 identifier and length to get correct offset to
msgSecurityParameters.

Bug: 12181
Change-Id: Icf83616ac0a63e1d48652738942fe339dd165cab
Reviewed-on: https://code.wireshark.org/review/14158
Reviewed-by: Stig Bjørlykke &lt;stig@bjorlykke.org&gt;
Reviewed-on: https://code.wireshark.org/review/14161
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Decode ASN.1 identifier and length to get correct offset to
msgSecurityParameters.

Bug: 12181
Change-Id: Icf83616ac0a63e1d48652738942fe339dd165cab
Reviewed-on: https://code.wireshark.org/review/14158
Reviewed-by: Stig Bjørlykke &lt;stig@bjorlykke.org&gt;
Reviewed-on: https://code.wireshark.org/review/14161
</pre>
</div>
</content>
</entry>
<entry>
<title>ber: avoid deep recursion for constructed strings</title>
<updated>2016-02-24T06:28:49+00:00</updated>
<author>
<name>Peter Wu</name>
<email>peter@lekensteyn.nl</email>
</author>
<published>2016-02-24T02:06:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=8f7a26e8fcf878bb55601edae5032caf71c2e587'/>
<id>8f7a26e8fcf878bb55601edae5032caf71c2e587</id>
<content type='text'>
Bound the recursion depth to avoid a stack overflow while parsing a
deeply nested constructed string.

Call chain before this patch:

 - dissect_ber_octet_string
   - dissect_ber_constrained_octet_string
     - reassemble_octet_string (called for constructed types)
       - dissect_ber_octet_string *recursion*

After this patch, the reassemble_octet_string will throw if the maximum
recursion depth is reached.

Bug: 11822
Change-Id: I6753e3c9f5dcbfab0e4c174418b2c7eb784d64d2
Reviewed-on: https://code.wireshark.org/review/14108
Reviewed-by: Michael Mann &lt;mmann78@netscape.net&gt;
Petri-Dish: Michael Mann &lt;mmann78@netscape.net&gt;
Tested-by: Petri Dish Buildbot &lt;buildbot-no-reply@wireshark.org&gt;
Reviewed-by: Anders Broman &lt;a.broman58@gmail.com&gt;
(cherry picked from commit 9ff932bf5ea554f9e94ee1364284aff9eb3fd619)
Reviewed-on: https://code.wireshark.org/review/14110
(cherry picked from commit 307bbd253fc61657935eca992ec9325dbfff3274)
Reviewed-on: https://code.wireshark.org/review/14111
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Bound the recursion depth to avoid a stack overflow while parsing a
deeply nested constructed string.

Call chain before this patch:

 - dissect_ber_octet_string
   - dissect_ber_constrained_octet_string
     - reassemble_octet_string (called for constructed types)
       - dissect_ber_octet_string *recursion*

After this patch, the reassemble_octet_string will throw if the maximum
recursion depth is reached.

Bug: 11822
Change-Id: I6753e3c9f5dcbfab0e4c174418b2c7eb784d64d2
Reviewed-on: https://code.wireshark.org/review/14108
Reviewed-by: Michael Mann &lt;mmann78@netscape.net&gt;
Petri-Dish: Michael Mann &lt;mmann78@netscape.net&gt;
Tested-by: Petri Dish Buildbot &lt;buildbot-no-reply@wireshark.org&gt;
Reviewed-by: Anders Broman &lt;a.broman58@gmail.com&gt;
(cherry picked from commit 9ff932bf5ea554f9e94ee1364284aff9eb3fd619)
Reviewed-on: https://code.wireshark.org/review/14110
(cherry picked from commit 307bbd253fc61657935eca992ec9325dbfff3274)
Reviewed-on: https://code.wireshark.org/review/14111
</pre>
</div>
</content>
</entry>
<entry>
<title>[Automatic update for 2016-02-21]</title>
<updated>2016-02-21T16:24:40+00:00</updated>
<author>
<name>Gerald Combs</name>
<email>gerald@wireshark.org</email>
</author>
<published>2016-02-21T16:24:34+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=ce2a840b28c250dbd93e9e081139fbd2396f8177'/>
<id>ce2a840b28c250dbd93e9e081139fbd2396f8177</id>
<content type='text'>
Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I38a7ee2034cdf8cebaee545dd9db5091c39d10d5
Reviewed-on: https://code.wireshark.org/review/14056
Reviewed-by: Gerald Combs &lt;gerald@wireshark.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I38a7ee2034cdf8cebaee545dd9db5091c39d10d5
Reviewed-on: https://code.wireshark.org/review/14056
Reviewed-by: Gerald Combs &lt;gerald@wireshark.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix various off-by-one in buffer sizes</title>
<updated>2016-02-20T15:37:08+00:00</updated>
<author>
<name>Peter Wu</name>
<email>peter@lekensteyn.nl</email>
</author>
<published>2016-02-20T15:02:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=2dd323bd63b4fd41d75c5ca262166e8ebd8926e0'/>
<id>2dd323bd63b4fd41d75c5ca262166e8ebd8926e0</id>
<content type='text'>
Some only allow buffer overruns (read), others also buffer overflows
(write).

Found by looking for '\[ *N *\]' where N is 255, 0xff, 15 and 0xf (case
insensitive).

Change-Id: I250687e2fdeb8fbd5eaf0bbb8251c3dab9640760
Reviewed-on: https://code.wireshark.org/review/14034
Reviewed-by: Peter Wu &lt;peter@lekensteyn.nl&gt;
(cherry picked from commit 3b644a75c9530b8fc60e2fa964dfb2ae327e240d)
 [Trivial conflict resolution]
Reviewed-on: https://code.wireshark.org/review/14039
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some only allow buffer overruns (read), others also buffer overflows
(write).

Found by looking for '\[ *N *\]' where N is 255, 0xff, 15 and 0xf (case
insensitive).

Change-Id: I250687e2fdeb8fbd5eaf0bbb8251c3dab9640760
Reviewed-on: https://code.wireshark.org/review/14034
Reviewed-by: Peter Wu &lt;peter@lekensteyn.nl&gt;
(cherry picked from commit 3b644a75c9530b8fc60e2fa964dfb2ae327e240d)
 [Trivial conflict resolution]
Reviewed-on: https://code.wireshark.org/review/14039
</pre>
</div>
</content>
</entry>
<entry>
<title>ber: fix buffer overrun when handling empty sets</title>
<updated>2016-02-20T15:07:26+00:00</updated>
<author>
<name>Peter Wu</name>
<email>peter@lekensteyn.nl</email>
</author>
<published>2016-02-20T14:06:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=c43f94f03a46cd5778e807aa3454dbbb48dfaed9'/>
<id>c43f94f03a46cd5778e807aa3454dbbb48dfaed9</id>
<content type='text'>
When a set is empty, only a terminator (ber_sequence_t with NULL func)
is present. In that case, do not try to find more values as that will
never succeed.

Bug: 12106
Change-Id: I26cd4ba84a9580e92d5921592a27c2af17c0bebf
Reviewed-on: https://code.wireshark.org/review/14028
Petri-Dish: Peter Wu &lt;peter@lekensteyn.nl&gt;
Tested-by: Petri Dish Buildbot &lt;buildbot-no-reply@wireshark.org&gt;
Reviewed-by: Peter Wu &lt;peter@lekensteyn.nl&gt;
(cherry picked from commit 55b5b7caf3ec4856838b0416d5a91d3a3ff67ec8)
Reviewed-on: https://code.wireshark.org/review/14036
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a set is empty, only a terminator (ber_sequence_t with NULL func)
is present. In that case, do not try to find more values as that will
never succeed.

Bug: 12106
Change-Id: I26cd4ba84a9580e92d5921592a27c2af17c0bebf
Reviewed-on: https://code.wireshark.org/review/14028
Petri-Dish: Peter Wu &lt;peter@lekensteyn.nl&gt;
Tested-by: Petri Dish Buildbot &lt;buildbot-no-reply@wireshark.org&gt;
Reviewed-by: Peter Wu &lt;peter@lekensteyn.nl&gt;
(cherry picked from commit 55b5b7caf3ec4856838b0416d5a91d3a3ff67ec8)
Reviewed-on: https://code.wireshark.org/review/14036
</pre>
</div>
</content>
</entry>
<entry>
<title>gsm_abis_oml: fix buffer overrun</title>
<updated>2016-02-20T14:39:38+00:00</updated>
<author>
<name>Peter Wu</name>
<email>peter@lekensteyn.nl</email>
</author>
<published>2016-02-20T14:27:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=1d5f6009bfa8a0a2dcdce269f6fca841839aa81c'/>
<id>1d5f6009bfa8a0a2dcdce269f6fca841839aa81c</id>
<content type='text'>
Do not read outside boundaries when tag is exactly 0xff.

    tag = tvb_get_guint8(tvb, offset);
    tdef = find_tlv_tag(tag);
        ...
        return &amp;nm_att_tlvdef_base.def[tag];

Bug: 11825
Change-Id: I42e624185abb2166aa0f8d0dbd71a2a86fc0b18e
Reviewed-on: https://code.wireshark.org/review/14030
Reviewed-by: Peter Wu &lt;peter@lekensteyn.nl&gt;
(cherry picked from commit c31425f9ae15067e26ccc6183c206c34713cb256)
Reviewed-on: https://code.wireshark.org/review/14032
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Do not read outside boundaries when tag is exactly 0xff.

    tag = tvb_get_guint8(tvb, offset);
    tdef = find_tlv_tag(tag);
        ...
        return &amp;nm_att_tlvdef_base.def[tag];

Bug: 11825
Change-Id: I42e624185abb2166aa0f8d0dbd71a2a86fc0b18e
Reviewed-on: https://code.wireshark.org/review/14030
Reviewed-by: Peter Wu &lt;peter@lekensteyn.nl&gt;
(cherry picked from commit c31425f9ae15067e26ccc6183c206c34713cb256)
Reviewed-on: https://code.wireshark.org/review/14032
</pre>
</div>
</content>
</entry>
<entry>
<title>Prep for 1.12.10.</title>
<updated>2016-02-19T23:49:45+00:00</updated>
<author>
<name>Gerald Combs</name>
<email>gerald@wireshark.org</email>
</author>
<published>2016-02-19T18:39:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=035c0f940a0f130147bea8a1110e83ed9da6c93f'/>
<id>035c0f940a0f130147bea8a1110e83ed9da6c93f</id>
<content type='text'>
Change-Id: If724e053e1f2af6a963cc81ffa3e507a88719e1e
Reviewed-on: https://code.wireshark.org/review/14021
Reviewed-by: Gerald Combs &lt;gerald@wireshark.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: If724e053e1f2af6a963cc81ffa3e507a88719e1e
Reviewed-on: https://code.wireshark.org/review/14021
Reviewed-by: Gerald Combs &lt;gerald@wireshark.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>rsl: avoid buffer overread</title>
<updated>2016-02-19T17:49:40+00:00</updated>
<author>
<name>Peter Wu</name>
<email>peter@lekensteyn.nl</email>
</author>
<published>2016-02-19T17:36:38+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/tools/wireshark/commit/?id=08d1876a23668470ea4f706ee6d7a5f102d72810'/>
<id>08d1876a23668470ea4f706ee6d7a5f102d72810</id>
<content type='text'>
Fixes a buffer overrun in dissct_rsl_ipaccess_msg when the tag is
exactly 0xff:

        tag = tvb_get_guint8(tvb, offset);
        tdef = &amp;rsl_att_tlvdef.def[tag];

Bug: 11829
Change-Id: I25a3c6948242a52f59431ce84c108b2e52008930
Reviewed-on: https://code.wireshark.org/review/14011
Reviewed-by: Peter Wu &lt;peter@lekensteyn.nl&gt;
(cherry picked from commit de65fd6b00d0b891930324b9549c93ccfe9cac30)
Reviewed-on: https://code.wireshark.org/review/14013
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes a buffer overrun in dissct_rsl_ipaccess_msg when the tag is
exactly 0xff:

        tag = tvb_get_guint8(tvb, offset);
        tdef = &amp;rsl_att_tlvdef.def[tag];

Bug: 11829
Change-Id: I25a3c6948242a52f59431ce84c108b2e52008930
Reviewed-on: https://code.wireshark.org/review/14011
Reviewed-by: Peter Wu &lt;peter@lekensteyn.nl&gt;
(cherry picked from commit de65fd6b00d0b891930324b9549c93ccfe9cac30)
Reviewed-on: https://code.wireshark.org/review/14013
</pre>
</div>
</content>
</entry>
</feed>
