From ac3e0d0988dc8d75c201f455f4fc2e134243044e Mon Sep 17 00:00:00 2001 From: Raff Tsai Date: Thu, 19 Sep 2019 17:06:45 +0800 Subject: Directly use BaseIndexableProvider - Add function getXmlResourceId, Fragments don't need to write xml resource id twice. - Remove getPreferenceControllers from Indexable.java. Because it will move to SettingsLib later for other apps which don't need this function Bug: 135053028 Test: robolectric Change-Id: I1e74519aecdea3dde64a5aea79f08d766dbc0003 --- src/com/android/settings/search/BaseSearchIndexProvider.java | 8 +++++++- src/com/android/settings/search/Indexable.java | 7 ------- 2 files changed, 7 insertions(+), 8 deletions(-) (limited to 'src/com/android/settings/search') diff --git a/src/com/android/settings/search/BaseSearchIndexProvider.java b/src/com/android/settings/search/BaseSearchIndexProvider.java index 64e6a9c0d2..58b571eaf9 100644 --- a/src/com/android/settings/search/BaseSearchIndexProvider.java +++ b/src/com/android/settings/search/BaseSearchIndexProvider.java @@ -103,7 +103,6 @@ public class BaseSearchIndexProvider implements Indexable.SearchIndexProvider { return nonIndexableKeys; } - @Override public List getPreferenceControllers(Context context) { final List controllersFromCode = createPreferenceControllers(context); @@ -135,6 +134,13 @@ public class BaseSearchIndexProvider implements Indexable.SearchIndexProvider { return null; } + /** + * Returns the xml resource Id. + */ + public int getXmlResourceId() { + return mXmlRes; + } + /** * Returns true if the page should be considered in search query. If return false, entire page * will be suppressed during search query. diff --git a/src/com/android/settings/search/Indexable.java b/src/com/android/settings/search/Indexable.java index eef7184762..e3d917663f 100644 --- a/src/com/android/settings/search/Indexable.java +++ b/src/com/android/settings/search/Indexable.java @@ -70,12 +70,5 @@ public interface Indexable { */ @Keep List getNonIndexableKeys(Context context); - - /** - * @return a list of {@link AbstractPreferenceController} for ResultPayload data during - * Indexing. - */ - @Keep - List getPreferenceControllers(Context context); } } -- cgit v1.2.3