diff options
author | Luca Stefani <luca.stefani.ge1@gmail.com> | 2019-02-24 16:03:57 +0100 |
---|---|---|
committer | Luca Stefani <luca.stefani.ge1@gmail.com> | 2019-02-24 16:03:57 +0100 |
commit | 210bf806712ac860ab0c076dffb4de575a7d1f60 (patch) | |
tree | 1b9541fd1cdf9924f4ef11c6ccbe2a910f05feda | |
parent | bae10861f246647b40f1b7940cb94f3dbd342b2e (diff) | |
download | packages_apps_Messaging-210bf806712ac860ab0c076dffb4de575a7d1f60.tar.gz packages_apps_Messaging-210bf806712ac860ab0c076dffb4de575a7d1f60.tar.bz2 packages_apps_Messaging-210bf806712ac860ab0c076dffb4de575a7d1f60.zip |
Remove notification settings from database
Change-Id: I8f9112f3ffbb965856394f780012f9b46bd9aefb
6 files changed, 10 insertions, 74 deletions
diff --git a/src/com/android/messaging/datamodel/BugleDatabaseOperations.java b/src/com/android/messaging/datamodel/BugleDatabaseOperations.java index d30cec4..5ece174 100644 --- a/src/com/android/messaging/datamodel/BugleDatabaseOperations.java +++ b/src/com/android/messaging/datamodel/BugleDatabaseOperations.java @@ -171,8 +171,7 @@ public class BugleDatabaseOperations { final ArrayList<ParticipantData> participants = getConversationParticipantsFromRecipients(recipients, refSubId); - return getOrCreateConversation(db, threadId, senderBlocked, participants, false, false, - null); + return getOrCreateConversation(db, threadId, senderBlocked, participants); } /** @@ -190,7 +189,7 @@ public class BugleDatabaseOperations { Assert.isNotMainThread(); final ArrayList<ParticipantData> recipients = new ArrayList<>(1); recipients.add(recipient); - return getOrCreateConversation(db, threadId, senderBlocked, recipients, false, false, null); + return getOrCreateConversation(db, threadId, senderBlocked, recipients); } /** @@ -200,15 +199,11 @@ public class BugleDatabaseOperations { * @param threadId The message's thread * @param archived Flag whether the conversation should be created archived * @param participants list of conversation participants - * @param noNotification If notification should be disabled - * @param noVibrate If vibrate on notification should be disabled - * @param soundUri If there is custom sound URI * @return a conversation id */ @DoesNotRunOnMainThread public static String getOrCreateConversation(final DatabaseWrapper db, final long threadId, - final boolean archived, final ArrayList<ParticipantData> participants, - boolean noNotification, boolean noVibrate, String soundUri) { + final boolean archived, final ArrayList<ParticipantData> participants) { Assert.isNotMainThread(); // Check to see if this conversation is already in out local db cache @@ -231,8 +226,7 @@ public class BugleDatabaseOperations { BugleDatabaseOperations.getOrCreateParticipantInTransaction(db, self); // Create a new conversation conversationId = BugleDatabaseOperations.createConversationInTransaction( - db, threadId, conversationName, selfId, participants, archived, - noNotification, noVibrate, soundUri); + db, threadId, conversationName, selfId, participants, archived); db.setTransactionSuccessful(); } finally { db.endTransaction(); @@ -357,15 +351,11 @@ public class BugleDatabaseOperations { * @param threadId The message's thread * @param selfId The selfId to make default for this conversation * @param archived Flag whether the conversation should be created archived - * @param noNotification If notification should be disabled - * @param noVibrate If vibrate on notification should be disabled - * @param soundUri The customized sound * @return The existing conversation id or new conversation id */ static String createConversationInTransaction(final DatabaseWrapper dbWrapper, final long threadId, final String conversationName, final String selfId, - final List<ParticipantData> participants, final boolean archived, - boolean noNotification, boolean noVibrate, String soundUri) { + final List<ParticipantData> participants, final boolean archived) { // We want conversation and participant creation to be atomic Assert.isTrue(dbWrapper.getDatabase().inTransaction()); boolean hasEmailAddress = false; @@ -389,15 +379,6 @@ public class BugleDatabaseOperations { if (archived) { values.put(ConversationColumns.ARCHIVE_STATUS, 1); } - if (noNotification) { - values.put(ConversationColumns.NOTIFICATION_ENABLED, 0); - } - if (noVibrate) { - values.put(ConversationColumns.NOTIFICATION_VIBRATION, 0); - } - if (!TextUtils.isEmpty(soundUri)) { - values.put(ConversationColumns.NOTIFICATION_SOUND_URI, soundUri); - } fillParticipantData(values, participants); diff --git a/src/com/android/messaging/datamodel/DatabaseHelper.java b/src/com/android/messaging/datamodel/DatabaseHelper.java index 5bfca06..b8f97cf 100644 --- a/src/com/android/messaging/datamodel/DatabaseHelper.java +++ b/src/com/android/messaging/datamodel/DatabaseHelper.java @@ -133,15 +133,6 @@ public class DatabaseHelper extends SQLiteOpenHelper { /* Participant count not including self (so will be 1 for 1:1 or bigger for group) */ public static final String PARTICIPANT_COUNT = "participant_count"; - /* Should notifications be enabled for this conversation? */ - public static final String NOTIFICATION_ENABLED = "notification_enabled"; - - /* Notification sound used for the conversation */ - public static final String NOTIFICATION_SOUND_URI = "notification_sound_uri"; - - /* Should vibrations be enabled for the conversation's notification? */ - public static final String NOTIFICATION_VIBRATION = "notification_vibration"; - /* Conversation recipients include email address */ public static final String INCLUDE_EMAIL_ADDRESS = "include_email_addr"; @@ -181,9 +172,6 @@ public class DatabaseHelper extends SQLiteOpenHelper { + ConversationColumns.OTHER_PARTICIPANT_NORMALIZED_DESTINATION + " TEXT, " + ConversationColumns.CURRENT_SELF_ID + " TEXT, " + ConversationColumns.PARTICIPANT_COUNT + " INT DEFAULT(0), " - + ConversationColumns.NOTIFICATION_ENABLED + " INT DEFAULT(-1), " - + ConversationColumns.NOTIFICATION_SOUND_URI + " TEXT, " - + ConversationColumns.NOTIFICATION_VIBRATION + " INT DEFAULT(-1), " + ConversationColumns.INCLUDE_EMAIL_ADDRESS + " INT DEFAULT(0), " + ConversationColumns.SMS_SERVICE_CENTER + " TEXT ," + ConversationColumns.IS_ENTERPRISE + " INT DEFAULT(0)" diff --git a/src/com/android/messaging/datamodel/SyncManager.java b/src/com/android/messaging/datamodel/SyncManager.java index b3571bf..aab35dd 100644 --- a/src/com/android/messaging/datamodel/SyncManager.java +++ b/src/com/android/messaging/datamodel/SyncManager.java @@ -50,33 +50,14 @@ public class SyncManager { */ public static class ConversationCustomization { private final boolean mArchived; - private final boolean mMuted; - private final boolean mNoVibrate; - private final String mNotificationSoundUri; - public ConversationCustomization(final boolean archived, final boolean muted, - final boolean noVibrate, final String notificationSoundUri) { + public ConversationCustomization(final boolean archived) { mArchived = archived; - mMuted = muted; - mNoVibrate = noVibrate; - mNotificationSoundUri = notificationSoundUri; } public boolean isArchived() { return mArchived; } - - public boolean isMuted() { - return mMuted; - } - - public boolean noVibrate() { - return mNoVibrate; - } - - public String getNotificationSoundUri() { - return mNotificationSoundUri; - } } SyncManager() { @@ -427,15 +408,13 @@ public class SyncManager { if (customization != null) { // There is user customization we need to recover conversationId = BugleDatabaseOperations.getOrCreateConversation(db, threadId, - customization.isArchived(), participants, customization.isMuted(), - customization.noVibrate(), customization.getNotificationSoundUri()); + customization.isArchived(), participants); if (customization.isArchived()) { mArchivedConversations.add(conversationId); } } else { conversationId = BugleDatabaseOperations.getOrCreateConversation(db, threadId, - false/*archived*/, participants, false/*noNotification*/, - false/*noVibrate*/, null/*soundUri*/); + false/*archived*/, participants); } if (conversationId != null) { diff --git a/src/com/android/messaging/datamodel/action/GetOrCreateConversationAction.java b/src/com/android/messaging/datamodel/action/GetOrCreateConversationAction.java index b262141..7dd09c1 100644 --- a/src/com/android/messaging/datamodel/action/GetOrCreateConversationAction.java +++ b/src/com/android/messaging/datamodel/action/GetOrCreateConversationAction.java @@ -110,7 +110,7 @@ public class GetOrCreateConversationAction extends Action implements Parcelable } final String conversationId = BugleDatabaseOperations.getOrCreateConversation(db, threadId, - false, participants, false, false, null); + false, participants); return conversationId; } diff --git a/src/com/android/messaging/datamodel/action/InsertNewMessageAction.java b/src/com/android/messaging/datamodel/action/InsertNewMessageAction.java index 2567ca9..783372e 100644 --- a/src/com/android/messaging/datamodel/action/InsertNewMessageAction.java +++ b/src/com/android/messaging/datamodel/action/InsertNewMessageAction.java @@ -273,7 +273,7 @@ public class InsertNewMessageAction extends Action implements Parcelable { } final String conversationId = BugleDatabaseOperations.getOrCreateConversation(db, threadId, - false, participants, false, false, null); + false, participants); final ParticipantData self = BugleDatabaseOperations.getOrCreateSelf(db, subId); diff --git a/src/com/android/messaging/datamodel/data/ConversationListItemData.java b/src/com/android/messaging/datamodel/data/ConversationListItemData.java index a9fcfd9..46d4b64 100644 --- a/src/com/android/messaging/datamodel/data/ConversationListItemData.java +++ b/src/com/android/messaging/datamodel/data/ConversationListItemData.java @@ -310,12 +310,6 @@ public class ConversationListItemData { + " as " + ConversationListViewColumns.PREVIEW_CONTENT_TYPE + ", " + DatabaseHelper.CONVERSATIONS_TABLE + '.' + ConversationColumns.PARTICIPANT_COUNT + " as " + ConversationListViewColumns.PARTICIPANT_COUNT + ", " - + DatabaseHelper.CONVERSATIONS_TABLE + '.' + ConversationColumns.NOTIFICATION_ENABLED - + " as " + ConversationListViewColumns.NOTIFICATION_ENABLED + ", " - + DatabaseHelper.CONVERSATIONS_TABLE + '.' + ConversationColumns.NOTIFICATION_SOUND_URI - + " as " + ConversationListViewColumns.NOTIFICATION_SOUND_URI + ", " - + DatabaseHelper.CONVERSATIONS_TABLE + '.' + ConversationColumns.NOTIFICATION_VIBRATION - + " as " + ConversationListViewColumns.NOTIFICATION_VIBRATION + ", " + DatabaseHelper.CONVERSATIONS_TABLE + '.' + ConversationColumns.INCLUDE_EMAIL_ADDRESS + " as " + ConversationListViewColumns.INCLUDE_EMAIL_ADDRESS + ", " @@ -378,9 +372,6 @@ public class ConversationListItemData { ConversationColumns.OTHER_PARTICIPANT_NORMALIZED_DESTINATION; static final String CURRENT_SELF_ID = ConversationColumns.CURRENT_SELF_ID; static final String PARTICIPANT_COUNT = ConversationColumns.PARTICIPANT_COUNT; - static final String NOTIFICATION_ENABLED = ConversationColumns.NOTIFICATION_ENABLED; - static final String NOTIFICATION_SOUND_URI = ConversationColumns.NOTIFICATION_SOUND_URI; - static final String NOTIFICATION_VIBRATION = ConversationColumns.NOTIFICATION_VIBRATION; static final String INCLUDE_EMAIL_ADDRESS = ConversationColumns.INCLUDE_EMAIL_ADDRESS; static final String MESSAGE_STATUS = MessageColumns.STATUS; @@ -406,9 +397,6 @@ public class ConversationListItemData { ConversationListViewColumns.OTHER_PARTICIPANT_NORMALIZED_DESTINATION, ConversationListViewColumns.PARTICIPANT_COUNT, ConversationListViewColumns.CURRENT_SELF_ID, - ConversationListViewColumns.NOTIFICATION_ENABLED, - ConversationListViewColumns.NOTIFICATION_SOUND_URI, - ConversationListViewColumns.NOTIFICATION_VIBRATION, ConversationListViewColumns.INCLUDE_EMAIL_ADDRESS, ConversationListViewColumns.MESSAGE_STATUS, ConversationListViewColumns.SHOW_DRAFT, |