Revert "lineage-sdk self-removing prefs: move reap from onBindViewHolder to onAttached"lineage-15.0

This reverts commit 027b615325092f7676a34c137248dc9fcd57cc35.

While it served its original purpose, this was causing bad side-effects
when using our constraints (verified at least with requiresConfig and
requiresAction). Moving the reap to onAttached was rendering self-removing
prefs useless because if the view isn't loaded yet, the preference
(which also doesn't yet exists) can't really be hidden.

Change-Id: Ic61fe4b9979412d89c55ea1543c494e69bf6eab7

1 files changed, 0 insertions, 6 deletions

diff --git a/sdk/src/java/lineageos/preference/SelfRemovingListPreference.java b/sdk/src/java/lineageos/preference/SelfRemovingListPreference.java
index 0b8c7985..d1d3ec5a 100644
--- a/sdk/src/java/lineageos/preference/SelfRemovingListPreference.java
+++ b/sdk/src/java/lineageos/preference/SelfRemovingListPreference.java
@@ -44,12 +44,6 @@ public class SelfRemovingListPreference extends ListPreference {
     }
 
     @Override
-    public void onAttached() {
-        super.onAttached();
-        mConstraints.onAttached();
-    }
-
-    @Override
     public void onBindViewHolder(PreferenceViewHolder holder) {
         super.onBindViewHolder(holder);
         mConstraints.onBindViewHolder(holder);