aboutsummaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* tools: reorder includesDenis 'GNUtoo' Carikli2020-07-213-10/+12
| | | | | | | | | | This reorders includes alphabetically and groups them together: - C standard library includes of depth 1 are grouped together - "System" libraries of depth > 1 age grouped together - The (lib)samsung-ipc include(s) is/are grouped together Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* tools: nv_data-md5: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-58/+57
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* tools: ipc-modem: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-393/+408
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. checkpatch.pl still produces warning on tools/ipc-modem.c but there were good reasons to ignore them: - Since there is no documentation for the samsung-ipc protocol, beside the libsamsung-ipc source code, the code that was commented out or between #if 0 #endif has been preserved as it could be relevant to the understanding of the protocol. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. - checkpatch also emits many warnings for "quoted string split across lines". The issue here is that we have conflicting rules in the code style. - In one hand there is a limit of 80 characters per line. - On the other hand, user-visible strings should not be broken because "that breaks the ability to grep for them"[1]. So the strings were split in a way that limit the probability of not finding them in grep. The assignment of the global declaration to 0 also triggered a checkpatch.pl error: ERROR: do not initialise globals to 0 So they were fixed as the fix shouldn't induce any functional change: In the the C18 standard draft[2] in the Semantics section of the Initialization section (6.7.9) we have: If an object that has static or thread storage duration is not initialized explicitly, then: [...] - if it has arithmetic type, it is initialized to (positive or unsigned) zero; References: ----------- [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v5.6#n81 [2]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* tools: ipc-test: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-251-95/+93
| | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* nv_data-md5: use linebreak when printing the md5 stringDenis 'GNUtoo' Carikli2020-01-301-1/+1
| | | | | | This enables easy copy-paste from a terminal. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* nv_data-md5: use ipc_client loggingDenis 'GNUtoo' Carikli2020-01-301-2/+45
| | | | | | | | Without that, functions like ipc_nv_data_md5_calculate won't print anything as the ipc_client logging requires a valid ipc_client. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* ipc_nv_data_md5_calculate: print errors when ipc_client is defined.Denis 'GNUtoo' Carikli2020-01-301-1/+2
| | | | | | | Without that, there are no ways to know the cause of failures with ipc_nv_data_md5_calculate. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* ipc-test: improve error reportingDenis 'GNUtoo' Carikli2020-01-181-9/+9
| | | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Acked-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* tools: get rid of unused variablesDenis 'GNUtoo' Carikli2019-12-052-4/+0
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* tools: silence unused variable warningsDenis 'GNUtoo' Carikli2019-07-242-6/+12
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* tools: nv_data-md5 tool for calculating (salted) nv_data md5Paul Kocialkowski2016-02-022-0/+65
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Fix crash in modemctrl after a failed bootstrapPaul Wise2014-11-021-1/+1
|
* Properly handle errors bootstrapping modemPaul Wise2014-11-021-2/+6
|
* tools: Autotools intermediates cleanupPaul Kocialkowski2014-09-072-456/+0
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* tools: Proper arguments to ipc_client_pollPaul Kocialkowski2014-08-284-2/+458
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* tools: ipc-test test program, for various purposesPaul Kocialkowski2014-02-212-0/+142
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* tools: modemctrl tool rename, in favor of ipc-modemPaul Kocialkowski2014-02-212-5/+5
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* ipc: Consistent coding style and major cleanupPaul Kocialkowski2014-02-151-31/+31
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Prefer official Samsung IPC protocol namesPaul Kocialkowski2014-02-081-13/+12
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Follow consistent coding style in headersPaul Kocialkowski2014-02-061-19/+19
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Good-looking copyright blocks, with the right order in copyright linesPaul Kocialkowski2014-01-251-1/+0
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Rework handlers and ipc functions for better consistencyPaul Kocialkowski2013-06-271-37/+22
| | | | | | | | | | | | | | | | | | | | Detailed list of the changes introduced by this commit: * Rename ipc_client_bootstrap_modem to ipc_client_bootstrap * Rename ipc_client_new/free to ipc_client_create/destroy * Rename log_handler to log_callback and change arguments order * Remove handlers common data and fd mechanisms * Set transport, power and gprs common data for handlers * Add data_create and data_destroy handlers * Rework arguments order for handlers * Add poll transport handler * Remove functions types typedefs * Remove dumb ipc_client_send_* functions * Remove ipc_client_gprs_handlers_available * Adapt device files for the new API changes * Adapt modemctrl for the new API changes Change-Id: Ia9ba1045dbbf9f5e31a201aa8629b49019158972 Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* modemctrl: Update Copyright block for better accuracyPaul Kocialkowski2013-06-251-3/+4
| | | | | Change-Id: I0ddd3a6b32920033c3d70f046aea3674f94fa75e Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Moved radio.h and types.h to samsung-ipc.h (API) and protocol.h (IPC protocol).Paul Kocialkowski2013-06-251-1/+1
| | | | | | | Also some minor headers cosmetics. Change-Id: Id2b988b118d956e91827b9b840e3f384424593ae Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Drop support for the (incomplete) old protocol implementation used on H1.Paul Kocialkowski2013-06-251-2/+0
| | | | | | | Also refactor headers: values aligned to 16x4 spaces and other cosmetics Change-Id: I5a6f2c2471599c88c4be74591117d0ab2dfaaddf Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Fix outstanding compiler warningsSimon Busch2013-06-231-1/+6
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* modemctrl: Remove SIM initializing messagePaul Kocialkowski2013-03-071-3/+0
| | | | | Change-Id: If73a5bc5a87ae1bfdb0921ef16338be11cc7b989 Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* switch to GPLv2+ as license as decided by all authors per mailSimon Busch2012-09-211-1/+1
|
* tools: drop not working forwarding toolSimon Busch2012-08-302-191/+0
|
* net: renaming some parts to be more reasonableSimon Busch2012-08-301-2/+2
|
* sec: rename ipc_sec_pin_status_response structureSimon Busch2012-08-291-4/+4
|
* sec: rename IPC_SEC_PIN_STATUS to IPC_SEC_SIM_STATUSSimon Busch2012-08-291-2/+2
|
* sec: refactor type naming to be clean and not misleadingSimon Busch2012-08-291-11/+11
|
* tools: use ${top_builddir} rather than ${top_srcdir}Simon Busch2012-03-231-2/+2
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* Fixed modemctrl for sec header changesPaulK2012-02-241-2/+2
|
* Adjust for recent changes to device creation structureSimon Busch2012-02-031-2/+0
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* Rework IPC client creation to detect device automatically on startupSimon Busch2012-02-031-24/+25
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* Rework device specific code so we can build one library for all devices nowSimon Busch2012-02-031-28/+45
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* Adjust to get everything compiling with autotools againSimon Busch2012-01-281-7/+1
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* modemctrl: add command to bootstrap modem onlySimon Busch2012-01-271-0/+4
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* tools: forward: use modem_io structure to determine size of data we readSimon Busch2012-01-241-1/+9
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* tools: add first and untested version of a simple forward utilitySimon Busch2012-01-242-6/+188
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* Modified handlers with common handlers data and device-specific functionsPaulK2012-01-141-1/+3
|
* Set negative rc for errors, plus cosmeticsPaulK2011-12-301-2/+2
|
* Rewritten modemctrl to provide an usable test binaryPaulK2011-11-071-130/+256
|
* Fixed Makefile.am on tools/ (added defines while building)PaulK2011-11-011-1/+9
|
* Implemented minimal ipc upper-layer in modemctrl, with auto call functionsPaulK2011-10-311-40/+300
|
* Comment some not compiling code in modemctrl toolSimon Busch2011-10-301-0/+3
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* Fix several places in code for latest infrastructure changesSimon Busch2011-10-291-3/+2
| | | | Signed-off-by: Simon Busch <morphis@gravedo.de>
* split devices, require compile-time device selectionJoerie de Gram2011-10-281-3/+3
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 20:15:50 +0000