aboutsummaryrefslogtreecommitdiffstats
path: root/samsung-ipc/devices/crespo
Commit message (Collapse)AuthorAgeFilesLines
* samsung-ipc: make #include relative to samsung-ipc/Denis 'GNUtoo' Carikli2020-07-221-3/+3
| | | | | | | | | | | | | | This has several advantages: - It makes the header context more obvious: #include "xmm626.h" could mislead people into thinking that the xmm626.h header is in the same directory than the file using that directive, while it is instead in another location. This in turn could make people suppose that there is a "xmm626.h" header specific to the galaxys2 driver. Instead the #include "modems/xmm616/xmm616.h" directive is much more clear. - We can have two headers with the same filename. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* samsung-ipc: use #include "file" instead of #include <file> when relevantDenis 'GNUtoo' Carikli2020-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The way <> and "" are included are implementation defined according to the C18 standard[1]: A preprocessing directive of the form # include < h-char-sequence > new-line searches a sequence of implementation-defined places for a header identified uniquely by the specified sequence between the < and > delimiters, and causes the replacement of that directive by the entire contents of the header. How the places are specified or the header identified is implementation-defined. A preprocessing directive of the form # include " q-char-sequence " new-line causes the replacement of that directive by the entire contents of the source file identified by the specified sequence between the " delimiters. The named source file is searched for in an implementation-defined manner. If this search is not supported, or if the search fails, the directive is reprocessed as if it read And the GCC documentation has the following on #include directives[2]: Both user and system header files are included using the preprocessing directive ‘#include’. It has two variants: #include <file> This variant is used for system header files. It searches for a file named file in a standard list of system directories. You can prepend directories to this list with the -I option (see Invocation). #include "file" This variant is used for header files of your own program. It searches for a file named file first in the directory containing the current file, then in the quote directories and then the same directories used for <file>. You can prepend directories to the list of quote directories with the -iquote option. References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf [2]https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: crespo: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-273-421/+428
| | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. "unsigned" was changed to "unsigned int" because checkpatch.pl was printing the following warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' According to the C18 standard[1], "unsigned" is the same as "unsigned int": in the "6.7 Declarations" section we have: "- unsigned, or unsigned int" [...] Each of the comma-separated multisets designates the same type [...] References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* ipc_client_gprs_specs handlers: pass the ipc_client structDenis 'GNUtoo' Carikli2020-02-281-4/+8
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: data_create/data_destroy handlers: pass the ipc_client structDenis 'GNUtoo' Carikli2020-02-281-2/+4
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: gprs activate/deactivate handlers: pass the ipc_client structDenis 'GNUtoo' Carikli2020-02-281-2/+4
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: transport: pass the ipc_client structDenis 'GNUtoo' Carikli2020-02-211-9/+14
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* device boot handlers: pass it the ipc_client structDenis 'GNUtoo' Carikli2020-02-211-2/+4
| | | | | | | | | | | This enables to use logging inside the handlers: ipc_client_log needs access to the ipc_client struct to work. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: crespo: cosmetic cleanupsDenis 'GNUtoo' Carikli2020-02-081-28/+46
| | | | | | | | | | - Whitespaces were unified to use 4 spaces as stated by the last line that has vim settings. - The line length was limited to 80 characters with the exception of the functions with only one argument where it didn't make sense to try to split it as the result would look counter intuitive. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: crespo: Reorder includes alphabeticallyDenis 'GNUtoo' Carikli2020-02-071-9/+8
| | | | | Acked-by: Fil Lupin <fillupin@protonmail.com> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* file_data_{read,write}: Add loggingDenis 'GNUtoo' Carikli2020-01-301-1/+1
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Silence warning about implicit declaration asprintfDenis 'GNUtoo' Carikli2019-12-051-0/+1
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: crespo: silence unused variable warningsDenis 'GNUtoo' Carikli2019-07-241-8/+13
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Add some missing headersPaul Kocialkowski2016-02-021-0/+1
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* External fds polling supportPaul Kocialkowski2014-08-071-5/+35
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* devices: Size limit when reading RFS dataPaul Kocialkowski2014-08-021-2/+2
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Missing gprs_activate/deactivate handlers definitionsPaul Kocialkowski2014-07-291-2/+12
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* GPRS cid count is unsigned integerPaul Kocialkowski2014-07-281-2/+2
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* utils: Shared libraries don't allow for internal functionsPaul Kocialkowski2014-07-261-1/+0
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Generic xmm616 and xmm626 namesPaul Kocialkowski2014-05-161-17/+17
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* ipc: Consistent coding style and major cleanupPaul Kocialkowski2014-02-152-110/+105
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* utils: Files rename, new functions, proper types and few other cleanupsPaul Kocialkowski2014-02-131-2/+2
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* rfs: Proper IPC functions for nv_data specs, without generic fallback valuesPaul Kocialkowski2014-02-112-0/+11
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* devices folder instead of device, for better consistencyPaul Kocialkowski2014-02-083-0/+652
| | | | Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
* Move all device specific source files into main source directorySimon Busch2011-08-245-991/+0
|
* Add missing source filesSimon Busch2011-08-242-0/+865
|
* Move all source code into samsung-ipc directorySimon Busch2011-08-243-0/+126
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-12 16:21:16 +0000