aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* WIP: Add compilation test scriptpatches-todo/compilation-scriptDenis 'GNUtoo' Carikli2020-09-151-0/+136
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* samsung-ipc: utils.c: file_data_{read,write}: report open errorDenis 'GNUtoo' Carikli2020-08-311-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | Mounting the EFS on your local computer can result in user id and permissions mismatch because the /etc/fstab doesn't always match the user ids used by Android. For instance here's the GT-N7000 EFS on my laptop: $ ls -l [...]/nv_data.bin -rwx------ 1 1001 1001 2097152 1 janv. 2000 [...]/nv_data.bin When using nv_data-md5 on it we have: $ ./tools/nv_data-md5 [...]/nv_data.bin [ipc] file_data_read: Error: fd: -1 [ipc] ipc_nv_data_md5_calculate failed: data is NULL Calculating nv_data backup md5 failed The error was too cryptic, and I ended up having to dig into the source code to understand what was going on. With this patch we now have an error message that is easier to understand: $ ./tools/nv_data-md5 [...]/nv_data.bin [ipc] file_data_read open failed with error 13: Permission denied [ipc] ipc_nv_data_md5_calculate failed: data is NULL Calculating nv_data backup md5 failed Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* samsung-ipc/utils: reorder includesDenis 'GNUtoo' Carikli2020-08-311-8/+9
| | | | | | | | | This reorders includes alphabetically and groups them together: - C standard library includes of depth 1 are grouped together - "System" libraries of depth > 1 age grouped together - The (lib)samsung-ipc include(s) is/are grouped together Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* xmm626_hsic_ack_read: pass the ipc_client structDenis 'GNUtoo' Carikli2020-07-241-4/+5
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* xmm626_mipi_ack_read: pass the ipc_client structDenis 'GNUtoo' Carikli2020-07-241-6/+7
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* xmm626_hsic_modem_command_send: pass the ipc_client structDenis 'GNUtoo' Carikli2020-07-241-13/+17
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* xmm626_mipi_modem_command_send: pass the ipc_client structDenis 'GNUtoo' Carikli2020-07-241-12/+15
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* xmm626_mipi_modem_data_send: pass the ipc_client structDenis 'GNUtoo' Carikli2020-07-241-5/+7
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* xmm626_hsic_modem_data_send: pass the ipc_client structDenis 'GNUtoo' Carikli2020-07-241-4/+6
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Android.mk: add nv_data-md5Denis 'GNUtoo' Carikli2020-07-241-0/+16
| | | | | | | | | | | | | | | | | The nv_data-md5 tool can be used to create the nv_data.md5 or .nv_data.md5 files. This tool is already integrated in the Autotools build system, so it's a good idea to also add it to the Android.mk to enable to build it in Android as well if needed. As libsamsung-ipc is not packaged yet in most common GNU/Linux distributions, it might be useful to add it in the resulting Android images, but it's up to the Android distributions using libsamsung-ipc to decide that, for instance by adding nv_data-md5 to PRODUCT_PACKAGES in the repositories of various devices. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* samsung-ipc: make #include relative to samsung-ipc/Denis 'GNUtoo' Carikli2020-07-2219-51/+45
| | | | | | | | | | | | | | This has several advantages: - It makes the header context more obvious: #include "xmm626.h" could mislead people into thinking that the xmm626.h header is in the same directory than the file using that directive, while it is instead in another location. This in turn could make people suppose that there is a "xmm626.h" header specific to the galaxys2 driver. Instead the #include "modems/xmm616/xmm616.h" directive is much more clear. - We can have two headers with the same filename. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* samsung-ipc: use #include "file" instead of #include <file> when relevantDenis 'GNUtoo' Carikli2020-07-2113-17/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The way <> and "" are included are implementation defined according to the C18 standard[1]: A preprocessing directive of the form # include < h-char-sequence > new-line searches a sequence of implementation-defined places for a header identified uniquely by the specified sequence between the < and > delimiters, and causes the replacement of that directive by the entire contents of the header. How the places are specified or the header identified is implementation-defined. A preprocessing directive of the form # include " q-char-sequence " new-line causes the replacement of that directive by the entire contents of the source file identified by the specified sequence between the " delimiters. The named source file is searched for in an implementation-defined manner. If this search is not supported, or if the search fails, the directive is reprocessed as if it read And the GCC documentation has the following on #include directives[2]: Both user and system header files are included using the preprocessing directive ‘#include’. It has two variants: #include <file> This variant is used for system header files. It searches for a file named file in a standard list of system directories. You can prepend directories to this list with the -I option (see Invocation). #include "file" This variant is used for header files of your own program. It searches for a file named file first in the directory containing the current file, then in the quote directories and then the same directories used for <file>. You can prepend directories to the list of quote directories with the -iquote option. References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf [2]https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* samsung-ipc: xmm626: xmm626_modem_prj.h: include xmm626_modem_if.hDenis 'GNUtoo' Carikli2020-07-212-1/+2
| | | | | | | xmm626_modem_prj.h uses the MAX_IPC_DEV define and the modem_link enum which come from xmm626_modem_if.h Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* tools: reorder includesDenis 'GNUtoo' Carikli2020-07-213-10/+12
| | | | | | | | | | This reorders includes alphabetically and groups them together: - C standard library includes of depth 1 are grouped together - "System" libraries of depth > 1 age grouped together - The (lib)samsung-ipc include(s) is/are grouped together Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* Android.mk: remove deprecated LOCAL_COPY_HEADERSreplicant-6.0-0004-rc2Denis 'GNUtoo' Carikli2020-07-161-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Android "Build System Best Practices" document[1] states: "LOCAL_COPY_HEADERS is deprecated. Soong modules cannot use these headers, and when the VNDK is enabled, System modules in Make cannot declare or use them either." and: "Don't use non-local paths in your LOCAL_EXPORT_C_INCLUDE_DIRS, [...]. Non-local exported include dirs are not supported in Soong." And having both VNDK enabled and LOCAL_COPY_HEADERS does prevent the build on Replicant 10. LOCAL_COPY_HEADERS was kept for compatibility reasons in the fear that not removing it would potentially break older Replicant versions like Replicant 4.2 which are still needed in order to test libsamsung-ipc on devices that are not supported anymore by subsequent Replicant versions. However since: - LOCAL_EXPORT_C_INCLUDE_DIRS is also used in Replicant 4.2 and 6.0 as well - all devices currently supported by libsamsung-ipc are supported by one of these Replicant versions[2] it should be safe to remove all usage of LOCAL_COPY_HEADERS in Android. This change was tested at build time with the following configurations: - Replicant 10.0 with the i9300 target - Replicant 6.0 with the i9300 target - Replicant 4.2 with the galaxysmtd target References: ----------- [1]https://android.googlesource.com/platform/build/soong/+/master/docs/best_practices.md#headers [2]With the exception of the Galaxy Tab which was never supported by Replicant. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Acked-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* autogen.sh: don't run ./configureDenis 'GNUtoo' Carikli2020-07-081-2/+0
| | | | | | | | | | | | | | In project using autotools, autogen.sh scrips are common and are typically used to generate the ./configure script. While running ./configure in that script might speed up the setup for compiling libsamsung-ipc manually, packagers that know a bit about the autotools probably don't expect that script to run ./configure as well, as packagers typically run ./configure after autogen.sh. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Acked-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* modems: xmm626: switch remaining files to Linux code styleDenis 'GNUtoo' Carikli2020-06-274-94/+91
| | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. "unsigned" was changed to "unsigned int" because checkpatch.pl was printing the following warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' According to the C18 standard[1], "unsigned" is the same as "unsigned int": in the "6.7 Declarations" section we have: "- unsigned, or unsigned int" [...] Each of the comma-separated multisets designates the same type [...] References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* modems: xmm626: kernel_smdk4412: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-453/+476
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* modems: xmm626: hsic: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-273-483/+506
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* modems: xmm626: mipi: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-533/+552
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: ipc_devices: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-145/+141
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: piranha: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-256/+259
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: n7100: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-306/+314
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: n5100: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-306/+315
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: maguro: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-297/+302
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: i9300: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-306/+314
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: galaxys2: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-313/+325
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: crespo: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-273-421/+428
| | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. "unsigned" was changed to "unsigned int" because checkpatch.pl was printing the following warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' According to the C18 standard[1], "unsigned" is the same as "unsigned int": in the "6.7 Declarations" section we have: "- unsigned, or unsigned int" [...] Each of the comma-separated multisets designates the same type [...] References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* devices: aries: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-274-687/+697
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* modems: xmm616: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-241/+247
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: svc.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-68/+67
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: ss.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-22/+20
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: snd.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-28/+26
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: sms.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-73/+75
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: sec.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-101/+105
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: sat.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-12/+12
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: samsung-ipc.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-44/+56
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: rfs.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-24/+24
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: pwr.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-16/+14
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: protocol.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-42/+40
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: pb.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-8/+6
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: net.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-66/+65
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: misc.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-28/+26
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: imei.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-5/+3
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: gprs.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-93/+93
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: gen.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-9/+7
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: disp.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-16/+14
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: call.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-79/+80
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: utils: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-308/+322
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. For __FUNCTION__, according to checkpatch.pl, it's gcc specific: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ However __func__ is part of the C18 standard[1]. In the "6.4.2.2 Predefined identifiers" section, we have: "The identifier __func__ shall be implicitly declared by the translator as if, immediately following the opening brace of each function definition, the declaration static const char __func__[] = "function-name"; " Using symbolic permissions for file mode triggered a checkpatch.pl warning: WARNING: Symbolic permissions 'S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH' are not preferred. Consider using octal permissions '0644'. The rationale behind that is that octal is generally easier to understand than the symbolic relresentation. For more information, see the follwoing Linux commit: f90774e1fd27 checkpatch: look for symbolic permissions and suggest octal instead References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: svc: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-38/+38
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-22 13:45:17 +0000