aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>2022-06-14 15:56:08 +0200
committerDenis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>2022-06-26 02:11:32 +0200
commit8ce0431431a314c17af0a5809632e4d9c2042011 (patch)
tree56c42a0e19bdb2ecb1fd2d4a8f85a7b6692561d3
parent27cd6e6dbefa66a431c0c5300a176b15ab205ce7 (diff)
downloadhardware_replicant_libsamsung-ipc-8ce0431431a314c17af0a5809632e4d9c2042011.tar.gz
hardware_replicant_libsamsung-ipc-8ce0431431a314c17af0a5809632e4d9c2042011.tar.bz2
hardware_replicant_libsamsung-ipc-8ce0431431a314c17af0a5809632e4d9c2042011.zip
partitions: android: test: remplace mkdir shell command
Without that fix, we have the following warning: CC partitions/android.o ../../../../samsung-ipc/tests/partitions/android.c: In function ‘create_dummy_modem_image’: ../../../../samsung-ipc/tests/partitions/android.c:52:9: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 52 | system("mkdir -p /tmp/libsamsung-ipc.55f4731d2e11e85bd889/"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
-rw-r--r--samsung-ipc/tests/partitions/android.c26
1 files changed, 24 insertions, 2 deletions
diff --git a/samsung-ipc/tests/partitions/android.c b/samsung-ipc/tests/partitions/android.c
index 708480a..45da72a 100644
--- a/samsung-ipc/tests/partitions/android.c
+++ b/samsung-ipc/tests/partitions/android.c
@@ -43,13 +43,35 @@ static char const * const dummy_modem_image_paths[] = {
};
-int create_dummy_modem_image(__attribute__((unused)) struct ipc_client *client,
+int create_dummy_modem_image(struct ipc_client *client,
__attribute__((unused)) const char * const path)
{
+ int rc;
+
+ rc = mkdir("/tmp/", 0755);
+ if (rc == -1) {
+ rc = errno;
+ if (rc != EEXIST)
+ ipc_client_log(client,
+ "%s: mkdir %s failed with error %d: %s",
+ __func__, "/tmp/", rc, strerror(rc));
+ }
+
+ rc = mkdir("/tmp/libsamsung-ipc.55f4731d2e11e85bd889/", 0755);
+ if (rc == -1) {
+ rc = errno;
+ if (rc != EEXIST) {
+ ipc_client_log(client,
+ "%s: mkdir %s failed with error %d: %s",
+ __func__,
+ "/tmp/libsamsung-ipc.55f4731d2e11e85bd889/",
+ rc, strerror(rc));
+ }
+ }
+
/* TODO: replace it by C code but make sure that the replacement code
* is as robust as the shell commands
*/
- system("mkdir -p /tmp/libsamsung-ipc.55f4731d2e11e85bd889/");
system("touch /tmp/libsamsung-ipc.55f4731d2e11e85bd889/modem.img");
return 0;