aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>2020-07-08 19:25:49 +0200
committerDenis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>2020-07-16 16:48:43 +0200
commitd0c4082f93f857efa8e937f8bec9c4257f0ee784 (patch)
tree519ec7c201e3e2e83c5717bac063c0e2cf2b1a3b
parentef71e498d8d2a9d1fd77439553a10a55aac1a3e1 (diff)
downloadhardware_replicant_libsamsung-ipc-d0c4082f93f857efa8e937f8bec9c4257f0ee784.tar.gz
hardware_replicant_libsamsung-ipc-d0c4082f93f857efa8e937f8bec9c4257f0ee784.tar.bz2
hardware_replicant_libsamsung-ipc-d0c4082f93f857efa8e937f8bec9c4257f0ee784.zip
Android.mk: remove deprecated LOCAL_COPY_HEADERS
The Android "Build System Best Practices" document[1] states: "LOCAL_COPY_HEADERS is deprecated. Soong modules cannot use these headers, and when the VNDK is enabled, System modules in Make cannot declare or use them either." and: "Don't use non-local paths in your LOCAL_EXPORT_C_INCLUDE_DIRS, [...]. Non-local exported include dirs are not supported in Soong." And having both VNDK enabled and LOCAL_COPY_HEADERS does prevent the build on Replicant 10. LOCAL_COPY_HEADERS was kept for compatibility reasons in the fear that not removing it would potentially break older Replicant versions like Replicant 4.2 which are still needed in order to test libsamsung-ipc on devices that are not supported anymore by subsequent Replicant versions. However since: - LOCAL_EXPORT_C_INCLUDE_DIRS is also used in Replicant 4.2 and 6.0 as well - all devices currently supported by libsamsung-ipc are supported by one of these Replicant versions[2] it should be safe to remove all usage of LOCAL_COPY_HEADERS in Android. This change was tested at build time with the following configurations: - Replicant 4.2 with the galaxysmtd target - Replicant 6.0 with the i9300 target References: ----------- [1]https://android.googlesource.com/platform/build/soong/+/master/docs/best_practices.md#headers [2]With the exception of the Galaxy Tab which was never supported by Replicant. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
-rw-r--r--Android.mk1
1 files changed, 1 insertions, 0 deletions
diff --git a/Android.mk b/Android.mk
index a433f58..63207e4 100644
--- a/Android.mk
+++ b/Android.mk
@@ -127,6 +127,7 @@ LOCAL_C_INCLUDES := $(libsamsung_ipc_local_c_includes)
LOCAL_CFLAGS := $(libsamsung_local_cflags)
LOCAL_SHARED_LIBRARIES := $(libsamsung_ipc_local_shared_libraries)
+
LOCAL_EXPORT_C_INCLUDE_DIRS := $(local_export_c_include_dirs)
include $(BUILD_STATIC_LIBRARY)