<feed xmlns='http://www.w3.org/2005/Atom'>
<title>replicant/hardware_replicant_libsamsung-ipc, branch for-master</title>
<subtitle>Patches not merged yet, used for building and testing them
</subtitle>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/'/>
<entry>
<title>Add code coverage support</title>
<updated>2023-02-14T03:26:11+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2022-08-22T15:28:37+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=f66740de1a33b33d2198d306c480067f9742c735'/>
<id>f66740de1a33b33d2198d306c480067f9742c735</id>
<content type='text'>
Usage:
$ ./configure --enable-code-coverage-tests --enable-debug \
   --enable-samsung-ipc-device=fifo [...]
$ make check
$ sudo make install [...]

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Usage:
$ ./configure --enable-code-coverage-tests --enable-debug \
   --enable-samsung-ipc-device=fifo [...]
$ make check
$ sudo make install [...]

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>configure.ac: fix the python3 interpreter detection.</title>
<updated>2023-02-14T03:26:11+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2022-09-01T15:45:44+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=b1057dab8dc34df3220f5b2f1cdf0478ed3affd2'/>
<id>b1057dab8dc34df3220f5b2f1cdf0478ed3affd2</id>
<content type='text'>
Guix system users need to use guix shell and the provided
scripts/manifest.scm to do local builds and testing.

However 'guix shell --container' doesn't have /usr/bin/env, so tests
don't work if we rely on what is in the sheebang (#!).

In various Makefile.am we had:
    PY_LOG_COMPILER = $(PYTHON)
but PYTHON was undefined, so for some reasons that made 'make check'
rely on the sheebang instead of just using 'python'.

With this fix, with
'guix shell --pure --container -f scripts/manifest.scm',
./configure now properly detect the 'python3' that is in the path:
    Interpreters paths:

      PYTHON3..................: python3

And 'python3' is then used to run the python test scripts, which makes
then makes 'make check' succeed.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Guix system users need to use guix shell and the provided
scripts/manifest.scm to do local builds and testing.

However 'guix shell --container' doesn't have /usr/bin/env, so tests
don't work if we rely on what is in the sheebang (#!).

In various Makefile.am we had:
    PY_LOG_COMPILER = $(PYTHON)
but PYTHON was undefined, so for some reasons that made 'make check'
rely on the sheebang instead of just using 'python'.

With this fix, with
'guix shell --pure --container -f scripts/manifest.scm',
./configure now properly detect the 'python3' that is in the path:
    Interpreters paths:

      PYTHON3..................: python3

And 'python3' is then used to run the python test scripts, which makes
then makes 'make check' succeed.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts: manifest.scm: fix missing bzip2, gzip, tar and xz</title>
<updated>2023-02-14T03:26:11+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2022-09-01T15:52:21+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=582af1b08343861a191f3d11993a7e81587d1661'/>
<id>582af1b08343861a191f3d11993a7e81587d1661</id>
<content type='text'>
In configure.ac we already build xz, bzip2 and gzip archives as we
have the following:
    AM_INIT_AUTOMAKE([dist-bzip2 dist-xz subdir-objects])
and that in the commit aedf4ffd7d16721b522df2d20b1f41f8574c3940 ("Add
tests for builds using tarballs") we automatically built these
archives during make check.

But we forgot to add the required utilities in scripts/manifest.scm.

Without tar and xz, when running make check with
'guix shell --pure --container -f scripts/manifest.scm', we have the
following error:
    tardir=libsamsung-ipc-0.7.0 &amp;&amp; ${TAR-tar} chof - "$tardir" | \
            XZ_OPT=${XZ_OPT--e} xz -c &gt;libsamsung-ipc-0.7.0.tar.xz
    /bin/sh: line 1: xz: command not found
    /bin/sh: line 1: tar: command not found

And if we don't add bzip2 we still have the following error:
'guix shell --pure --container -f scripts/manifest.scm', we have the
following error:
    tardir=libsamsung-ipc-0.7.0 &amp;&amp; ${TAR-tar} chof - "$tardir" | \
          BZIP2=${BZIP2--9} bzip2 -c &gt;libsamsung-ipc-0.7.0.tar.bz2
    /bin/sh: line 1: bzip2: command not found

And we also need gzip:
    tardir=libsamsung-ipc-0.7.0 &amp;&amp; ${TAR-tar} chof - "$tardir" | \
            eval GZIP= gzip --best -c &gt;libsamsung-ipc-0.7.0.tar.gz
    /bin/sh: line 1: gzip: command not found

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In configure.ac we already build xz, bzip2 and gzip archives as we
have the following:
    AM_INIT_AUTOMAKE([dist-bzip2 dist-xz subdir-objects])
and that in the commit aedf4ffd7d16721b522df2d20b1f41f8574c3940 ("Add
tests for builds using tarballs") we automatically built these
archives during make check.

But we forgot to add the required utilities in scripts/manifest.scm.

Without tar and xz, when running make check with
'guix shell --pure --container -f scripts/manifest.scm', we have the
following error:
    tardir=libsamsung-ipc-0.7.0 &amp;&amp; ${TAR-tar} chof - "$tardir" | \
            XZ_OPT=${XZ_OPT--e} xz -c &gt;libsamsung-ipc-0.7.0.tar.xz
    /bin/sh: line 1: xz: command not found
    /bin/sh: line 1: tar: command not found

And if we don't add bzip2 we still have the following error:
'guix shell --pure --container -f scripts/manifest.scm', we have the
following error:
    tardir=libsamsung-ipc-0.7.0 &amp;&amp; ${TAR-tar} chof - "$tardir" | \
          BZIP2=${BZIP2--9} bzip2 -c &gt;libsamsung-ipc-0.7.0.tar.bz2
    /bin/sh: line 1: bzip2: command not found

And we also need gzip:
    tardir=libsamsung-ipc-0.7.0 &amp;&amp; ${TAR-tar} chof - "$tardir" | \
            eval GZIP= gzip --best -c &gt;libsamsung-ipc-0.7.0.tar.gz
    /bin/sh: line 1: gzip: command not found

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts: manifest.scm: fix missing find</title>
<updated>2023-02-14T03:26:10+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2022-09-01T15:52:21+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=228bc79c2c24f2eca97bdc93898572e1e7681721'/>
<id>228bc79c2c24f2eca97bdc93898572e1e7681721</id>
<content type='text'>
Without that fix, when running make check with
'guix shell --pure --container -f scripts/manifest.scm', we have the
following error:
    test -n "" \
    || find "libsamsung-ipc-0.7.0" -type d ! -perm -755 \
    	-exec chmod u+rwx,go+rx {} \; -o \
      ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
      ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
      ! -type d ! -perm -444 -exec /bin/sh [...]/install-sh \
                                         -c -m a+r {} {} \; \
    || chmod -R a+r "libsamsung-ipc-0.7.0"
    /bin/sh: line 2: find: command not found

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Without that fix, when running make check with
'guix shell --pure --container -f scripts/manifest.scm', we have the
following error:
    test -n "" \
    || find "libsamsung-ipc-0.7.0" -type d ! -perm -755 \
    	-exec chmod u+rwx,go+rx {} \; -o \
      ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
      ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
      ! -type d ! -perm -444 -exec /bin/sh [...]/install-sh \
                                         -c -m a+r {} {} \; \
    || chmod -R a+r "libsamsung-ipc-0.7.0"
    /bin/sh: line 2: find: command not found

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts: manifest.scm: fix missing cmp</title>
<updated>2023-02-14T03:26:10+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2022-09-01T15:22:32+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=f70f5c066fb2d5bad58c48226508a74867f1f3ed'/>
<id>f70f5c066fb2d5bad58c48226508a74867f1f3ed</id>
<content type='text'>
Without that fix, when running ./configure with
'guix shell --pure --container -f scripts/manifest.scm', we have the
following warning:
    checking for a working dd... ./configure: line 7277: cmp: command
    not found

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Without that fix, when running ./configure with
'guix shell --pure --container -f scripts/manifest.scm', we have the
following warning:
    checking for a working dd... ./configure: line 7277: cmp: command
    not found

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts: manifest.scm: Add missing curl</title>
<updated>2023-02-14T03:26:09+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2022-09-01T15:04:06+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=72ac060112b53bca6a80de0ce9d3c32da4cf726d'/>
<id>72ac060112b53bca6a80de0ce9d3c32da4cf726d</id>
<content type='text'>
Without that fix, when running ./configure with
'guix shell --pure --container -f scripts/manifest.scm', we have the
following error:
    checking for libcurl &gt;= 7.62.0... no

    configure: error: Package requirements (libcurl &gt;= 7.62.0) were
    not met:

    No package 'libcurl' found

    Consider adjusting the PKG_CONFIG_PATH environment variable if you
    installed software in a non-standard prefix.

    Alternatively, you may set the environment variables
    LIBCURL_CFLAGS and LIBCURL_LIBS to avoid the need to call
    pkg-config.  See the pkg-config man page for more details.

This issue wasn't found before because builds in guix shell weren't
often tested with --container.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Without that fix, when running ./configure with
'guix shell --pure --container -f scripts/manifest.scm', we have the
following error:
    checking for libcurl &gt;= 7.62.0... no

    configure: error: Package requirements (libcurl &gt;= 7.62.0) were
    not met:

    No package 'libcurl' found

    Consider adjusting the PKG_CONFIG_PATH environment variable if you
    installed software in a non-standard prefix.

    Alternatively, you may set the environment variables
    LIBCURL_CFLAGS and LIBCURL_LIBS to avoid the need to call
    pkg-config.  See the pkg-config man page for more details.

This issue wasn't found before because builds in guix shell weren't
often tested with --container.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts: guix.scm: libsamsung-ipc-gcc-autotools: use new arguments style</title>
<updated>2023-02-14T03:26:09+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2023-02-14T01:23:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=b9eaadcf9792050ec83097439479dd0f8dd69d6f'/>
<id>b9eaadcf9792050ec83097439479dd0f8dd69d6f</id>
<content type='text'>
This commit should contain no functional changes.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit should contain no functional changes.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts: guix.scm: libsamsung-ipc-clang-autotools: use new arguments style</title>
<updated>2023-02-14T03:26:08+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2023-02-14T01:23:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=0521387112a004eda96d167143a0ebaa8e36afcf'/>
<id>0521387112a004eda96d167143a0ebaa8e36afcf</id>
<content type='text'>
This commit should contain no functional changes.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit should contain no functional changes.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts: guix.scm: sync packages list with guix style</title>
<updated>2023-02-14T03:26:08+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2023-02-14T01:23:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=94d0dfdeb5d7799f9ef3cba45634011858dc53d0'/>
<id>94d0dfdeb5d7799f9ef3cba45634011858dc53d0</id>
<content type='text'>
The guix style command reformats a package or a file to use the code
style used by Guix.

This commits sync the packages list definition with the output
produced by guix style.

This commit should contain no functional changes.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The guix style command reformats a package or a file to use the code
style used by Guix.

This commits sync the packages list definition with the output
produced by guix style.

This commit should contain no functional changes.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts: guix.scm: sync with-fixed-android-make-stub definition with guix style</title>
<updated>2023-02-14T03:26:08+00:00</updated>
<author>
<name>Denis 'GNUtoo' Carikli</name>
<email>GNUtoo@cyberdimension.org</email>
</author>
<published>2023-02-14T01:23:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.replicant.us/contrib/GNUtoo/replicant/hardware_replicant_libsamsung-ipc/commit/?id=46a84affc5703eb752660d1eb3ca8473e60a2089'/>
<id>46a84affc5703eb752660d1eb3ca8473e60a2089</id>
<content type='text'>
The guix style command reformats a package or a file to use the code
style used by Guix.

This commits sync the with-fixed-android-make-stub definition with the
output produced by guix style.

This commit should contain no functional changes.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The guix style command reformats a package or a file to use the code
style used by Guix.

This commits sync the with-fixed-android-make-stub definition with the
output produced by guix style.

This commit should contain no functional changes.

Signed-off-by: Denis 'GNUtoo' Carikli &lt;GNUtoo@cyberdimension.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
