From 3f7ccca648e855bd4decc6f8272559717f3d1295 Mon Sep 17 00:00:00 2001 From: Jeff Tinker Date: Mon, 9 Oct 2017 11:52:18 -0700 Subject: Fix information disclosure in mediadrmserver Test:poc provided in bug bug:62872384 Change-Id: I3d104a2a64a0cb81e9fd5b04c4def1fbee64da2d CVE-2017-13152 --- media/libmedia/IDrm.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/media/libmedia/IDrm.cpp b/media/libmedia/IDrm.cpp index 6f6530bfe2..637770ddb5 100644 --- a/media/libmedia/IDrm.cpp +++ b/media/libmedia/IDrm.cpp @@ -572,8 +572,13 @@ IMPLEMENT_META_INTERFACE(Drm, "android.drm.IDrm"); void BnDrm::readVector(const Parcel &data, Vector &vector) const { uint32_t size = data.readInt32(); - vector.insertAt((size_t)0, size); - data.read(vector.editArray(), size); + if (vector.insertAt((size_t)0, size) < 0) { + vector.clear(); + } + if (data.read(vector.editArray(), size) != NO_ERROR) { + vector.clear(); + android_errorWriteWithInfoLog(0x534e4554, "62872384", -1, NULL, 0); + } } void BnDrm::writeVector(Parcel *reply, Vector const &vector) const { -- cgit v1.2.3