/* * Copyright (C) 2017 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ #include #include #include #include #include #include #include #include extern const fs_path_config* __for_testing_only__android_dirs; extern const fs_path_config* __for_testing_only__android_files; extern bool (*__for_testing_only__fs_config_cmp)(bool, const char*, size_t, const char*, size_t); // Maximum entries in system/core/libcutils/fs_config.cpp:android_* before we // hit a nullptr termination, before we declare the list is just too big or // could be missing the nullptr. static constexpr size_t max_idx = 4096; static const struct fs_config_cmp_test { bool dir; const char* prefix; const char* path; bool match; } fs_config_cmp_tests[] = { // clang-format off { true, "system/lib", "system/lib/hw", true }, { true, "vendor/lib", "system/vendor/lib/hw", true }, { true, "system/vendor/lib", "vendor/lib/hw", true }, { true, "system/vendor/lib", "system/vendor/lib/hw", true }, { false, "vendor/bin/wifi", "system/vendor/bin/w", false }, { false, "vendor/bin/wifi", "system/vendor/bin/wifi", true }, { false, "vendor/bin/wifi", "system/vendor/bin/wifi2", false }, { false, "system/vendor/bin/wifi", "system/vendor/bin/wifi", true, }, { false, "odm/bin/wifi", "system/odm/bin/wifi", true }, { false, "oem/bin/wifi", "system/oem/bin/wifi", true }, { false, "data/bin/wifi", "system/data/bin/wifi", false }, { false, "system/bin/*", "system/bin/wifi", true }, { false, "vendor/bin/*", "system/vendor/bin/wifi", true }, { false, "system/bin/*", "system/bin", false }, { false, "system/vendor/bin/*", "vendor/bin/wifi", true }, { false, NULL, NULL, false }, // clang-format on }; static bool check_unique(std::vector& paths, const std::string& config_name, const std::string& prefix) { bool retval = false; std::string alternate = "system/" + prefix; for (size_t idx = 0; idx < paths.size(); ++idx) { size_t second; std::string path(paths[idx]); // check if there are multiple identical paths for (second = idx + 1; second < paths.size(); ++second) { if (path == paths[second]) { GTEST_LOG_(ERROR) << "duplicate paths in " << config_name << ": " << paths[idx]; retval = true; break; } } // check if path is / if (android::base::StartsWith(path, prefix.c_str())) { // rebuild path to be system//... to check for alias path = alternate + path.substr(prefix.size()); for (second = 0; second < paths.size(); ++second) { if (path == paths[second]) { GTEST_LOG_(ERROR) << "duplicate alias paths in " << config_name << ": " << paths[idx] << " and " << paths[second] << " (remove latter)"; retval = true; break; } } continue; } // check if path is system// if (android::base::StartsWith(path, alternate.c_str())) { // rebuild path to be /... to check for alias path = prefix + path.substr(alternate.size()); for (second = 0; second < paths.size(); ++second) { if (path == paths[second]) break; } if (second >= paths.size()) { GTEST_LOG_(ERROR) << "replace path in " << config_name << ": " << paths[idx] << " with " << path; retval = true; } } } return retval; } static bool check_unique(const fs_path_config* paths, const char* type_name, const std::string& prefix) { std::string config("system/core/libcutils/fs_config.cpp:android_"); config += type_name; config += "[]"; bool retval = false; std::vector paths_tmp; for (size_t idx = 0; paths[idx].prefix; ++idx) { if (idx > max_idx) { GTEST_LOG_(WARNING) << config << ": has no end (missing null prefix)"; retval = true; break; } paths_tmp.push_back(paths[idx].prefix); } return check_unique(paths_tmp, config, prefix) || retval; } static bool check_fs_config_cmp(const fs_config_cmp_test* tests) { bool match, retval = false; for (size_t idx = 0; tests[idx].prefix; ++idx) { match = __for_testing_only__fs_config_cmp(tests[idx].dir, tests[idx].prefix, strlen(tests[idx].prefix), tests[idx].path, strlen(tests[idx].path)); if (match != tests[idx].match) { GTEST_LOG_(ERROR) << tests[idx].path << (match ? " matched " : " didn't match ") << tests[idx].prefix; retval = true; break; } } return retval; } #define endof(pointer, field) (offsetof(typeof(*(pointer)), field) + sizeof((pointer)->field)) static bool check_unique(const std::string& config, const std::string& prefix) { int retval = false; std::string data; if (!android::base::ReadFileToString(config, &data)) return retval; const fs_path_config_from_file* pc = reinterpret_cast(data.c_str()); size_t len = data.size(); std::vector paths_tmp; size_t entry_number = 0; while (len > 0) { uint16_t host_len = (len >= endof(pc, len)) ? pc->len : INT16_MAX; if (host_len > len) { GTEST_LOG_(WARNING) << config << ": truncated at entry " << entry_number << " (" << host_len << " > " << len << ")"; const std::string unknown("?"); GTEST_LOG_(WARNING) << config << ": entry[" << entry_number << "]={ " << "len=" << ((len >= endof(pc, len)) ? android::base::StringPrintf("%" PRIu16, pc->len) : unknown) << ", mode=" << ((len >= endof(pc, mode)) ? android::base::StringPrintf("0%" PRIo16, pc->mode) : unknown) << ", uid=" << ((len >= endof(pc, uid)) ? android::base::StringPrintf("%" PRIu16, pc->uid) : unknown) << ", gid=" << ((len >= endof(pc, gid)) ? android::base::StringPrintf("%" PRIu16, pc->gid) : unknown) << ", capabilities=" << ((len >= endof(pc, capabilities)) ? android::base::StringPrintf("0x%" PRIx64, pc->capabilities) : unknown) << ", prefix=" << ((len >= offsetof(fs_path_config_from_file, prefix)) ? android::base::StringPrintf( "\"%.*s...", (int)(len - offsetof(fs_path_config_from_file, prefix)), pc->prefix) : unknown) << " }"; retval = true; break; } paths_tmp.push_back(pc->prefix); pc = reinterpret_cast(reinterpret_cast(pc) + host_len); len -= host_len; ++entry_number; } return check_unique(paths_tmp, config, prefix) || retval; } void check_two(const fs_path_config* paths, const char* type_name, const char* prefix) { ASSERT_FALSE(paths == nullptr); ASSERT_FALSE(type_name == nullptr); ASSERT_FALSE(prefix == nullptr); bool check_internal = check_unique(paths, type_name, prefix); EXPECT_FALSE(check_internal); bool check_overrides = check_unique(std::string("/") + prefix + "etc/fs_config_" + type_name, prefix); EXPECT_FALSE(check_overrides); } TEST(fs_config, vendor_dirs_alias) { check_two(__for_testing_only__android_dirs, "dirs", "vendor/"); } TEST(fs_config, vendor_files_alias) { check_two(__for_testing_only__android_files, "files", "vendor/"); } TEST(fs_config, oem_dirs_alias) { check_two(__for_testing_only__android_dirs, "dirs", "oem/"); } TEST(fs_config, oem_files_alias) { check_two(__for_testing_only__android_files, "files", "oem/"); } TEST(fs_config, odm_dirs_alias) { check_two(__for_testing_only__android_dirs, "dirs", "odm/"); } TEST(fs_config, odm_files_alias) { check_two(__for_testing_only__android_files, "files", "odm/"); } TEST(fs_config, system_alias) { EXPECT_FALSE(check_fs_config_cmp(fs_config_cmp_tests)); }