summaryrefslogtreecommitdiffstats
path: root/logd
Commit message (Collapse)AuthorAgeFilesLines
* logd: sepolicy dynamic rate limitingMark Salyzyn2017-01-046-17/+266
| | | | | | | | | | | | | | | | | | | | | | | | | | | Processing overhead for selinux violation messages is costly. We want to deal with bursts of violations, but we have no intent of allowing that sustained burst to go unabated as there is a cost of processing and battery usage. Tunables in libaudit.h are: AUDIT_RATE_LIMIT_DEFAULT 20 /* acceptable burst rate */ AUDIT_RATE_LIMIT_BURST_DURATION 10 /* number of seconds of burst */ AUDIT_RATE_LIMIT_MAX 5 /* acceptable sustained rate */ Since we can only asymptotically handle DEFAULT rate, we set an upper threshold of half way between the MAX and DEFAULT rate. Default kernel audit subsystem message rate is set to 20 a second. If sepolicy exceeds 125 violation messages over up to ten seconds (>=~12/s), tell kernel audit subsystem to drop the rate to 5 messages a second. If rate drops below 50 messages over the past ten seconds (<5/s), tell kernel it is ok to increase the burst rate back to 20 messages a second. Test: gTest logd-unit-tests --gtest_filter=logd.sepolicy_rate_limiter_* Bug: 27878170 Change-Id: I843f8dcfbb3ecfbbe94a4865ea332c858e3be7f2
* Merge "LogAudit.cpp: replace newlines with spaces in audit messages"Treehugger Robot2017-01-031-0/+7
|\
| * LogAudit.cpp: replace newlines with spaces in audit messagesNick Kralevich2017-01-031-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | Some kernels have a bug which causes a newline to show up in audit messages. The embedded newlines cause one message to look like two due to prefix controls. Replace any newlines with spaces. Duplicate spaces are further consolidated in code immediately after this newly added code. Test: create an audit message with a newline, and watch it be cleaned up. Bug: 27878170 Change-Id: Id90c29ab9e10d3be96f51403b0293622d782422a
* | logd: Add support for ro.logd.auditd.[main|events]Mark Salyzyn2017-01-034-10/+21
|/ | | | | | | | | | | | | | | | | | | | | log selinux audit messages boolean (true or false, default true) selection for logging destinations: ro.logd.auditd - turn on logd.auditd to pick up violations. ro.logd.auditd.dmesg - to the kernel log. ro.logd.auditd.main - to the "main" log buffer. ro.logd.auditd.events - to the "events" log buffer. We used to also read logd.auditd.dmesg and persist.logd.auditd.dmesg which do not get refreshed when /data mounts internally. This is a confusing state as these properties will be read after a logd crash and restart, adjusting the behavior of the logger. Same can be said for logd.auditd as well. Drop reading these other parameters. Test: manual set r/o parameters, stop/start logd to confirm behavior Bug: 33969000 Bug: 27878170 Change-Id: I1a6bb4a903074c9aa7b227cf583a0094d49cbefd
* logd: gtest: logd.timeout socket does not clean up properlyMark Salyzyn2016-12-291-10/+41
| | | | | | | | | | | | | | | | Until the socket ages out, it sticks around and gets reused in subsequent tests affecting the outcome of those tests. We opt to run logd.timeout in a forked and isolated process to keep these conditions from interfering. Adjusted benchmark execute to only run the tests we are interested in to improve the time it takes to run. Commented some areas of code to make them easier to maintain. Test: gTest logd-unit-tests success Bug: 33962045 Change-Id: Ic1b98bc4a2d7e8927f1a87628e3bcc368c9cf8ce
* logd: LogBufferElementKey use uint32_t for uidMark Salyzyn2016-12-211-4/+3
| | | | | Test: gTest liblog-unit-tests, logd-unit-tests & logcat-unit-test Change-Id: Icae34b1fa0b3df0a45ad175ec81aaf232f322f38
* Merge "logd: trailing spaces in log statistics (part deux)"Treehugger Robot2016-12-201-9/+12
|\
| * logd: trailing spaces in log statistics (part deux)Mark Salyzyn2016-12-191-9/+12
| | | | | | | | | | | | Test: manual Bug: 30118730 Change-Id: Iafda6f95e1b1377649e01868c81c0056c116e01b
* | Merge "Revert "logd: trailing spaces in log statistics""Treehugger Robot2016-12-201-1/+1
|\|
| * Revert "logd: trailing spaces in log statistics"Mark Salyzyn2016-12-191-1/+1
| | | | | | | | | | | | | | | | | | | | Caused +/- field data to land under the Pruned column This reverts commit 0adcc3e3e8bd6d7c57994f828ee22c104b4eb043. Test: manual Bug: 30118730 Change-Id: Ic75ce3a90baded19f3efc0cc77474fe5d9a8accd
* | Merge "logd: sum liblog tag messages"Treehugger Robot2016-12-192-23/+84
|\ \
| * | logd: sum liblog tag messagesMark Salyzyn2016-12-192-23/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As an extension to the duplicate multiple message filtering, special case liblog tagged event messages to be summed. This solves the inefficient and confusing duplicate message report from the DOS attack detection such as: liblog: 2 liblog: 2 liblog: 2 liblog: 2 liblog: 3 which would result in: liblog: 2 chatty: ... expire 2 lines liblog: 2 liblog: 3 And instead sums them and turns them all into: liblog: 11 liblog messages should never be subject to chatty conversion. Test: liblog-benchmarks manually check for coalesced liblog messages and make sure they do not turn into chatty messages. Instrumented code to capture sum intermediates to be sure. Bug: 33535908 Change-Id: I3bf03c4bfa36071b578bcd6f62234b409a91184b
* | | Merge "logd: correct duplicate message state machine"Treehugger Robot2016-12-191-6/+70
|\| |
| * | logd: correct duplicate message state machineMark Salyzyn2016-12-191-6/+70
| |/ | | | | | | | | | | | | | | | | | | | | | | Inspection turned up that for the case of three identical messages, the result would be a stutter of the first message only. Added comments to describe the state machine, incoming variables, outcoming and false condition outputs, for proper maintenance in the future. Test: gTest liblog-benchmarks BM_log_maximum* and manually check for correct midstream chatty messages, Bug: 33535908 Change-Id: I852260d18a484e6207b80063159f1a74eaa83b55
* / logd: add android::sizesTotal() functionMark Salyzyn2016-12-193-1/+10
|/ | | | | | Test: gTest liblog-unit-tests, logd-unit-tests and logcat-unit-tests Bug: 31456426 Change-Id: I6fb6cd589227fc43d22f9336e01f1bf7e3feb24c
* logd: record multiple duplicate messages as chattyMark Salyzyn2016-12-1510-42/+262
| | | | | | | | | | | | | | | | | | | | If a series of messages arrive from a single source with identical message content payload, then suppress them and generate a chatty report. The checking is done on a per log id basis. This alters the assumption that chatty messages are always at the oldest entries, they now show up in the middle too. To address this change in behavior we print the first line, a chatty reference which internally takes little space, then the last line in the series. This does not conserve processing time in logd, and certainly has no impact on the long path of formatting and submitting log messages from from the source, but it may contribute to memory space and signal to noise savings under heavy spammy loads. Test: gTest liblog-unit-tests, logd-unit-tests & logcat-unit-tests Bug: 33535908 Change-Id: I3160c36d4f4e2f8216f528605a1b3993173f4dec
* Define range of GIDs for cached app data.Jeff Sharkey2016-12-131-1/+1
| | | | | | | | | | | | | | | To support upcoming disk usage calculation optimizations, this change creates a new GID for each app that will be used to mark its cached data. We're allocating these unique GIDs so that we can use quotactl() to track cached data on a per-app basis. This change also tightens up the implementation of both the cache and shared GID calculation to ensure that they stay inside the valid ranges, and includes tests to verify. Test: builds, boots, tests pass Bug: 27948817 Change-Id: Ie4377e5aae267f2da39a165888139228995987cb
* utils: Add FastStrcmp.hMark Salyzyn2016-12-096-33/+17
| | | | | | | | | | Move existing fast<str*cmp> templates for general use, pulled from the implementation used in logd that dealt with speed through cache locality and subroutine call mitigation. Rename to fastcmp. Test: logd-benchmarks and based on manual profiling from the past Bug: 31456426 Change-Id: Ic62f4a437fc3e06ffdeaae73a6f34e197957a6b0
* Merge "system/core: replace EVENT_TAG_MAP_FILE with NULL"Mark Salyzyn2016-11-291-1/+1
|\ | | | | | | | | | | am: 9bfd9f558b Change-Id: Ief7fcc4f7dd8086186b38c091fed626560ca7215
| * system/core: replace EVENT_TAG_MAP_FILE with NULLMark Salyzyn2016-11-211-1/+1
| | | | | | | | | | | | | | | | | | | | NULL represents system default. In the future, NULL could represent static and dynamic tags, which can come from multiple files based on implementation details in the liblog library. Test: gTest logd-unit-tests & liblog-unit-tests Bug: 31456426 Change-Id: I0e3d296de81ca299ae63d7b83781639ee67ec298
* | Merge "logd: add EXIT command"Mark Salyzyn2016-11-182-14/+46
|\| | | | | | | | | | | am: 16300f192b Change-Id: Idd68cfba26f8fcc928db4fe2483d30e5d4f49a59
| * logd: add EXIT commandMark Salyzyn2016-11-172-14/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Debugging aid. Allows us to run: $ cat -n '<STUFF>\0EXIT\0' | nc -U /dev/socket/logd and the pipeline will exit once done. Without the EXIT command we will have to <CTRL+C> out to terminate the pipeline. This is necessary since Android's netcat command does not support the -q feature, and having the EXIT command is faster and cleaner anyways. Test: manual as noted above. Bug: 31456426 Change-Id: I65333358188db85e2eb1bb6a14deed1565826ac4
* | Merge "libcutils: move cutils/files.h to cutils/android_get_control_file.h"Mark Salyzyn2016-11-171-1/+1
|\| | | | | | | | | | | am: 8c41e791ed Change-Id: Ifbc00285da734859d590153a7c6cfc8e51c014f9
| * libcutils: move cutils/files.h to cutils/android_get_control_file.hMark Salyzyn2016-11-161-1/+1
| | | | | | | | | | | | | | | | | | | | files.[h|cpp] is bound to be abused with junk, replace with android_get_control_file.[h|cpp]. Plus some sundry cleanup. Test: gTest libcutils-tests, logd-unit-tests, liblog-unit-tests, logcat-unit-tests and init_tests Bug: 32450474 Change-Id: Ibd4a7aa4624ea19a43d1f98a3c71ac37805d36b5
* | logd: report last prune memory overheadMark Salyzyn2016-11-041-2/+8
|\| | | | | | | | | | | am: b0672290e3 Change-Id: I4b060ad4427e24170cc7a3aeae7aa9f6643ba8d6
| * logd: report last prune memory overheadMark Salyzyn2016-11-041-2/+8
| | | | | | | | | | | | | | | | | | | | An estimate based on chatty impact for all known pids, uids and tags and per log id if applicable, calculate the maximum last pruned watermark iterator map usage and add to the Total Overhead. Test: Confirm that the Total Overhead change is negligable. Bug: 31942525 Change-Id: Icd2e9bc0747c3376ca0e9c90aa110c103529d98f
* | logd: report statistics memory overheadMark Salyzyn2016-11-042-0/+43
|\| | | | | | | | | | | am: 6d981af120 Change-Id: I69376a8783867a21f0cd85eea4b299f3d2c81a95
| * logd: report statistics memory overheadMark Salyzyn2016-11-042-0/+43
| | | | | | | | | | | | | | | | | | Add in to the Total Overhead the amount of storage we are using to hold on to the statistics. Test: see that the Total Overhead accounts for about 100K Bug: 31942525 Change-Id: Ibe241c0bccc5a9df52395802338c8a7fc3b64104
| * Merge changes I432016e2,Id208b11b,Ia6a38729,Icdaf9e35,I842a7a64, ...Treehugger Robot2016-11-043-60/+130
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * changes: logd: if eng build, be a bit more permissive about failures libcutils: klog inherit android_get_control_file("/dev/kmsg") logd: start logd service in logd uid logd: auditd + klogd control CAPS logd: drop capabilities in logd --reinit and logd.daemon logd: drop libminijail dependency logd: start logd services in logd gid logd: set executable's capabilities in file system logd: inherit android_get_control_file() init: service file keyword libcutils: add android_get_control_file() libcutils: add android_get_control_socket() test
* | \ logd: if eng build, be a bit more permissive about failuresMark Salyzyn2016-11-041-10/+17
|\ \ \ | | |/ | |/| | | | | | | | | | am: 107e29ac1b Change-Id: I85ebcae9f756bf2feb79e6d77ea63ad0b2ff4829
| * | logd: if eng build, be a bit more permissive about failuresMark Salyzyn2016-11-031-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | Allows us some leaway to investigate logd issues on eng builds Test: gTests logd-unit-tests, liblog-unit-tests and logcat-unit-tests Manual on eng builds, bad logd.rc to fake permission issues Bug: 32450474 Change-Id: I432016e29e5601d67c502076ead941cecdcbebe7
* | | logd: start logd service in logd uidMark Salyzyn2016-11-041-0/+1
|\| | | | | | | | | | | | | | | | | am: 77fdb22cf6 Change-Id: I38d93fb74ea4f37ee137f78063d082637b8fd68a
| * | logd: start logd service in logd uidMark Salyzyn2016-11-031-0/+1
| | | | | | | | | | | | | | | | | | | | | Test: gTest logd-unit-tests, liblog-unit-tests and logcat-unit-tests Manual inspect grep '^Cap' /proc/<tid>/status for correct capabilities Bug: 32450474 Change-Id: Ia6a3872901969a789d4309d410dbfd5f5d17b3ce
* | | logd: auditd + klogd control CAPSMark Salyzyn2016-11-041-7/+7
|\| | | | | | | | | | | | | | | | | am: d2b3291ffa Change-Id: I7d8fd4a7df7ceffd90e8eaab03861ae426cbf35b
| * | logd: auditd + klogd control CAPSMark Salyzyn2016-11-031-7/+7
| | | | | | | | | | | | | | | | | | Test: gTest logd-unit-tests, liblog-unit-tests and logcat-unit-testsa Bug: 32450474 Change-Id: Icdaf9e352e86c9e140928509201da743004aeedb
* | | logd: drop capabilities in logd --reinit and logd.daemonMark Salyzyn2016-11-041-31/+39
|\| | | | | | | | | | | | | | | | | am: d8f01807b8 Change-Id: I17f06463258e95a6cc83242cc8a8d4bb0ccb4907
| * | logd: drop capabilities in logd --reinit and logd.daemonMark Salyzyn2016-11-031-31/+39
| | | | | | | | | | | | | | | | | | Test: gTest logd-unit-tests, liblog-unit-tests and logcat-unit-tests Bug: 32450474 Change-Id: I842a7a64f0ba695acef66caf54270f9475c9f9ac
* | | logd: drop libminijail dependencyMark Salyzyn2016-11-042-9/+47
|\| | | | | | | | | | | | | | | | | am: f0b8e1bce6 Change-Id: I968916b41f82fa1cbe4f7ac37dc75c938a9c1627
| * | logd: drop libminijail dependencyMark Salyzyn2016-11-032-9/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | Use libcap instead of libminijail. Set CAP_SETGID before setgroups, then clear it afterwards. Test: gTest logd-unit-tests, liblog-unit-tests and logcat-unit-tests Bug: 32450474 Change-Id: I2ed027fd5efd95f76b1dd4c5791bae5f2ea94c28
* | | logd: start logd services in logd gidMark Salyzyn2016-11-041-1/+3
|\| | | | | | | | | | | | | | | | | am: 5b44340acb Change-Id: Id9f27660a09e640815071dac85ed4bac78172886
| * | logd: start logd services in logd gidMark Salyzyn2016-11-031-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | logd - start as root:logd+system+readproc logd-reinit - start as logd:logd ToDo: start as logd:logd+system+readproc (libminijail) Test: gTest logd-unit-tests, liblog-unit-tests and logcat-unit-tests Bug: 32450474 Change-Id: I42c806ca1730a7f9eb9e34f064ae31a2ef9fc678
* | | logd: inherit android_get_control_file()Mark Salyzyn2016-11-042-16/+30
|\| | | | | | | | | | | | | | | | | am: e0b8ccd1a3 Change-Id: I7b6fc3898d2e69542309fe120122849579f91f22
| * | logd: inherit android_get_control_file()Mark Salyzyn2016-11-032-16/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | Setup and then collect from the environment /proc/kmsg and /dev/kmsg file descriptors. Do not do so for logcat --reinit. Test: gTest logd-unit-tests, liblog-unit-tests and logcat-unit-tests Bug: 32450474 Change-Id: Ied537ca561fcd4e71a9ad9c57398a23ba23f6ced
* | | Merge "logd: switch to using arraysize() from libbase macros"Mark Salyzyn2016-11-032-6/+8
|\ \ \ | | |/ | |/| | | | | | | | | | am: fc08963f85 Change-Id: If17fd9389ec65f379fa42096e835be2ed667f703
| * | Merge "logd: switch to using arraysize() from libbase macros"Treehugger Robot2016-11-032-6/+8
| |\ \ | | |/ | |/|
| | * logd: switch to using arraysize() from libbase macrosMark Salyzyn2016-11-032-6/+8
| | | | | | | | | | | | | | | | | | Test: logd-unit-tests, liblog-unit-tests & logcat-unit-tests Bug: 32450474 Change-Id: Iacdc4677f2c83898a7812c2af2c36e7ff7d92764
* | | logd: clear DUMPABLEMark Salyzyn2016-11-031-0/+5
|\| | | | | | | | | | | | | | | | | am: 6a70ded7bf Change-Id: I4bcfb53d9c4a13761c80a8f2070320c85b486b0b
| * | logd: clear DUMPABLEMark Salyzyn2016-11-031-0/+5
| |/ | | | | | | | | | | | | | | Do not allow anyone to see logd memory. Test: gTest logd-unit-tests, liblog-unit-tests and logcat-unit-tests Bug: 32450474 Change-Id: Ic7377efcb7e1d3cd91b50741061037a0fb589045
* | Merge "logd: getTag() functional for chatty entries"Mark Salyzyn2016-10-263-25/+53
|\| | | | | | | | | | | am: fbe0b45544 Change-Id: I20705e262af4ed7c36616459b1f37dadca294277
| * logd: getTag() functional for chatty entriesMark Salyzyn2016-10-253-25/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | getTag() becomes invalid when entry is dropped because mMsg disappears to save space; but the per-tag spam filter depends on it still being valid. Conserve space in LogBufferElement by optimizing the size of the fields, then add a new mTag field that is set in the object constructor. Add an isBinary() method. SideEffects: save 12 bytes/log message overhead on 64-bit. Test: define DEBUG_CHECK_FOR_STALE_ENTRIES and look for stale entries Bug: 32247044 Change-Id: Iaa5f416718a92c9e0e6ffd56bd5260d8b908d5c0
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-25 04:37:15 +0000