replicant/core/libmemunreachable, branch master Patches not merged yet, used for building and testing them Make memunreachable_test more robust against false negative leaks 2018-05-15T05:17:44+00:00 Colin Cross ccross@android.com 2018-05-14T21:55:39+00:00 05dca7ae962b2c9f7b038cea21cf318468a18404 For some reason, the memunreachable tests are rock solid on the devices covered by APCT, but catch a ton of false-negatives on hikey960, which show up as failures that look like: system/core/libmemunreachable/tests/MemUnreachable_test.cpp:200: Failure Expected equality of these values: 1U Which is: 1 info.leaks.size() Which is: 0 These happen when a stray copy of a pointer is lying around that points to the memory it is expected to leak. The stray pointers can be on the stack or in the jemalloc thread cache of freed allocations, which is always considered active memory. Add some extra cleanups to get rid of old pointers. 1. Clear the tcache when destructing UnreachableMemoryInfo 2. Clear the stack and tcache before and after each test 3. Make MemunreachbleTest.twice match MemunreachableTest.stack Also fix MemunreachableTest.notdumpable, which was only passing when run as root, which was bypassing what the test was trying to cover. Make the test pass when run as non-root, and skip when the test is running as root. Bug: 79701104 Test: memunreachable_test Test: memunreachable_test as root Change-Id: Ia6c6df11e76405d08118afcc19c1fe80a6684c56 Merged-In: Ia6c6df11e76405d08118afcc19c1fe80a6684c56 (cherry picked from commit ca71f170b78e4707dbaa5bf4ddace47a455b4699) 
For some reason, the memunreachable tests are rock solid on the
devices covered by APCT, but catch a ton of false-negatives on
hikey960, which show up as failures that look like:
system/core/libmemunreachable/tests/MemUnreachable_test.cpp:200: Failure
Expected equality of these values:
  1U
    Which is: 1
  info.leaks.size()
    Which is: 0

These happen when a stray copy of a pointer is lying around that
points to the memory it is expected to leak.  The stray pointers
can be on the stack or in the jemalloc thread cache of freed
allocations, which is always considered active memory.

Add some extra cleanups to get rid of old pointers.
1.  Clear the tcache when destructing UnreachableMemoryInfo
2.  Clear the stack and tcache before and after each test
3.  Make MemunreachbleTest.twice match MemunreachableTest.stack

Also fix MemunreachableTest.notdumpable, which was only passing
when run as root, which was bypassing what the test was trying
to cover.  Make the test pass when run as non-root, and skip
when the test is running as root.

Bug: 79701104
Test: memunreachable_test
Test: memunreachable_test as root
Change-Id: Ia6c6df11e76405d08118afcc19c1fe80a6684c56
Merged-In: Ia6c6df11e76405d08118afcc19c1fe80a6684c56
(cherry picked from commit ca71f170b78e4707dbaa5bf4ddace47a455b4699)
Remove test_suites: ["vts"] from memunreachable_binder_test 2018-04-18T23:35:05+00:00 Colin Cross ccross@android.com 2018-03-15T21:22:20+00:00 2f569b75a4a90641965e8427445553df5f6abd7f memunreachable_binder_test is pulled in by test/vts/tools/build/tasks/list/vts_test_bin_package_list.mk, it doesn't need to be listed in test_suites. Fixes warnings: build/make/core/base_rules.mk:620: warning: overriding commands for target `out/host/linux-x86/vts/android-vts/testcases/memunreachable_binder_test' build/make/core/base_rules.mk:620: warning: ignoring old commands for target `out/host/linux-x86/vts/android-vts/testcases/memunreachable_binder_test' Bug: 78229249 Test: vts-tradefed run commandAndExit vts -m VtsKernelBinderTest Change-Id: Ifd282b2f5bb652295fa34ad247919eb85ea7abc8 Merged-In: Ifd282b2f5bb652295fa34ad247919eb85ea7abc8 (cherry picked from commit f013b621520bbfaaeb165ddd430accbe3fe66df2) 
memunreachable_binder_test is pulled in by
test/vts/tools/build/tasks/list/vts_test_bin_package_list.mk, it
doesn't need to be listed in test_suites.

Fixes warnings:
build/make/core/base_rules.mk:620: warning: overriding commands for target `out/host/linux-x86/vts/android-vts/testcases/memunreachable_binder_test'
build/make/core/base_rules.mk:620: warning: ignoring old commands for target `out/host/linux-x86/vts/android-vts/testcases/memunreachable_binder_test'

Bug: 78229249
Test: vts-tradefed run commandAndExit vts -m VtsKernelBinderTest
Change-Id: Ifd282b2f5bb652295fa34ad247919eb85ea7abc8
Merged-In: Ifd282b2f5bb652295fa34ad247919eb85ea7abc8
(cherry picked from commit f013b621520bbfaaeb165ddd430accbe3fe66df2)
Make memunreachable_binder_test suitable for VTS 2018-02-28T02:29:18+00:00 Colin Cross ccross@android.com 2018-02-28T00:00:00+00:00 51e6c252c495234fc4acc256d65fcb04888357a2 Link statically against libmemunreachable to avoid runtime dependency on libmemunreachable.so. Provide a better error when run as non-root. Rename the test to MemunreachableBinderTest. Add comments explaining the test sequence. Bug: 28275695 Test: memunreachable_binder_test Change-Id: Iddfba636205b7ca3ad31a6ba2c4e85abadd32d0d 
Link statically against libmemunreachable to avoid runtime
dependency on libmemunreachable.so.
Provide a better error when run as non-root.
Rename the test to MemunreachableBinderTest.
Add comments explaining the test sequence.

Bug: 28275695
Test: memunreachable_binder_test
Change-Id: Iddfba636205b7ca3ad31a6ba2c4e85abadd32d0d
bpfmt. 2018-02-17T01:58:14+00:00 Elliott Hughes enh@google.com 2018-02-17T01:58:14+00:00 dc699a269f6a22af6cbba0f6e1359fde103dc4d3 Bug: N/A Test: builds Change-Id: I89ad00e1c4c7e0767bc80a7ac7935a4d55e090ac 
Bug: N/A
Test: builds
Change-Id: I89ad00e1c4c7e0767bc80a7ac7935a4d55e090ac
Add explanation for clone use 2018-02-08T23:07:47+00:00 Daniel Colascione dancol@google.com 2018-02-08T23:06:43+00:00 b650aef2a031fbb6cc2a7bef832fa60eb355f9a1 Test: no code changes Change-Id: I70c8af8261cda3163677557fd78ae0119b1f1be0 
Test: no code changes
Change-Id: I70c8af8261cda3163677557fd78ae0119b1f1be0
Add OWNERS. 2017-12-07T21:30:03+00:00 Elliott Hughes enh@google.com 2017-12-07T19:31:02+00:00 693d63f9cfc21e3334c6f8f228d73c4fb60ced8b Bug: N/A Test: N/A Change-Id: Ie785058c0f5eb9b4086c98ccba6e63e3ed411b65 
Bug: N/A
Test: N/A
Change-Id: Ie785058c0f5eb9b4086c98ccba6e63e3ed411b65
Silence static analyzer warnings about memory leaks 2017-09-24T20:36:29+00:00 George Burgess IV gbiv@google.com 2017-09-24T20:36:29+00:00 80136a1e4142d66846cf9024ac83346a9444cdca The static analyzer complains that this memory is leaked regardless of how I try to work around it (unless we escape the memory by using a global or something, but...). Basically, as long as there's some sort of operation on the reinterpret_cast'ed pointer, it complains. If we remove the bitwise negations, it doesn't. Doing so would presumably defeat the purpose of this test, though, so add a NOLINT. Bug: 27101951 Test: mma. No more static analyzer warning for this file. Change-Id: If9008946a2145d17b8651535141bfd7ec9224739 
The static analyzer complains that this memory is leaked regardless of
how I try to work around it (unless we escape the memory by using a
global or something, but...). Basically, as long as there's some sort
of operation on the reinterpret_cast'ed pointer, it complains. If we
remove the bitwise negations, it doesn't. Doing so would presumably
defeat the purpose of this test, though, so add a NOLINT.

Bug: 27101951
Test: mma. No more static analyzer warning for this file.
Change-Id: If9008946a2145d17b8651535141bfd7ec9224739
Fix static analyzer warnings 2017-09-13T00:01:20+00:00 George Burgess IV gbiv@google.com 2017-09-12T23:54:53+00:00 180e5e7021d17176bf2f5f110970e58cb19d6310 The static analyzer was complaining that we were potentially leaking memory here (in `ASSERT_NE(ptr, nullptr)` after `new (char)`). This wasn't correct, but it's also not possible for `new` to return nullptr without std::nothrow. In any case, swap to direct calls to `::operator new`, since it looks like this test explicitly wants calls to `::operator new` to be emitted (which the C++ standard doesn't guarantee for all `new` expressions). Bug: 27101951 Test: mma; static analyzer warnings are gone. Also ran memunreachable_test on marlin; no failures. Change-Id: Ia740e41079f263040da978ba1ccc71c9c39f53fd 
The static analyzer was complaining that we were potentially leaking
memory here (in `ASSERT_NE(ptr, nullptr)` after `new (char)`). This
wasn't correct, but it's also not possible for `new` to return nullptr
without std::nothrow.

In any case, swap to direct calls to `::operator new`, since it looks
like this test explicitly wants calls to `::operator new` to be emitted
(which the C++ standard doesn't guarantee for all `new` expressions).

Bug: 27101951
Test: mma; static analyzer warnings are gone. Also ran
memunreachable_test on marlin; no failures.
Change-Id: Ia740e41079f263040da978ba1ccc71c9c39f53fd
Define current ABI string in android-base/macros.h 2017-08-23T18:46:38+00:00 dimitry dimitry@google.com 2017-08-23T08:25:22+00:00 b6ba817de4b80ec2430383899b051e86dd2bec27 Test: make Change-Id: I8200d7b3232edba43a583c5ff1e1b0f78c768f69 
Test: make
Change-Id: I8200d7b3232edba43a583c5ff1e1b0f78c768f69
Remove LOCAL_CLANG and clang: true 2017-07-25T12:29:50+00:00 Lennart Wieboldt lennart.1997@gmx.de 2017-07-24T17:32:07+00:00 cd15fc7ba80b31539e85792ec35d7ebe0c8ff764 clang is the default compiler since Android nougat Test: mma & verified it´s still build with clang Change-Id: I34adaeef2f6558a09f26027271222bad94780507 Signed-off-by: Lennart Wieboldt <lennart.1997@gmx.de> 
clang is the default compiler since Android nougat

Test: mma & verified it´s still build with clang
Change-Id: I34adaeef2f6558a09f26027271222bad94780507
Signed-off-by: Lennart Wieboldt <lennart.1997@gmx.de>