replicant/core/fastboot/usb_windows.c, branch master Patches not merged yet, used for building and testing them Move fastboot's Windows code to C++. 2015-06-24T17:48:43+00:00 Elliott Hughes enh@google.com 2015-06-24T17:48:43+00:00 c636b64e31cefab659f11d05fcdbedf2fb9cf4c1 Change-Id: I92414594cbdbc1896402c6d950d890042f8df6cf 
Change-Id: I92414594cbdbc1896402c6d950d890042f8df6cf
Fix adb/fastboot windows compilations. 2014-12-10T00:03:29+00:00 Christopher Ferris cferris@google.com 2014-11-06T22:34:24+00:00 67a7a4ae274ebd873a78e791b96da35a210db0cc Many of the windows files where not including stdlib.h even though they are using malloc/free calls. (cherry-pick of ae7bf0959bd3f79afbf365e41f015ed1c304afdc.) Change-Id: If6959df9909d9d9928e9f4a2a96018166361cf3c 
Many of the windows files where not including stdlib.h even though they
are using malloc/free calls.

(cherry-pick of ae7bf0959bd3f79afbf365e41f015ed1c304afdc.)

Change-Id: If6959df9909d9d9928e9f4a2a96018166361cf3c
fastboot: turn on -Werror 2014-05-14T15:33:56+00:00 Mark Salyzyn salyzyn@google.com 2014-04-30T21:05:28+00:00 5957c1ffe79b34d8b1859f9f11644d1007193cbc - Deal with a missing initializer issue - Deal with some -Wunused issues - Deal with some signed/unsigned issues - switch to usleep from sleep to facilitate win_sdk compile Change-Id: I64e32a5b0782aeed9582f489e866173c4df1afbf 
- Deal with a missing initializer issue
- Deal with some -Wunused issues
- Deal with some signed/unsigned issues
- switch to usleep from sleep to facilitate win_sdk compile

Change-Id: I64e32a5b0782aeed9582f489e866173c4df1afbf
Fastboot: fix fastboot timeout issue of Windows host side 2014-04-25T06:15:08+00:00 Jiebing Li jiebing.li@intel.com 2012-08-07T06:29:21+00:00 bbb7981e49048a657d724bfda9465cdfe7c03a87 Normally fastboot follows the procedure that host sends a command to device and device sends back response after the command is executed. But sometimes device spends too long time to execute the command so that timeout error occurs before host receives the response. This patch fixes the issue by aligning with the solution of ADB. ADB commit id: 1c4b760a5d41de3196572d50d1404e453174cf9a Change-Id: I50e6bf428ea38219b64cca6ab82db22af28e0264 Author: Jiebing Li <jiebing.li@intel.com> Signed-off-by: Bo Huang <bo.b.huang@intel.com> 
Normally fastboot follows the procedure that host sends a command
to device and device sends back response after the command
is executed.

But sometimes device spends too long time to execute the command
so that timeout error occurs before host receives the response.

This patch fixes the issue by aligning with the solution of ADB.
ADB commit id: 1c4b760a5d41de3196572d50d1404e453174cf9a

Change-Id: I50e6bf428ea38219b64cca6ab82db22af28e0264
Author: Jiebing Li <jiebing.li@intel.com>
Signed-off-by: Bo Huang <bo.b.huang@intel.com>
Wait for device to disappear after reboot-bootloader. 2013-10-17T20:06:32+00:00 Mark Wachsler wachsler@google.com 2013-10-02T13:35:38+00:00 157b00171a06f9ac2fd25ee3a86e801e896713d6 (Linux only for now) With fastboot reading serial numbers from sysfs, it had become possible for a fastboot command issued immediately after rebooting the bootloader to fail, because sysfs still thought the device was online. To prevent this, after reboot-bootloader we wait for the device to disconnect. Also made usb_read and usb_write fail immediately if the descriptor has been closed; this prevents an incorrect error message ("Bad file descriptor") when errors from fb_getvar are ignored (e.g., by fb_format_supported). Also removed unused fd param from filter_usb_device, and simplified logic in usb_write by using do/while instead of a special case for len == 0. Change-Id: I799b857eab411fd8ad25f5777fc61c685152ea86 
(Linux only for now) With fastboot reading serial numbers from sysfs, it had
become possible for a fastboot command issued immediately after rebooting
the bootloader to fail, because sysfs still thought the device was online.
To prevent this, after reboot-bootloader we wait for the device to disconnect.

Also made usb_read and usb_write fail immediately if the descriptor has been
closed; this prevents an incorrect error message ("Bad file descriptor")
when errors from fb_getvar are ignored (e.g., by fb_format_supported).

Also removed unused fd param from filter_usb_device, and simplified logic
in usb_write by using do/while instead of a special case for len == 0.

Change-Id: I799b857eab411fd8ad25f5777fc61c685152ea86
resolved conflicts for merge of 13081c69 to master 2012-05-02T01:34:22+00:00 Scott Anderson saa@android.com 2012-05-02T01:34:22+00:00 a61bcad58ba1f7359183a333ee58303ed67e4a2f Change-Id: I631e466fc53e9b0f4a39f24f959b4ae9b626bdda 
Change-Id: I631e466fc53e9b0f4a39f24f959b4ae9b626bdda
fastboot: Add ability to specify device path 2012-04-19T18:59:09+00:00 Scott Anderson saa@android.com 2012-04-06T19:39:30+00:00 13081c6915220db03886b177f1a8e0b2c63467c9 For manufacturing and testing, there is a need to talk to whatever device is connected to a given port on the host. This change modifies fastboot's "-s" option to take either a serial number or a device path. The device paths of the connected devices can be listed using "fastboot -l devices" whose output will resemble: 016B75D60A00600D usb:2-5 fastboot AD3C12020173 usb:1-4.3 fastboot The second column lists the device paths. If the -l option is not given, the output from "fastboot devices" will be the same as it used to be (i.e. the paths will not be printed). Finally, note that the format of the device paths are platform dependent. The example above is from Linux. On OS-X, the paths will be "usb:" followed by hex digits. For Windows, the device paths will be printed as "????????????" and the -s option will not be able to select a device until someone implements the underlying functionality in usb_windows.c. Change-Id: I1f01b8f47acd32edb0ac18db107316a2c923bbde Signed-off-by: Scott Anderson <saa@android.com> 
For manufacturing and testing, there is a need to talk to
whatever device is connected to a given port on the host.  This
change modifies fastboot's "-s" option to take either a serial
number or a device path.  The device paths of the connected
devices can be listed using "fastboot -l devices" whose output
will resemble:

    016B75D60A00600D	usb:2-5	fastboot
    AD3C12020173	usb:1-4.3	fastboot

The second column lists the device paths.  If the -l option is
not given, the output from "fastboot devices" will be the same as
it used to be (i.e. the paths will not be printed).

Finally, note that the format of the device paths are platform
dependent.  The example above is from Linux.  On OS-X, the paths
will be "usb:" followed by hex digits.  For Windows, the device
paths will be printed as "????????????" and the -s option will
not be able to select a device until someone implements the
underlying functionality in usb_windows.c.

Change-Id: I1f01b8f47acd32edb0ac18db107316a2c923bbde
Signed-off-by: Scott Anderson <saa@android.com>
Remove trailing whitespaces 2012-02-28T15:21:08+00:00 Anatol Pomazau anatol@google.com 2012-02-28T15:21:08+00:00 5ae3f93f3bafbeb1fc9a3324475c58c725749c5e Change-Id: I6f83333a6ee0fbc562a12bb9555c43a44c98768e 
Change-Id: I6f83333a6ee0fbc562a12bb9555c43a44c98768e
Enlarge USB bulk transfer size for faster downloads 2011-03-28T16:45:21+00:00 David Krause david.krause@motorola.com 2011-03-08T06:10:16+00:00 913eb8bf874fcec647667bd7113da65b6e38488a The default USB transfer bulk is fixed as 4096 in fastboot util code for Windows and Linux. Enlarging the bulk size can greatly improve the image download speed via USB. For Windows, adjust the max bulk size to 1MB to maximize the USB transfer speed. With this change, the USB transfer speed can be doubled to 20MB/s. For Linux, adjust the max bulk size to 16384 to maximize the USB transfer speed according to MAX_USBFS_BUFFER_SIZE definition in drivers/usb/core/devio.c. For OSX, the maxLenToSend is already 1MB in code. Change-Id: If6af8c6301f6f6c2ef345e37241706f16d8f5cda 
The default USB transfer bulk is fixed as 4096 in fastboot util code for
Windows and Linux. Enlarging the bulk size can greatly improve the image
download speed via USB.

For Windows, adjust the max bulk size to 1MB to maximize the USB transfer
speed. With this change, the USB transfer speed can be doubled to 20MB/s.

For Linux, adjust the max bulk size to 16384 to maximize the USB transfer
speed according to MAX_USBFS_BUFFER_SIZE definition in drivers/usb/core/devio.c.

For OSX, the maxLenToSend is already 1MB in code.

Change-Id: If6af8c6301f6f6c2ef345e37241706f16d8f5cda
Make fastboot say "no permissions" for non-writable devices. 2009-10-07T01:07:49+00:00 Elliott Hughes enh@google.com 2009-10-07T01:07:49+00:00 b4add9b74525210478bac702d27fdaf9cf7ab18f Without this patch, "adb devices" will say "no permissions" when it sees a device it can't write to, but "fastboot devices" will silently ignore it. This is confusing to n00bs, especially since it doesn't seem to be widely known that a device's USB id might be different in the bootloader (meaning two udev rules are needed). It can also be confusing if you're sshed in, when you can't access the device because you won't be in the "plugdev" group, but "fastboot devices" won't make this clear. I'm not sure about the Mac OS and Windows changes. AIUI, devices are always writable on those platforms, but I don't use either, so I can't test this. This patch shouldn't alter the behavior on either of those platforms. 
Without this patch, "adb devices" will say "no permissions" when it sees
a device it can't write to, but "fastboot devices" will silently ignore it.
This is confusing to n00bs, especially since it doesn't seem to be widely
known that a device's USB id might be different in the bootloader (meaning
two udev rules are needed). It can also be confusing if you're sshed in,
when you can't access the device because you won't be in the "plugdev"
group, but "fastboot devices" won't make this clear.

I'm not sure about the Mac OS and Windows changes. AIUI, devices are always
writable on those platforms, but I don't use either, so I can't test this.
This patch shouldn't alter the behavior on either of those platforms.