diff options
| author | Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> | 2020-11-07 23:51:42 +0100 |
|---|---|---|
| committer | Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> | 2020-11-08 01:30:08 +0100 |
| commit | f9012aabdf4148e7b7c2b82c5cc242a1678bda2c (patch) | |
| tree | e54b9888f805284963949a42091df22a52c29445 | |
| parent | 1545189a7b49fc3d54e8698f3a62bd1c6165daa3 (diff) | |
| download | hardware_replicant_libsamsung-ipc-f9012aabdf4148e7b7c2b82c5cc242a1678bda2c.tar.gz hardware_replicant_libsamsung-ipc-f9012aabdf4148e7b7c2b82c5cc242a1678bda2c.tar.bz2 hardware_replicant_libsamsung-ipc-f9012aabdf4148e7b7c2b82c5cc242a1678bda2c.zip | |
nv_data-imei: fix leftover from bruteforce_imei_offset
At first I tried to do a bruteforce that computed the IMEI once
for each location in the file. While this was inefficient, it kept
the code simple enough to validate that it worked as the code wasn't
tested before.
However, during the rewrite of that loop to make it more efficient I
forgot to complete it.
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
| -rw-r--r-- | tools/nv_data-imei.c | 25 |
1 files changed, 18 insertions, 7 deletions
diff --git a/tools/nv_data-imei.c b/tools/nv_data-imei.c index b406f34..6ec5adc 100644 --- a/tools/nv_data-imei.c +++ b/tools/nv_data-imei.c @@ -616,16 +616,15 @@ static int encode_imei(unsigned char *buf, struct imei *imei) int bruteforce_imei_offset(char *nv_data_path, struct imei *given_imei) { struct ipc_client *client = NULL; - struct imei found_imei; size_t file_size; + size_t search_size; size_t nv_data_chunk_size; void *buffer = NULL; void *ptr = NULL; unsigned char given_imei_buffer[(IMEI_LENGTH + 1) / 2] = { 0 }; + bool found_imei = false; int rc; - memset(&found_imei, 0, sizeof(found_imei)); - rc = ipc_setup(&client); if (rc) return rc; @@ -662,9 +661,12 @@ int bruteforce_imei_offset(char *nv_data_path, struct imei *given_imei) rc = encode_imei((unsigned char *)&given_imei_buffer, given_imei); if (rc < 0) return rc; + ptr = buffer; + search_size = file_size; + do { - ptr = memchr(ptr, given_imei_buffer[0], file_size); + ptr = memchr(ptr, given_imei_buffer[0], search_size); if (ptr) { if (!strncmp((void*)given_imei_buffer, ptr, sizeof(given_imei_buffer))) { @@ -672,13 +674,22 @@ int bruteforce_imei_offset(char *nv_data_path, struct imei *given_imei) "=> Found IMEI at 0x%x (%d)", (ptr - buffer), (ptr - buffer)); - rc = 0; - goto complete; + found_imei = true; } + + /* Continue searching even if we already found + * it just in case we find the IMEI at a second + * location too. + */ + search_size = file_size - (ptr - buffer); + ptr ++; } } while (ptr); - ipc_client_log(client, "=> IMEI not found"); + if (!found_imei) { + rc = 0; + ipc_client_log(client, "=> IMEI not found"); + } error: complete: |